It is currently 29 Oct 2025, 22:31
   
Text Size

Booster slots

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Booster slots

Postby Max mtg » 24 Apr 2013, 06:37

I take this one - should not be a large task.
Targets:
1. Introduce booster slots for custom printsheets (non-basic land in DGM)
2. Let ARN boosters yeild rares and uncommons (that is add slots with 1/2 uncommon and 1/2 rare chance)
3. (Optional) Make point 1 configurable from files (non-hardcoded)
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Booster slots

Postby Max mtg » 24 Apr 2013, 12:52

Thank you for all those thanks!

A preview of boosters file - featuring new syntax and extended filtering rules
boosters.txt | Open
Code: Select all
10E: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
2ED: 1 covers, 11 Common, 3 Uncommon, 1 Rare
3ED: 1 covers, 11 Common, 3 Uncommon, 1 Rare
4ED: 5 covers, 11 Common, 3 Uncommon, 1 Rare
5DN: 3 covers, 11 Common, 3 Uncommon, 1 Rare
5ED: 5 covers, 11 Common, 3 Uncommon, 1 Rare
6ED: 1 covers, 11 Common, 3 Uncommon, 1 Rare
7ED: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
8ED: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
9ED: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
ALA: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
ALL: 1 covers, 8 Common, 3 Uncommon, 1 Rare
APC: 1 covers, 11 Common, 3 Uncommon, 1 Rare
ARB: 3 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand ALA
ARN: 1 covers, 6 Common, 2 UncommonRare
ATQ: 1 covers, 6 Common, 2 UncommonRare
AVR: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
BOK: 3 covers, 11 Common, 3 Uncommon, 1 Rare
CFX: 3 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand ALA
CHK: 5 covers, 11 Common, 3 Uncommon, 1 Rare
CHR: 1 covers, 9 Common, 3 UncommonRare
CSP: 3 covers, 11 Common, 3 Uncommon, 1 Rare
DGM: 3 covers, 10 Common, 3 Uncommon, 1 Rare:!name("Maze's End"), 1 MazeLand
DIS: 3 covers, 11 Common, 3 Uncommon, 1 Rare
DKA: 3 covers, 9 Common:!dfc, 3 Uncommon:!dfc, 1 Rare:!dfc, 1 Any:dfc, 1 BasicLand
DRK: 1 covers, 6 Common, 2 UncommonRare
DST: 3 covers, 11 Common, 3 Uncommon, 1 Rare
EVE: 3 covers, 11 Common, 3 Uncommon, 1 Rare
EXO: 1 covers, 11 Common, 3 Uncommon, 1 Rare
FEM: 1 covers, 5 Common, 2 Uncommon, 1 Rare
FUT: 3 covers, 11 Common, 3 Uncommon, 1 Rare
GPT: 3 covers, 11 Common, 3 Uncommon, 1 Rare
GTC: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
HML: 1 covers, 6 Common, 2 UncommonRare
ICE: 5 covers, 11 Common, 3 Uncommon, 1 Rare
INV: 3 covers, 11 Common, 3 Uncommon, 1 Rare
ISD: 5 covers, 9 Common:!dfc, 3 Uncommon:!dfc, 1 Rare:!dfc, 1 Any:dfc, 1 BasicLand
JUD: 1 covers, 11 Common, 3 Uncommon, 1 Rare
LEA: 1 covers, 11 Common, 3 Uncommon, 1 Rare
LEB: 1 covers, 11 Common, 3 Uncommon, 1 Rare
LEG: 1 covers, 11 Common, 3 Uncommon, 1 Rare
LGN: 3 covers, 11 Common, 3 Uncommon, 1 Rare
LRW: 5 covers, 11 Common, 3 Uncommon, 1 Rare
M10: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
M11: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
M12: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
M13: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
MBS: 3 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
MIR: 5 covers, 11 Common, 3 Uncommon, 1 Rare
MMQ: 3 covers, 11 Common, 3 Uncommon, 1 Rare
MOR: 3 covers, 11 Common, 3 Uncommon, 1 Rare
MRD: 5 covers, 11 Common, 3 Uncommon, 1 Rare
NMS: 1 covers, 11 Common, 3 Uncommon, 1 Rare
NPH: 3 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
ODY: 3 covers, 11 Common, 3 Uncommon, 1 Rare
ONS: 5 covers, 11 Common, 3 Uncommon, 1 Rare
PCY: 1 covers, 11 Common, 3 Uncommon, 1 Rare
PLC: 3 covers, 11 Common, 3 Uncommon, 1 Rare
PLS: 1 covers, 11 Common, 3 Uncommon, 1 Rare
PO2: 1 covers, 11 Common, 3 Uncommon, 1 Rare
POR: 5 covers, 11 Common, 3 Uncommon, 1 Rare
PTK: 1 covers, 5 Common, 2 Uncommon, 1 Rare, 2 BasicLand
RAV: 5 covers, 11 Common, 3 Uncommon, 1 Rare
ROE: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
RTR: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
SCG: 3 covers, 11 Common, 3 Uncommon, 1 Rare
SHM: 5 covers, 11 Common, 3 Uncommon, 1 Rare
SOK: 3 covers, 11 Common, 3 Uncommon, 1 Rare
SOM: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
STH: 1 covers, 11 Common, 3 Uncommon, 1 Rare
TMP: 3 covers, 11 Common, 3 Uncommon, 1 Rare
TOR: 1 covers, 11 Common, 3 Uncommon, 1 Rare
TSP: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 TimeShifted
UDS: 1 covers, 11 Common, 3 Uncommon, 1 Rare
ULG: 1 covers, 11 Common, 3 Uncommon, 1 Rare
USG: 3 covers, 11 Common, 3 Uncommon, 1 Rare
VIS: 1 covers, 11 Common, 3 Uncommon, 1 Rare
WTH: 1 covers, 11 Common, 3 Uncommon, 1 Rare
WWK: 3 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand ZEN
ZEN: 5 covers, 10 Common, 3 Uncommon, 1 Rare, 1 BasicLand
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Booster slots

Postby Max mtg » 24 Apr 2013, 21:46

Took more than expected, I am done with core part, but commited lot of untested code, hoping to tune it up tomorrow.

if you have any bug reports related to this - please report.

Known issues: all limited cubes have default booster structure, guild sealed (gtc, rtr) not working.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Booster slots

Postby Max mtg » 25 Apr 2013, 12:41

Guild sealed are working!
DGM slot under construction.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Booster slots

Postby Max mtg » 25 Apr 2013, 13:42

Fully implemented!

Please report bugs.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Booster slots

Postby Chris H. » 25 Apr 2013, 14:18

Hey Max.

I had a crash today using this morning's snapshot build so this issue may have been fixed afterwards.

crash report at:

http://www.slightlymagic.net/forum/viewtopic.php?f=52&t=6333&p=116336#p116336
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Booster slots

Postby slowe » 25 Apr 2013, 21:45

I'm not sure if this is related to your changes or if it's an older problem, but I opened an Innistrad booster where Garruk Relentless took the place of the normal rare. I think the problem comes about because it's selected as a mythic rare, because I haven't seen any rare transform cards showing up in that slot. Whatever the case, Dark Ascension is probably affected as well.
slowe
 
Posts: 127
Joined: 05 Jan 2010, 14:04
Has thanked: 6 times
Been thanked: 10 times

Re: Booster slots

Postby Max mtg » 26 Apr 2013, 01:17

slowe, please make a screenshot or list all the cards in such a booster.
I cannot be sure, if there was no rare/mythic on some other place in the booster you refer to.


PS: I've opened over 20 boosters of ISD (I've hacked the quest shop) and never seen a booster without both rare/mythic and dfc.

Have to add that chances to catch some good rares or mythic in boosters are now as bad as for the real ones :)
Oh, wrote that and soon got Liliana and Garruk in a single Booster. Wish I had had that luck with paper cards.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Booster slots

Postby slowe » 26 Apr 2013, 03:07

I don't recall any of the other contents except that Garruk was in the normal rare spot and another transform card was in the transform card slot. As you pointed out, replicating this is difficult because the probability is so low, but I'll keep an eye out.
Then again, it's so rare and doesn't really affect anything negatively that it's not really worth the energy tracking down the bug. :roll:

Ooh, nice pack.
slowe
 
Posts: 127
Joined: 05 Jan 2010, 14:04
Has thanked: 6 times
Been thanked: 10 times

Re: Booster slots

Postby friarsol » 27 Apr 2013, 20:19

I just opened a DGM booster pack in Quest mode and I just received a Guildgate outside of the Land slot which shouldn't happen. DGM Land can only appear in the land slot.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Booster slots

Postby Max mtg » 28 Apr 2013, 00:57

You'll have to implement a filter to exclude gates (or maybe even any lands) out of slot used for common cards.
See innistrad's dfc filter for an example.

I am at the airport already
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times


Return to Developer's Corner

Who is online

Users browsing this forum: Timothysow and 20 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 21 users online :: 1 registered, 0 hidden and 20 guests (based on users active over the past 10 minutes)
Most users ever online was 9298 on 10 Oct 2025, 12:54

Users browsing this forum: Timothysow and 20 guests

Login Form