Card Creation Request Thread

[sumomole]

It produces mana as soon as it goes on the battlefield and doesn't let me pay the cost first, I have looked up cards such as Avacyn's Pilgrim , Llanowar Elves and Silver Myr and they all have the same code so why won't Deranged Assistant work properly?

Unfortunately, mana ability can only tapself to produce mana, any other cost need to use activated ability and mana token.

[Master Necro]

It produces mana as soon as it goes on the battlefield and doesn't let me pay the cost first, I have looked up cards such as Avacyn's Pilgrim , Llanowar Elves and Silver Myr and they all have the same code so why won't Deranged Assistant work properly?

Unfortunately, mana ability can only tapself to produce mana, any other cost need to use activated ability and mana token.

Thanks!

[Master Necro]

Hey ummmm, I need help again, and I swear it is the last time for a while.

I need help making Havengul Runebinder work properly.

[thefiremind]

I need help making Havengul Runebinder work properly.

Add ignore_filter="1" to the RESOLUTION_TIME_ACTION that generates tokens, then move the AI_AVAILABILITY blocks inside the activated ability (just before </ACTIVATED_ABILITY>).

[Master Necro]

I need help making Havengul Runebinder work properly.

Add ignore_filter="1" to the RESOLUTION_TIME_ACTION that generates tokens, then move the AI_AVAILABILITY blocks inside the activated ability (just before </ACTIVATED_ABILITY>).

I have done as you said and it still doesn't work.

[thefiremind]

Sorry, I haven't been clear enough but I thought you knew where to put XML tags... what I meant was this:

Code: Select all

    <RESOLUTION_TIME_ACTION ignore_filter="1">
    local token_count = 1
    if token_count &gt; 0 then
       MTG():PutTokensIntoPlay( "TOKEN_ZOMBIE_2_2_277466", token_count, EffectController() )
    end
    </RESOLUTION_TIME_ACTION>

[Master Necro]

Sorry, I haven't been clear enough but I thought you knew where to put XML tags... what I meant was this:

Code: Select all

    <RESOLUTION_TIME_ACTION ignore_filter="1">
    local token_count = 1
    if token_count &gt; 0 then
       MTG():PutTokensIntoPlay( "TOKEN_ZOMBIE_2_2_277466", token_count, EffectController() )
    end
    </RESOLUTION_TIME_ACTION>

And now I know, thanks.

Well I just copy pasted what you gave me and it still doesn't work, test it and see. When I activate the ability it doesn't give me the choice to exile the cards from the graveyard, it gives me the choice to exile any card except those in the graveyard.

[thefiremind]

Whoops, something always gets overlooked... the query for the card to exile is bound to a target definition with ID 6, but your definition has ID 0. Change it to

Code: Select all

<TARGET_DEFINITION id="6">

Incidentally, that's exactly the same problem that my Azorius Charm had... it seems I should get used to check the coherence between definition IDs and queries.

[Master Necro]

Whoops, something always gets overlooked... the query for the card to exile is bound to a target definition with ID 6, but your definition has ID 0. Change it to

Code: Select all

<TARGET_DEFINITION id="6">

Incidentally, that's exactly the same problem that my Azorius Charm had... it seems I should get used to check the coherence between definition IDs and queries.

Well there is good news and bad news.

The good news is it works now, it asks to discard a creature card from my graveyard and it summons my 2/2 Zombie token.

The bad news is it doesn't put the +1/+1 counters on the zombies.

[thefiremind]

Sometimes it really appears that I find problems one by one when I could just find them all in one shot, but of course I don't do it on purpose, it's just that I usually look only in the places where I know problems can be hidden most times. And when I find one, I assume it's the only one. For example, in this card, I didn't look carefully inside the FILTER block because that should always be copied from other cards (I still copy filters from other cards and only tweak where needed, it's faster than writing them 100% manually)... how could I imagine that someone invents new functions, like GetCreatureType? That should be GetSubType.

[Master Necro]

Sometimes it really appears that I find problems one by one when I could just find them all in one shot, but of course I don't do it on purpose, it's just that I usually look only in the places where I know problems can be hidden most times. And when I find one, I assume it's the only one. For example, in this card, I didn't look carefully inside the FILTER block because that should always be copied from other cards (I still copy filters from other cards and only tweak where needed, it's faster than writing them 100% manually)... how could I imagine that someone invents new functions, like GetCreatureType? That should be GetSubType.

Yeah just put a pair of long ears on me and call me...

[gorem2k]

to thefiremind,

I've just noticed something's not clear about Infinite Reflection you made earlier.

here's the rule text:

When Infinite Reflection enters the battlefield attached to a creature, each other nontoken creature you control becomes a copy of that creature.
Nontoken creatures you control enter the battlefield as a copy of enchanted creature.

your version only changes creatures already in play to target enchanted creature, but doesn't affect the next one entering.



here I had Infinite reflection on Fog Bank then I played Consecrated Sphinx.

[thefiremind]

You are right, I made a last-minute change on Infinite Reflection but actually forgot to test it. The problem is that I don't know how to fix it properly.

If you change

Code: Select all

    <DURATION>
    return TriggerObject() == nil or
    (TriggerObject():GetZone() ~= ZONE_TRANSITION and TriggerObject():GetZone() ~= ZONE_IN_PLAY)
    </DURATION>

with

Code: Select all

    <DURATION>
    return TriggerObject() == nil
    </DURATION>

Infinite Reflection works, but the cards still retain their transformation when they leave the battlefield. I thought that there was 1 pointer protection too much, so I tried to delete

Code: Select all

    EffectDC():Protect_CardPtr(COMPARTMENT_ID_PARAM_TRIGGER_OBJECT)

but do you know what happened? The opponent's creatures were correctly losing their transformation when hitting the graveyard, while mine were not! I guess the solution would involve saving TriggerObject() into another pointer and do all the things from there, but I remember that being my first implementation of Infinite Reflection and couldn't get it to work.

If some other modder wants to have a look at it and fix it, here is the card.

[gorem2k]

I guess the solution would involve saving TriggerObject() into another pointer and do all the things from there, but I remember that being my first implementation of Infinite Reflection and couldn't get it to work.

I hardly follow you, this is beyond my skills though would granting a delayed trigger work ?

Anyhow this card must be a pain to implement given it's clearly not expected to fit in current DotP engine.

[RiiakShiNal]

It looks like Infinite Reflection works fine if you remove the internal="1" from the second TRIGGERED_ABILITY.