Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by swordshine » 20 Jun 2013, 06:32
r22167, Gideon, Champion of Justice's first ability is broken.
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by jsv » 20 Jun 2013, 06:44
r22164, got this in forge.log:
Also in the log:
- Code: Select all
SVar 'X' not found in ability, fallback to Card (Sanity Grinding). Ability is ( )
SVar 'X' not found in ability, fallback to Card (Sanity Grinding). Ability is ( )
SVar 'X' not found in ability, fallback to Card (Sanity Grinding). Ability is ( )
SVar 'X' not found in ability, fallback to Card (Sanity Grinding). Ability is ( )
[... 12 times more ...]
Also in the log:
- Code: Select all
Unsupported file type of the sound file: res/sound/end_of_turn.wav - could not get audio input stream from input file
- Attachments
-
end_of_turn.zip- (83.47 KiB) Downloaded 197 times
Re: Bug Reports (snapshot builds)
by swordshine » 20 Jun 2013, 09:37
I think this should use getDefinedCardsOrTargeted(sa, "Defined"), Gideon, Champion of Justice is the only card that contains "Defined" and "ValidTgts" in PutCounter effect.swordshine wrote:r22167, Gideon, Champion of Justice's first ability is broken.
- Code: Select all
### Eclipse Workspace Patch 1.0
#P trunk
Index: src/main/java/forge/card/ability/effects/CountersPutEffect.java
===================================================================
--- src/main/java/forge/card/ability/effects/CountersPutEffect.java (revision 22167)
+++ src/main/java/forge/card/ability/effects/CountersPutEffect.java (working copy)
@@ -90,7 +90,7 @@
}
}
- List<Card> tgtCards = getTargetCards(sa);
+ List<Card> tgtCards = getDefinedCardsOrTargeted(sa, "Defined");
for (final Card tgtCard : tgtCards) {
counterAmount = (sa.usesTargeting() && sa.hasParam("DividedAsYouChoose")) ? sa.getTargetRestrictions().getDividedValue(tgtCard) : counterAmount;
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by jsv » 20 Jun 2013, 10:23
r22167, endless loop on Goblin Arsonist activation:
- Attachments
-
Re: Bug Reports (snapshot builds)
by friarsol » 20 Jun 2013, 12:17
Yea this is the same as I posted below. Sloth says the function that removes it from the stack is broken due to Targeting changes.jsv wrote:r22167, endless loop on Goblin Arsonist activation:
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by pqnet » 20 Jun 2013, 14:42
I have found some bugs/crashes and fixed them. Where am I supposed to post report (and patches for review)? I used the bug tracker ( cardforge.org/bugs ), but looks like most activity is done through this thread.
- pqnet
- Posts: 1
- Joined: 02 Jun 2013, 21:19
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by friarsol » 20 Jun 2013, 14:47
If it's for recent SVN builds, feel free to post them here.pqnet wrote:I have found some bugs/crashes and fixed them. Where am I supposed to post report (and patches for review)? I used the bug tracker ( cardforge.org/bugs ), but looks like most activity is done through this thread.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Max mtg » 20 Jun 2013, 18:13
Looks like triggers similiar to Goblin Arsonist are already fixed.
Gideon's ability fixed as proposed by Swordshine
Gideon's ability fixed as proposed by Swordshine
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Hanmac » 20 Jun 2013, 20:33
Momentary Blink does not work with evoke elementars, the sacrifice Effect does still resolve and kills the Creature even if it should be a new one
Re: Bug Reports (snapshot builds)
by xbon » 21 Jun 2013, 00:41
Anywhere to get more recent snapshots? there hasn't been a new snapshot in 3 days, and I want to use some of the more recently fixed cards like the sliver.friarsol wrote:If it's for recent SVN builds, feel free to post them here.
Re: Bug Reports (snapshot builds)
by Chris H. » 21 Jun 2013, 01:31
xbon wrote:Anywhere to get more recent snapshots? there hasn't been a new snapshot in 3 days, and I want to use some of the more recently fixed cards like the sliver.friarsol wrote:If it's for recent SVN builds, feel free to post them here.
The dev team is in the process of changing Forge to require that it be run from Java 7 only. Some issues came up and we are dealing with them as quickly as we can.
At this time Forge will build for windows/*nix only and we are not able to provide a Mac OS X version at this time. We hope to be able to resolve this issue soon.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Bug Reports (snapshot builds)
by Max mtg » 21 Jun 2013, 01:42
Chris, is it possible to release only windows/linux shapshots for the time being (until jendave fixes osx-related issues)?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by friarsol » 21 Jun 2013, 02:25
r22173
AI has The Great Gatsby deck (Guildgates) and casts Smelt-Ward Gatekeepers and doesn't target anything. I can't imagine Sloth would put this in a deck if this target didn't work correct. The first time I had Kamahl, Pit Fighter out, which definitely is worth taking, but honestly pretty much anything should be worth grabbing.
AI has The Great Gatsby deck (Guildgates) and casts Smelt-Ward Gatekeepers and doesn't target anything. I can't imagine Sloth would put this in a deck if this target didn't work correct. The first time I had Kamahl, Pit Fighter out, which definitely is worth taking, but honestly pretty much anything should be worth grabbing.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by xbon » 21 Jun 2013, 03:41
Description: Start Match, with 2 fully random decks.
- RuntimeException | Open
- NullPointerException | Open
Re: Bug Reports (snapshot builds)
by Max mtg » 21 Jun 2013, 06:09
Haunt does not throw exceptions when target is about to be chosen.
Now there's another problem - tirggered ability that resolves when haunted creature dies won't leave stack
Now there's another problem - tirggered ability that resolves when haunted creature dies won't leave stack
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Who is online
Users browsing this forum: No registered users and 24 guests