Forge version 1.4.4

[spr]

There is a regression that I believe is being looked into - viewtopic.php?f=52&t=6333&start=2280#p127294.

Cheers,
Steve.

[drdev]

If you're referring to the issue I introduced, I'll be committing a fix in the next couple hours once I can get in front of a computer (posting this from my phone).

EDIT: Just committed the fix for this issue in r22699.

[Chris H.]

Attempted the beta build and deploy this morning and got the following build failure.

Code: Select all

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running TestSuite
[INFO] Configuring TestNG with: TestNG652Configurator
[INFO]
[INFO] Results :
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] BUILD FAILURE
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [INFO] Total time: 4:45.129s
[INFO] [INFO] Finished at: Tue Jul 30 09:03:06 EDT 2013
[INFO] [INFO] Final Memory: 45M/522M
[INFO] [INFO] ------------------------------------------------------------------------
[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.2:site (default-site) on project forge: failed to get report for org.codehaus.mojo:cobertura-maven-plugin: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.14.1:test (default-test) on project forge: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.14.1:test failed: There was an error in the forked process
[INFO] [ERROR] org.testng.TestNGException:
[INFO] [ERROR] Cannot instantiate class forge.PanelTest
[INFO] [ERROR] at org.testng.internal.ObjectFactoryImpl.newInstance(ObjectFactoryImpl.java:38)
[INFO] [ERROR] at org.testng.internal.ClassHelper.createInstance1(ClassHelper.java:387)
[INFO] [ERROR] at org.testng.internal.ClassHelper.createInstance(ClassHelper.java:299)
[INFO] [ERROR] at org.testng.internal.ClassImpl.getDefaultInstance(ClassImpl.java:110)
[INFO] [ERROR] at org.testng.internal.ClassImpl.getInstances(ClassImpl.java:186)
[INFO] [ERROR] at org.testng.internal.TestNGClassFinder.<init>(TestNGClassFinder.java:120)
[INFO] [ERROR] at org.testng.TestRunner.initMethods(TestRunner.java:409)
[INFO] [ERROR] at org.testng.TestRunner.init(TestRunner.java:235)
[INFO] [ERROR] at org.testng.TestRunner.init(TestRunner.java:205)
[INFO] [ERROR] at org.testng.TestRunner.<init>(TestRunner.java:153)
[INFO] [ERROR] at org.testng.SuiteRunner$DefaultTestRunnerFactory.newTestRunner(SuiteRunner.java:522)
[INFO] [ERROR] at org.testng.SuiteRunner.init(SuiteRunner.java:157)
[INFO] [ERROR] at org.testng.SuiteRunner.<init>(SuiteRunner.java:111)
[INFO] [ERROR] at org.testng.TestNG.createSuiteRunner(TestNG.java:1299)
[INFO] [ERROR] at org.testng.TestNG.createSuiteRunners(TestNG.java:1286)
[INFO] [ERROR] at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
[INFO] [ERROR] at org.testng.TestNG.run(TestNG.java:1057)
[INFO] [ERROR] at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:77)
[INFO] [ERROR] at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:189)
[INFO] [ERROR] at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:105)
[INFO] [ERROR] at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:117)
[INFO] [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[INFO] [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
[INFO] [ERROR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[INFO] [ERROR] at java.lang.reflect.Method.invoke(Method.java:601)
[INFO] [ERROR] at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:208)
[INFO] [ERROR] at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:159)
[INFO] [ERROR] at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:87)
[INFO] [ERROR] at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
[INFO] [ERROR] at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:95)
[INFO] [ERROR] Caused by: java.lang.reflect.InvocationTargetException
[INFO] [ERROR] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
[INFO] [ERROR] at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
[INFO] [ERROR] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
[INFO] [ERROR] at java.lang.reflect.Constructor.newInstance(Constructor.java:525)
[INFO] [ERROR] at org.testng.internal.ObjectFactoryImpl.newInstance(ObjectFactoryImpl.java:29)
[INFO] [ERROR] ... 29 more
[INFO] [ERROR] Caused by: java.lang.NullPointerException
[INFO] [ERROR] at java.awt.Window.initGC(Window.java:467)
[INFO] [ERROR] at java.awt.Window.init(Window.java:487)
[INFO] [ERROR] at java.awt.Window.<init>(Window.java:536)
[INFO] [ERROR] at java.awt.Frame.<init>(Frame.java:420)
[INFO] [ERROR] at java.awt.Frame.<init>(Frame.java:385)
[INFO] [ERROR] at javax.swing.JFrame.<init>(JFrame.java:180)
[INFO] [ERROR] at forge.PanelTest.<init>(PanelTest.java:46)
[INFO] [ERROR] ... 34 more
[INFO] [ERROR] -> [Help 1]
[INFO] [ERROR]
[INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[INFO] [ERROR]
[INFO] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[INFO] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

[friarsol]

While it would be nice to get a beta release, I think we should fix right clicking to undeclare attackers/blockers. That's pretty important and worth delaying the release a day or two I'd think.

[spr]

I think we should aim for Chris's orginal suggestion of Friday. In the interim, test, test and test - only committing bug fixes or very minor updates. No new major functionality.

Cheers,
Steve

[Chris H.]

While it would be nice to get a beta release, I think we should fix right clicking to undeclare attackers/blockers. That's pretty important and worth delaying the release a day or two I'd think.

 
We can wait a few days.

I was able to build and release a snapshot just now.

My attempt to build and release the 1.4.4 beta has modified the pom file and the tags dir. If we leave this alone the 1.4.4 beta will instead be 1.4.5. Is this a problem for anyone?

I am not sure how to revert those two changes.

[drdev]

While it would be nice to get a beta release, I think we should fix right clicking to undeclare attackers/blockers. That's pretty important and worth delaying the release a day or two I'd think.

 
We can wait a few days.

I was able to build and release a snapshot just now.

My attempt to build and release the 1.4.4 beta has modified the pom file and the tags dir. If we leave this alone the 1.4.4 beta will instead be 1.4.5. Is this a problem for anyone?

I am not sure how to revert those two changes.

I'm going to fix right-clicking today. Is there anything else right-clicking is supposed to do with cards that I broke with my recent changes to how mouse events are handled for cards?

That said, I don't really understand why left-clicking an attacker/blocker doesn't remove it from combat. MTGO uses left-click both to declare and undeclare attackers/blockers, which feels right to me. I feel like right-click should be reserved for opening context menus or for situations where left click does something and we want right-click to do something different (like the recent behavior change I added for right-clicking filters in deck editor). In the case of attackers/blockers, it sounds like left clicking does nothing, so why not let it undeclare?

[spr]

Sounds sensible to me. But then I guess the Windows 8 guys thought the same thing when they decided to get rid of the Start button.

As some wise person cautioned me when I joined, you need to tread lightly when it comes to GUI updates. People like what they like, no matter how much you are convinced yours is the right way.

What I have been doing is creating a new preferences setting - this lets you toggle between your new behaviour and the old. Leave it off by default to keep everything as is, switch on to get new behaviour. For example, see the "Themed ComboBox" or "Show Background Image on Match Screen" settings.

Cheers,
Steve

[friarsol]

As some wise person cautioned me when I joined, you need to tread lightly when it comes to GUI updates. People like what they like, no matter how much you are convinced yours is the right way.

Yea I think that's the important thing, it may feel "better" the way you are used to, but we've been doing undeclare this way for several years, and switching it would feel broken to me and much of our user base. "Because MTGO does it" is not a good enough reason. I only play with a touchpad, and sometimes I'll double click things accidentally. In this scenario, that would mean creatures I planned on attacking/blocking with would undeclare because I "left clicked again" and if I wasn't being vigilant about double checking my combat plans, I could easily end up losing a game because I'm struggling with the UI, instead of enjoying the game.

[moomarc]

The other important consideration is that a second left click has meaning when Banding is involved as it initiates the start of declaring a band.

[drdev]

Ok, I'm convinced. I'll leave it as right-click and not add left-click support. It will just take some getting used to certain things that differ from MTGO, which is what I'm used to. But then again, part of the reason I'm here is the issues I have with MTGO's UI, so change can be a good thing.

That said, would anyone object to a tooltip indicating what left vs. right click does in that situation to make it more discoverable for new users?

Also, nobody mentioned whether right-clicking cards does anything else beside undeclare attackers/blockers. Can I get a final confirmation of that so I don't forget to fix something else I might have broken?

[spr]

That said, would anyone object to a tooltip indicating what left vs. right click does in that situation to make it more discoverable for new users?

Personally, only if it is an option that could be turned off ("Show tooltip hints" option in preferences for example).

Cheers,
Steve

[friarsol]

Also, nobody mentioned whether right-clicking cards does anything else beside undeclare attackers/blockers. Can I get a final confirmation of that so I don't forget to fix something else I might have broken?

I haven't looked at Inputs in a long time, I know Max streamlined most of them pretty recently, so he may have an idea. But he also said that he's going to be pretty busy with work related things for another week or two.

Probably the only way to know for sure if look at anything that overrides Input.onCardSelected(Card card, boolean isRmb) and see if they actually care about isRmb.

[Max mtg]

I don't remember.

The right mouse button could be used anywhere else. Right-clicking could be a nice improvement to unselect cards in inputs that are used to proliferate or add/remove counters or distribute damage.

I would not advise to assign right mouse to anything implemented outside of inputs. For card zoom feature the only middle button is both intuitive and more than enough.
Mac users (who probably don't have a middle button) might use "scroll up" action (is that swipe up over mouse surface?).

[drdev]

I don't remember.

The right mouse button could be used anywhere else. Right-clicking could be a nice improvement to unselect cards in inputs that are used to proliferate or add/remove counters or distribute damage.

I would not advise to assign right mouse to anything implemented outside of inputs. For card zoom feature the only middle button is both intuitive and more than enough.
Mac users (who probably don't have a middle button) might use "scroll up" action (is that swipe up over mouse surface?).

I was not suggesting making right-click do anything it didn't previously do. I just want to make sure I restore it to work as before (except on mouse up instead of on mouse down).

As for zoom, I added support for holding down both left and right mouse buttons at the same time to zoom, which allows the feature to be available to users without a middle button/mouse wheel. That's why (in addition to fixing some other issues like drag drop) I needed to change card selection to happen on mouse up instead of mouse down: so that this shortcut won't interfere with individual left or right click behavior.