Thefiremind's DotP2014 DLC v10 (03/Dec/2013)

[sumomole]

OK, I fixed Ancestral Vision and Wheel of Fate in the only way I found working. It's an approximation, but the whole suspend mechanic is an approximation so I think I can live with it.

You can try this.
And I read your TFM_CanBeSuspended, why do you check the card's characteristics, rather than use Object():CanBePlayed( EffectController() )?

EDIT: And I found TFM_KinshipCheck, I have done the same thing, but when I discovered Coat of Arms, I didn't so.

Code: Select all

filter:Add(FE_SUBTYPE, OP_INTERSECTS, object )

If I'm wrong, please tell me.

[thefiremind]

You can try this.

That's a nice finding that I totally overlooked, I'll use that.
EDIT: It works perfect! New update on its way!

And I read your TFM_CanBeSuspended, why do you check the card's characteristics, rather than use Object():CanBePlayed( EffectController() )?

I'm not sure, I think I found it was better in DotP2013, but I can't remember exactly why.

EDIT: And I found TFM_KinshipCheck, I have done the same thing, but when I discovered Coat of Arms, I didn't so.

Code: Select all

filter:Add(FE_SUBTYPE, OP_INTERSECTS, object )

Yes but if I ever need to use my function together with a filter, maybe not using a filter in the function could make my life easier. Aside from that, I don't think there's much difference between the two approaches... maybe performance-wise, but I'm careful about performance whenever I can, so I think I can afford a couple more loops here and there.

[gorem2k]

I have a request to you dear thefiremind,

Would you mind adding :

Code: Select all

r.SetBackTypes("GARRUK_RELENTLESS", CARD_TYPE_ENCHANTMENT)
r.SetBackSubTypes("GARRUK_RELENTLESS", ENCHANTMENT_TYPE_GARRUK)


to your D14_TFM_TRANSFORM.LOL ?

I don't want to cause too much interference with your mod.

[thefiremind]

I have a request to you dear thefiremind,

Would you mind adding :

Code: Select all

r.SetBackTypes("GARRUK_RELENTLESS", CARD_TYPE_ENCHANTMENT)
r.SetBackSubTypes("GARRUK_RELENTLESS", ENCHANTMENT_TYPE_GARRUK)


to your D14_TFM_TRANSFORM.LOL ?

I don't want to cause too much interference with your mod.

Sure, no problem, but before doing that, I'd like to end what I'm working on: an invisible token that will make your Planeswalkers faster to code. And since that token checks for the Planeswalker sub-types with a table as I explained on the other topic, that ENCHANTMENT_TYPE_GARRUK will probably need to be PLANESWALKER_TYPE_GARRUK if you find the token worth to be used. Or even better, you can add "Garruk" directly into the back face's XML: there are no cards that care about "Whenever a Garruk enters the battlefield", so you can't cause unwanted triggers.
I'm almost done, just some further testing and I'll post token and functions into your mod's topic.

[gorem2k]

Have you decided whether or not you'll do a separate mod for Planeswalker?

If so, it will save me work
If not then I will start right away and translate mines the best I can.

I ask because I see no point in doing 2 sets of different planeswalkers..

[thefiremind]

Have you decided whether or not you'll do a separate mod for Planeswalker?

If so, it will save me work
If not then I will start right away and translate mines the best I can.

I ask because I see no point in doing 2 sets of different planeswalkers..

I'm sorry but I don't have a definitive answer, it depends on how much time I can invest on it. If I do that, it won't be released very soon anyway.

[East Bay]

Have you decided whether or not you'll do a separate mod for Planeswalker?

If so, it will save me work
If not then I will start right away and translate mines the best I can.

I ask because I see no point in doing 2 sets of different planeswalkers..

I added the planeswalker manager token to the 4 I want to use Jace, the Mind Sculptor, Liliana of the Veil, Elspeth, Knight-Errant, and Tezzeret, Agent of Bolas.

[gorem2k]

I think there's something missing in _PLANESWALKERS_MANAGER

Code: Select all

  <!-- 6. Cards allowed to target Planeswalkers -->
  <TRIGGERED_ABILITY replacement_effect="1">
    <TRIGGER value="CARD_CONSIDERED_FOR_TARGETTING" pre_trigger="1">
    if PLW_IsInNameSet( SecondaryObject(), "EXCEPTIONS" ) == false and PLW_IsInNameSet( TriggerObject(), "PLANESWALKERS" ) then
       MTG():OverrideEvent()
       return true
    end
    return false
    </TRIGGER>
  </TRIGGERED_ABILITY>


the problem is I have included Nicol Bolas, Planeswalker in exception list and I think if I target a player with him (his 3rd ability) it thinks SecondaryObject() is false, so it override the event and I can't target a player with this planeswalker. In fact every planeswalker which are in exceptions list won't be able to target a player I think... I'm sure you've got a solution, as always

EDIT: just saw there's an existing PLAYER_CONSIDERED_FOR_TARGETTING. so this shouldn't be the problem... anyway I'll paste the card here:

Bolas | Open

Code: Select all

<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="PLW_NICOL_BOLAS_PLANESWALKER_444260991" />
  <CARDNAME text="NICOL_BOLAS_PLANESWALKER" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Nicol Bolas, Planeswalker]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Nicol Bolas, planeswalker]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Nicol Bolas, planeswalker]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Planeswalker Nicol Bolas]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Nicol Bolas, Planeswalker]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[プレインズウォーカー、ニコル・ボーラス]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[플레인즈워커 니콜 볼라스]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Никол Болас, Planeswalker]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Nicol Bolas, Planeswalker]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="444260991" />
  <ARTID value="444260991" />
  <ARTIST name="D. Alexander Gregory" />
  <CASTING_COST cost="{4}{U}{B}{B}{R}" />
  <TYPE metaname="Planeswalker" />
  <TYPE metaname="Enchantment" />
  <SUB_TYPE metaname="Bolas" />
  <EXPANSION value="M13" />
  <RARITY metaname="M" />
  <TRIGGERED_ABILITY replacement_effect="1" active_zone="ZONE_TRANSITION">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[|(Loyalty 5)|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[|(Loyauté 5)|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[|(Lealtad 5)|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[|(Loyalität 5)|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[|(Fedeltà 5)|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[（忠誠 5）]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[|(충성 5)|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[|(Верность 5)|]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[|(Lealdade 5)|]]></LOCALISED_TEXT>
    <COUNTER_REGISTRATION name="Loyalty" proliferate="11" />
    <TRIGGER value="ZONECHANGE_TRANSITION" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" from_zone="ZONE_ANY" />
    <RESOLUTION_TIME_ACTION>
    if EffectSource() ~= nil then
       EffectSource():AddCounters( MTG():GetCountersType("Loyalty"), 5 )
    end
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>
  <ACTIVATED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[(+3): Destroy target noncreature permanent.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[(+3) : Détruisez le permanent non-créature ciblé.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[(+3): Destruye el permanente objetivo que no sea criatura.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[(+3): Zerstöre eine bleibende Karte deiner Wahl, die keine Kreatur ist.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[(+3): Distruggi un permanente non creatura bersaglio.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[(＋３)：クリーチャーでないパーマネント１つを対象とし、それを破壊する。－２：クリーチャー１体を対象とし、それのコントロールを得る。－９：プレイヤー１人を対象とする。プレインズウォーカー、ニコル・ボーラスはそのプレイヤーに７点のダメージを与える。そのプレイヤーはカードを７枚捨て、その後、パーマネントを７つ生け贄に捧げる。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[(+3): 생물이 아닌 지속물 한 개를 목표로 정한다. 그 지속물을 파괴한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[(+3): уничтожьте целевой перманент, не являющийся существом.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[(+3): Destrua a permanente alvo que não seja uma criatura.]]></LOCALISED_TEXT>
    <AVAILABILITY per_turn_limit="1" sorcery_time="1" />
    <COST mana_cost="{0}" type="Mana" />
    <PLAY_TIME_ACTION>
    if EffectSource() ~= nil then
       EffectSource():AddCounters( MTG():GetCountersType("Loyalty"), 3 )
    end
    </PLAY_TIME_ACTION>
    <TARGET tag="CARD_QUERY_CHOOSE_NONCREATURE_PERMANENT_TO_DESTROY" definition="0" compartment="0" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Set_Or()
    local subfilter = filter:AddSubFilter_And()
       subfilter:Add( FE_TYPE, OP_NOT, CARD_TYPE_CREATURE )
        subfilter:Add( FE_IS_PERMANENT, true)   
    PLW_FilterNameSet(filter, "PLANESWALKERS", true)
    </TARGET_DEFINITION>
    <RESOLUTION_TIME_ACTION>
    for i = 0,(1-1) do
       local target_card = EffectDC():Get_Targets(0):Get_CardPtr(i)
       if target_card ~= nil then
          target_card:Destroy()
       end
    end
    </RESOLUTION_TIME_ACTION>
    <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
    <SFX text="TARGET_MAELSTROM_PLAY" />
  </ACTIVATED_ABILITY>
  <ACTIVATED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[(-2): Gain control of target creature.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[(-2) : Acquérez le contrôle de la créature ciblée.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[(-2): Gana el control de la criatura objetivo.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[(-2): Übernimm die Kontrolle über eine Kreatur deiner Wahl.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[(-2): Prendi il controllo di una creatura bersaglio.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[(-2): Gain control of target creature.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[(-2): 생물 한 개를 목표로 정한다. 그 생물의 조종권을 얻는다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[(-2): получите контроль над целевым существом.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[(-2): Ganhe o controle da criatura alvo.]]></LOCALISED_TEXT>
    <AVAILABILITY per_turn_limit="1" sorcery_time="1" />
    <COST type="RemoveCountersSelf" amount="2" counter_type="Loyalty" />
    <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_GAIN_CONTROL" definition="0" compartment="0" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    </TARGET_DEFINITION>
    <CONTINUOUS_ACTION layer="2">
    local card = EffectDC():Get_Targets(0):Get_CardPtr(0)
    if card ~= nil then
       card:SetController(EffectController())
    end
    </CONTINUOUS_ACTION>
    <DURATION>
    return EffectController() == nil
    </DURATION>
    <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
  </ACTIVATED_ABILITY>
  <ACTIVATED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[(-9): Nicol Bolas, Planeswalker deals 7 damage to target player. That player discards seven cards, then sacrifices seven permanents.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[(-9) : Nicol Bolas, planeswalker inflige 7 blessures au joueur ciblé. Ce joueur se défausse de sept cartes et sacrifie ensuite sept permanents.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[(-9): Nicol Bolas, planeswalker hace 7 puntos de daño al jugador objetivo.  Ese jugador descarta siete cartas y luego sacrifica siete permanentes.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[(-9): Planeswalker Nicol Bolas fügt einem Spieler deiner Wahl 7 Schadenspunkte zu. Dieser Spieler wirft sieben Karten aus seiner Hand ab und opfert dann sieben bleibende Karten.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[(-9): Nicol Bolas, Planeswalker infligge 7 danni a un giocatore bersaglio. Quel giocatore scarta sette carte, poi sacrifica sette permanenti.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[(-9): Nicol Bolas, Planeswalker deals 7 damage to target player. That player discards seven cards, then sacrifices seven permanents.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[(-9): 플레이어 한 명을 목표로 정한다. 플레인즈워커 니콜 볼라스는 그 플레이어에게 피해 7점을 입힌다. 그 플레이어는 카드 일곱 장을 버리고 지속물 일곱 개를 희생한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[(-9): Никол Болас, Planeswalker наносит 7 повреждений целевому игроку. Тот игрок сбрасывает семь карт, затем приносит в жертву семь перманентов.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[(-9): Nicol Bolas, Planeswalker, causa 7 pontos de dano ao jogador alvo. Aquele jogador descarta sete cards e depois sacrifica sete permanentes.]]></LOCALISED_TEXT>
    <AVAILABILITY per_turn_limit="1" sorcery_time="1" />
    <COST type="RemoveCountersSelf" amount="9" counter_type="Loyalty" />
    <TARGET tag="CARD_QUERY_CHOOSE_PLAYER" definition="0" compartment="7" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:SetFilterType( FILTER_TYPE_PLAYERS )
    </TARGET_DEFINITION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(7):Get_PlayerPtr(0)
    if target_player ~= nil then
       EffectSourceLKI():DealDamageTo( 7, target_player )
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(7):Get_PlayerPtr(0)
    if target_player ~= nil then
        local filter = ClearFilter()
       filter:SetZone( ZONE_HAND, target_player)
       target_player:SetItemCount( 7 )
       for i = 0,(7-1) do
          target_player:SetItemPrompt (i, "CARD_QUERY_CHOOSE_CARD_TO_DISCARD" )
       end
       target_player:ChooseItems( EffectDC():Make_Targets(1) )
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(7):Get_PlayerPtr(0)
    if target_player ~= nil then
       for i = 0,(7-1) do
          local card = EffectDC():Get_Targets(1):Get_CardPtr(i)
          if card ~= nil  then
             card:Discard()
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(7):Get_PlayerPtr(0)
    if target_player ~= nil then
        local filter = ClearFilter()
       filter:SetZone( ZONE_BATTLEFIELD, target_player)
       filter:Add( FE_IS_PERMANENT, true )
       target_player:SetItemCount( 7 )
       for i = 0,(7-1) do
          target_player:SetItemPrompt (i, "CARD_QUERY_CHOOSE_PERMANENT_TO_SACRIFICE" )
       end
       target_player:ChooseItems( EffectDC():Make_Targets(2) )
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(7):Get_PlayerPtr(0)
    if target_player ~= nil then
       for i = 0,(7-1) do
          local card = EffectDC():Get_Targets(2):Get_CardPtr(i)
          if card ~= nil  then
             target_player:Sacrifice( card )
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
    <AI_SIMPLIFIED_TARGETING compartment="7" hint="HINT_ENEMY_ONLY" />
    <SFX text="GLOBAL_DEATH_PLAY" />
  </ACTIVATED_ABILITY>

  <TRIGGERED_ABILITY replacement_effect="1" active_zone="ZONE_ANY">
    <TRIGGER value="BEGINNING_OF_STEP">
    return MTG():GetStep() == STEP_UPKEEP and MTG():GetTurnNumber() == 0
    </TRIGGER>
    <RESOLUTION_TIME_ACTION>
    PLW_CreateUniqueToken( "_PLANESWALKERS_MANAGER_991800002", "_PLANESWALKERS_MANAGER", EffectController() )
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>
  <TOKEN_REGISTRATION reservation="1" type="_PLANESWALKERS_MANAGER_991800002" />

  <AI_COUNTER_SCORE type="Loyalty" score="100" />
  <AI_BASE_SCORE score="600" zone="ZONE_BATTLEFIELD" />
</CARD_V2>


[thefiremind]

That part of the manager defines exceptions for cards that target Planeswalkers, not for Planeswalkers that target other things, so it shouldn't give any problem of this kind.
I can't see any problem with your Bolas's ultimate... I guess you were sure you had 9 counters on it, right? (I know it's a dumb question, but for a moment I was thinking my Garruk Wildspeaker wasn't working when there just weren't 2 lands to target, so a distraction can always happen ).
I'll give it another look tomorrow anyway, it's pretty late here and I can't guarantee I'm fully functional.

[gorem2k]

That part of the manager defines exceptions for cards that target Planeswalkers, not for Planeswalkers that target other things, so it shouldn't give any problem of this kind.
I can't see any problem with your Bolas's ultimate... I guess you were sure you had 9 counters on it, right? (I know it's a dumb question, but for a moment I was thinking my Garruk Wildspeaker wasn't working when there just weren't 2 lands to target, so a distraction can always happen ).
I'll give it another look tomorrow anyway, it's pretty late here and I can't guarantee I'm fully functional.

ok, take it easy!! I think I've found the problem. somehow, the filters from other ability block were interfering. I've learned that what is between <ACTIVATED_ABILITY> and </ACTIVATED_ABILITY> can affect other abilities.. ah well, where you from by the way? Europe ? California?

EDIT: OK, no need to bother with this, it's fixed!

[thefiremind]

ok, take it easy!!

I always take it easy, I'm a quiet guy. If sometimes it doesn't seem so, believe me, it's not intended.

EDIT: OK, no need to bother with this, it's fixed!

OK, all's well what ends well.

where you from by the way? Europe ? California?

I'm from Italy. I don't spread the information too much (like putting it under my avatar) because of a reason that could seem selfish so I won't say it.

[BlindWillow]

I love the names you came up for these decks. Especially "The Esper...iment". That one actually made me laugh out loud.

One correction I noticed for Gavony Township.

<COST type="Mana" cost="{2}{G}{W}" />

should be

<COST mana_cost="{2}{G}{W}" type="Mana" />

[thefiremind]

Those leftovers from DotP2013 are really easy to slip through... it's fixed now.

[drleg3nd]

hey fire, i was using your griselbrand in my deck. When i activated his ability, I did not lose any life.

[Mazerius]

Dear Firemind,
I just installed DoTP2014 (skidrow version), and wanted to use your mod among others. I downloaded all the included files you named, and also Rick's DLL (copy pasted it in game directory, where the dotp2014.exe file is). Same for all the files you listed as required. But no new decks are appearing in my deck manager. Any insights on what I'm doing wrong?
Thanks in advance!