r23340 - Support skinned titlebar for main window

[spr]

spr, friarsol, I've committed several changes to address the issues you've brought up here. Thanks for the input.

Thanks for the changes. Some initial observations -

• If full screen and you open a modal dialog Forge is minimized!
• The maximize does not take into account any additional desktop bars that might be present. For example, I have the standard Windows 7 taskbar on the bottom of my screen but I also have a custom appbar at the top of my screen. When I maximize, the bottom of the Forge window disappears behind the Windows taskbar by the amount taken up by the top appbar.
• If overlay is active then the Forge button should be disabled (like the MenuBar previously) since the overlay is effectively modal within the Forge frame. The rest of the titlebar should be still be active though.
• I still find the auto-bar a tad sluggish, so I have tweaked it thus - Revealspeed = 200, revealDelay = 100. If you are happy with that they will be included in my next commit. Or I can add a couple of settings as mentioned previously.

Cheers,
Steve

[drdev]

spr, friarsol, I've committed several changes to address the issues you've brought up here. Thanks for the input.

Thanks for the changes. Some initial observations -

• If full screen and you open a modal dialog Forge is minimized!
• The maximize does not take into account any additional desktop bars that might be present. For example, I have the standard Windows 7 taskbar on the bottom of my screen but I also have a custom appbar at the top of my screen. When I maximize, the bottom of the Forge window disappears behind the Windows taskbar by the amount taken up by the top appbar.
• If overlay is active then the Forge button should be disabled (like the MenuBar previously) since the overlay is effectively modal within the Forge frame. The rest of the titlebar should be still be active though.
• I still find the auto-bar a tad sluggish, so I have tweaked it thus - Revealspeed = 200, revealDelay = 100. If you are happy with that they will be included in my next commit. Or I can add a couple of settings as mentioned previously.

Cheers,
Steve

• The modal issue is known and my top priority to fix (today hopefully).
• Can you send me a screenshot of that your window looks like when maximized? Apparently the algorithm I used for determining the maximize bounds needs some work.
• I'll disable the Forge button when an overlay is active.
• Go ahead and commit the reveal speed tweak and we can always adjust it later or add a setting if we decide it's necessary.

[spr]

I marked the overlap in red but it is pretty easy to see anyway.

One other thing. Now that you have removed the status bar we need another way of displaying the Forge version. Suggest you add it to the Home screen below or on logo. Or add an About box to the menu.

Cheers,
Steve

[drdev]

The version is still accessible since it's in the window title that appears on the taskbar and other places, so I thought it was OK to omit it from the UI.

That said, I like the idea of adding an About Box (accessible via Forge > Help > About Forge). Would you be able to add that yourself, or do you want me to?

[spr]

That said, I like the idea of adding an About Box (accessible via Forge > Help > About Forge). Would you be able to add that yourself, or do you want me to?

I plan on committing a few bit and pieces later so unless I see that you have added something in the SVN log I will add a simple message box showing the version via the menu option you mentioned.

Cheers,
Steve

[drdev]

Reveal speed tweak looks good. I did make one tweak though, which is, when first opening Full Screen mode, delay hiding the titlebar by half a second so it's more clear that it was hidden in a way that it can still be accessed (r23433).

I've also committed a fix so, while an Overlay is shown, the Forge button appears disabled, the Forge menu can't be opened, and keyboard shortcuts for items in the Forge menu and submenus are disabled (r23434).

I also found and fixed the bug in the maximized bounds code, so Forge should no longer extend behind the taskbar when maximized (r23435).

EDIT: I just committed the fixes so that internal dialogs are properly parented by the main window and so that opening them doesn't minimize Full Screen Forge, nor does activating another application on a different monitor (r23436-23437). See here for more details.

[spr]

Thanks for all the fixes.

A couple of additional issues :

• When in full screen, F1 and any other link (see Help menu) that launches an external app (browser, text editor, etc) are opened in the background "behind" forge. It kind of makes sense but if it is not possible to show them in front of forge when in full screen mode then forge should drop down to normal maximize mode first so that they are displayed properly.
• A titlebar state issue? :
  - Open Forge in full screen mode with titlebar set to autohide mode.
  - Deactivate full screen mode.
  - Activate full screen mode. The titlebar autohides as expected.
  - Open Deck Editor. The titlebar is visible and remains so.

Cheers,
Steve

[drdev]

Thanks for all the fixes.

A couple of additional issues :

• When in full screen, F1 and any other link (see Help menu) that launches an external app (browser, text editor, etc) are opened in the background "behind" forge. It kind of makes sense but if it is not possible to show them in front of forge when in full screen mode then forge should drop down to normal maximize mode first so that they are displayed properly.
• A titlebar state issue? :
  - Open Forge in full screen mode with titlebar set to autohide mode.
  - Deactivate full screen mode.
  - Activate full screen mode. The titlebar autohides as expected.
  - Open Deck Editor. The titlebar is visible and remains so.

Cheers,
Steve

The first issue I fixed in r23444. The second I can no longer reproduce using the Deck Editor navigation tab with the changes in r23447. Let me know if you can still reproduce.

[Chris H.]

Running today's snapshot build (r23448) on my Mac. I clicked on the full screen button and Forge slowed down and then became unresponsive for the most part.

Forge appears to work OK if I stay in windowed mode.

[drdev]

Running today's snapshot build (r23448) on my Mac. I clicked on the full screen button and Forge slowed down and then became unresponsive for the most part.

Forge appears to work OK if I stay in windowed mode.

Odd, I didn't change anything with Full Screen in the last few commits. Can you reproduce this with an older build (post-Full Screen)?

[Chris H.]

Running today's snapshot build (r23448) on my Mac. I clicked on the full screen button and Forge slowed down and then became unresponsive for the most part.

Forge appears to work OK if I stay in windowed mode.

Odd, I didn't change anything with Full Screen in the last few commits. Can you reproduce this with an older build (post-Full Screen)?

 
Yesterday's snapshot (23426) is showing the same problem but the slow down does not appear as quickly in full screen mode.