Formal Request Thread

[Lance20xd6]

I requested Primal Command some time ago and thefiremind posted some code for it but said some strings need localised text. I'm not really sure what that means or how to do it. I have only managed to make a couple of cards by using his web generator and copy and pasting cards with similar abilities.

[thefiremind]

- <CONTINUOUS_ABILITY> on anything that changes the effect of permanents on the battlefield e.g. +X/+X, granting First Strike, etc.

Just to avoid adding further confusion to new modders, it's CONTINUOUS_ACTION.

replacement_effect="1" means whenever a certain effect occurs, there is an effect or action that replaces the first effect.

This is the "official" explanation of what a replacement effect is in Magic, but using replacement_effect="1" has a wider purpose: it makes the triggered ability totally transparent to the players. The card doesn't glow not even for a moment, players can't respond to it, and triggers (some of them or all of them, I'm not totally sure) can't be triggered inside it. So it's useful not only for replacement effects, but also for any ability that we need to hide from the players (like wiping a register at the end of each turn).
Don't forget that there's also replacement_query="1" that is basically the same, but allows to ask for queries inside the ability (with replacement_effect="1" the queries don't work properly).

I requested Primal Command some time ago and thefiremind posted some code for it but said some strings need localised text. I'm not really sure what that means

It means this:

| Open

or how to do it.

If you open DATA_CORE\DATA_ALL_PLATFORMS\TEXT_PERMANENT\CARD_UI_TEXT0000.XML and search for "Jund", then compare what you find with the Jund Charm card XML, you can see how each of those strings is localised for Jund Charm, and you need to do the same for Primal Command. It requires no skill at all, it's just very boring because if you want the card to display the strings properly in all languages you need to copy and paste 4 modes x 9 languages = 36 strings.

Okay, so I ironed out the bugs in the XML code and the Duplicant seems to exile cards properly, but the Clone ability (any of it) doesn't seem to trigger. I notice that there are tags like Get_Power and Get_Toughness, but how would you go about making sure the Duplicant inherited the creature type properly?

Let me have a try at it... now that I'm pretty sure that the new Oracle wording can be ignored in DotP, I think I can get it to work.

[jacque]

Just to avoid adding further confusion to new modders, it's CONTINUOUS_ACTION.

Oopsie, typed that outside using my phone =( hehehe

Hmm... TFM dunno why, somehow Primal Command's 3rd Mode not working... the Target Player shuffles graveyard to his/her library...

[thefiremind]

Hmm... TFM dunno why, somehow Primal Command's 3rd Mode not working... the Target Player shuffles graveyard to his/her library...

I just tried and it works for me. Maybe you are using another version of Primal Command without noticing, or you copied something wrong?

Here's Duplicant. But I have bad news: despite having active_zone="ZONE_ANY", variable P/T doesn't work in exile. I tried to exile a Geist-Honored Monk while I still had the Spirit tokens on the battlefield, and Duplicant died. Then I looked at my exile zone, and Geist-Honored Monk was shown as 0/0. I'm afraid this is an engine bug and there's nothing we can do about it. My Duplicant works perfectly if you exile creatures with fixed P/T, though.

Duplicant (tested) | Open

Code: Select all

<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="DUPLICANT_220526" />
  <CARDNAME text="DUPLICANT" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Duplicant]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Répliquant]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Duplicante]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Duplikant]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Replicatore]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[映し身人形]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Duplicant]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Duplicant]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Duplicante]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="220526" />
  <ARTID value="220526" />
  <ARTIST name="Thomas M. Baxa" />
  <CASTING_COST cost="{6}" />
  <TYPE metaname="Artifact" />
  <TYPE metaname="Creature" />
  <SUB_TYPE metaname="Shapeshifter" />
  <EXPANSION value="ARC" />
  <RARITY metaname="R" />
  <POWER value="2" />
  <TOUGHNESS value="4" />
  <TRIGGERED_ABILITY linked_ability_group="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[|Imprint| — When Duplicant enters the battlefield, you may exile target nontoken creature.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[|Empreinte| — Quand le Changeforme arrive sur le champ de bataille, vous pouvez exiler la créature non-jeton ciblée.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[|Estampa| — Cuando el Duplicante entre al campo de batalla, puedes exiliar la criatura objetivo que no sea una ficha.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[|Einprägen| — Wenn der Duplikant ins Spiel kommt, kannst du eine Nichtspielsteinkreatur deiner Wahl ins Exil schicken.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[|Imprimere| — Quando il Replicatore entra nel campo di battaglia, puoi esiliare una creatura non pedina bersaglio.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[刻印 ― 映し身人形が場に出たとき、クリーチャー１体を対象とする。あなたはそれをゲームから取り除いてもよい。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[|Imprint| — When Duplicant enters the battlefield, you may exile target nontoken creature.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[|Imprint| — When Duplicant enters the battlefield, you may exile target nontoken creature.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[|Estampar| — Quando Duplicante entra no campo de batalha, você pode exilar a criatura alvo que não seja uma ficha.]]></LOCALISED_TEXT>
    <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_EXILE" definition="0" compartment="0" count="1" />
    <TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
    filter:Add(FE_IS_TOKEN, false)
    </TARGET_DEFINITION>
    <RESOLUTION_TIME_ACTION>
    local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
    if target ~= nil then
       if target ~= EffectSource() then -- if you exile Duplicant itself, this is useless
          LinkedDC():Set_CardPtr(0, target)
          LinkedDC():Protect_CardPtr(0)
       end
       target:Exile()
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target = LinkedDC():Get_CardPtr(0)
    local source = EffectSource()
    if target ~= nil and source ~= nil then
       target:NailOnto(source)
    end
    </RESOLUTION_TIME_ACTION>
    <MAY />
    <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY" />
    <AUTO_SKIP>
    return EffectDC():Get_Targets(0):Get_CardPtr(0) == false
    </AUTO_SKIP>
  </TRIGGERED_ABILITY>
  <STATIC_ABILITY linked_ability_group="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[As long as a card exiled with Duplicant is a creature card, Duplicant has the power, toughness, and creature types of the last creature card exiled with Duplicant. It’s still a Shapeshifter.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Tant que le Répliquant a l’empreinte d’une carte de créature, il a la force, l’endurance et les types de créature de cette carte. C’est toujours aussi un changeforme.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cuando una carta de criatura esté estampada en el Duplicante, éste tiene la fuerza, resistencia y tipo de criatura de esa carta. Aún se considera un metamorfo.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Solange eine Kreaturenkarte auf dem Duplikant eingeprägt ist, hat der Duplikant die Stärke, Widerstandskraft und Kreaturentypen dieser Karte. Er ist immer noch ein Gestaltwandler.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Fintanto che una carta esiliata con il Replicatore è una carta creatura, il Replicatore ha la forza, la costituzione e i tipi di creatura dell’ultima carta creatura esiliata con il Replicatore. È ancora un Polimorfo.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[クリーチャー・カードが映し身人形に刻印されているかぎり、映し身人形は刻印されているカードのパワーとタフネスとクリーチャー・タイプを持つ。 それは多相の戦士でもある。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[As long as a card exiled with Duplicant is a creature card, Duplicant has the power, toughness, and creature types of the last creature card exiled with Duplicant. It’s still a Shapeshifter.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[As long as a card exiled with Duplicant is a creature card, Duplicant has the power, toughness, and creature types of the last creature card exiled with Duplicant. It’s still a Shapeshifter.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Enquanto o card de criatura estiver estampado em Duplicante, Duplicante tem o poder, a resistência e todos os tipos de criatura daquele card. Ele ainda é um Metamorfo.]]></LOCALISED_TEXT>
    <CONTINUOUS_ACTION layer="7B">
    local source = EffectSource()
    local imprinted = LinkedDC():Get_CardPtr(0)
    if source ~= nil and imprinted ~= nil and imprinted:GetCardType():Test(CARD_TYPE_CREATURE) then
       local source_characteristics = source:GetCurrentCharacteristics()
       local imprinted_characteristics = imprinted:GetCurrentCharacteristics()
       source_characteristics:Power_Set( imprinted_characteristics:Power_Get() )
       source_characteristics:Toughness_Set( imprinted_characteristics:Toughness_Get() )
    end
    </CONTINUOUS_ACTION>
    <CONTINUOUS_ACTION layer="4">
    local source = EffectSource()
    local imprinted = LinkedDC():Get_CardPtr(0)
    if source ~= nil and imprinted ~= nil and imprinted:GetCardType():Test(CARD_TYPE_CREATURE) then
       local source_subtype = source:GetCurrentCharacteristics():SubType_GetWritable()
       local imprinted_subtype = imprinted:GetSubType()
       for ct=1000,1230 do -- counting all creature types till Sable
          if imprinted_subtype:Test(ct) then
             source_subtype:Add(ct)
          end
       end
    end
    </CONTINUOUS_ACTION>
  </STATIC_ABILITY>
  <SFX text="COMBAT_BLADE_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
  <SFX text="COMBAT_BLADE_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
  <AI_BASE_SCORE score="1200" zone="ZONE_HAND" />
</CARD_V2>

EDIT: I found what's wrong in the creatures with variable P/T. I'll warn RiiakShiNal in his core fixes topic.

[jacque]

I just tried and it works for me. Maybe you are using another version of Primal Command without noticing, or you copied something wrong?

Sorry TFM, it was the 4th option... not 3rd >.<... I noticed the code is the same as D14's Survival of the Fittest... I noticed this was missing:

Code: Select all

for i=0, (1-1) do

Added that in and now it's working perfectly...

[thefiremind]

I noticed this was missing:

Code: Select all

for i=0, (1-1) do

Added that in and now it's working perfectly...

I removed that loop because it was useless, but then I forgot to substitute "i" with "0". I could have used a ChooseItem instead of ChooseItems, but I don't know if QUERY_FLAG_AI_COMPLEX would still work with that (and since I don't even know what QUERY_FLAG_AI_COMPLEX really does, I didn't want to take the risk).

[fallenangle]

Your Duplicant seems to be using the 2013 information. Doesn't it have different numbering (and a different artist) in the latest set?

[thefiremind]

Your Duplicant seems to be using the 2013 information. Doesn't it have different numbering (and a different artist) in the latest set?

And why should anyone be forced to use information from the latest set? I retrieved the Mirrodin version from my web generator because it had more translations, then decided to use the Archenemy ID since it has the same picture. If you can find a good picture of the Commander's Arsenal version, feel free to change it. You can even copy the abilities from my version and paste it onto yours if you prefer, I won't complain.

[drleg3nd]

if i remember correctly TFM had put in a code somewhere to kill planewalkers..is it possible to do Heros Downfall or Dreadbore ?

[thefiremind]

if i remember correctly TFM had put in a code somewhere to kill planewalkers..is it possible to do Heros Downfall or Dreadbore ?

This is the post you are looking for:
viewtopic.php?f=109&t=11726&p=132856#p132856
In other words, take the ability from Murder and substitute the TARGET_DEFINITION with the one I wrote.

[drleg3nd]

ok ladies and gentleman, time for another game of "find the error"..to play all you have to do is find any errors or discrepancies on codes..bonus points for correction

Disciple of Phenax | Open

Code: Select all

<TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When Disciple of Phenax enters the battlefield, target player reveals a number of cards from his or her hand equal to your devotion to black. You choose one of them. That player discards that card.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Quand le Disciple de Phénax arrive sur le champ de bataille, le joueur ciblé révèle un nombre de cartes de sa main égal à votre dévotion au noir. Vous en choisissez une. Ce joueur se défausse de cette carte.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cuando el Discípulo de Fenax entre al campo de batalla, el jugador objetivo muestra una cantidad de cartas de su mano igual a tu devoción al negro. Elige una de ellas. Ese jugador descarta esa carta.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Wenn die Schülerin des Phenax ins Spiel kommt, zeigt ein Spieler deiner Wahl so viele Karten aus seiner Hand offen vor, wie deine Hingabe zu Schwarz beträgt. Du bestimmst eine davon. Dieser Spieler wirft diese Karte ab.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Quando la Discepola di Fenax entra nel campo di battaglia, un giocatore bersaglio rivela dalla sua mano un numero di carte pari alla tua devozione al nero. Scegli una di quelle carte. Quel giocatore scarta quella carta.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[フィナックスの信奉者が戦場に出たとき、プレイヤー１人を対象とする。そのプレイヤーは自分の手札から、あなたの黒への信心に等しい枚数のカードを公開する。あなたはそのうちの１枚を選ぶ。そのプレイヤーはそのカードを捨てる。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[페낙스의 사도가 전장에 들어올 때, 플레이어 한 명을 목표로 정한다. 그 플레이어는 당신의 흑색 신앙심만큼의 카드를 손에서 공개한다. 당신은 그 카드들 중에서 한 장을 고른다. 그 플레이어는 그 카드를 버린다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Когда Приверженица Фенакса выходит на поле битвы, целевой игрок показывает количество карт из своей руки, равное вашей Преданности черному. Вы выбираете одну из них. Тот игрок сбрасывает ту карту.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Quando Discípulo de Fenax entra no campo de batalha, o jogador alvo revela um número de cards da própria mão igual a sua devoção ao preto. Você escolhe um deles. Aquele jogador descarta aquele card.]]></LOCALISED_TEXT>
    <TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
    <FILTER filter_id="0">
    local filter = ClearFilter()
    filter:SetFilterType(FILTER_TYPE_PLAYERS)
    filter:Add( FE_TEAM, OP_NOT, EffectController():GetTeam() )
    </FILTER>
    <RESOLUTION_TIME_ACTION filter_id="0">
    local controller = EffectSourceLKI():GetPlayer()
    local dFilter = ClearFilter()
    dFilter:Add( FE_CONTROLLER, OP_IS, EffectController() )
    local dSubFilter = dFilter:AddSubFilter_Or()
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT )
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_ENCHANTMENT )
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_LAND )
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_PLANESWALKER )
    local nTotal = dFilter:ChromaCount( COLOUR_BLACK )
    local total = filter:CountStopAt( target_player:Hand_Count() )
       if total &gt; 0 then
          filter:Clear()
          filter:SetZone(ZONE_HAND, target_player)
          target_player:SetItemCount(total)
          for i=0,total-1 do
             target_player:SetItemPrompt(i, "CARD_QUERY_CHOOSE_CARD_TO_REVEAL")
          end
          target_player:ChooseItems( EffectDC():Make_Targets(1) )
       end
    end      
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
    if target_player ~= nil then
       local total = EffectDC():Get_Targets(1) and EffectDC():Get_Targets(1):Count()
       if total ~= nil and total &gt; 0 then
          for i=0,total-1 do
             local card = EffectDC():Get_Targets(1):Get_CardPtr(i)
             if card ~= nil then
                card:Reveal()
             end
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
    if target_player ~= nil then
       local total = EffectDC():Get_Targets(1) and EffectDC():Get_Targets(1):Count()
       if total ~= nil and total &gt; 0 then
          EffectController():ChooseItemFromDC( "CARD_QUERY_CHOOSE_CARD_TO_DISCARD", EffectDC():Get_Targets(1), EffectDC():Make_Targets(2) )
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_card = EffectDC():Get_Targets(2) and EffectDC():Get_Targets(2):Get_CardPtr(0)
    if target_card ~= nil then
       target_card:Discard()
    end
    </RESOLUTION_TIME_ACTION>
    <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
  </TRIGGERED_ABILITY>

Witches' Eye | Open

Code: Select all

<STATIC_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Equipped creature has “{1}, {T}: Scry 1.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[La créature équipée a « {1}, {T} : Regard 1. »]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[La criatura equipada tiene “{1}, {T}: Adivina 1”.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Die ausgerüstete Kreatur hat „{1}, {T}: Hellsicht 1.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[La creatura equipaggiata ha “{1}, {T}: Profetizza 1.”]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[装備しているクリーチャーは「{1}, {T}：占術１を行う。」を持つ。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[장착된 생물은 “{1}, {T}: 점술 1을 한다.”라는 능력을 가진다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Снаряженное существо имеет способность «{1}, {T}: предскажите 1».]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[A criatura equipada tem “{1}, {T}: Vidência 1.”]]></LOCALISED_TEXT>
    <CONTINUOUS_ACTION layer="8">
    if EffectSource()~= nil then
       local parent = EffectSource():GetParent()
       if parent ~= nil then
          parent:GetCurrentCharacteristics():GrantAbility(1)
       end
    end
    </CONTINUOUS_ACTION>
    <AI_AVAILABILITY window_step="declare_blockers" type="window" />
    <AI_AVAILABILITY type="in_response" response_source="1" />
    <AI_AVAILABILITY window_step="declare_blockers" type="window" />
    <AI_AVAILABILITY type="in_response" response_target="1" />
  </STATIC_ABILITY>
  <ACTIVATED_ABILITY resource_id="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[{1}, {T}: Scry 1.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[{1}, {T} : Regard 1.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[{1}, {T}: Adivina 1.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[{1}, {T}: Hellsicht 1.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[{1}, {T}: Profetizza 1.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[{1}, {T}：占術１を行う。」を持つ。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[{1}, {T}: 점술 1을 한다.”라는 능력을 가진다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[{1}, {T}: предскажите 1».]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[{1}, {T}: Vidência 1.]]></LOCALISED_TEXT>
    <COST mana_cost="{1}" type="Mana" />
    <COST type="TapSelf" />
    <RESOLUTION_TIME_ACTION>
    local filter = ClearFilter()
    local effectController = EffectController()
    filter:SetZone( ZONE_LIBRARY, effectController )
    filter:SetPortion( 1 )
    effectController:SetItemCount( 1 )
    effectController:SetItemPrompt(0, "CARD_QUERY_CHOOSE_CARD_TO_PUT_ON_BOTTOM_LIBRARY" )
    effectController:SetItemPrompt(1, "CARD_QUERY_CHOOSE_CARD_TO_PUT_ON_BOTTOM_LIBRARY" )
    effectController:ChooseItems( EffectDC():Make_Targets(0), QUERY_FLAG_UP_TO )
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local rem_count = 1
    local cardsInLibrary = EffectController():Library_Count()
    if rem_count &gt; cardsInLibrary then
      rem_count = cardsInLibrary
    end
    local target_array = {}
    for i=0,1 do
      target_array[i] = EffectDC():Get_Targets(0):Get_CardPtr(i)
    end
    for i = 0,1 do
      if target_array[i] ~= nil then
         target_array[i]:PutOnBottomOfLibrary()
         rem_count = rem_count-1
       end
    end
    EffectDC():Set_Int(1, rem_count)
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local filter = ClearFilter()
    local effectController = EffectController()
    local remainingCount = EffectDC():Get_Int(2)
    if remainingCount &gt; 0 then
      filter:SetZone( ZONE_LIBRARY, effectController )
      filter:SetPortion( remainingCount )
      effectController:SetItemCount( remainingCount )
       for i = 0, (remainingCount-1) do
          effectController:SetItemPrompt( i, "CARD_QUERY_CHOOSE_CARD_TO_PUT_ONTO_LIBRARY" )
       end
       effectController:ChooseItems( EffectDC():Make_Targets(1) )
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local remainingCount = EffectDC():Get_Int(2)
    if remainingCount &gt; 0 then
      local target_array = {}
       for i = 0, (remainingCount-1) do
         target_array[i] = EffectDC():Get_Targets(1):Get_CardPtr(i)
       end
       for i = 0, (remainingCount-1) do
         if target_array[i] ~= nil then
           target_array[i]:PutOnTopOfLibrary()
         end
       end
    end
    </RESOLUTION_TIME_ACTION>
  </ACTIVATED_ABILITY>
  <ACTIVATED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Equip {1}]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Équipement {1}]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Equipar {1}.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Ausrüsten {1}]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Equipaggiare {1}]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[装備 {1}]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[장착 {1}]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Снарядить {1}]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Equipar {1}]]></LOCALISED_TEXT>
    <COST mana_cost="{1}" type="Mana" />
    <AVAILABILITY sorcery_time="1" />
    <AI_AVAILABILITY type="restriction" restriction_type="equip" />
    <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_EQUIP" definition="0" compartment="0" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
    </TARGET_DEFINITION>
    <RESOLUTION_TIME_ACTION>
    local target_card = EffectDC():Get_Targets(0):Get_CardPtr(0)
    if (target_card ~= nil and EffectSource() ~= nil) then
       EffectSource():Attach( target_card )   
    end
    </RESOLUTION_TIME_ACTION>
    <AUTO_SKIP>
    local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
    if target ~= nil then
       return false
    else
       return true
    end
    </AUTO_SKIP>
  </ACTIVATED_ABILITY>

Agent of the Fates | Open

Code: Select all

<TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Heroic — Whenever you cast a spell that targets Agent of the Fates, each opponent sacrifices a creature.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Héroïque — À chaque fois que vous lancez un sort qui cible l’Agent des Moires, chaque adversaire sacrifie une créature.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Heroísmo — Siempre que lances un hechizo que haga objetivo al Agente de las Moiras, cada oponente sacrifica una criatura.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Heroisch — Immer wenn du einen Zauberspruch wirkst, der den Agenten des Schicksals als Ziel hat, opfert jeder Gegner eine Kreatur.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Eroismo — Ogniqualvolta lanci una magia che bersaglia l’Agente delle Moire, ogni avversario sacrifica una creatura.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[英雄的 ― あなたが運命の工作員を対象とする呪文を１つ唱えるたび、各対戦相手はそれぞれクリーチャーを１体生け贄に捧げる。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[영웅 — 당신이 운명의 집행자를 목표로 주문을 발동할 때마다, 각 상대는 생물 한 개를 희생한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Героизм — Каждый раз, когда вы разыгрываете заклинание, целью которого является Агент Судеб, каждый оппонент жертвует существо.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Heroico — Toda vez que você conjura uma mágica cujo alvo é Agente dos Destinos, cada oponente sacrifica uma criatura.]]></LOCALISED_TEXT>
    <SFX text="CASTER_BUFF_PLAY" />
    <TRIGGER value="BECAME_TARGET_OF_SPELL" simple_qualifier="self">
    return SecondaryObject():GetController() == EffectController()
    </TRIGGER>
    <RESOLUTION_TIME_ACTION repeating="1">
    local n = MTG():GetActionRepCount()               
    local num_players = MTG():GetNumberOfPlayers()
    if n &lt; num_players then
       local player = MTG():GetNthPlayer(n)
       if player ~= nil and player:GetTeam() ~= EffectController():GetTeam() then
          local filter = ClearFilter()
          filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
          filter:Add(FE_CONTROLLER, OP_IS, player)
          if filter:CountStopAt(1) == 1 then
             player:ChooseItem( "CHOOSE_A_CREATURE_TO_SACRIFICE", EffectDC():Make_Targets(n) )
          end
       end
       return true
    else
       for i=0,num_players-1 do
          local player = MTG():GetNthPlayer(i)
          if player ~= nil and player:GetTeam() ~= EffectController():GetTeam() then
             local creature = EffectDC():Get_Targets(i) and EffectDC():Get_Targets(i):Get_CardPtr(0)
             if creature ~= nil then
                MTG():GetNthPlayer(i):Sacrifice(creature)
             end
          end
       end
    end
    return false
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>

Blaze Commando | Open

Code: Select all

<TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Whenever an instant or sorcery spell you control deals damage, put two 1/1 red and white Soldier creature tokens with haste onto the battlefield.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[À chaque fois qu’un sort d’éphémère ou de rituel que vous contrôlez inflige des blessures, mettez sur le champ de bataille deux jetons de créature 1/1 rouge et blanche Soldat avec la célérité.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Siempre que un hechizo de instantáneo o de conjuro que controles haga daño, pon en el campo de batalla dos fichas de criatura Soldado rojas y blancas 1/1 con la habilidad de prisa.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Immer wenn ein Spontanzauber oder eine Hexerei, den oder die du kontrollierst, Schaden zufügt, bringe zwei 1/1 rote und weiße Soldat-Kreaturenspielsteine mit Eile ins Spiel.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Ogniqualvolta una magia istantaneo o stregoneria che controlli infligge danno, metti sul campo di battaglia due pedine creatura Soldato 1/1 rosse e bianche con rapidità.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[あなたがコントロールするインスタント呪文かソーサリー呪文がダメージを与えるたび、速攻を持つ赤であり白である１/１の兵士・クリーチャー・トークンを２体戦場に出す。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[당신이 조종하는 순간마법이나 집중마법 주문이 피해를 입힐 때마다, 신속 능력을 가졌으며 적색이고 백색인 1/1 병사 생물 토큰 두 개를 전장에 놓는다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Каждый раз, когда мгновенное заклинание или заклинание волшебства под вашим контролем наносит повреждения, положите на поле битвы две фишки существа 1/1 красный и белый Солдат с Ускорением.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Whenever an instant or sorcery spell you control deals damage, put two 1/1 red and white Soldier creature tokens with haste onto the battlefield.]]></LOCALISED_TEXT>
    <TRIGGER value="SOURCE_DEALS_DAMAGE" simple_qualifier="objectyoucontrol" pre_trigger="1" damage_type="all">
    return (TriggerObject():GetCardType():Test(CARD_TYPE_INSTANT) or TriggerObject():GetCardType():Test(CARD_TYPE_SORCERY) )
   </TRIGGER>
   <FILTER filter_id="0">
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE  )
    filter:Add( FE_TEAM, OP_NOT, EffectController():GetTeam() )
    </FILTER>
   <RESOLUTION_TIME_ACTION>
    MTG():PutTokenCopiesOntoBattlefield( "TOKEN_SOLDIER_1_1_RW_812350806", 2, EffectController() )
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>

[RiiakShiNal]

Disciple of Phenax:

• You are missing a TARGET block for "Target player".
• There is no need for a filter on this card so the FILTER block is useless.
• You have not defined target_player so it is nil and will throw errors.
• The card says they reveal the top X cards, not choose X cards so this whole block is wrong:

  Code: Select all

            target_player:SetItemCount(total)
          for i=0,total-1 do
             target_player:SetItemPrompt(i, "CARD_QUERY_CHOOSE_CARD_TO_REVEAL")
          end
          target_player:ChooseItems( EffectDC():Make_Targets(1) )

Witches' Eye:

• You should grant the ability on layer 6 instead of layer 8.
• You have a SetItemCount() of 1 (which is right), but then you have 2 SetItemPrompt() calls when you only need 1.
• In your second RESOLUTION_TIME_ACTION your loops are "for i=0,1 do", but you only have 1 item not two. Loops are pointless when you only have 1 item.
• For remainingCount you call Get_Int(2), but you haven't set register 2.

Agent of the Fates: At a casual glance I'm not really seeing a problem with this one, though you could change "MTG():GetNthPlayer(i):Sacrifice(creature)" to just "player:Sacrifice(creature)" as you have already defined player as "MTG():GetNthPlayer(i)".

Blaze Commando:

• There is no need for a FILTER here so that block is useless.
• The TRIGGER should not have pre_trigger="1" because this does not stop the damage or interfere with the damage at all.
• I'm not seeing a TOKEN_REGISTRATION, but I assume the card has one (if not it will cause crashes).
• I don't know if your token (TOKEN_SOLDIER_1_1_RW_812350806) exists or not, if not then it won't produce those tokens.
• You should use PutTokensOntoBattlefield() instead of PutTokenCopiesOntoBattlefield().

[drleg3nd]

[quote="RiiakShiNal"]Disciple of Phenax:

• You are missing a TARGET block for "Target player".
• There is no need for a filter on this card so the FILTER block is useless.
• You have not defined target_player so it is nil and will throw errors.
• The card says they reveal the top X cards, not choose X cards so this whole block is wrong:

  Code: Select all

            target_player:SetItemCount(total)
          for i=0,total-1 do
             target_player:SetItemPrompt(i, "CARD_QUERY_CHOOSE_CARD_TO_REVEAL")
          end
          target_player:ChooseItems( EffectDC():Make_Targets(1) )

thx for the help riiak, for phenax i used mire's toll seemed to be closest to ability im looking for...where can i find right code for target player ?

[RiiakShiNal]

thx for the help riiak, for phenax i used mire's toll seemed to be closest to ability im looking for...where can i find right code for target player ?

Any card with "Target Player" (I pulled this one from Balefire Liege):

Code: Select all

<TARGET tag="CARD_QUERY_CHOOSE_PLAYER_DEAL_DAMAGE" definition="0" compartment="0" count="1" />
<TARGET_DEFINITION id="0">
   local filter = ClearFilter()
   filter:SetFilterType( FILTER_TYPE_PLAYERS )
</TARGET_DEFINITION>

Obviously you will need to change the text to something more appropriate.

[drleg3nd]

how's this looks now ?

| Open

Code: Select all

<TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When Disciple of Phenax enters the battlefield, target player reveals a number of cards from his or her hand equal to your devotion to black. You choose one of them. That player discards that card.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Quand le Disciple de Phénax arrive sur le champ de bataille, le joueur ciblé révèle un nombre de cartes de sa main égal à votre dévotion au noir. Vous en choisissez une. Ce joueur se défausse de cette carte.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cuando el Discípulo de Fenax entre al campo de batalla, el jugador objetivo muestra una cantidad de cartas de su mano igual a tu devoción al negro. Elige una de ellas. Ese jugador descarta esa carta.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Wenn die Schülerin des Phenax ins Spiel kommt, zeigt ein Spieler deiner Wahl so viele Karten aus seiner Hand offen vor, wie deine Hingabe zu Schwarz beträgt. Du bestimmst eine davon. Dieser Spieler wirft diese Karte ab.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Quando la Discepola di Fenax entra nel campo di battaglia, un giocatore bersaglio rivela dalla sua mano un numero di carte pari alla tua devozione al nero. Scegli una di quelle carte. Quel giocatore scarta quella carta.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[フィナックスの信奉者が戦場に出たとき、プレイヤー１人を対象とする。そのプレイヤーは自分の手札から、あなたの黒への信心に等しい枚数のカードを公開する。あなたはそのうちの１枚を選ぶ。そのプレイヤーはそのカードを捨てる。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[페낙스의 사도가 전장에 들어올 때, 플레이어 한 명을 목표로 정한다. 그 플레이어는 당신의 흑색 신앙심만큼의 카드를 손에서 공개한다. 당신은 그 카드들 중에서 한 장을 고른다. 그 플레이어는 그 카드를 버린다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Когда Приверженица Фенакса выходит на поле битвы, целевой игрок показывает количество карт из своей руки, равное вашей Преданности черному. Вы выбираете одну из них. Тот игрок сбрасывает ту карту.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Quando Discípulo de Fenax entra no campo de batalha, o jogador alvo revela um número de cards da própria mão igual a sua devoção ao preto. Você escolhe um deles. Aquele jogador descarta aquele card.]]></LOCALISED_TEXT>
    <TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD"/>
    <TARGET tag="CARD_QUERY_CHOOSE_CARDS_TO_REVEAL" definition="0" compartment="0" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:SetFilterType( FILTER_TYPE_PLAYERS )
    </TARGET_DEFINITION>
    <RESOLUTION_TIME_ACTION filter_id="0">
    local controller = EffectSourceLKI():GetPlayer()
    local dFilter = ClearFilter()
    dFilter:Add( FE_CONTROLLER, OP_IS, EffectController() )
    local dSubFilter = dFilter:AddSubFilter_Or()
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT )
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_ENCHANTMENT )
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_LAND )
    dSubFilter:Add( FE_TYPE, OP_IS, CARD_TYPE_PLANESWALKER )
    local nTotal = dFilter:ChromaCount( COLOUR_BLACK )
    local total = filter:CountStopAt( target_player:Hand_Count() )
       if total &gt; 0 then
          filter:Clear()
          filter:SetZone(ZONE_HAND, target_player)
          target_player:SetItemCount(total)
          for i=0,total-1 do
             target_player:SetItemPrompt(i, "CARD_QUERY_CHOOSE_CARD_TO_REVEAL")
          end
          target_player:ChooseItems( EffectDC():Make_Targets(1) )
       end
    end      
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
    if target_player ~= nil then
       local total = EffectDC():Get_Targets(1) and EffectDC():Get_Targets(1):Count()
       if total ~= nil and total &gt; 0 then
          for i=0,total-1 do
             local card = EffectDC():Get_Targets(1):Get_CardPtr(i)
             if card ~= nil then
                card:Reveal()
             end
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
    if target_player ~= nil then
       local total = EffectDC():Get_Targets(1) and EffectDC():Get_Targets(1):Count()
       if total ~= nil and total &gt; 0 then
          EffectController():ChooseItemFromDC( "CARD_QUERY_CHOOSE_CARD_TO_DISCARD", EffectDC():Get_Targets(1), EffectDC():Make_Targets(2) )
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local target_card = EffectDC():Get_Targets(2) and EffectDC():Get_Targets(2):Get_CardPtr(0)
    if target_card ~= nil then
       target_card:Discard()
    end
    </RESOLUTION_TIME_ACTION>
    <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
  </TRIGGERED_ABILITY>
  <SFX text="COMBAT_BLUNT_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
  <SFX text="COMBAT_BLUNT_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
</CARD_V2>