Forge version 1.5.6

[Chris H.]

Tentative target release date: Friday November 29.

[drdev]

I assume this should be 1.5.6?

[Chris H.]

I assume this should be 1.5.6?

 
Oh my,

I changed the version number in the topic.

[drdev]

The Cascade and alternative cost crash is fixed. Given the extent of the bug's impact, should we consider a quick release to roll it out, or just do a snapshot build?

[Chris H.]

The Cascade and alternative cost crash is fixed. Given the extent of the bug's impact, should we consider a quick release to roll it out, or just do a snapshot build?

 
I currently have build bugs in my local copy and they prevent a build and release at this time.

[friarsol]

r23693
Vexing Sphinx Cumulative Upkeep displays as 0 instead of Discard a card in the CardDetailPanel. I haven't checked other things, but there are a bunch of cumulative upkeep cards that have non-mana costs, and there are other things like Deepcavern Imp that may also be affected.

[drdev]

r23693
Vexing Sphinx Cumulative Upkeep displays as 0 instead of Discard a card in the CardDetailPanel. I haven't checked other things, but there are a bunch of cumulative upkeep cards that have non-mana costs, and there are other things like Deepcavern Imp that may also be affected.

I noticed Vexing Sphinx as well and haven't yet figured it out. I've already confirmed other non-mana costs don't have the same issue, including Deepcavern Imp, though please let me know if you find any others.

[drdev]

I haven't heard anything back about the new Workshop screen on the original thread, so I thought I'd post something here in case nobody has noticed it. There are so many stickied threads right now, it's too easy to not notice a new thread or new posts to non-stickied threads. Any thought on alleviating that?

Anyway, since that original post, I've added a File menu with a Save item (Ctrl+S shortcut), undo/redo support (with the new classes FTextEditor and FUndoManager that can be reused elsewhere), a prompt to save when switching away from a card with unsaved changes (either to a different card or different screen), and support for updating rules and display of the card when saving.

I'm still looking for feedback, particularly in terms of any risks with modifying CardRules, PaperCard, and Card instances after Forge initially loads, and in terms of the conditions under which the Workshop should be available and/or editing allowed. I'd also like for people making card script changes right now to try using the screen and let me know what I could improve.

Also, if somebody with graphical design skills could help create an icon for the Workshop screen (currently using the Settings icon), as well as icons for other screens that re-use other existing icons (like the Deck Editor, Game, and Draft screens), that would be awesome. They could just be added to the default skin file for now, unless others want to create custom versions of the icons for the other skins.

Here's a screenshot of the Workshop screen for reference:

Thanks.
-Dan

[moomarc]

I havent really had time to contribute anything lately, let alone keep up with the branches, but from the screen grab it looks great. I actually dont mind the icons you've grabbed for the tabs (although I suppose the icon might not correspond as well in some skins), but when I get an opening I'll throw something together. What size are the icons?

[drdev]

I havent really had time to contribute anything lately, let alone keep up with the branches, but from the screen grab it looks great. I actually dont mind the icons you've grabbed for the tabs (although I suppose the icon might not correspond as well in some skins), but when I get an opening I'll throw something together. What size are the icons?

I scale them to 16x16 I believe, though I'd need to check the FNavigationBar source to be certain.

[drdev]

I just posted a response to some Workshop feedback here, including a list of enhancement ideas and some other clarifications.

I'd like to make a decision at least on accessibility control this week so I have time to get it working before 1.5.6 is released. Any input on that is appreciated.

Thanks.
-Dan

[drdev]

r23693
Vexing Sphinx Cumulative Upkeep displays as 0 instead of Discard a card in the CardDetailPanel. I haven't checked other things, but there are a bunch of cumulative upkeep cards that have non-mana costs, and there are other things like Deepcavern Imp that may also be affected.

I noticed Vexing Sphinx as well and haven't yet figured it out. I've already confirmed other non-mana costs don't have the same issue, including Deepcavern Imp, though please let me know if you find any others.

After getting Workshop back up and running for saving cards, I managed to fix Vexing Sphinx, along with several dozen additional cards that didn't have mana costs properly formatted before. At this point, all cards should have mana costs formatted properly. Please let me know if you find any cards I missed that still need fixing.

As for Workshop, I committed a temporary fix so the tab isn't available unless running in Developer Mode. I'll remove that fix once Workshop supports custom card/set creation, but in the meantime it should prevent most of our end users from stumbling on to it.

Another cool update that's ready to go is that reminder text now appears in italics. It's still pretty inconsistent which cards display reminder text though. Ideally it'd be nice to have it available for all cards that need it, with the ability to hide it via a setting.

With that in mind, does anybody want a setting to hide reminder text? As the code is written right now, it'd be a pretty easy setting to add.

[squee1968]

I would like that setting. Also, IMHO, I think the default setting should be set to "off", as the panel would be pretty crowded for some cards, especially for those who make that panel smaller than the default size, making the text harder to read.

[lujo]

I got a bug, not sure if this is the place - snapshot version of 1.5.6, not sure anyone reported it.

Obsidian Battleaxe (or whatever it's called) - the tribal equipment from morningtide gives you a choice of equipping it for free on any warrior when it comes into play (there's also a wizard, soldier, rogue and shaman similar equipment). It registers opponents creatures too - and if you missclick the opponents creature get's it's stats increased as if it were equipped.

You're not supposed to be able to put equipment on creatures you don't controll as far as I know.

[drdev]

I would like that setting. Also, IMHO, I think the default setting should be set to "off", as the panel would be pretty crowded for some cards, especially for those who make that panel smaller than the default size, making the text harder to read.

I just added the "Hide Reminder Text" setting to the Graphic preference section. However, I chose to default that setting to "off" (so reminder text still displays by default) so as not to change existing behavior.