Board index 
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels) 2014
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels) 2014
Formal Request Thread
Moderator: CCGHQ Admins
Re: Formal Request Thread
by drleg3nd » 03 Dec 2013, 13:04
hey guys can someone help with this card last ability and chk out the codes i inputted to see if everything chks out.thx
i was looking for Verdant Haven to copy last ability but either it wasnt made or it's not on portable HDD
i was looking for Verdant Haven to copy last ability but either it wasnt made or it's not on portable HDD
Re: Formal Request Thread
by RiiakShiNal » 03 Dec 2013, 14:00
For these abilities they will only work with manual mana as otherwise there is no way to tell when something is tapped for mana. The abilities are going to be variants on how I coded Mana Flare as they will be TRIGGERED_ABILITYs with value="BECAME_TAPPED_FOR_MANA", the difference is in what it will produce for Verdant Haven you can choose any color (so you can look at cards like Birds of Paradise and Abundant Growth) for Utopia Sprawl you only need to produce the colour that was chosen when entering the battlefield so that makes that ability slightly easier.drleg3nd wrote:hey guys can someone help with this card last ability and chk out the codes i inputted to see if everything chks out.thx
i was looking for Verdant Haven to copy last ability but either it wasnt made or it's not on portable HDD
You should note though that you will have problems with the abilities if you enchant a basic land or enchant a land that does not use my manual mana functions because the required triggers will only function with my manual mana functions.
No, this won't work. the ACTIVATED_ABILITY is completely wrong. First the ability says "target opponent's graveyard", but you define the player as EffectController() (which is you, not an opponent). You need to have a TARGET block and a TARGET_DEFINITION for selecting which opponent.drleg3nd wrote:can someone chk out this card thx,
- Tariel,Reckoner of Souls | Open
Also it says "choose a creature card at random" not "choose a card at random" so you can't use Graveyard_Count() or Graveyard_GetNth(). You need to set up a filter for CARD_TYPE_CREATURE in zone ZONE_GRAVEYARD belonging to targeted player, EvaluateObjects() on that filter then GetRandomEvaluatedObject() to get the random creature.
Also you need to watch your code structure and syntax you have an if block without an end and you have then at the end of a line without a corresponding if and end.
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2188
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Formal Request Thread
by NeoAnderson » 03 Dec 2013, 14:22
As Riiak already tell you this code will not work for many reasons.drleg3nd wrote:can someone chk out this card thx,
- Tariel,Reckoner of Souls | Open
If i would code it i thought something like this :
- Tariel,Reckoner of Souls (Tested) | Open
Last edited by NeoAnderson on 03 Dec 2013, 14:40, edited 1 time in total.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by thefiremind » 03 Dec 2013, 14:33
Tariel is both in my mod (guaranteed to work) and here (not guaranteed, I haven't checked the code myself).
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
Currently busy with life...
-
thefiremind - Programmer
- Posts: 3515
- Joined: 07 Nov 2011, 10:55
- Has thanked: 118 times
- Been thanked: 722 times
Re: Formal Request Thread
by drleg3nd » 03 Dec 2013, 20:33
thx for the help guys on Tariel and Utopia Sprawl..here is my 2nd try for Utopia, hopefully im on right track.RiiakShiNal wrote:For these abilities they will only work with manual mana as otherwise there is no way to tell when something is tapped for mana. The abilities are going to be variants on how I coded Mana Flare as they will be TRIGGERED_ABILITYs with value="BECAME_TAPPED_FOR_MANA", the difference is in what it will produce for Verdant Haven you can choose any color (so you can look at cards like Birds of Paradise and Abundant Growth) for Utopia Sprawl you only need to produce the colour that was chosen when entering the battlefield so that makes that ability slightly easier.drleg3nd wrote:hey guys can someone help with this card last ability and chk out the codes i inputted to see if everything chks out.thx
i was looking for Verdant Haven to copy last ability but either it wasnt made or it's not on portable HDD
You should note though that you will have problems with the abilities if you enchant a basic land or enchant a land that does not use my manual mana functions because the required triggers will only function with my manual mana functions.
.
Re: Formal Request Thread
by NeoAnderson » 03 Dec 2013, 22:26
Hi guys,
I have some questions, hope someone could help me.
I am working on a new card :
Elysian Fields
Type : Enchantment
Effect : At the beginning of your upkeep, if an creature is exiled in the Elysian Fields put a Elysium counter on the Elysian Fields.
: exile a non-token creature in the Elysian Fields. You can use this ability once per turn and can be only one creature at a time exiled in the Elysian Fields.
Second Ability : : remove all Elysium counters, from Elysian Fields, return to the battlefield the exiled creature with power and toughness X/X, where X is the number of counters removed added to the power and toughness at the time when it was exiled. You can use this ability once per turn and only if there is at least one Elysium counter on the Elysian Fields.
My questions :
1. First issues is about AVAILABILITY block, i know i cannot retrieve LinkedDC values from these blocks, i would know if someone have a solution to work around the problem.
2. Is possible to retrieve any information about the card that is NailOnTo another one? I mean after i have used nailonto on a card there is an inverse function to know if a card is nail on to another one??
3. To implement this card i have used a TRIGGER value="ACTIVATED_ABILITY_PLAYED" but it doesn't trigger so i had to force it with FireTrigger, now it works but i would understand why this trigger is not automatically working ?
4. As i coded the card the values permanently change, until the card changes zone. If i would keep these values changed also in other zones? For Example : a 3/3 creature is powered up by Elysian Fields and now it is 5/5, a spell make it to return in my hand , as it is coded it returns to a 3/3 status, if I would keep the powered status, which will be the better solution?
I already tried with 2 delayed triggers, granted by Elysian Fields when the card is powered up, but i had some problems, one of this issues was that the card has a conflict if is exiled again under Elysian fields, and the second power up, is overrided by the delayed dc.
I have some questions, hope someone could help me.
I am working on a new card :
Elysian Fields
Type : Enchantment
Effect : At the beginning of your upkeep, if an creature is exiled in the Elysian Fields put a Elysium counter on the Elysian Fields.
- Elysian Fields | Open
: exile a non-token creature in the Elysian Fields. You can use this ability once per turn and can be only one creature at a time exiled in the Elysian Fields.Second Ability :
: remove all Elysium counters, from Elysian Fields, return to the battlefield the exiled creature with power and toughness X/X, where X is the number of counters removed added to the power and toughness at the time when it was exiled. You can use this ability once per turn and only if there is at least one Elysium counter on the Elysian Fields.My questions :
1. First issues is about AVAILABILITY block, i know i cannot retrieve LinkedDC values from these blocks, i would know if someone have a solution to work around the problem.
2. Is possible to retrieve any information about the card that is NailOnTo another one? I mean after i have used nailonto on a card there is an inverse function to know if a card is nail on to another one??
3. To implement this card i have used a TRIGGER value="ACTIVATED_ABILITY_PLAYED" but it doesn't trigger so i had to force it with FireTrigger, now it works but i would understand why this trigger is not automatically working ?
4. As i coded the card the values permanently change, until the card changes zone. If i would keep these values changed also in other zones? For Example : a 3/3 creature is powered up by Elysian Fields and now it is 5/5, a spell make it to return in my hand , as it is coded it returns to a 3/3 status, if I would keep the powered status, which will be the better solution?
I already tried with 2 delayed triggers, granted by Elysian Fields when the card is powered up, but i had some problems, one of this issues was that the card has a conflict if is exiled again under Elysian fields, and the second power up, is overrided by the delayed dc.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by RiiakShiNal » 04 Dec 2013, 01:26
This will not work and is not correct. The second ability (choosing a color as it enters the battlefield) is not a mana ability so it should not have RSN_MarkManaAbilityStart() (you can simply remove that entire PLAY_TIME_ACTION block as it should not be there).drleg3nd wrote:thx for the help guys on Tariel and Utopia Sprawl..here is my 2nd try for Utopia, hopefully im on right track.
The TRIGGER in the 3rd ability is incomplete (invalid XML syntax due to not closing the tag) and it is wrong; it should test for EffectSource():GetParent() is not nil and that it equals TriggerObject(). Also since you don't have a RESOLUTION_TIME_ACTION block to produce the chosen colour of mana (using RSN_ProduceNoTrigger()) it can't produce anything. Since you have the player choose a colour it will never be able to produce colourless mana so the TOKEN_REGISTRATION for RSN_TOKEN_MANA_C is extraneous.
An easy way would be to use my ObjectDC functions, though you could roll your own solution using the DuelDataChest() for keeping track of whether a creature is exiled or not.NeoAnderson wrote:My questions :
1. First issues is about AVAILABILITY block, i know i cannot retrieve LinkedDC values from these blocks, i would know if someone have a solution to work around the problem.
I do not know of any such function.NeoAnderson wrote:2. Is possible to retrieve any information about the card that is NailOnTo another one? I mean after i have used nailonto on a card there is an inverse function to know if a card is nail on to another one??
It does fire, but you haven't set the LinkedDC() variable for the delayed trigger to fire at that point, you probably want ABILITY_RESOLVED which occurs after the ability resolves instead of before.NeoAnderson wrote:3. To implement this card i have used a TRIGGER value="ACTIVATED_ABILITY_PLAYED" but it doesn't trigger so i had to force it with FireTrigger, now it works but i would understand why this trigger is not automatically working ?
It should always return to the printed P/T when not on the battlefield as according to MtG rules if a creature leaves the battlefield then is brought back to the battlefield it should be treated as a new instance of the creature instead of as the same creature.NeoAnderson wrote:4. As i coded the card the values permanently change, until the card changes zone. If i would keep these values changed also in other zones? For Example : a 3/3 creature is powered up by Elysian Fields and now it is 5/5, a spell make it to return in my hand , as it is coded it returns to a 3/3 status, if I would keep the powered status, which will be the better solution?
I already tried with 2 delayed triggers, granted by Elysian Fields when the card is powered up, but i had some problems, one of this issues was that the card has a conflict if is exiled again under Elysian fields, and the second power up, is overrided by the delayed dc.
So this is something that you really shouldn't do (on top of being very difficult).
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2188
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Formal Request Thread
by drleg3nd » 04 Dec 2013, 02:13
ok 3rd attempt on Utopia Sprawl
- | Open
Re: Formal Request Thread
by NeoAnderson » 04 Dec 2013, 02:23
Ok I think the time is come for me to better check your ObjectDC functions, i need to see some examples to understand how to implement it, i read something on your wiki page about it, if i remember you have implemented it using DuelDataChest function..RiiakShiNal wrote:An easy way would be to use my ObjectDC functions, though you could roll your own solution using the DuelDataChest() for keeping track of whether a creature is exiled or not.NeoAnderson wrote:My questions :
1. First issues is about AVAILABILITY block, i know i cannot retrieve LinkedDC values from these blocks, i would know if someone have a solution to work around the problem.
B. About DuelDataChest values i am worried to encounter problems, if more players play the same spell...so problably it need more code to check this occurrance.
OK thanks anyway was just an idea to set the Availability, i thought something like if there is a card nailonto EffectSource then return false...but i think i will work around with your ObjectDC function.RiiakShiNal wrote:I do not know of any such function.NeoAnderson wrote:2. Is possible to retrieve any information about the card that is NailOnTo another one? I mean after i have used nailonto on a card there is an inverse function to know if a card is nail on to another one??
OK thanks Riiak i tried to find something with this trigger but the forum search need some improvementsRiiakShiNal wrote:It does fire, but you haven't set the LinkedDC() variable for the delayed trigger to fire at that point, you probably want ABILITY_RESOLVED which occurs after the ability resolves instead of before.NeoAnderson wrote:3. To implement this card i have used a TRIGGER value="ACTIVATED_ABILITY_PLAYED" but it doesn't trigger so i had to force it with FireTrigger, now it works but i would understand why this trigger is not automatically working ?
and i was not sure how this trigger works I will try to revise with ABILITY_RESOLVED hoping that TriggerObject is the Object who generate the trigger.I am sorry for these question but i am just trying to find something different to make with new cards, so sometimes my fantasy can override the MTG rulesRiiakShiNal wrote:It should always return to the printed P/T when not on the battlefield as according to MtG rules if a creature leaves the battlefield then is brought back to the battlefield it should be treated as a new instance of the creature instead of as the same creature.NeoAnderson wrote:4. As i coded the card the values permanently change, until the card changes zone. If i would keep these values changed also in other zones? For Example : a 3/3 creature is powered up by Elysian Fields and now it is 5/5, a spell make it to return in my hand , as it is coded it returns to a 3/3 status, if I would keep the powered status, which will be the better solution?
I already tried with 2 delayed triggers, granted by Elysian Fields when the card is powered up, but i had some problems, one of this issues was that the card has a conflict if is exiled again under Elysian fields, and the second power up, is overrided by the delayed dc.
So this is something that you really shouldn't do (on top of being very difficult).
I will left the effect as it is now.EDIT :
Riiak i tried your RSN_ObjectDC function but i am not sure if i used it correctly, the main problem is I still have the same problem of LinkedDC. I revised some parts of the card code so now is just an hybrid version with LinkedDC and RSN_ObjectDC but the worst thing is that AVAILABILITY BLOCK still gives the same error: [lua] ?:0: attempt to index a nil value.
I have initialized the RSN_Object when the card comes into battlefield
- Code: Select all
<TRIGGERED_ABILITY linked_ability_group="1" forced_skip="1">
<TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
<RESOLUTION_TIME_ACTION>
if EffectSource() ~= nil then
local oDC = RSN_GetObjectDC( EffectSource(), true )
oDC:Int_Set( 4857, 1 )
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
When i read the value i use the follow syntax ( I have use false value because the Chest should be already created):
- Code: Select all
<AVAILABILITY>
local filter = ClearFilter()
filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
filter:Add( FE_IS_TOKEN, false )
local count = filter:Count()
if count > 0 then
local oDC = RSN_GetObjectDC( EffectSource(), false )
if oDC:Int_Get( 4857 ) == 1 then
return true
else
return false
end
else
return false
end
</AVAILABILITY>
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by MC Brodie » 04 Dec 2013, 04:55
Would it work if you moved the code in the availability block to the prerequisite block in a generic cost that does nothing? I can only remember seeing "return true" in the prerequitsite block but who knows maybe it will work. Try something lke this:
- Code: Select all
<COST type="generic">
<PREREQUISITE>
local filter = ClearFilter()
filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
filter:Add( FE_IS_TOKEN, false )
local count = filter:Count()
if count > 0 then
return true
else
return false
end
</PREREQUISITE>
</COST>
-----------------------------------------------------------------------
Song of the Day: 46 and 2 (cover)
Song of the Day: 46 and 2 (cover)
Re: Formal Request Thread
by NeoAnderson » 04 Dec 2013, 05:39
Thanks you MC Brodie,MC Brodie wrote:Would it work if you moved the code in the availability block to the prerequisite block in a generic cost that does nothing? I can only remember seeing "return true" in the prerequitsite block but who knows maybe it will work. Try something lke this:
- Code: Select all
<COST type="generic">
<PREREQUISITE>
local filter = ClearFilter()
filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
filter:Add( FE_IS_TOKEN, false )
local count = filter:Count()
if count > 0 then
return true
else
return false
end
</PREREQUISITE>
</COST>
But the problem is not about the filter:Count() function it works also into AVAILABILITY block, i need to make work the reading of a Chest value like LinkedDC, or RSN_ObjectDC.
I tried this solution already with LinkedDC but it doesn't work also as PREREQUISITE.
Thanks anyway.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by RiiakShiNal » 04 Dec 2013, 14:33
Well, you didn't really fix the TRIGGER at all; it should be like this:drleg3nd wrote:ok 3rd attempt on Utopia SprawlI have to admit, these mana ability cards confuse me, it feels way over my head when I see all that zig zag of words.
- | Open
- Code: Select all
<TRIGGER value="BECAME_TAPPED_FOR_MANA">
return EffectSource():GetParent() ~= nil and EffectSource():GetParent() == TriggerObject()
</TRIGGER>
- Code: Select all
<RESOLUTION_TIME_ACTION>
-- Get the chosen colour.
LinkedDC():Int_Set(0, GetChosenColour())
</RESOLUTION_TIME_ACTION>
- Code: Select all
<RESOLUTION_TIME_ACTION>
local nColour = LinkedDC():Int_Get(0)
local oPlayer = EffectSourceLKI():GetParent() ~= nil and EffectSourceLKI():GetParent():GetController()
if (nColour == COLOUR_BLACK) then
RSN_ProduceForPlayerNoTrigger( "{B}", 1, oPlayer )
elseif (nColour == COLOUR_BLUE) then
RSN_ProduceForPlayerNoTrigger( "{U}", 1, oPlayer )
elseif (nColour == COLOUR_GREEN) then
RSN_ProduceForPlayerNoTrigger( "{G}", 1, oPlayer )
elseif (nColour == COLOUR_RED) then
RSN_ProduceForPlayerNoTrigger( "{R}", 1, oPlayer )
else
RSN_ProduceForPlayerNoTrigger( "{W}", 1, oPlayer )
end
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
RSN_EliminateExtraManaTokens()
</RESOLUTION_TIME_ACTION>
I designed my ObjectDC functions to key off the instance of a card, thus if there are multiple copies in a deck (or multiple decks), a card is copied, or is re-cast from another zone that it will always have its own unique ObjectDC chest. So if you are using my ObjectDC functions you should not have to worry about such problems.NeoAnderson wrote:Ok I think the time is come for me to better check your ObjectDC functions, i need to see some examples to understand how to implement it, i read something on your wiki page about it, if i remember you have implemented it using DuelDataChest function..
B. About DuelDataChest values i am worried to encounter problems, if more players play the same spell...so problably it need more code to check this occurrance.
For a card to access another card's ObjectDC it has to have that object's instance to access it. For example if we wanted to access CardB's ObjectDC from CardA then CardA would have to access it like:
- Code: Select all
local oBCardDC = RSN_GetObjectDC( oCardB, false )
For any card to access its own ObjectDC it only has to call RSN_ObjectDC() as that will automatically use EffectSource() to link the ObjectDC.
Given that we can't get Effect objects in current DotP versions it should give you the correct TriggerObject(). As for how the trigger works it should fire just after an ability resolves (at which point your LinkedDC() value should be set). If you need a trigger that fires after an ability is played, but before it resolves (between PLAY_TIME_ACTIONs and RESOLUTION_TIME_ACTIONs) then try ABILITY_ABOUT_TO_RESOLVE.NeoAnderson wrote:OK thanks Riiak i tried to find something with this trigger but the forum search need some improvements
EffectSource() is not always available in AVAILABILITY blocks so instead try using Object() which should always be available for linking the ObjectDC. Also if you are just going to call RSN_GetObjectDC() with EffectSource() you could just as easily use RSN_ObjectDC() which uses EffectSource() without you having to type it.NeoAnderson wrote:EDIT :
Riiak i tried your RSN_ObjectDC function but i am not sure if i used it correctly, the main problem is I still have the same problem of LinkedDC. I revised some parts of the card code so now is just an hybrid version with LinkedDC and RSN_ObjectDC but the worst thing is that AVAILABILITY BLOCK still gives the same error: [lua] ?:0: attempt to index a nil value.
I have initialized the RSN_Object when the card comes into battlefield
- Code: Select all
<TRIGGERED_ABILITY linked_ability_group="1" forced_skip="1">
<TRIGGER value="ZONECHANGE_END" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
<RESOLUTION_TIME_ACTION>
if EffectSource() ~= nil then
local oDC = RSN_GetObjectDC( EffectSource(), true )
oDC:Int_Set( 4857, 1 )
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
When i read the value i use the follow syntax ( I have use false value because the Chest should be already created):What's wrong??
- Code: Select all
<AVAILABILITY>
local filter = ClearFilter()
filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
filter:Add( FE_IS_TOKEN, false )
local count = filter:Count()
if count > 0 then
local oDC = RSN_GetObjectDC( EffectSource(), false )
if oDC:Int_Get( 4857 ) == 1 then
return true
else
return false
end
else
return false
end
</AVAILABILITY>
Also when you use a false parameter on RSN_GetObjectDC() you need to add a check for the possibility that the ObjectDC is nil. For example if you initialize the ObjectDC in a TRIGGERED_ABILITY on an Artifact or Enchantment then try to access it in an ACTIVATED_ABILITY on the same card then if the player uses the ACTIVATED_ABILITY before the TRIGGERED_ABILITY has resolved then the ObjectDC will be nil because it hasn't been initialized yet. The same situation arises with AVAILABILITY blocks as they are checked during state-based effects to see if the ability can be activated and this will occur before ETB TRIGGERED_ABILITYs finish resolving as such the ObjectDC won't be initialized yet.
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2188
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Formal Request Thread
by drleg3nd » 04 Dec 2013, 22:39
hey thx for help riiak but I guess I messed up somewhere lol got this error:
- Error | Open
Re: Formal Request Thread
by drleg3nd » 04 Dec 2013, 22:45
is Joraga Treespeaker floating around some where ? otherwise i'll attempt to make if Tfm or someone made level up ability
Who is online
Users browsing this forum: No registered users and 6 guests