Board index 
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels) 2014
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels) 2014
Formal Request Thread
Moderator: CCGHQ Admins
Re: Formal Request Thread
by NeoAnderson » 25 Dec 2013, 12:43
You're welcomeDeadpoolmtg wrote:Thanks again NeoAnderson!
I have a question:
CARD_UI_TEXT4 goes on "DATA_DLC_DECK_BUILDER_CUSTOM\DATA_ALL_PLATFORMS\CARDS"?
The path for that file is \DATA_DLC_DECK_BUILDER_CUSTOM\DATA_ALL_PLATFORMS\TEXT_PERMANENT
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by NeoAnderson » 25 Dec 2013, 16:56
About Pyromancer Ascension and Hive Mind you cand find it inside sumomole mod: http://www.slightlymagic.net/forum/viewtopic.php?f=109&t=10914
About Pyromancer's Swath i have encountered some problems because into 2014 there isn't Set_Amount for damage and with multiply is not possible to add just 2 point of damage, probably other skilled users can put some light on this issue.
About Pyromancer's Swath i have encountered some problems because into 2014 there isn't Set_Amount for damage and with multiply is not possible to add just 2 point of damage, probably other skilled users can put some light on this issue.
Last edited by NeoAnderson on 25 Dec 2013, 17:29, edited 1 time in total.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by thefiremind » 25 Dec 2013, 17:08
We discussed about this before and there's no way to add damage properly in DotP2014. More about it on this post (and following).NeoAnderson wrote:About Pyromancer's Swath i have encountered some problems because into 2014 there isn't Set_Amount for damage and with multiply is not possible to add just 2 point of damage, probably other skilled users can put some light on this issue.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
Currently busy with life...
-
thefiremind - Programmer
- Posts: 3515
- Joined: 07 Nov 2011, 10:55
- Has thanked: 118 times
- Been thanked: 722 times
Re: Formal Request Thread
by NeoAnderson » 25 Dec 2013, 17:15
Yeah i think i have already read that post my friendthefiremind wrote:We discussed about this before and there's no way to add damage properly in DotP2014. More about it on this post (and following).NeoAnderson wrote:About Pyromancer's Swath i have encountered some problems because into 2014 there isn't Set_Amount for damage and with multiply is not possible to add just 2 point of damage, probably other skilled users can put some light on this issue.
For example this card require to add 2 damage point we could replace it so :
1. Damage multiply (2)
2. Damage Prevent ( (Damage():GetAmount / 2) - 2 )
Numerical example : Damage 3 points
1. Multiply(2) = 3*2 = 6
2. Prevent Amount ( (6 / 2) - 2) = (3 - 2) = 1
Total damage 6 - 1 = 5
But for some reason i received unexpected results
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by NeoAnderson » 25 Dec 2013, 17:25
Another card requestedDeadpoolmtg wrote:Hi guys, need the following cards to enhance the Pyromancer Ascencion(Spellweaver Helix) deck and other to make a Hive Mind deck.
Pact of the Titan (Hive Mind)
Pyromancer's Swath (Pyromancer Ascension)
Ideas Unbound (Pyromancer Ascension)
Here you can download it :
IDEAS_UNBOUND_88789.zip- Card XML + TDX
- (586 KiB) Downloaded 221 times
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by NeoAnderson » 25 Dec 2013, 17:50
I made a revised version of this card using Riiak Mana Function.silver1114 wrote:I need a gyre sage that can handel any amount of counters on it and it should proly use manual mana so the mana has a mana pool
the gyre sage i have only can saport 19 +1/+1 counter then when you tap it no mater the number of countere you only get 19 green mana.
- Gyre_Sage | Open
to your mana pool for each +1/+1 counter on Now it should add any numbers of mana to your mana pool.
- GYRE_SAGE_627063.zip
- Card XML + TDX
- (111.71 KiB) Downloaded 246 times
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by RiiakShiNal » 25 Dec 2013, 19:41
Well, if Damage():Multiply() will accept a floating point number then you could just multiply by (1 + (2.0 / Damage():GetAmount())), but that is only if Multiply() will work properly with floating point multipliers (and round the result).NeoAnderson wrote:Yeah i think i have already read that post my friend
For example this card require to add 2 damage point we could replace it so :
1. Damage multiply (2)
2. Damage Prevent ( (Damage():GetAmount / 2) - 2 )
Numerical example : Damage 3 points
1. Multiply(2) = 3*2 = 6
2. Prevent Amount ( (6 / 2) - 2) = (3 - 2) = 1
Total damage 6 - 1 = 5
But for some reason i received unexpected results
Mathematically it works:
- Code: Select all
Damage + 2 = Damage * Multiplier
(Damage + 2) / Damage = (Damage * Multiplier) / Damage
(Damage / Damage) + (2 / Damage) = Multiplier
1 + (2 / Damage) = Multiplier
Also for Gyre Sage a better way to code the mana production step would be like this:
- Code: Select all
<RESOLUTION_TIME_ACTION>
local GreenTotal = EffectSourceLKI():CountCounters(MTG():PlusOnePlusOneCounters())
RSN_Produce( "{G}", GreenTotal )
</RESOLUTION_TIME_ACTION>
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2188
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Formal Request Thread
by NeoAnderson » 26 Dec 2013, 00:02
Hi my friend, the solution above, is the same TheFireMind used into the other topic, and i also tried but it doesn't work.RiiakShiNal wrote:Well, if Damage():Multiply() will accept a floating point number then you could just multiply by (1 + (2.0 / Damage():GetAmount())), but that is only if Multiply() will work properly with floating point multipliers (and round the result).
Mathematically it works:Given the above for an initial damage of 4 you would get a multiplier of 1.5 with 1.5 * 4 = 6. For an initial damage of 5 you would get a multiplier of 1.4 with 1.4 * 5 = 7. For an initial damage of 9 you would get a multiplier of 1 2/9 (approximately 1.222222, actually 1.2 with a repeating decimal of 2) with 1 2/9 * 9 = 11 (1.222222 * 9 = 10.999998). For an initial damage of 3 you would get a multiplier of 1 2/3 (approximately 1.666667, actually 1.6 with a repeating decimal of 6) with 1 2/3 * 3 = 5 (1.666667 * 3 = 5.000001). Due to the approximations either the Multiply() function would have to round the result or you would have to add a very small amount to the multiplier (like 0.000001) so it will truncate to the proper value (this is assuming the Multiply function accepts floating point numbers).
- Code: Select all
Damage + 2 = Damage * Multiplier
(Damage + 2) / Damage = (Damage * Multiplier) / Damage
(Damage / Damage) + (2 / Damage) = Multiplier
1 + (2 / Damage) = Multiplier
Probably Multiply asks for an integer parameter, or rounds it or trunc it before computing the operation.
Anyway i found another solution, it is not perfect, because Unpreventable Damage lose this characteristic, but it is the only one i found to have an approximation to these kind of card who increments the damage.
- Code: Select all
<TRIGGERED_ABILITY replacement_effect="1">
<TRIGGER value="SOURCE_DEALS_DAMAGE_TO_PLAYER" simple_qualifier="objectyoucontrol" pre_trigger="1" damage_type="all">
if (TriggerObject():GetCardType():Test(CARD_TYPE_INSTANT) or TriggerObject():GetCardType():Test(CARD_TYPE_SORCERY) ) then
local delayDC = EffectDC():Make_Chest(0)
delayDC:Set_CardPtr(0, TriggerObject())
delayDC:Protect_CardPtr(0)
delayDC:Set_PlayerPtr(1, SecondaryPlayer())
MTG():CreateDelayedTrigger(1, delayDC)
return true
else
return false
end
</TRIGGER>
<RESOLUTION_TIME_ACTION>
if Damage():GetAmount() == 1 then
Damage():Multiply(3)
else
Damage():Multiply(2)
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
<TRIGGERED_ABILITY replacement_effect="1">
<TRIGGER value="SOURCE_DEALS_DAMAGE_TO_OBJECT" simple_qualifier="objectyoucontrol" pre_trigger="1" damage_type="all">
if (TriggerObject():GetCardType():Test(CARD_TYPE_INSTANT) or TriggerObject():GetCardType():Test(CARD_TYPE_SORCERY) ) then
local delayDC = EffectDC():Make_Chest(0)
delayDC:Set_CardPtr(0, TriggerObject())
delayDC:Protect_CardPtr(0)
delayDC:Set_CardPtr(1, SecondaryObject())
delayDC:Protect_CardPtr(1)
MTG():CreateDelayedTrigger(2, delayDC)
return true
else
return false
end
</TRIGGER>
<RESOLUTION_TIME_ACTION>
if Damage():GetAmount() == 1 then
Damage():Multiply(3)
else
Damage():Multiply(2)
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
<TRIGGERED_ABILITY resource_id ="1" replacement_effect="1">
<TRIGGER value="PLAYER_TAKES_DAMAGE" >
local PlayerReceiving = EffectDC():Get_PlayerPtr(1)
if TriggerPlayer() == PlayerReceiving then
return true
else
return false
end
</TRIGGER>
<CLEANUP fire_once="1" />
<RESOLUTION_TIME_ACTION>
if Damage():GetAmount() > 3 then
local amount = Damage():GetAmount()
local amountfinal = ((amount/2) - 2 )
Damage():PreventAmount( amountfinal )
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
<TRIGGERED_ABILITY resource_id ="2" replacement_effect="1">
<TRIGGER value="OBJECT_TAKES_DAMAGE" >
local CardReceiving = EffectDC():Get_CardPtr(1)
if TriggerObject() == CardReceiving then
return true
else
return false
end
</TRIGGER>
<CLEANUP fire_once="1" />
<RESOLUTION_TIME_ACTION>
if Damage():GetAmount() > 3 then
local amount = Damage():GetAmount()
local amountfinal = ((amount/2) - 2 )
Damage():PreventAmount( amountfinal )
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
I made some tests and it seems to work properly please it you can take a look and let me know if could be ok.
You're right i just take the code from a card i made sometime ago,RiiakShiNal wrote:Also for Gyre Sage a better way to code the mana production step would be like this:
- Code: Select all
<RESOLUTION_TIME_ACTION>
local GreenTotal = EffectSourceLKI():CountCounters(MTG():PlusOnePlusOneCounters())
RSN_Produce( "{G}", GreenTotal )
</RESOLUTION_TIME_ACTION>
So here you can find my version of Pyromancer's Swath (Still to be better tested)
- PYROMANCERS_SWATH_370397.zip
- Card XML + TDX
- (521.6 KiB) Downloaded 226 times
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by Deadpoolmtg » 26 Dec 2013, 00:58
The cards seems to work when only one is on battlefield, when i put two more, the damage was 0. Tested with Flame Jab.NeoAnderson wrote:Hi my friend, the solution above, is the same TheFireMind used into the other topic, and i also tried but it doesn't work.RiiakShiNal wrote:Well, if Damage():Multiply() will accept a floating point number then you could just multiply by (1 + (2.0 / Damage():GetAmount())), but that is only if Multiply() will work properly with floating point multipliers (and round the result).
Mathematically it works:Given the above for an initial damage of 4 you would get a multiplier of 1.5 with 1.5 * 4 = 6. For an initial damage of 5 you would get a multiplier of 1.4 with 1.4 * 5 = 7. For an initial damage of 9 you would get a multiplier of 1 2/9 (approximately 1.222222, actually 1.2 with a repeating decimal of 2) with 1 2/9 * 9 = 11 (1.222222 * 9 = 10.999998). For an initial damage of 3 you would get a multiplier of 1 2/3 (approximately 1.666667, actually 1.6 with a repeating decimal of 6) with 1 2/3 * 3 = 5 (1.666667 * 3 = 5.000001). Due to the approximations either the Multiply() function would have to round the result or you would have to add a very small amount to the multiplier (like 0.000001) so it will truncate to the proper value (this is assuming the Multiply function accepts floating point numbers).
- Code: Select all
Damage + 2 = Damage * Multiplier
(Damage + 2) / Damage = (Damage * Multiplier) / Damage
(Damage / Damage) + (2 / Damage) = Multiplier
1 + (2 / Damage) = Multiplier
Probably Multiply asks for an integer parameter, or rounds it or trunc it before computing the operation.
Anyway i found another solution, it is not perfect, because Unpreventable Damage lose this characteristic, but it is the only one i found to have an approximation to these kind of card who increments the damage.As it is wrote works for damage + 2 for other increments need some modifies.
- Code: Select all
<TRIGGERED_ABILITY replacement_effect="1">
<TRIGGER value="SOURCE_DEALS_DAMAGE_TO_PLAYER" simple_qualifier="objectyoucontrol" pre_trigger="1" damage_type="all">
if (TriggerObject():GetCardType():Test(CARD_TYPE_INSTANT) or TriggerObject():GetCardType():Test(CARD_TYPE_SORCERY) ) then
local delayDC = EffectDC():Make_Chest(0)
delayDC:Set_CardPtr(0, TriggerObject())
delayDC:Protect_CardPtr(0)
delayDC:Set_PlayerPtr(1, SecondaryPlayer())
MTG():CreateDelayedTrigger(1, delayDC)
return true
else
return false
end
</TRIGGER>
<RESOLUTION_TIME_ACTION>
if Damage():GetAmount() == 1 then
Damage():Multiply(3)
else
Damage():Multiply(2)
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
<TRIGGERED_ABILITY replacement_effect="1">
<TRIGGER value="SOURCE_DEALS_DAMAGE_TO_OBJECT" simple_qualifier="objectyoucontrol" pre_trigger="1" damage_type="all">
if (TriggerObject():GetCardType():Test(CARD_TYPE_INSTANT) or TriggerObject():GetCardType():Test(CARD_TYPE_SORCERY) ) then
local delayDC = EffectDC():Make_Chest(0)
delayDC:Set_CardPtr(0, TriggerObject())
delayDC:Protect_CardPtr(0)
delayDC:Set_CardPtr(1, SecondaryObject())
delayDC:Protect_CardPtr(1)
MTG():CreateDelayedTrigger(2, delayDC)
return true
else
return false
end
</TRIGGER>
<RESOLUTION_TIME_ACTION>
if Damage():GetAmount() == 1 then
Damage():Multiply(3)
else
Damage():Multiply(2)
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
<TRIGGERED_ABILITY resource_id ="1" replacement_effect="1">
<TRIGGER value="PLAYER_TAKES_DAMAGE" >
local PlayerReceiving = EffectDC():Get_PlayerPtr(1)
if TriggerPlayer() == PlayerReceiving then
return true
else
return false
end
</TRIGGER>
<CLEANUP fire_once="1" />
<RESOLUTION_TIME_ACTION>
if Damage():GetAmount() > 3 then
local amount = Damage():GetAmount()
local amountfinal = ((amount/2) - 2 )
Damage():PreventAmount( amountfinal )
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
<TRIGGERED_ABILITY resource_id ="2" replacement_effect="1">
<TRIGGER value="OBJECT_TAKES_DAMAGE" >
local CardReceiving = EffectDC():Get_CardPtr(1)
if TriggerObject() == CardReceiving then
return true
else
return false
end
</TRIGGER>
<CLEANUP fire_once="1" />
<RESOLUTION_TIME_ACTION>
if Damage():GetAmount() > 3 then
local amount = Damage():GetAmount()
local amountfinal = ((amount/2) - 2 )
Damage():PreventAmount( amountfinal )
end
</RESOLUTION_TIME_ACTION>
</TRIGGERED_ABILITY>
I made some tests and it seems to work properly please it you can take a look and let me know if could be ok.You're right i just take the code from a card i made sometime ago,RiiakShiNal wrote:Also for Gyre Sage a better way to code the mana production step would be like this:
- Code: Select all
<RESOLUTION_TIME_ACTION>
local GreenTotal = EffectSourceLKI():CountCounters(MTG():PlusOnePlusOneCounters())
RSN_Produce( "{G}", GreenTotal )
</RESOLUTION_TIME_ACTION>
So here you can find my version of Pyromancer's Swath (Still to be better tested)
I do not know if it is normal, but at the end of opponent's turn there was an activation of an effect that could not see what happened. Similar to the effect of discarding the hand at end of turn, but the opponent do not discarded anything, the ability triggered with no apparent effect.
-
Deadpoolmtg - Posts: 12
- Joined: 02 Jul 2013, 17:25
- Has thanked: 28 times
- Been thanked: 0 time
Re: Formal Request Thread
by NeoAnderson » 26 Dec 2013, 01:55
As i said the card were not tested well.Deadpoolmtg wrote:The cards seems to work when only one is on battlefield, when i put two more, the damage was 0. Tested with Flame Jab.
I do not know if it is normal, but at the end of opponent's turn there was an activation of an effect that could not see what happened. Similar to the effect of discarding the hand at end of turn, but the opponent do not discarded anything, the ability triggered with no apparent effect.
Anyway i tried and you're right if there are multiple instances of the card it doesn't work.
At this point i don't know if we can do something to fix it.
About the triggering at the end of turn, is normal because i didn't se any control if the player has no cards in hand, so the trigger fire anyway also if that player has no cards.(This is simple to fix.)
Tomorrow i will try to make some modifies but i really don't know if this card could work as expected.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by NeoAnderson » 26 Dec 2013, 08:55
Ok my friend i have made a revised version of this card now it should work also for multiple instances, i made some tests without problems, but to better understand if it correctly works please hard test it with different combos and situations and let me know.Deadpoolmtg wrote:The cards seems to work when only one is on battlefield, when i put two more, the damage was 0. Tested with Flame Jab.
I do not know if it is normal, but at the end of opponent's turn there was an activation of an effect that could not see what happened. Similar to the effect of discarding the hand at end of turn, but the opponent do not discarded anything, the ability triggered with no apparent effect.
The concept idea is simple :
1. The card allow to trigger only one instance setting a PlayerDataChest.
2. The Instance who will trigger will consider also all the other instances of the card.
3. It retrieves the most closer index to multiply the damage.
4. It prevents the excess damage.
In the screenshoot below we have the follow play action :
On the battlefield we have 2 instance of Pyromancer's Swath we have played Sulfurous Blast.
Normally it deals 3 damage to each players if played during sorcery time.
Considering the 2 instances of Pyromancer's Swath the damage should be : 3 + 2 + 2 = 7
So the card will multiply the damage of 3 with an index of 3. We will have a damage of 9.
Making the difference between the obtained damage and the damage we should have 9 - 7 = 2 this will be the damage prevented.
With this solution is easier to modify the additional damage for other cards
Here you can download the revised card :
- PYROMANCERS_SWATH_370397 rev A.zip
- Card revised XML + TDX
- (521.87 KiB) Downloaded 223 times
Last edited by NeoAnderson on 27 Dec 2013, 03:51, edited 2 times in total.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by MC Brodie » 26 Dec 2013, 22:39
I need some help with Seht's Tiger. I couldn't figure out how to give protection to a player the normal way so I tried to code the parts of DEBT using delayed triggers. I have something working for damage and targeting but I don't know how to do the enchantments part. Any suggestions?
-----------------------------------------------------------------------
Song of the Day: 46 and 2 (cover)
Song of the Day: 46 and 2 (cover)
Re: Formal Request Thread
by thefiremind » 26 Dec 2013, 22:50
Actually, unless they screwed it up in DotP2014, it should work just like it works for creatures: set the filter, then call EffectController():Protection().MC Brodie wrote:I need some help with Seht's Tiger. I couldn't figure out how to give protection to a player the normal way so I tried to code the parts of DEBT using delayed triggers. I have something working for damage and targeting but I don't know how to do the enchantments part. Any suggestions?
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
Currently busy with life...
-
thefiremind - Programmer
- Posts: 3515
- Joined: 07 Nov 2011, 10:55
- Has thanked: 118 times
- Been thanked: 722 times
Re: Formal Request Thread
by NeoAnderson » 26 Dec 2013, 23:21
I have not tested but try if this works (Updated i made a quick test and i also revise a small part now should work):thefiremind wrote:Actually, unless they screwed it up in DotP2014, it should work just like it works for creatures: set the filter, then call EffectController():Protection().MC Brodie wrote:I need some help with Seht's Tiger. I couldn't figure out how to give protection to a player the normal way so I tried to code the parts of DEBT using delayed triggers. I have something working for damage and targeting but I don't know how to do the enchantments part. Any suggestions?
- Seht’s Tiger UNTESTED | Open
I know it is not exactly what we would do, but until DotP developers, decide to use functions that make sense, i think can be an acceptable approximation.
Please check the version below i have replaced DuelDataChest with PlayerDataChest due to possible conflicts when more players have this card into play.
- PYROMANCERS_SWATH_370397 rev A.zip
- Card Revised ver A. XML + TDX
- (521.87 KiB) Downloaded 245 times
2. I also have a question for you, and Riiak, sumomole.
Probably i already know the answer ("NO") but i want to try anyway.
There is any possibility to remove an attacking creture (after attacking declared) without using function to put it into another zone?
I mean i am coding Arabian Night set and i found some cards that works into an hypothetical sub-step after attacking declared and after blocking declared. These cards as like Ydwen Efreet or Mijae Djinn try to interact before combat damage or blocking resolution is computed, and this seems not possible into Dotp. What's your opinion about?
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by MC Brodie » 27 Dec 2013, 03:05
I know I tried that and I don't know how I could have messed that up. Thank you both. As a guy I work with says PEBCAK...
-----------------------------------------------------------------------
Song of the Day: 46 and 2 (cover)
Song of the Day: 46 and 2 (cover)
Who is online
Users browsing this forum: Bing [Bot] and 2 guests