Board index 
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels) 2014
Programs with AI or Rules Enforcement Magic: The Gathering - Duels of the Planeswalkers New MTG Cards and Decks (2010, 2012, 2013, 2014, 2015, Magic Duels) 2014
Formal Request Thread
Moderator: CCGHQ Admins
Re: Formal Request Thread
by NeoAnderson » 09 Jan 2014, 15:26
There is a possibility to make heroic recognize Bestow as it is coded.MC Brodie wrote:Is there a way we could hack a workaround so heroic recognizes bestow? For example have the bestow cards grant heroic cards an ability that fires the appropriate trigger for heroic when targeted by a bestow creature.
Also, if you are still looking for heroic cards Neo you can definitely find them in thefiremind's mod. There may be some in sumomole's mod or drlegends. Though I didn't notice any heroic cards in sumo's card list from the quick glance I took.
I made some tests with :
A. Firemind card Fabled Hero (Works with a modify)
B. Sumomole card Tormented Hero (Works with a modify)
The main problem we have is always the same, Bestow doesn't target the card before to be played. So the trigger SPELL_PLAYED fires before we have targeted the creature. For this reason cards with heroic as coded wouldn't trigger.
There is a secondary problem, Sumomole uses a different approach he uses 2 combined trigger "SPELL_PLAYED" and "BECOME_TARGET_OF_SPELL", how i coded Bestow the targetting action is made into Trigger ability, so when it targets a creature it is a target of an ability.
To make sumomole version working with this Bestow we can add another trigger "BECOME_TARGET_OF_ABILITY" and copy the effect into this trigger.
Now we only needs to be sure it will works only with creature with Bestow, i haven't tried but i think we can use a player datachest to set a value to recognize the card with bestow.
I have reolved this problem but this means that if we want to use thi Bestow we need to code Heroic cards considering this implementation!
FIRST OF ALL I HAVE RESIVED THE CARD WITH BESTOW ADDING A VALUE INTO A PLAYER DATA CHEST.
- Celestial Archon REV 5.0 | Open
Example card with Heroic by Sumomole : THIS CARD WILL TRIGGER WITH BESTOW
Example card with Heroic modified by Neo :
...................................................................................................................
The same can be done with the card made by TheFireMind.
THIS CARD WILL NOT TRIGGER WITH BESTOW
Example card with Heroic by TheFireMind :THIS CARD WILL TRIGGER WITH BESTOW
Example card with Heroic modified by Neo :
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by RiiakShiNal » 09 Jan 2014, 19:06
Actually, this is wrong, the target is illegal by the time it resolves so in accordance with the rules it should enter the battlefield as an Enchantment Creature (Cathars' Crusade should trigger).NeoAnderson wrote:3. Target a creature, grant shroud to the target creature before the ability resolve. - It is casted as Aura and is attached. OK
6B is wrong as the cost should not be reduced as the spell should not become an aura until it is already on the stack.NeoAnderson wrote:6. Under the effect of Blood Funnel - Normal casting cost doesn't change OK
Cast with Bestow we have 2 different scenarios
A. You play the card by clicking on it without zoom on the ability, you will be asked for a multiple choice with option of normal cast or alternative cast. In this case the cost of bestow is not reduced . OK
B. You zoom on the card while it still is in your hand, launch it with Bestow by clicking on the ability row. In this case the cost is reduced. UNDEFINED BEHAVIOUR
Infinite Reflection is supposed to change the card in the transition zone, though a creature cast with Bestow should change into an Enchantment - Aura in the Stack before it transitions to the battlefield.NeoAnderson wrote:8. About Infinite Reflection i have found one version of this card but i am not sure if it works as it should work.
I mean this cards is implemented changing the cards while are into transition zone.
Anyway using this version we have a weird effect if we cast the card with bestow, it change into aura enchantment, it is attached to the creature, but it also become a copy of the creature under the effect of Infinite Reflection. UNDEFINED BEHAVIOUR
I listed those cards because those are cards that may have interaction problems with the Bestow approximation. I don't know if they have been coded or not, but most of them should be possible to code (I try not to list cards that can't be coded because if the card can't be coded listing it for interaction problems is a moot point).NeoAnderson wrote:About the cards like Teferi's Response i think Riiak named them just as example because i haven't find any of them.AngelLestat wrote:One question, all the cards that you guys named like Teferi's Response, are cards already coded or you just use them like example? (I am not making a request, just asking)
Mana tokens are not lands (they are invisible cards that are typeless). Manual tap lands create mana tokens which have to be registered to prevent crashes. When registering tokens you have to register the types of the tokens being produced. If a card produces aAngelLestat wrote:Ok that helps.. One question, all lands count also like token? Or just the lands who has the abilitie to become creature?
And if a sorcery make them creatures? This mean that all lands needs to have this line?
mana token then it needs to register RSN_TOKEN_MANA_U, if it produces a 
mana token then it needs to register RSN_TOKEN_MANA_C. Only cards that produce tokens need to register the tokens (it doesn't matter what other abilities they have or don't have).Additionally, there are cards that produce tokens other than mana tokens (1/1 Green Elf tokens, etc...) these cards must also register their tokens, but their register line will need to reference their tokens not the mana tokens.
Cards that produce mana but do not tap manually are not written using the manual mana functions and generally do not create tokens (thus they do not need to register tokens).AngelLestat wrote:I notice that I cant not tap manually some of my lands, this make them suspects of causing the crash?
Also there is many lands who adds 2 possible colors, but when I choose the color it does not tap, only when I play the spell it taps.
So it seems that many of these lands are not using the Riiak function.
If that is the problem, I just need to add that line? Or with some modification at _W in case generate different colors?
Oh another case to test would be to make sure that if a Bestowed creature (in other words it is currently an Enchantment - Aura) is copied by Copy Enchantment that the result is an Enchantment Creature (due to the copiable values). I don't expect this to be a problem with your implementation, but it should probably still be tested.
Just getting started: Xander9009's DotP 2014 Community Wad
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
Need a deck builder: DotP 2014 Deck Builder
Problems Modding: DotP 2014 Frequent Modding Mistakes
- RiiakShiNal
- Programmer
- Posts: 2188
- Joined: 16 May 2011, 21:37
- Has thanked: 75 times
- Been thanked: 497 times
Re: Formal Request Thread
by MC Brodie » 10 Jan 2014, 04:06
I'm having trouble with the 2nd option on Profane Command. This is what I'm trying but it won't let me use the 2nd option. This is what I'm trying. Can anyone help me out?
- | Open
-----------------------------------------------------------------------
Song of the Day: 46 and 2 (cover)
Song of the Day: 46 and 2 (cover)
Re: Formal Request Thread
by thefiremind » 10 Jan 2014, 09:44
I can't see anything wrong (well, aside the pointer protection which is useless if you don't need to do anything else with the creature you are resurrecting, but that doesn't give problems).MC Brodie wrote:I'm having trouble with the 2nd option on Profane Command. This is what I'm trying but it won't let me use the 2nd option. This is what I'm trying. Can anyone help me out?
I have only one idea: substitute GetEffectX() with EffectSource():GetPaidX(). It probably won't make any difference, but it's worth trying.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
Currently busy with life...
-
thefiremind - Programmer
- Posts: 3515
- Joined: 07 Nov 2011, 10:55
- Has thanked: 118 times
- Been thanked: 722 times
Re: Formal Request Thread
by MC Brodie » 10 Jan 2014, 15:40
I couldn't get it to work that way. I ended up using a workaround similar to what I came up with for Simic Manipulator. Although in this case the workaround allows the player to target an illegal card in the graveyard. The first check of the target definition is based on total mana available and the check when the spell resolves is based on the value ofthefiremind wrote:I can't see anything wrong (well, aside the pointer protection which is useless if you don't need to do anything else with the creature you are resurrecting, but that doesn't give problems).
I have only one idea: substitute GetEffectX() with EffectSource():GetPaidX(). It probably won't make any difference, but it's worth trying.
. This allows the user to target a card in the graveyard then not pay enough for to make it an illegal target. In the end I don't think it will be too much of a problem.Thanks for the help.
- | Open
-----------------------------------------------------------------------
Song of the Day: 46 and 2 (cover)
Song of the Day: 46 and 2 (cover)
Re: Formal Request Thread
by NeoAnderson » 10 Jan 2014, 15:43
First of all thanks for your support, your analysis help me to revise the code.RiiakShiNal wrote:Actually, this is wrong, the target is illegal by the time it resolves so in accordance with the rules it should enter the battlefield as an Enchantment Creature (Cathars' Crusade should trigger).
6B is wrong as the cost should not be reduced as the spell should not become an aura until it is already on the stack.
Infinite Reflection is supposed to change the card in the transition zone, though a creature cast with Bestow should change into an Enchantment - Aura in the Stack before it transitions to the battlefield.
Oh another case to test would be to make sure that if a Bestowed creature (in other words it is currently an Enchantment - Aura) is copied by Copy Enchantment that the result is an Enchantment Creature (due to the copiable values). I don't expect this to be a problem with your implementation, but it should probably still be tested.
I want to inform you i have resolved all the points above, now it works as it is supposed to work.
I made a stand alone topic to discuss about this implemention so if you want to take a look to my new code i will be glad to receive your opinion and also some suggestions to make other tests.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by neuro » 10 Jan 2014, 21:47
Ok thanks for info. I added Brute Force and Stun Sniper. I got your XML for BF and I got Stun Sniper from web generator. Added abilities to stun sniper.
I dont need images right now. So I skipped the TDX part. If problem is this how can I create TDX pictures?
I found TDX converter. But what to convert?
- Code: Select all
<SFX text="TARGET_FIREBALL_PLAY" />
<COST mana_cost="{1}" type="Mana" />
<COST type="TapSelf" />
<TARGET_DEFINITION id="0">
local filter = ClearFilter()
filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
</TARGET_DEFINITION>
<TARGET tag="CARD_QUERY_CHOOSE_DEAL_1_DAMAGE" definition="0" compartment="0" count="1" />
<RESOLUTION_TIME_ACTION>
local target_creature = EffectDC():Get_Targets(0):Get_CardPtr(0)
if ( target_creature ~= nil ) then
EffectSourceLKI():DealDamageTo( 1, target_creature )
target_creature:Tap()
end
</RESOLUTION_TIME_ACTION>
I dont need images right now. So I skipped the TDX part. If problem is this how can I create TDX pictures?
I found TDX converter. But what to convert?
- neuro
- Posts: 4
- Joined: 08 Jan 2014, 14:10
- Has thanked: 0 time
- Been thanked: 0 time
Re: Formal Request Thread
by NeoAnderson » 10 Jan 2014, 22:25
Ok the contents of the ability is ok, but you must be sure it is included into an <ACTIVATED_ABILITY> Block...neuro wrote:Ok thanks for info. I added Brute Force and Stun Sniper. I got your XML for BF and I got Stun Sniper from web generator. Added abilities to stun sniper.I saw these card in deck editor. Added to a deck. I saw the deck in the game but could not see these cards.
- card | Open
I dont need images right now. So I skipped the TDX part. If problem is this how can I create TDX pictures?
I found TDX converter. But what to convert?
- Code: Select all
<ACTIVATED_ABILITY>
.......................
......................
</ACTIVATED_ABILITY>
About the TDX creation :
1.first of all you need Gibbed Tools, you can download the tools here : http://svn.gib.me/builds/duels/, download the latest updated file right now is "duels-r6_b10.zip".
2.Unzip the tools into a folder. You will find some files into this folder, the one you need to convert a Png file to TDX is Gibbed.Duels.TdxConvert.exe.
3.Now find the right image for you card, convert it to .PNG using any PhotoEditing software (Photoshop or other programs who support PNG format). The sizes of this picture must be 512x376 pixels.
4. Copy the PNG file into Gibbed Tools folder.
5. From DOS prompt execute this command : Gibbed.Duels.TdxConvert PICTURENAME.PNG
6. Rename the TDX file as like ART ID VALUE of the card.
7. Move the TDX into \DATA_DLC_DECK_BUILDER_CUSTOM\DATA_ALL_PLATFORMS\ART_ASSETS\ILLUSTRATIONS subfolder.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Formal Request Thread
by neuro » 11 Jan 2014, 14:06
Thank you for the info. You guys very helpful.
- neuro
- Posts: 4
- Joined: 08 Jan 2014, 14:10
- Has thanked: 0 time
- Been thanked: 0 time
Tribute Mechanic of Born of the Gods
by sumomole » 13 Jan 2014, 08:11
I try to code new mechanic - Tribute, it runs well, but AI will always choose the first option, I can't fix it, I need help! 
EDIT:well, so ridiculous, but I think I found where the error.
"replacement_query", right, that's it, common triggered ability supports continuous action, we can choose an opponent, then the opponent to make a choice, and then we can make a final choice, but in a replacement ability AI won't make the second step choice, so when I use EffectController():GetOpponent() instead of the choose opponent step, everything is fine. 
maybe use random selection instead of manually selection is the best way, who cares what the opponent is, in fact, they are the same. 
certainly, I'm still looking for a perfect solution, if you know, please tell me, thanks in advance.
and would like to thank NeoAnderson's reply!
EDIT2:The new test, and the following is only a temporary solution, it is not perfect.
EDIT:well, so ridiculous, but I think I found where the error.
"replacement_query", right, that's it, common triggered ability supports continuous action, we can choose an opponent, then the opponent to make a choice, and then we can make a final choice, but in a replacement ability AI won't make the second step choice, so when I use EffectController():GetOpponent() instead of the choose opponent step, everything is fine. maybe use random selection instead of manually selection is the best way, who cares what the opponent is, in fact, they are the same. certainly, I'm still looking for a perfect solution, if you know, please tell me, thanks in advance.
and would like to thank NeoAnderson's reply!
EDIT2:The new test, and the following is only a temporary solution, it is not perfect.
- Pharagax Giant Updated | Open
Last edited by sumomole on 14 Jan 2014, 00:31, edited 4 times in total.
-
sumomole - Programmer
- Posts: 611
- Joined: 07 Jun 2011, 08:34
- Has thanked: 51 times
- Been thanked: 234 times
Re: Tribute Mechanic of Born of the Gods
by NeoAnderson » 13 Jan 2014, 09:22
I have tested your code also changing the number of counters from 2 to 20 but the Ai always select the counters.sumomole wrote:I try to code new mechanic - Tribute, it runs well, but AI will always choose the first option, I can't fix it, I need help!
I think the only solution is to make some functions, who assign some points to a choice, to set different priority, then select the choice with more points.
To do this we should set some base conditions for the points to assign, and probably must be studied some different functions for each kind of effect other cards with tribute will have.
For this card we could make some functions who checks :
1. The total life of the player who have to make the choice, it have to check if it can receive the damage (over 10 point assign 1 to damage choice else assign 1 to counters choice, if life is equal or less than the damage choose the counters).
2. If he controls a creature with combat damage immunity choose counters!
3. The num of creature he controls, if he controls 1 creature more than the opponent who is casting the card, assign 1 to counters choice else assign 1 to damage choice.
4. If the greatest power of the creatures he control is greater or equal than the toughness of the overpowered card then assign 1 to counters choice else assign 1 to damage choice.
..................
And some other functions can be useful to make a reasonable choice. Obviously there a many conditions we are not able to check, as for example, if he can cast instant who can kill the creature, or if can cast spell who will take the control of the creature, and so on, but also if we are not able to define an exact condition we could get an acceptable approximation instead of always the same choice.
Here you can find a starting idea to make it working, it is not perfect but it start to make resonable choices.
You need also these functions :
- Functions | Open
PHARAGAX_GIANT_123456.zip- CARD XML + TDX + FUNCTION LOL FILE
- (539.39 KiB) Downloaded 247 times
EDIT : ooopsss i just see your updated post
B. Sumo, i would receive your opinion about my Bestow implementation, i also made and interaction with heroic cards starting from your code. Please tell me what you think about it.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Tribute Mechanic of Born of the Gods
by NeoAnderson » 13 Jan 2014, 12:04
Are you sure that using EffectController():GetNextPlayer() the AI make reasonable choices?sumomole wrote:EDIT:well, so ridiculous, but I think I found where the error.
certainly, I'm still looking for a perfect solution, if you know, please tell me, thanks in advance.
and would like to thank NeoAnderson's reply!
I have changed your code using this function instead of choose target player block.
I changed the counters number from 2 to 20.
So normally a reasonable choice is to take 5 damage instead of let the creature become 23/23.
The AI always choose to add counters.
- Code: Select all
...............................
<RESOLUTION_TIME_ACTION>
local player = EffectController():GetNextPlayer()
if player ~= nil then
player:BeginNewMultipleChoice()
player:AddMultipleChoiceAnswer( "CARD_QUERY_OPTION_YES" )
player:AddMultipleChoiceAnswer( "CARD_QUERY_INTET_DO_NOT_PAY_MANA" )
player:AskMultipleChoiceQuestion( "UI_CONDITIONAL_QUESTION_BODY" )
end
</RESOLUTION_TIME_ACTION>
<RESOLUTION_TIME_ACTION>
local player = EffectController():GetNextPlayer()
if player ~= nil then
local result = player:GetMultipleChoiceResult()
if result == 0 then
EffectSource():AddCounters( MTG():PlusOnePlusOneCounters(), 20 )
else
local delayDC = EffectDC():Make_Chest(1)
MTG():CreateDelayedTrigger(1, delayDC)
end
end
</RESOLUTION_TIME_ACTION>
............................
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Tribute Mechanic of Born of the Gods
by sumomole » 13 Jan 2014, 13:04
I have tested and everything is fine, when the value is 2, AI will choose be dealt 10 damage rather than let the creature becomes large, when the value is 20, AI will even choose be dealt 15 deamage, if AI insist that the first creature becomes large, that usually means it has ways to cope, by the way, I now use EffectController():GetOpponent(), it ensures to an opponent, and use LinkedDC instead of Delayed Trigger.NeoAnderson wrote:Are you sure that using EffectController():GetNextPlayer() the AI make reasonable choices?
I have changed your code using this function instead of choose target player block.
I changed the counters number from 2 to 20.
So normally a reasonable choice is to take 5 damage instead of let the creature become 23/23.
The AI always choose to add counters.
-
sumomole - Programmer
- Posts: 611
- Joined: 07 Jun 2011, 08:34
- Has thanked: 51 times
- Been thanked: 234 times
Re: Tribute Mechanic of Born of the Gods
by NeoAnderson » 13 Jan 2014, 13:21
Ok i have tested your new code.sumomole wrote:I have tested and everything is fine, when the value is 2, AI will choose be dealt 10 damage rather than let the creature becomes large, when the value is 20, AI will even choose be dealt 15 deamage, if AI insist that the first creature becomes large, that usually means it has ways to cope, by the way, I now use EffectController():GetOpponent(), it ensures to an opponent.NeoAnderson wrote:Are you sure that using EffectController():GetNextPlayer() the AI make reasonable choices?
I have changed your code using this function instead of choose target player block.
I changed the counters number from 2 to 20.
So normally a reasonable choice is to take 5 damage instead of let the creature become 23/23.
The AI always choose to add counters.
I think i have understand where is the problem.
If we cast the card the choice is taken with a reasonable sense.
I was using a card to putontobattlefield permanent from the deck, in that case your code doesn't work it always add counters no matter what the conditions are.
Test report : Counters value : 10 Damage : 5
Normal cast : 3 times it takes damage then let the creature receive counters.
PutOntoBattlefield : Always Add Counters.
- NeoAnderson
- Posts: 914
- Joined: 10 Sep 2013, 07:49
- Has thanked: 18 times
- Been thanked: 139 times
Re: Tribute Mechanic of Born of the Gods
by sumomole » 13 Jan 2014, 14:09
It sounds interesting, but if you use make AI lose game rather than add counters, AI will not hesitate to choose damage, it maybe not smart, but not a fool.NeoAnderson wrote:Ok i have tested your new code.
I think i have understand where is the problem.
If we cast the card the choice is taken with a reasonable sense.
I was using a card to putontobattlefield permanent from the deck, in that case your code doesn't work it always add counters no matter what the conditions are.
Test report : Counters value : 10 Damage : 5
Normal cast : 3 times it takes damage then let the creature receive counters.
PutOntoBattlefield : Always Add Counters.
-
sumomole - Programmer
- Posts: 611
- Joined: 07 Jun 2011, 08:34
- Has thanked: 51 times
- Been thanked: 234 times
Who is online
Users browsing this forum: No registered users and 3 guests