Forge version 1.5.11

[drdev]

...

Ok, check against multiple GameFormats is not a problem - already commited.


Your deck list seems to ignore decks found in subfolders, that are supported by the actual FDeckChooser.

I'm noticing that several of my decks now show up with Format, (none) that didn't used to. Any idea why?

As for subfolders, I should have something working soon.

[Max mtg]

I'm noticing that several of my decks now show up with Format, (none) that didn't used to. Any idea why?

Could be due to r24254.
http://www.wizards.com/Magic/TCG/Resour ... sfrvintage

[drdev]

I'm noticing that several of my decks now show up with Format, (none) that didn't used to. Any idea why?

Could be due to r24254.
http://www.wizards.com/Magic/TCG/Resour ... sfrvintage

Ah, that makes sense. I believe those decks do containing multiple copies of some restricted cards.

Should we maybe display "Casual" instead of "(none)" for such decks?

On that note, I think it might be nice to be able to right-click on a deck and click a menu item to open a dialog with a breakdown of what formats it's legal in and what cards make it illegal in other formats, with a button you can click to create a copy of a deck for a given format with all illegal cards removed. I could see that being particularly useful for when a deck rotates out of Standard and you want to salvage as much of the deck as possible into a still Standard-legal deck.

I could work on something like that if that sounds useful to others.

[Max mtg]

Should we maybe display "Casual" instead of "(none)" for such decks?

On that note, I think it might be nice to be able to right-click on a deck and click a menu item to open a dialog with a breakdown of what formats it's legal in and what cards make it illegal in other formats, with a button you can click to create a copy of a deck for a given format with all illegal cards removed. I could see that being particularly useful for when a deck rotates out of Standard and you want to salvage as much of the deck as possible into a still Standard-legal deck.

I could work on something like that if that sounds useful to others.

sure, why not?

About that method to create a filtered copy of a deck - if you're goind to implement one, please make it in GameFormat class (not in the Deck class I mean)

[drdev]

Should we maybe display "Casual" instead of "(none)" for such decks?

On that note, I think it might be nice to be able to right-click on a deck and click a menu item to open a dialog with a breakdown of what formats it's legal in and what cards make it illegal in other formats, with a button you can click to create a copy of a deck for a given format with all illegal cards removed. I could see that being particularly useful for when a deck rotates out of Standard and you want to salvage as much of the deck as possible into a still Standard-legal deck.

I could work on something like that if that sounds useful to others.

sure, why not?

About that method to create a filtered copy of a deck - if you're goind to implement one, please make it in GameFormat class (not in the Deck class I mean)

Ok, can do.

[Max mtg]

The changes you made to iterator of StorageBase are bad. Regular file system never lists all files recursivelly.

[Diogenes]

Great work on the multiple card art support, Agetian! I hope it's okay to post follow-ups here, since the topic's still being discussed.

If any art parameters in a decklist are invalid Forge won't recognize the deck, and the numerical parameters used don't correspond to the card's filename (forest|xxx|3 points to forest4.full.jpg, while forest|xxx|4 might not exist.) I can see this being a potential issue for users crafting decks by hand.

The next thing is sort of two issues in one. Users should receive unlimited access to basic lands in limited formats, and currently they do not (I'll throw this up in bug reports as well.) Incidentally, it's become harder to add lands to decks in limited, as the twenty of each basic land provided are split into multiple stacks. (As an aside, would it be easy to provide a "generic basic" in the card list for each set in addition to the isolated variants?)

Thanks again! I've attached the Alara block precons with their respective lands if anyone would like to commit them.

EDIT: Wow, Agetian, that was fast. Thank you. I'm attaching the new and improved collection. This will not work on today's daily build, but should work as of r24323

[Agetian]

@ Diogenes: 1) EDIT: r24323: Art indexes now start at 1 instead of at 0 and match the file naming conventions. For the sake of limited backwards compatibility, if a deck has cards with art index 0 they'll be treated as cards with art index 1 random art. Diogenes, please update your precons accordingly

2) EDIT: r24321: I changed the pool generation mechanism to generate 50 basic lands per art for every basic land type. This guarantees at least 50 basic lands of each type even for sets where only one picture is available for a card, and normally generates 150 or 200 basic lands of each type, 50 per art. This should theoretically be enough for any sane limited play needs even though it's technically not "unlimited". Implementing a "generic basic land" would be tricky and will likely confuse the matters more than it will solve issues.

Thanks for the precons, I'll look through them soon!

- Agetian

[drdev]

The changes you made to iterator of StorageBase are bad. Regular file system never lists all files recursivelly.

We're not a file system though. The only place we offer subfolder support is for decks, and we want to be sure to load all decks, including those in subfolders. Do you have an alternate suggestion, instead of just saying it's "bad"? Is there a case where we would use these Storage classes and wouldn't want to iterate through subfolders too?

Note that I am planning to add back support for showing the subfolder path for each deck in a way that allows sorting, and eventually grouping.

[Agetian]

@ Diogenes: By the way, a little thing that needs tweaking in your modified precons - Dead Ahead does not seem to have assigned art indexes for Swamps. Do you know the art index codes for it?
P.S. Now the art indexes start at 1, you may want to update the numbering in your deck files accordingly. Thanks in advance!

- Agetian

[Diogenes]

@ Diogenes: By the way, a little thing that needs tweaking in your modified precons - Dead Ahead does not seem to have assigned art indexes for Swamps. Do you know the art index codes for it?
P.S. Now the art indexes start at 1, you may want to update the numbering in your deck files accordingly. Thanks in advance!

- Agetian

I got ninja'ed. They're already uploaded in my other post.

[Agetian]

@ Diogenes: Downloaded them! I'm not sure where exactly you'd like to upload them into the game - they are available as quest precons, but current quest precons have additional metadata in them (e.g. description and whatnot) that are not available in your precon files... Can you please clarify where exactly you'd like to put them?

- Agetian

[Diogenes]

@ Diogenes: Downloaded them! I'm not sure where exactly you'd like to upload them into the game - they are available as quest precons, but current quest precons have additional metadata in them (e.g. description and whatnot) that are not available in your precon files... Can you please clarify where exactly you'd like to put them?

- Agetian

I guess I got a little bit ahead of myself, I didn't know that the quest precons had extra information. I'll go ahead and merge the two later in the day, then re-upload the set. Sorry about that.

[Agetian]

@ Diogenes: Oh, OK! No problem! Please check out res/quest/precons for an example of what's inside those quest decks.

- Agetian

[Diogenes]

Alright, sorry for the misfires, here they are.