Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by friarsol » 25 Jan 2014, 01:09
Fmartel, it looks like your using an old version: 1.5.8. Pleease update to the latest version. Additionally, please post bug reports in the thread announcement of the thread you are using.fmartel wrote:Hello again. I got this error message at the bigining of my 2nd inrow game of commander...
Description: [describe what you were doing when the crash occurred]
- IndexOutOfBoundsException | Open
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Agetian » 25 Jan 2014, 07:09
r24473: It looks like the sizes of columns in deck editor and deck list are not saved/loaded correctly across sessions. Might be related to Sol's earlier report of column positioning not being saved as well.
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by Max mtg » 25 Jan 2014, 11:20
fixed with r24486Agetian wrote:r24485: Got this crash when starting a standard Constructed match (no variants chosen):
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by drdev » 25 Jan 2014, 14:40
Both of those are known issues I plan to fix shortly.Agetian wrote:r24473: It looks like the sizes of columns in deck editor and deck list are not saved/loaded correctly across sessions. Might be related to Sol's earlier report of column positioning not being saved as well.
- Agetian
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by jasmines » 25 Jan 2014, 14:45
Description: [describe what you were doing when the crash occurred]
- ExceptionInInitializerError | Open
- jasmines
- Posts: 6
- Joined: 25 Jan 2014, 14:35
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by swordshine » 26 Jan 2014, 07:03
Booster Draft -> New Booster Draft Game -> Custom
- NullPointerException | Open
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Re: Bug Reports (snapshot builds)
by Agetian » 27 Jan 2014, 05:46
Fixed in r24519. I removed a small bit of offending code that seemed to do nothing beneficial in addition to the code right above it. Not sure if this code was/is necessary for something I don't quite understand though, please report or re-fix differently if anything was broken "thanks" to this change.swordshine wrote:Booster Draft -> New Booster Draft Game -> Custom
- NullPointerException | Open
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by Max mtg » 27 Jan 2014, 06:14
Ok, now you start a game, then go to devmode -> add card to hand (or play), scroll through the list and find out that you no longer see the card under selection.Agetian wrote:code that seemed to do nothing beneficial in addition to the code right above it
I expected you would have looked through with SVN "blame" feature to discover the purpose that code was added for.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Agetian » 27 Jan 2014, 06:21
Oh, I was unaware of what the "blame" feature was for, thanks for the tip! 
I'll try to recorrect in another way then. Do you have a suggestion for a better fix, by the way? The original code was broken because it worked out of match (and thus took all the various InventoryItems, including e.g. custom drafts, into that part of the algorithm where it tried to display them as a card via CMatchUI).
- Agetian
I'll try to recorrect in another way then. Do you have a suggestion for a better fix, by the way? The original code was broken because it worked out of match (and thus took all the various InventoryItems, including e.g. custom drafts, into that part of the algorithm where it tried to display them as a card via CMatchUI). - Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by Agetian » 27 Jan 2014, 06:42
The trace was showing a NPE in GuiChoose.java:93 called from BoosterDraft.java:144.Max mtg wrote:Which expression evaluated to null when the code used to throw an exception?
- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Re: Bug Reports (snapshot builds)
by Max mtg » 27 Jan 2014, 06:56
I mean not the line, but the expression.Agetian wrote:The trace was showing a NPE in GuiChoose.java:93 called from BoosterDraft.java:144.Max mtg wrote:Which expression evaluated to null when the code used to throw an exception?
- Agetian
When you know what has evaluated to null, you (in the simplest case) add a check against null value and do not execute the code that supposes that such expression is not null.
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Agetian » 27 Jan 2014, 07:05
OK, I think I got that fixed - there were a couple expressions evaluating to null that mattered, I got them fixed and will commit a different fix now. Hopefully that'll be a better and more appropriate solution.Max mtg wrote:I mean not the line, but the expression.
When you know what has evaluated to null, you (in the simplest case) add a check against null value and do not execute the code that supposes that such expression is not null.
Thanks for help and tips!- Agetian
- Agetian
- Programmer
- Posts: 3486
- Joined: 14 Mar 2011, 05:58
- Has thanked: 683 times
- Been thanked: 569 times
Who is online
Users browsing this forum: No registered users and 11 guests