It is currently 19 Jul 2025, 10:48
   
Text Size

Bug reports

Moderators: ubeefx, beholder, melvin, ShawnieBoy, Lodici, CCGHQ Admins

Re: Bug reports

Postby ShawnieBoy » 15 Mar 2014, 20:09

tonetisd wrote:When Jaddi Lifestrider comes into play doesn't allow you to tap creatures to win life.

Thanks.
Hi tonetisd. Jaddi Lifestrider isn't currently implemented in Magarena. Have you posted on the right forum?
User avatar
ShawnieBoy
Programmer
 
Posts: 601
Joined: 02 Apr 2012, 22:42
Location: UK
Has thanked: 80 times
Been thanked: 50 times

Re: Bug reports

Postby Lodici » 16 Mar 2014, 07:37

noxxle wrote:After exiting Magarena (1.47), I am unable to move icons on my desktop until logging out. I've tested on two windows 8 tablets, Lenovo's Miix 8 and Thinkpad 8.

Any idea what could cause this?
Sorry, absolutely no idea. Try re-installing java.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Bug reports

Postby tiagoruback » 27 Mar 2014, 01:09

Haazda Snare Squad activates ability when other cards attack. (Whenever Haazda Snare Squad attacks, you may pay {W}. If you do, tap target creature an opponent controls.)

I attacked with 4 other cards, and his ability triggered 4 times. I think there's something wrong with the code of this card.
tiagoruback
 
Posts: 22
Joined: 04 Apr 2012, 14:22
Location: Brazil
Has thanked: 11 times
Been thanked: 6 times

Re: Bug reports

Postby melvin » 27 Mar 2014, 05:27

tiagoruback wrote:Haazda Snare Squad activates ability when other cards attack. (Whenever Haazda Snare Squad attacks, you may pay {W}. If you do, tap target creature an opponent controls.)

I attacked with 4 other cards, and his ability triggered 4 times. I think there's something wrong with the code of this card.
Good find, it was triggering whenever anything attacks. Fixed in https://code.google.com/p/magarena/sour ... 462efb76e2 for next release.
User avatar
melvin
AI Programmer
 
Posts: 1062
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 459 times

Re: Bug reports

Postby muaddib » 27 Mar 2014, 07:06

When Vizkopa Guildmage leave the game his second ability no longer to work.
I am not sure, but may it is wrong.
User avatar
muaddib
Tester
 
Posts: 118
Joined: 03 Mar 2011, 08:37
Location: Russia
Has thanked: 0 time
Been thanked: 5 times

Re: Bug reports

Postby melvin » 28 Mar 2014, 02:15

muaddib wrote:When Vizkopa Guildmage leave the game his second ability no longer to work.
I am not sure, but may it is wrong.
I must not be understanding your report right, but it is always the case that when permanent leaves the battlefield, its ability no longer apply.

Could you explain what you observed and what you think should happen instead. Thanks!
User avatar
melvin
AI Programmer
 
Posts: 1062
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 459 times

Re: Bug reports

Postby ShawnieBoy » 28 Mar 2014, 03:31

I think it's if the second ability has been activated, and then Vizkopa Guildmage leaves play?

It should continue until end of turn.

Also they should stack, if activated several times (not tested either of these)
User avatar
ShawnieBoy
Programmer
 
Posts: 601
Joined: 02 Apr 2012, 22:42
Location: UK
Has thanked: 80 times
Been thanked: 50 times

Re: Bug reports

Postby melvin » 28 Mar 2014, 06:19

ShawnieBoy wrote:I think it's if the second ability has been activated, and then Vizkopa Guildmage leaves play?
Ah, i see, thanks it makes sense now.

There is indeed a bug, the delayed trigger was associated with the permanent so it got removed when the permanent is removed. Fixed in https://code.google.com/p/magarena/sour ... 149775f1b8 for next release.
User avatar
melvin
AI Programmer
 
Posts: 1062
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 459 times

Re: Bug reports

Postby hong yie » 29 Mar 2014, 16:26

when i check at card explorer, i found:
- Broodmother Dragon
- Dragon Broodmother

2 cards, same picture. :)
delete one of them?
User avatar
hong yie
Programmer
 
Posts: 216
Joined: 10 Mar 2013, 06:44
Location: Jakarta
Has thanked: 75 times
Been thanked: 9 times

Re: Bug reports

Postby frank » 29 Mar 2014, 17:55

that's weird, because I only have Dragon Broodmother in there. And of course Broodmate Dragon, which is another creature, though. Checked the images folder, same result. Maybe you should do a fresh image download?

As of writing: magarena 1.48.920
frank
 
Posts: 46
Joined: 24 Mar 2014, 00:59
Has thanked: 8 times
Been thanked: 2 times

Re: Bug reports

Postby ShawnieBoy » 29 Mar 2014, 20:29

May be worth checking your scripts folder as well - If it's a misnamed Dragon Broodmother, you can delete it. Same goes for Broodmate Dragon, or rename the .txt (and double-check the name inside too) if it's supposed to be that.

Image re-downloading won't overwrite, make sure to delete images first ;)
User avatar
ShawnieBoy
Programmer
 
Posts: 601
Joined: 02 Apr 2012, 22:42
Location: UK
Has thanked: 80 times
Been thanked: 50 times

Re: Bug reports

Postby Lodici » 29 Mar 2014, 20:46

I think this can occur if you overwrite an existing version with the contents of the zip file from a new version. If, for example, in the new version the script file Dragon Broodmother was renamed to Broodmother Dragon then you will end up with two script files and thus two entries in the card explorer.

IMO, this is a possible issue with the upgrade process which could perhaps be easier and a bit clearer. What you should really do is extract the zip file for a new version to a new, empty folder. It will, of course, be missing all the downloaded images from the previous version so you will need to import (not download) the images from the old Magarena folder first using the Import option on the download dialog. This should prevent duplication.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Bug reports

Postby hong yie » 30 Mar 2014, 05:22

I think this can occur if you overwrite an existing version with the contents of the zip file from a new version. If, for example, in the new version the script file Dragon Broodmother was renamed to Broodmother Dragon then you will end up with two script files and thus two entries in the card explorer.
Yes, that is the problem. thanks. :)
User avatar
hong yie
Programmer
 
Posts: 216
Joined: 10 Mar 2013, 06:44
Location: Jakarta
Has thanked: 75 times
Been thanked: 9 times

Re: Bug reports

Postby ShawnieBoy » 30 Mar 2014, 10:52

Ok, get ready for this one...

I've been going through the abilities for the next (imminent) release, changing them for scripting to better reflect the card text. (You'll see ;))

I've stumbled across an easily confused set of abilities that trigger when an attacking creature becomes blocked. We've been doing one subset of these wrong.

Here's the big question, we have four attacking creatures: Norwood Warrior, Marhault Elsdragon, Elvish Berserker and Cave Tiger.
Each of them gets blocked by 5 creatures. How much of a power and toughness boost do each of them get?

How did you do? | Open
Lets see shall we?

Norwood Warrior 's ability triggers whenever it becomes blocked, just a +1/+1 - Easy.
Marhault Elsdragon has Rampage 1, so +4/+4 for him (+1/+1 for each blocker after the first). Simple.
Elvish Berserker gets a +1/+1 for each blocker so that's a +5/+5
Now, Cave Tiger, he also gets a +5/+5 - (He's currently scripted wrong. But Pygmy Troll is the same...) But there's more to it than that. The ability triggers once for each blocking creature, unlike the Elvish Berserker who gets +5/+5 all at once or Marhault Elsdragon who gets a lump-sum +4/+4, he gets 5 triggers of +1/+1

So I think you'll now know what would happen if a Strionic Resonator was used on each of them. Different to what you'd expect. ;)

Next scenario - Same creatures attacking, but this time a Fog Patch is cast (I know it's not implemented yet, but it gives an idea on how these abilities work). What happens?

| Open
Norwood Warrior gets a +1/+1, the ability triggers whenever it becomes blocked, regardless of how. No damage will be dealt of course, but the power and toughness still changes.
Marhault Elsdragon gets a +0/+0 - Yes, in a similar way to Norwood Warrior, the ability triggers regardless of how he becomes blocked, but the bonus he gets is dependant on how many creatures beyond the first are blocking.
Elvish Berserker also gets +0/+0 - He is blocked but not by creatures, similar to Marhault Elsdragon.
Cave Tiger has no abilities trigger, he is reliant on creatures being present. Even though he is blocked, it's not by a creature.


So after all that, it seems that we'll be needing yet another ability trigger for 'becomes blocked by a creature' :(
User avatar
ShawnieBoy
Programmer
 
Posts: 601
Joined: 02 Apr 2012, 22:42
Location: UK
Has thanked: 80 times
Been thanked: 50 times

Re: Bug reports

Postby melvin » 30 Mar 2014, 13:58

If we need one trigger per blocker, the correct trigger to use is MagicWhenBlocksTrigger. It triggers once per blocker and pass the blocker in the executeTrigger method. We just have to check if the Cave Tiger is the one being blocked by the blocker.
User avatar
melvin
AI Programmer
 
Posts: 1062
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 459 times

PreviousNext

Return to Magarena

Who is online

Users browsing this forum: No registered users and 5 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 5 users online :: 0 registered, 0 hidden and 5 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 5 guests

Login Form