TFM&G2K's Planeswalkers Pool v8g (12/Sep/2014)

[thefiremind]

I have another one for you, opponent AI had an Opalescence on the field and my Vraska the Unseen became a creature. Surely planeswalkers don't qualify as enchantments.

You probably need to take a look at the "Planeswalkers are still APPROXIMATED" paragraph on the first post.

[orlouge82]

I updated to the newest version of the Planeswalkers Pool (after using version 5 for a few months without any issues), and now when a player loses the game (usually in a multiplayer (offline) game), the game crashes. Am I missing something that I should have?

Thanks for all of your hard work on this!

[Kithkin]

I updated to the newest version of the Planeswalkers Pool (after using version 5 for a few months without any issues), and now when a player loses the game (usually in a multiplayer (offline) game), the game crashes. Am I missing something that I should have?

Same here playing 3FFA offline.

[thefiremind]

I updated to the newest version of the Planeswalkers Pool (after using version 5 for a few months without any issues), and now when a player loses the game (usually in a multiplayer (offline) game), the game crashes. Am I missing something that I should have?

I didn't do anything more than what I wrote in the changelog: add the new Ajani and substitute the old invisible token spawning function with a new one that calls the old one for each player. The crash at the end of the duel usually means that a TOKEN_REGISTRATION is missing, but I didn't miss the one on the new Ajani and the other ones are still in place... so I don't know what to think.

Does it happen with all Planeswalkers or just some of them? Which ones were in the players' decks (not just the ones that actually hit the battlefield) when the crash occurred?

You should also check that you don't have other mods that use a copy of my Planeswalker functions, because they would most likely interfere with mine after the update.

[Kithkin]

Does it happen with all Planeswalkers or just some of them? Which ones were in the players' decks (not just the ones that actually hit the battlefield) when the crash occurred?

I played a deck called Gorgon's Prophecies by HARBiNG3R and it includes Vraska the Unseen. No other mods were used.

[orlouge82]

I don't believe that I have any other mods that use a copy of your Planeswalker functions. And every time that the game crashed, I was using custom-made decks that included Kiora, the Crashing Wave, Jace, the Mind Sculptor, and Tamiyo, the Moon Sage. The game also crashed when I was using decks that included Elspeth, Sun's Champion, Jace, Architect of Thought, and the new Ajani, but it the game crashed even when I wasn't using decks that included those three.

[thefiremind]

I just tried to make a test deck with a bunch of Elspeth, Sun's Champion and fought against my Vampire deck. No crashes at the end of the duel. So now I'm pretty sure it's not this or my other mod's fault.

[Kithkin]

I just tried to make a test deck with a bunch of Elspeth, Sun's Champion and fought against my Vampire deck. No crashes at the end of the duel. So now I'm pretty sure it's not this or my other mod's fault.

Did you test 3FFA? Human vs. AI vs. AI?

[thefiremind]

Did you test 3FFA? Human vs. AI vs. AI?

I didn't think it would have mattered, but I just tried and... it matters. It crashes as soon as someone loses. I'm going to try out some ideas, but I have no sure fix for that.

[orlouge82]

Yeah, all of my crashes were Human vs. AI vs. AI vs. AI. Also, I have a bunch of DMP files from the crashes. Do those help at all?

[thefiremind]

I have a bunch of DMP files from the crashes. Do those help at all?

I can create a bunch, too, if I want... but I can't get any useful information from them.

I think I have isolated the crashing situation: the game crashes whenever a player loses while there are 2 or more invisible Planeswalker Manager tokens on the battlefield (most likely, only if the losing player is the controller of one of those tokens, but I haven't tried the opposite scenario). Judging from this, the crash should have happened even with the previous versions of this mod, whenever 2 or more players were using a deck that contains Planeswalkers.

EDIT: Got it! I removed the <TOKEN /> block from the invisible token, and the crash doesn't happen anymore. It must have something to do with the engine trying to clean up the token when its controller loses the game, maybe tokens whose original card isn't a token itself get treated differently. The fixed version is up on the first post.

[orlouge82]

My crashes occurred in games in which I was the only one using Planeswalkers in my deck. I never had any problems with the previous version of the mod, so I don't know why this one is crashing where the others didn't

[thefiremind]

My crashes occurred in games in which I was the only one using Planeswalkers in my deck. I never had any problems with the previous version of the mod, so I don't know why this one is crashing where the others didn't

That's exactly the point: if you weren't the only one using Planeswalkers during a game with the previous version it would have crashed, too. With the new one it crashed because everyone gets a Planeswalker manager. Anyway it's fixed now (see edit on my post above).

[Kithkin]

Anyway it's fixed now (see edit on my post above).

Thank you thefiremind. Problem solved. Glad I could hint you into the right direction.

[Parabolic]

I noticed Dack Fayden isn't accounted for. Any interest in adding him, or is he not possible to code?