Forge version 1.5.28
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Forge version 1.5.28
by KrazyTheFox » 13 Sep 2014, 17:40
That's a huge improvement. Thanks!drdev wrote:So I just committed a decent-sized refactoring of the logic used for AI mana payment (and the Auto button) in r27348. People were reporting issues with cards being sacrificed for mana ahead of lands being used, which wasn't right.
The new logic adjusts the scoring logic added previously for cards to increase the score based on the number of non-mana activated abilities available to the card, whether the card can attack or block, additional costs associated with the mana ability (such as paying life for painlands), and most importantly, a large score increase if the mana ability is not undoable (such as a sacrifice effect). That way, mana abilities that are non-undoable should be used as an absolute last resort.
Please let me know if this logic or the specific score adjustments I'm using need to be tweaked.
Thanks.
-Dan
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Forge version 1.5.28
by KrazyTheFox » 13 Sep 2014, 20:00
I've just committed a change to the way "charm" spells are presented in the card details panel. They now resemble the new format introduced in KTK. No script text needs changing for this to work, so all previous cards in this format should work, but do let me know if some don't so I can improve this.


-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Forge version 1.5.28
by elcnesh » 14 Sep 2014, 10:26
I'm trying to merge GuiRefactoring back into trunk, but it's failing miserably... Could someone else have a look at this? The branch should be up to date (up until r27379), but Subclipse somehow says it's not.
- elcnesh
- Posts: 290
- Joined: 16 May 2014, 15:11
- Location: Netherlands
- Has thanked: 34 times
- Been thanked: 92 times
Re: Forge version 1.5.28
by friarsol » 14 Sep 2014, 13:11
I'd recommend downloading TortioseSVN (or some other standalone SVN) to try to Merge back. I'm about to run out for most of the day, so I don't have time to try this out, but the capabilities of Subclipse I found to be pretty subpar.elcnesh wrote:I'm trying to merge GuiRefactoring back into trunk, but it's failing miserably... Could someone else have a look at this? The branch should be up to date (up until r27379), but Subclipse somehow says it's not.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Forge version 1.5.28
by Rob Cashwalker » 14 Sep 2014, 14:46
I see snapshots have been uploaded to cardforg.org. Who processed them? Can you confirm they were complete and successful?
Chris, this might be a good sign that the build and deploy could work again. Is there any way to disable the version increment for this test?
Chris, this might be a good sign that the build and deploy could work again. Is there any way to disable the version increment for this test?
The Force will be with you, Always.
-
Rob Cashwalker - Programmer
- Posts: 2167
- Joined: 09 Sep 2008, 15:09
- Location: New York
- Has thanked: 5 times
- Been thanked: 40 times
Re: Forge version 1.5.28
by KrazyTheFox » 14 Sep 2014, 17:30
I believe Chris published those.Rob Cashwalker wrote:I see snapshots have been uploaded to cardforg.org. Who processed them? Can you confirm they were complete and successful?
Chris, this might be a good sign that the build and deploy could work again. Is there any way to disable the version increment for this test?
--
I've had stroke of genius today in what I think might solve that "counter" display problem I was trying to solve way back when. I couldn't think of a good replacement for them that would be quick and descriptive... but the solution is so obvious. Tabs with colored text that have a shortened version of the counter's name and the exact number of counters:
The old counters could be left in and an option given to use this, those, or both. What do you guys think?
Edit: Example of a massive amount of counters:
Last edited by KrazyTheFox on 16 Jun 2017, 20:48, edited 1 time in total.
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Forge version 1.5.28
by Agetian » 14 Sep 2014, 17:38
Sounds like an awesome idea and looks really great to me!KrazyTheFox wrote:I've had stroke of genius today in what I think might solve that "counter" display problem I was trying to solve way back when. I couldn't think of a good replacement for them that would be quick and descriptive... but the solution is so obvious. Tabs with colored text that have a shortened version of the counter's name and the exact number of counters: <...>

- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Forge version 1.5.28
by Chris H. » 14 Sep 2014, 17:48
I built and deployed the two snapshots to cardforge. They completed successfully.
I am not aware of any way to disable the version increase.
I am not aware of any way to disable the version increase.
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Forge version 1.5.28
by Marek14 » 14 Sep 2014, 18:41
I'd suggest to extend the counter names to 5 characters so +1/+1 and -1/-1, most often used, could be shown in full. Alternately, they could be simply reduced to big + or -...KrazyTheFox wrote:I believe Chris published those.Rob Cashwalker wrote:I see snapshots have been uploaded to cardforg.org. Who processed them? Can you confirm they were complete and successful?
Chris, this might be a good sign that the build and deploy could work again. Is there any way to disable the version increment for this test?
--
I've had stroke of genius today in what I think might solve that "counter" display problem I was trying to solve way back when. I couldn't think of a good replacement for them that would be quick and descriptive... but the solution is so obvious. Tabs with colored text that have a shortened version of the counter's name and the exact number of counters:forgecounters.jpg
The old counters could be left in and an option given to use this, those, or both. What do you guys think?
Edit: Example of a massive amount of tokens:forgecounters2.jpg
Re: Forge version 1.5.28
by KrazyTheFox » 14 Sep 2014, 19:02
Yeah, I can do that. The names will be variable in length, depending on what the counter they represent is. "+1/+1" doesn't look as awful as I thought it might, so that'll stay the way it is. It'll probably be late tomorrow by the time I even get a chance to start looking at implementing this.Marek14 wrote:I'd suggest to extend the counter names to 5 characters so +1/+1 and -1/-1, most often used, could be shown in full. Alternately, they could be simply reduced to big + or -...
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Forge version 1.5.28
by friarsol » 15 Sep 2014, 03:47
I don't see this change affecting Energy Chamber, even though Gatherer shows this card with the new formatting. Does your change only affect spells and not triggers?KrazyTheFox wrote:I've just committed a change to the way "charm" spells are presented in the card details panel. They now resemble the new format introduced in KTK. No script text needs changing for this to work, so all previous cards in this format should work, but do let me know if some don't so I can improve this.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Forge version 1.5.28
by Agetian » 15 Sep 2014, 04:05
Dan put a lot of work into correcting announcement of X for various types of cards yesterday (which I'm really grateful for), and hopefully it'll now work in the absolute majority of cases. Some corner cases still remain, one of the reported ones is here:
viewtopic.php?f=26&t=15333&start=30#p161076
If anyone has a good enough idea, feel free to suggest an algorithm for this or try to implement a better way to handle this situation. I may have a look at it soon enough, but the next few days are going to be rather busy, so my level of Forge activity is likely to dwindle for a few days. For now, adding this issue to the "Known Issues" list to be picked up for fixing later.
- Agetian
viewtopic.php?f=26&t=15333&start=30#p161076
If anyone has a good enough idea, feel free to suggest an algorithm for this or try to implement a better way to handle this situation. I may have a look at it soon enough, but the next few days are going to be rather busy, so my level of Forge activity is likely to dwindle for a few days. For now, adding this issue to the "Known Issues" list to be picked up for fixing later.
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Forge version 1.5.28
by KrazyTheFox » 15 Sep 2014, 04:21
It only affects spells with the ApiType of "Charm" at the moment. I'll see about formatting otter cards with similar options after I get home from work tomorrow. Thanks for pointing that out.friarsol wrote:I don't see this change affecting Energy Chamber, even though Gatherer shows this card with the new formatting. Does your change only affect spells and not triggers?KrazyTheFox wrote:I've just committed a change to the way "charm" spells are presented in the card details panel. They now resemble the new format introduced in KTK. No script text needs changing for this to work, so all previous cards in this format should work, but do let me know if some don't so I can improve this.
-
KrazyTheFox - Programmer
- Posts: 725
- Joined: 18 Mar 2014, 23:51
- Has thanked: 66 times
- Been thanked: 226 times
Re: Forge version 1.5.28
by Marek14 » 15 Sep 2014, 07:22
One thing to do might be to limit values of X in selection in cases where only some are possible (including "X can't be 0" effects), with auto-select when only one is possible -- that would work great for Spell Blast which generally only has one allowed value except when there are multiple spells on stack.Agetian wrote:Dan put a lot of work into correcting announcement of X for various types of cards yesterday (which I'm really grateful for), and hopefully it'll now work in the absolute majority of cases. Some corner cases still remain, one of the reported ones is here:
viewtopic.php?f=26&t=15333&start=30#p161076
If anyone has a good enough idea, feel free to suggest an algorithm for this or try to implement a better way to handle this situation. I may have a look at it soon enough, but the next few days are going to be rather busy, so my level of Forge activity is likely to dwindle for a few days. For now, adding this issue to the "Known Issues" list to be picked up for fixing later.
- Agetian
"X can't be 0" effects:
Aeon Chronicler, Aladdin's Lamp, Arcanis the Omnipotent Avatar, Benalish Commander, Detritivore, Ertai's Meddling, Fungal Behemoth, Helm of Obedience, Marath, Will of the Wild; Mind Grind, Roiling Horror
Looking through the X cards (only considering X in mana cost so far), limits would be useful for:
Cards where there's maximum possible value of X:
AEther Tide -- can't choose more than the number of creature cards in hand OR the number of valid targets
Abandon Hope -- can't choose more than the number of cards in your hand (not counting the Abandon Hope)
Alexi, Zephyr Mage, Avalanche, Builder's Bane, Candelabra of Tawnos, Choking Vines, Curse of the Swine, Death Denied, Deepwood Elder, Distorting Wake, Dregs of Sorrow, Floodwater Dam, Glimpse the Sun God, Gridlock, Magus of the Candelabra, Malicious Advice, Midnight Ritual, Mishra's Helix, Orcish Settlers, Outmaneuver, Part Water, Prismatic Boon, Rats' Feast, Reality Spasm, Return to the Ranks, Runed Arch, Serene Sunset, Shattered Crypt, Suffer the Past, Synod Artificer, Thrive, Volcanic Eruption, Wave of Indifference, Winter Blast, Word of Binding -- can't choose more than the number of valid targets
Avalanche -- can't choose more than the number of valid targets
Bond of Agony -- can't choose more than the amount of life you can pay
Conflagrate, Hail of Arrows, Meteor Shower, Rock Slide, Rolling Thunder -- corner case when you can't choose more than 0 if there are no valid targets at all
Marath, Voice of the Wild -- can't choose more than the amount of +1/+1 counters on Marath
Scorched Earth -- can't choose more than the number of land cards in hand OR the number of valid targets
Skeletal Scrying -- can't choose more than the number of cards in your graveyard
Talon of Pain -- can't choose more than the number of charge counters on Talon of Pain
Winter's Chill -- can't choose more than the number of snow lands you control OR the number of valid targets
Cards where the value of X can only reach specific values:
Arcanis, the Omnipotent Avatar -- only values greater than 0 and equal to CMC of a creature you control
Blazing Shoal, Disrupting Shoal, Nourishing Shoal, Shining Shoal, Sickening Shoal -- when cast using alternative cost, only values equal to CMC of cards that could be exiled
Bosh, Iron Golem Avatar -- only values equal to CMC of an artifact you control
Deepfire Elemental, Detonate, Disembowel, Geth, Lord of the Vault; Gorilla Shaman, Hearth Kami, Kaervek's Purge, Linessa, Zephyr Mage; Molder, Plaguebearer, Postmortem Lunge, Repeal, Spell Blast, Spell Burst -- only values equal to CMC of valid targets
Dominate, Stir the Grave -- only values greater or equal to lowest CMC among valid targets
Figure of Destiny Avatar -- only values greater than number of +1/+1 counters on the valid target with lowest amount
Ink-Eyes, Servant of Oni Avatar -- only values equal to CMC of valid targets AND less or equal to maximum amount of life you can pay
Killing Glare, Minamo Sightbender -- only values greater than the lowest power among valid targets
Knollspine Invocation -- only values equal to CMC of a card in your hand
Profane Command -- if the second mode is chosen, only values greater than the lowest CMC among valid targets for that mode
Reflecting Mirror -- only values equal to 2*CMC of valid targets
Cards with color-restricted X costs: Atalya, Samite Master; Consume Spirit, Crimson Hellkite, Crypt Rats, Drain Life, Emblazoned Golem, Soul Burn
Automatically set X:
Chromatic Armor, Elite Arcanist, Prototype Portal, Soul Foundry, Spoils of War, Voodoo Doll
And of course, there's Illusionary Mask, a completely outlying case
Re: Forge version 1.5.28
by MIC132 » 15 Sep 2014, 08:45
Will the next version contain the Network Multiplayer stuff? Or is this still on hold?
Who is online
Users browsing this forum: No registered users and 32 guests