It is currently 18 May 2025, 20:06
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby ZappaZ » 12 Oct 2014, 21:32

drdev wrote:Thanks for all the bug reports guys. I just committed a big fix for card details so that morph cards are handled properly. I'm aware of the issue with P/T not factoring in state based effects, and that's the next thing I'm going to look into.

I do apologize for things being kind of broken at the moment, but it should all be worth it once I get things sorted out, as then I'll be able to start working on adding network support.
Hey thanks for all the hard work, I have a draught in new deck ideas so the bug hunt is enjoyable. ;)
ZappaZ
 
Posts: 92
Joined: 26 Jul 2014, 05:37
Has thanked: 26 times
Been thanked: 2 times

Re: Bug Reports (snapshot builds)

Postby nefigah » 12 Oct 2014, 21:50

r27896:

Opponent was able to target my Frontier Bivouac with his Maelstrom Pulse (on his second turn; there was definitely no effect in play that somehow would have made my lands into non-lands).
nefigah
 
Posts: 42
Joined: 16 Mar 2014, 15:49
Has thanked: 10 times
Been thanked: 1 time

Re: Bug Reports (snapshot builds)

Postby ZappaZ » 12 Oct 2014, 21:51

r27897

(P/T changes seems to be working again.)

Description: I'm attacking with a Khalni Hydra and the AI is blocking with 1. a 5/5 Crusader of Odric 2. an Elite Vanguard with four +1/+1 equipped with a Ring of Thune, this is during the Combat Damage phase.

RuntimeException | Open
Code: Select all
Forge Version:    1.5.29-SNAPSHOT-r-1u
Operating System: Windows 7 6.1 amd64
Java Version:     1.8.0_20 Oracle Corporation

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
   at forge.GuiDesktop.invokeInEdtAndWait(GuiDesktop.java:94)
   at forge.FThreads.invokeInEdtAndWait(FThreads.java:52)
   at forge.screens.match.CMatchUI.assignDamage(CMatchUI.java:588)
   at forge.match.MatchUtil.getDamageToAssign(MatchUtil.java:288)
   at forge.player.PlayerControllerHuman.assignCombatDamage(PlayerControllerHuman.java:294)
   at forge.game.combat.Combat.assignAttackersDamage(Combat.java:575)
   at forge.game.combat.Combat.assignCombatDamage(Combat.java:620)
   at forge.game.phase.PhaseHandler.onPhaseBegin(PhaseHandler.java:303)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:935)
   at forge.game.GameAction.startGame(GameAction.java:1339)
   at forge.game.Match.startGame(Match.java:71)
   at forge.match.MatchUtil$2.run(MatchUtil.java:206)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.reflect.InvocationTargetException
   at java.awt.EventQueue.invokeAndWait(Unknown Source)
   at java.awt.EventQueue.invokeAndWait(Unknown Source)
   at javax.swing.SwingUtilities.invokeAndWait(Unknown Source)
   at forge.GuiDesktop.invokeInEdtAndWait(GuiDesktop.java:88)
   ... 14 more
Caused by: java.lang.NullPointerException
   at forge.game.card.CardView$CardStateView.isCreature(CardView.java:752)
   at forge.view.arcane.CardPanel.updatePTOverlay(CardPanel.java:506)
   at forge.view.arcane.CardPanel.setCard(CardPanel.java:539)
   at forge.view.arcane.CardPanel.<init>(CardPanel.java:128)
   at forge.screens.match.VAssignDamage.addPanelForDefender(VAssignDamage.java:263)
   at forge.screens.match.VAssignDamage.<init>(VAssignDamage.java:204)
   at forge.screens.match.CMatchUI$4.run(CMatchUI.java:591)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$400(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.awt.EventQueue$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
ZappaZ
 
Posts: 92
Joined: 26 Jul 2014, 05:37
Has thanked: 26 times
Been thanked: 2 times

Re: Bug Reports (snapshot builds)

Postby ZappaZ » 12 Oct 2014, 22:03

r27897

Accorder Paladin's Battle Cry did not change AIs creatures Power visibly but they still got the increase.

EDIT:
Same thing happened when I used an Aspect of Hydra on my Garruk's Companion.
Last edited by ZappaZ on 12 Oct 2014, 22:12, edited 1 time in total.
ZappaZ
 
Posts: 92
Joined: 26 Jul 2014, 05:37
Has thanked: 26 times
Been thanked: 2 times

Re: Bug Reports (snapshot builds)

Postby nefigah » 12 Oct 2014, 22:04

r27896:

When scrying (with Preordain, in this case), selecting the cards I'm scrying in the menu/chooser thing appears to no longer show that card's picture in the main Card Viewer like it used to
nefigah
 
Posts: 42
Joined: 16 Mar 2014, 15:49
Has thanked: 10 times
Been thanked: 1 time

Re: Bug Reports (snapshot builds)

Postby ZappaZ » 12 Oct 2014, 22:06

r27897

Description: AI played a forest and went to BC phase.

NullPointerException | Open
Code: Select all
Forge Version:    1.5.29-SNAPSHOT-r-1u
Operating System: Windows 7 6.1 amd64
Java Version:     1.8.0_20 Oracle Corporation

java.lang.NullPointerException
   at forge.game.card.CardView.updateAttacking(CardView.java:128)
   at forge.game.card.Card.updateAttackingForView(Card.java:435)
   at forge.game.combat.Combat.addAttacker(Combat.java:170)
   at forge.game.combat.Combat.addAttacker(Combat.java:147)
   at forge.ai.ComputerUtilCard.canBeBlockedProfitably(ComputerUtilCard.java:645)
   at forge.ai.AiAttackController.shouldAttack(AiAttackController.java:978)
   at forge.ai.AiAttackController.declareAttackers(AiAttackController.java:824)
   at forge.ai.ComputerUtilCard.doesCreatureAttackAI(ComputerUtilCard.java:578)
   at forge.ai.ability.PumpAiBase.shouldPumpCard(PumpAiBase.java:485)
   at forge.ai.ability.PumpAiBase$3.apply(PumpAiBase.java:639)
   at forge.ai.ability.PumpAiBase$3.apply(PumpAiBase.java:636)
   at com.google.common.collect.Iterators$7.computeNext(Iterators.java:647)
   at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
   at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
   at forge.util.FCollection.<init>(FCollection.java:28)
   at forge.game.card.CardCollection.<init>(CardCollection.java:61)
   at forge.game.card.CardLists.filter(CardLists.java:223)
   at forge.ai.ability.PumpAiBase.getPumpCreatures(PumpAiBase.java:636)
   at forge.ai.ability.PumpAi.pumpTgtAI(PumpAi.java:307)
   at forge.ai.ability.PumpAi.canPlayAI(PumpAi.java:192)
   at forge.ai.SpellAbilityAi.canPlayAIWithSubs(SpellAbilityAi.java:23)
   at forge.ai.AiController.canPlaySa(AiController.java:701)
   at forge.ai.AiController.canPlayAndPayFor(AiController.java:688)
   at forge.ai.AiController.chooseSpellAbilityToPlay(AiController.java:1261)
   at forge.ai.AiController.getSpellAbilityToPlay(AiController.java:1242)
   at forge.ai.AiController.chooseSpellAbilityToPlay(AiController.java:1198)
   at forge.ai.PlayerControllerAi.chooseSpellAbilityToPlay(PlayerControllerAi.java:385)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:887)
   at forge.game.GameAction.startGame(GameAction.java:1339)
   at forge.game.Match.startGame(Match.java:71)
   at forge.match.MatchUtil$2.run(MatchUtil.java:206)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
ZappaZ
 
Posts: 92
Joined: 26 Jul 2014, 05:37
Has thanked: 26 times
Been thanked: 2 times

Re: Bug Reports (snapshot builds)

Postby nefigah » 12 Oct 2014, 22:17

r27896:

After coming into play from Suspend, my Lotus Bloom's oh-so-important activated ability is missing (both from the Card Detail pane and actually missing: clicking on it on the battlefield does nothing)
EDIT: But "Auto" mana-cost-paying was still able to use it; just not me manually!
EDIT 2: Got the same bug with Sarkhan that someone reported in an earlier revision—his +1 ability doesn't actually make him into a creature
nefigah
 
Posts: 42
Joined: 16 Mar 2014, 15:49
Has thanked: 10 times
Been thanked: 1 time

Re: Bug Reports (snapshot builds)

Postby ZappaZ » 12 Oct 2014, 22:25

r27897

Madcap Skills did not change a (Selesnya Charm) Token Knights Power visibly when equipped.
ZappaZ
 
Posts: 92
Joined: 26 Jul 2014, 05:37
Has thanked: 26 times
Been thanked: 2 times

Re: Bug Reports (snapshot builds)

Postby drdev » 13 Oct 2014, 00:14

I just fixed the long outstanding bug where the Log wouldn't update if it was visible (r27900).
drdev
Programmer
 
Posts: 1958
Joined: 27 Jul 2013, 02:07
Has thanked: 189 times
Been thanked: 565 times

Re: Bug Reports (snapshot builds)

Postby Starcrash » 13 Oct 2014, 00:53

Description: I was choosing a source to prevent damage from, specifically with "Deflecting Palm" from KTK.

NullPointerException | Open
Code: Select all
Forge Version:    1.5.28-r27804
Operating System: Windows 8.1 6.3 x86
Java Version:     1.8.0_20 Oracle Corporation

java.lang.NullPointerException
   at forge.player.PlayerControllerHuman.tempShowCard(PlayerControllerHuman.java:172)
   at forge.player.PlayerControllerHuman.tempShow(PlayerControllerHuman.java:166)
   at forge.GuiDesktop.chooseSingleEntityForEffect(GuiDesktop.java:196)
   at forge.player.PlayerControllerHuman.chooseSingleEntityForEffect(PlayerControllerHuman.java:434)
   at forge.game.player.PlayerController.chooseSingleEntityForEffect(PlayerController.java:177)
   at forge.game.ability.effects.ChooseSourceEffect.resolve(ChooseSourceEffect.java:143)
   at forge.game.ability.SpellApiBased.resolve(SpellApiBased.java:50)
   at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1240)
   at forge.game.ability.AbilityUtils.resolve(AbilityUtils.java:1222)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:584)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:1077)
   at forge.game.GameAction.startGame(GameAction.java:1585)
   at forge.game.Match.startGame(Match.java:81)
   at forge.match.MatchUtil$2.run(MatchUtil.java:232)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
Starcrash
 
Posts: 96
Joined: 30 May 2011, 18:39
Has thanked: 2 times
Been thanked: 1 time

Re: Bug Reports (snapshot builds)

Postby drdev » 13 Oct 2014, 01:22

nefigah wrote:r27896:

After coming into play from Suspend, my Lotus Bloom's oh-so-important activated ability is missing (both from the Card Detail pane and actually missing: clicking on it on the battlefield does nothing)
EDIT: But "Auto" mana-cost-paying was still able to use it; just not me manually!
EDIT 2: Got the same bug with Sarkhan that someone reported in an earlier revision—his +1 ability doesn't actually make him into a creature
I just fixed all the bugs relating to mana abilities being excluded in r27901.
drdev
Programmer
 
Posts: 1958
Joined: 27 Jul 2013, 02:07
Has thanked: 189 times
Been thanked: 565 times

Re: Bug Reports (snapshot builds)

Postby drdev » 13 Oct 2014, 01:30

Starcrash wrote:Description: I was choosing a source to prevent damage from, specifically with "Deflecting Palm" from KTK.

NullPointerException | Open
Code: Select all
Forge Version:    1.5.28-r27804
Operating System: Windows 8.1 6.3 x86
Java Version:     1.8.0_20 Oracle Corporation

java.lang.NullPointerException
   at forge.player.PlayerControllerHuman.tempShowCard(PlayerControllerHuman.java:172)
   at forge.player.PlayerControllerHuman.tempShow(PlayerControllerHuman.java:166)
   at forge.GuiDesktop.chooseSingleEntityForEffect(GuiDesktop.java:196)
   at forge.player.PlayerControllerHuman.chooseSingleEntityForEffect(PlayerControllerHuman.java:434)
   at forge.game.player.PlayerController.chooseSingleEntityForEffect(PlayerController.java:177)
   at forge.game.ability.effects.ChooseSourceEffect.resolve(ChooseSourceEffect.java:143)
   at forge.game.ability.SpellApiBased.resolve(SpellApiBased.java:50)
   at forge.game.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1240)
   at forge.game.ability.AbilityUtils.resolve(AbilityUtils.java:1222)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:584)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:1077)
   at forge.game.GameAction.startGame(GameAction.java:1585)
   at forge.game.Match.startGame(Match.java:81)
   at forge.match.MatchUtil$2.run(MatchUtil.java:232)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
Fixed in r27902.
drdev
Programmer
 
Posts: 1958
Joined: 27 Jul 2013, 02:07
Has thanked: 189 times
Been thanked: 565 times

Re: Bug Reports (snapshot builds)

Postby drdev » 13 Oct 2014, 01:34

ZappaZ wrote:r27897

Description: AI played a forest and went to BC phase.

NullPointerException | Open
Code: Select all
Forge Version:    1.5.29-SNAPSHOT-r-1u
Operating System: Windows 7 6.1 amd64
Java Version:     1.8.0_20 Oracle Corporation

java.lang.NullPointerException
   at forge.game.card.CardView.updateAttacking(CardView.java:128)
   at forge.game.card.Card.updateAttackingForView(Card.java:435)
   at forge.game.combat.Combat.addAttacker(Combat.java:170)
   at forge.game.combat.Combat.addAttacker(Combat.java:147)
   at forge.ai.ComputerUtilCard.canBeBlockedProfitably(ComputerUtilCard.java:645)
   at forge.ai.AiAttackController.shouldAttack(AiAttackController.java:978)
   at forge.ai.AiAttackController.declareAttackers(AiAttackController.java:824)
   at forge.ai.ComputerUtilCard.doesCreatureAttackAI(ComputerUtilCard.java:578)
   at forge.ai.ability.PumpAiBase.shouldPumpCard(PumpAiBase.java:485)
   at forge.ai.ability.PumpAiBase$3.apply(PumpAiBase.java:639)
   at forge.ai.ability.PumpAiBase$3.apply(PumpAiBase.java:636)
   at com.google.common.collect.Iterators$7.computeNext(Iterators.java:647)
   at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
   at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
   at forge.util.FCollection.<init>(FCollection.java:28)
   at forge.game.card.CardCollection.<init>(CardCollection.java:61)
   at forge.game.card.CardLists.filter(CardLists.java:223)
   at forge.ai.ability.PumpAiBase.getPumpCreatures(PumpAiBase.java:636)
   at forge.ai.ability.PumpAi.pumpTgtAI(PumpAi.java:307)
   at forge.ai.ability.PumpAi.canPlayAI(PumpAi.java:192)
   at forge.ai.SpellAbilityAi.canPlayAIWithSubs(SpellAbilityAi.java:23)
   at forge.ai.AiController.canPlaySa(AiController.java:701)
   at forge.ai.AiController.canPlayAndPayFor(AiController.java:688)
   at forge.ai.AiController.chooseSpellAbilityToPlay(AiController.java:1261)
   at forge.ai.AiController.getSpellAbilityToPlay(AiController.java:1242)
   at forge.ai.AiController.chooseSpellAbilityToPlay(AiController.java:1198)
   at forge.ai.PlayerControllerAi.chooseSpellAbilityToPlay(PlayerControllerAi.java:385)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:887)
   at forge.game.GameAction.startGame(GameAction.java:1339)
   at forge.game.Match.startGame(Match.java:71)
   at forge.match.MatchUtil$2.run(MatchUtil.java:206)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
Should be fixed with r27903.
drdev
Programmer
 
Posts: 1958
Joined: 27 Jul 2013, 02:07
Has thanked: 189 times
Been thanked: 565 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 13 Oct 2014, 01:37

r27901

When AI has a morph creature on the battlefield, I'm (not the controller) am able to click on the card detail panel to see what the morph is. Only controllers (or a card granting a particular effect) should be able to view the card's original state.

Edit: Also, it looks like when the AI has a card with an Aura on it, and I hover over the card being attached (not the Aura). The CDP still shows the Aura, and the highlight is around the Aura not the creature. Not only is that annoying from looking at stats perspective, it also makes targeting more difficult, since even though I'm clicking on the Creature, it thinks I'm clicking on the card BEHIND the highest z-indexed one, forcing me to click on the very edge of the card for targeting/detailing purposes.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby drdev » 13 Oct 2014, 02:03

nefigah wrote:r27896:

When scrying (with Preordain, in this case), selecting the cards I'm scrying in the menu/chooser thing appears to no longer show that card's picture in the main Card Viewer like it used to
Fixed in r27904.
drdev
Programmer
 
Posts: 1958
Joined: 27 Jul 2013, 02:07
Has thanked: 189 times
Been thanked: 565 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 49 guests


Who is online

In total there are 49 users online :: 0 registered, 0 hidden and 49 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 49 guests

Login Form