Bug Reports (snapshot builds)
Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by Myrd » 08 Dec 2014, 05:50
Fixed - test was flaky because it dependent on a toString() method that iterated over a map.KrazyTheFox wrote:forge.game.mana.ManaCostBeingPaidTest is failing on line 20 about half the time for my CI server (which is preventing builds from getting released).
My server is running the latest version of JDK 1.7.
- Code: Select all
junit.framework.ComparisonFailure: expected:<1{[G}{W]}> but was:<{1}{[W}{G]}>
at junit.framework.Assert.assertEquals(Assert.java:85)
at junit.framework.Assert.assertEquals(Assert.java:91)
at forge.game.mana.ManaCostBeingPaidTest.runConvokeTest(ManaCostBeingPaidTest.java:20)
at forge.game.mana.ManaCostBeingPaidTest.testPayManaViaConvoke(ManaCostBeingPaidTest.java:14)
Re: Bug Reports (snapshot builds)
by Myrd » 08 Dec 2014, 06:09
Playing Satyr Wayfinder reveals the 4 cards to the player twice. (In addition to the 3rd dialog to select the land to choose.)
I believe this bug was introduced in r28094. The issue is that both game.getAction().reveal(top, p, false); and the DelayedReveal run in this case for the player casting it.
Perhaps we can just get rid of the DelayedReveal in this case?
I believe this bug was introduced in r28094. The issue is that both game.getAction().reveal(top, p, false); and the DelayedReveal run in this case for the player casting it.
Perhaps we can just get rid of the DelayedReveal in this case?
Re: Bug Reports (snapshot builds)
by Agetian » 09 Dec 2014, 15:13
Here's a bug I noticed with the Morph card being announced before time: I attacked with my 8/6 Hooting Mandrills and the AI blocked with three creatures, one of which was a face-down Morph. However, during the declaration of damage order to the blockers I was able to clearly see the actual card's name for the opponent's Morph (highlighted on the screenshot), I don't think that's supposed to happen.
- Agetian
- Agetian
- Attachments
-
- Agetian
- Programmer
- Posts: 3490
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by drdev » 10 Dec 2014, 14:55
This bug was fixed right after the release. Have you tried installing the latest snapshot?SIXTY wrote:Description: [describe what you were doing when the crash occurred]
- NullPointerException | Open
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Bug Reports (snapshot builds)
by Agetian » 11 Dec 2014, 15:18
In continuation of my previous bug report related to Morph cards being spoiled by the "declare order of blockers for damage assignment" window, I have identified the spot where it happens (in particular, toString of CardView always returns the full ID and name of the face-down card, and then this information is taken unprocessed by the code that pops up the window where you can declare the order in which the blockers receive damage). I'm not sure what to do with this to make it work properly, please assist if possible. Here's a test case that clearly demonstrates the issue:
- Agetian
- Code: Select all
AICardsInPlay=Plains;Plains;Plains;Ponyback Brigade
AICardsInHand=Ponyback Brigade
AILife=3
HumanCardsInPlay=Forest;Forest;Forest;Forest;Force of Nature
- Agetian
- Agetian
- Programmer
- Posts: 3490
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by elcnesh » 11 Dec 2014, 15:43
I think there's two options:
1) Never use toString, always use a viewer-specific method;
2) Change toString to not always show the id. The hidden id I implemented yesterday can help here, as then the controller of the morph can easily check which creature is affected by mousing over it.
I think 2) is acceptable and a lot easier, but 1) would be slightly more elegant... What do you think?
1) Never use toString, always use a viewer-specific method;
2) Change toString to not always show the id. The hidden id I implemented yesterday can help here, as then the controller of the morph can easily check which creature is affected by mousing over it.
I think 2) is acceptable and a lot easier, but 1) would be slightly more elegant... What do you think?
- elcnesh
- Posts: 290
- Joined: 16 May 2014, 15:11
- Location: Netherlands
- Has thanked: 34 times
- Been thanked: 92 times
Re: Bug Reports (snapshot builds)
by Agetian » 11 Dec 2014, 16:24
I think #2 may actually work, though it may complicate the procedure just a little bit (since during e.g. the blocker damage order declaration it's impossible to mouse over the card, so you'll have to click the card name in the list and then see which one is highlighted, though that is, of course, possibleelcnesh wrote:I think there's two options:
1) Never use toString, always use a viewer-specific method;
2) Change toString to not always show the id. The hidden id I implemented yesterday can help here, as then the controller of the morph can easily check which creature is affected by mousing over it.
I think 2) is acceptable and a lot easier, but 1) would be slightly more elegant... What do you think?
).Would it be too difficult to implement #1 though if it'd allow to keep the possibility of showing the ID and name for cards that the player can legitimately see but avoid showing those for cards that are supposed to be hidden? (if this also helps avoid the burden of having to figure out the exact card by looking up its ID or by clicking around?).
EDIT: r28415: I implemented the fix #2 for now, let's see how that goes and if it has any major problems associated with it - if it does, probably #1 would be the better way, but I'm not the best person to code it...
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3490
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by krimsen » 11 Dec 2014, 20:47
Description: I played Tyrant's Choice with a Grudge Keeper and 2x Brago's Representative in play. I voted 3x "Death", AI voted "Torture". Exception was thrown when the Grudge Keeper ability should have been resolved.
- ClassCastException | Open
- krimsen
- Posts: 5
- Joined: 11 Dec 2014, 20:43
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by friarsol » 12 Dec 2014, 02:49
r28421
I seem to get this error regularly when 10x speeding through Quest Tournaments AIvsAI games.
I seem to get this error regularly when 10x speeding through Quest Tournaments AIvsAI games.
- NullPointerException | Open
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by Snowstorm » 18 Dec 2014, 08:32
r28485
The first bug is an 3+ multiplayer bug with Jace, Architect of Thought as it does not let me search all player libraries only my own and the first opponent.
The second bug deals with blinking walkers with Doubling Season out as it does not double their loyalty counters on arrival like it should. (Tested with Venser, the Sojourner)
(Can't play my superfriends deck without these two not working
)
Edit: I forgot about this bug until now but Forbidden Orchard does not allow you to choose what player gets the token and always picks the first opponent if playing with more than one other player.
Edit2: Another Multiplayer related bug, Mikokoro, Center of the Sea only draws for the first opponent and myself who activated.
Edit3: Another Multiplayer related bug, Whenever the AI uses cards like Blatant Thievery and Molten Primordial they only target one player (which is always me) and take cards for each player from me instead (so instead of losing one card I lose four).
The first bug is an 3+ multiplayer bug with Jace, Architect of Thought as it does not let me search all player libraries only my own and the first opponent.
The second bug deals with blinking walkers with Doubling Season out as it does not double their loyalty counters on arrival like it should. (Tested with Venser, the Sojourner)
(Can't play my superfriends deck without these two not working
)Edit: I forgot about this bug until now but Forbidden Orchard does not allow you to choose what player gets the token and always picks the first opponent if playing with more than one other player.
Edit2: Another Multiplayer related bug, Mikokoro, Center of the Sea only draws for the first opponent and myself who activated.
Edit3: Another Multiplayer related bug, Whenever the AI uses cards like Blatant Thievery and Molten Primordial they only target one player (which is always me) and take cards for each player from me instead (so instead of losing one card I lose four).
Re: Bug Reports (snapshot builds)
by matrix4767 » 20 Dec 2014, 16:49
I can't cast cards exiled with Intet, the Dreamer. I can't look at them either, they're just shown morphed.
-r28500
-r28500
- matrix4767
- Posts: 125
- Joined: 09 Sep 2014, 08:10
- Has thanked: 5 times
- Been thanked: 3 times
Re: Bug Reports (snapshot builds)
by merchantkompany » 21 Dec 2014, 03:44
Description: Clicked Deck Editor tab, brought this up. Showed I was on "Home" tab, but was displaying "Deck Editor" tab.
- NullPointerException | Open
- merchantkompany
- Posts: 1
- Joined: 21 Dec 2014, 03:38
- Has thanked: 0 time
- Been thanked: 0 time
Re: Bug Reports (snapshot builds)
by torridus » 21 Dec 2014, 07:02
Playing Plunge Into Darkness freezes the game if you're below zero life and have a Platinum Angel on the field. Forge just says "waiting for opponent" if you click "continue" after a crash report pops up. You can't concede to end the game, either - you have to completely exit Forge to get out of the freeze.
- NegativeArraySizeException | Open
Re: Bug Reports (snapshot builds)
by swordshine » 21 Dec 2014, 08:30
Snowstorm wrote:r28485
The second bug deals with blinking walkers with Doubling Season out as it does not double their loyalty counters on arrival like it should. (Tested with Venser, the Sojourner)
(Can't play my superfriends deck without these two not working
Edit: I forgot about this bug until now but Forbidden Orchard does not allow you to choose what player gets the token and always picks the first opponent if playing with more than one other player.
Edit2: Another Multiplayer related bug, Mikokoro, Center of the Sea only draws for the first opponent and myself who activated.
torridus wrote:Playing Plunge Into Darkness freezes the game if you're below zero life and have a Platinum Angel on the field. Forge just says "waiting for opponent" if you click "continue" after a crash report pops up. You can't concede to end the game, either - you have to completely exit Forge to get out of the freeze.
Using Forge ver 1.5.2814277
Fixed.matrix4767 wrote:I can't cast cards exiled with Intet, the Dreamer. I can't look at them either, they're just shown morphed.
-r28500
- swordshine
- Posts: 682
- Joined: 11 Jul 2010, 02:37
- Has thanked: 116 times
- Been thanked: 87 times
Who is online
Users browsing this forum: Timothysow and 9 guests