It is currently 18 Jul 2025, 13:05
   
Text Size

Card Contributions

Moderators: ubeefx, beholder, melvin, ShawnieBoy, Lodici, CCGHQ Admins

Re: Card Contributions

Postby muppet » 22 Feb 2015, 10:55

I actually had a look at making a new card and it seemed to work ok but turned out the engine didn't support scry 2 as far as I can tell so I might actually contribute at some point. I'll try again with a card that is supported and then I can have a look at others once I have done that.
muppet
Tester
 
Posts: 590
Joined: 03 Aug 2011, 14:37
Has thanked: 33 times
Been thanked: 30 times

Re: Card Contributions

Postby PalladiaMors » 22 Feb 2015, 17:58

I've tried for the first time to use MagicOrChoice to do cards that allow choosing between more than 2 choices, and was quite surprised to find out that it does work.

This obviously opens the way for a ton of new cards, including stuff that sees a lot of play. I remember ShawnieBoy once specifically mentioned that those cards shouldn't be done for the time being, though, so I though I should ask if it's ok to start exploring those now. At this point I've submitted only Funeral Charm, which was my first experiment.

It looked like the concern involved slowing down the AI too much. I have a pretty old computer, and Magarena runs fast here. Computer speed has went up considerably since Magarena was first released. Personally, I think the multiple choices look fine, but obviously I'll listen to what the developers have to say about this.
PalladiaMors
 
Posts: 343
Joined: 12 Jul 2014, 17:40
Has thanked: 36 times
Been thanked: 22 times

Re: Card Contributions

Postby Lodici » 22 Feb 2015, 18:16

PalladiaMors wrote:...but obviously I'll listen to what the developers have to say about this.
Since @ShawnieBoy seems to be taking a break we are missing a dedicated scripter so any contributions you can make @PalladiaMors will be very welcome. I am useless when it comes to the rules side of MTG so I won't be of much help but I think @melvin encourages submissions and usually checks (and fixes) any issues.
User avatar
Lodici
Programmer
 
Posts: 399
Joined: 13 Oct 2013, 09:44
Has thanked: 29 times
Been thanked: 71 times

Re: Card Contributions

Postby melvin » 23 Feb 2015, 03:40

PalladiaMors wrote:I've tried for the first time to use MagicOrChoice to do cards that allow choosing between more than 2 choices, and was quite surprised to find out that it does work.
It does work, just not according to the rules. The issue is that if one of the modal choices target, the target is chosen when the effect resolves and not when it goes on the stack. Personally I'm ok with it, we may eventually find a way to address this discrepancy.

Since we've been doing two choices, upping it to three or four shouldn't make too much of a difference. I don't see the concern with AI as long as it is tested that the AI is able to play these modal spells properly.
User avatar
melvin
AI Programmer
 
Posts: 1062
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 459 times

Re: Card Contributions

Postby melvin » 23 Feb 2015, 06:02

melvin wrote:The issue is that if one of the modal choices target, the target is chosen when the effect resolves and not when it goes on the stack.
Fixed in https://github.com/magarena/magarena/co ... 3ac48af651 Now it will ask for the target when putting effect on the stack.
User avatar
melvin
AI Programmer
 
Posts: 1062
Joined: 21 Mar 2010, 12:26
Location: Singapore
Has thanked: 36 times
Been thanked: 459 times

Re: Card Contributions

Postby PalladiaMors » 23 Feb 2015, 16:31

Healing Leaves had a mistake in its targeting hints, so I tried to submit a fix through GitHub. It actually doesn't require a groovy because it could borrow Healing Salve 's.
PalladiaMors
 
Posts: 343
Joined: 12 Jul 2014, 17:40
Has thanked: 36 times
Been thanked: 22 times

Re: Card Contributions

Postby muppet » 23 Feb 2015, 17:06

I'll have another go tonight at making a card maybe Ancient Tomb that doesn't look as though it shd be hard
muppet
Tester
 
Posts: 590
Joined: 03 Aug 2011, 14:37
Has thanked: 33 times
Been thanked: 30 times

Re: Card Contributions

Postby muppet » 24 Feb 2015, 09:13

Ok maybe this isn't so simple. Just to check I shd be able to add cards if I have a script and a groovy file if it needs one without recompiling the code? Aha ok I got a card to work so now I just have to work out why Ancient Tomb won't work hmm i'll try making it one mana not two maybe you can't add 2 mana at once for some reason. Ok so the engine doesn't like scry 2 and adding 2 mana at once is what I learnt so far.
muppet
Tester
 
Posts: 590
Joined: 03 Aug 2011, 14:37
Has thanked: 33 times
Been thanked: 30 times

Re: Card Contributions

Postby PalladiaMors » 24 Feb 2015, 13:37

Submitted a fix to Jund Charm 's target choices.

@muppet, you might want to have a good look at the topic "list of unsupported card groups".
PalladiaMors
 
Posts: 343
Joined: 12 Jul 2014, 17:40
Has thanked: 36 times
Been thanked: 22 times

Re: Card Contributions

Postby muppet » 24 Feb 2015, 13:59

PalladiaMors wrote:Submitted a fix to Jund Charm 's target choices.

@muppet, you might want to have a good look at the topic "list of unsupported card groups".
ok call me stupid where is it. can't see it on the wiki which was where I was getting the scripting info.
muppet
Tester
 
Posts: 590
Joined: 03 Aug 2011, 14:37
Has thanked: 33 times
Been thanked: 30 times

Re: Card Contributions

Postby PalladiaMors » 24 Feb 2015, 14:17

PalladiaMors
 
Posts: 343
Joined: 12 Jul 2014, 17:40
Has thanked: 36 times
Been thanked: 22 times

Re: Card Contributions

Postby muppet » 24 Feb 2015, 14:35

thanks again no idea why I wasn't looking on the forums at all :-). And good that agrees with what I thought was up with the cards I tried. Glad to see you have done the charms I fancied trying them once I knew what I was doing a bit.
muppet
Tester
 
Posts: 590
Joined: 03 Aug 2011, 14:37
Has thanked: 33 times
Been thanked: 30 times

Re: Card Contributions

Postby muppet » 24 Feb 2015, 18:18

Ok my next attempt might be a bit too complicated but its a good card and doesn't seem to have anything prohibited Deathrite Shaman. Umm I know it says adding to mana pool but its just a tap to gain a mana really.
muppet
Tester
 
Posts: 590
Joined: 03 Aug 2011, 14:37
Has thanked: 33 times
Been thanked: 30 times

Re: Card Contributions

Postby muppet » 25 Feb 2015, 09:28

Right so I tried to make Deathrite Shaman all worked fine except when I tried to combine anything with the mana generation. So I couldn't get the land to exile either before or after the mana generation in that line. I guess its possible you can't do some things as you make mana. I thought it might be possible given things like the pain lands where you generate mana and take a point of damage. At least I learnt a bit about how to make a card.
There was one other odd thing I cldn't get instant and sorcery card to work on the same line even though I see it done like that in other cards I had to make two abilities one for each which seemed to work ok.
muppet
Tester
 
Posts: 590
Joined: 03 Aug 2011, 14:37
Has thanked: 33 times
Been thanked: 30 times

Re: Card Contributions

Postby PalladiaMors » 25 Feb 2015, 11:40

I didn't comment before because I'm really not sure about whether Deathrite Shaman is implementable or not. Everything in it looks viable, but there's currently very few cards that generate mana in groovy form to use as reference. Exiling cards from graveyard should be fine, I remember doing a bunch of those a few months ago. Although, this one is a bit exotic because it can pick cards from both graveyards. Deathrite Shaman seems to be huge even in Legacy, it would be a pretty nice one to implement if you can get it right.
PalladiaMors
 
Posts: 343
Joined: 12 Jul 2014, 17:40
Has thanked: 36 times
Been thanked: 22 times

PreviousNext

Return to Magarena

Who is online

Users browsing this forum: No registered users and 3 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 3 users online :: 0 registered, 0 hidden and 3 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 3 guests

Login Form