Community Wad

[Splinterverse]

I don't see any inherent issues. It looks to me like it should prevent a creature from blocking if you control any tapped lands. Is that right?

Correct, but it's not working for some reason. I'll try it again with the tweaks you suggested.

Based on what you said earlier about planewsalkers, there are some cards that might need to be corrected.

GetCardType():Test(CARD_TYPE_PLANESWALKER) appears in the following cards' code:
Ajani, Mentor of Heroes
Day's Undoing
Dragonlord Kolaghan
Oath of Gideon
Oath of Nissa
Sundial of the Infinite
Time Stop

It also appears in Chandra's Phoenix, but the card file doesn't appear to be a community wad version.

[Xander9009]

Yes and no. GetCardType():Test(CARD_TYPE_PLANESWALKER) will successfully work in almost all circumstances when the card is no on the battlefield. For consistency's sake, we should modify those cards, but they'll work fine with their current code.

Some cards are in the base game, but they need to be modified to work properly (either they're bugged or they simply don't work with the CW). For those cards, go ahead and add them to the CW and make the needed changes, treating them as if they're any other CW card, except they don't get author tags, they don't have CW in the filename, and they use their original ArtID value.

Chandra's Phoenix, in particular, is already in the CW for exactly this reason. It can be modified/corrected like any other card.

[Splinterverse]

Yes and no. GetCardType():Test(CARD_TYPE_PLANESWALKER) will successfully work in almost all circumstances when the card is no on the battlefield. For consistency's sake, we should modify those cards, but they'll work fine with their current code.

Some cards are in the base game, but they need to be modified to work properly (either they're bugged or they simply don't work with the CW). For those cards, go ahead and add them to the CW and make the needed changes, treating them as if they're any other CW card, except they don't get author tags, they don't have CW in the filename, and they use their original ArtID value.

Chandra's Phoenix, in particular, is already in the CW for exactly this reason. It can be modified/corrected like any other card.

CW_General_IsPlaneswalker(oCard) works with a card in the library though correct? (I ask because I used it in a card that I plan to upload later today).

[Xander9009]

Should work for a card no matter where it is. They all should. Previously, they would work for any zone, but the zone needed specified, but I reworked them recently to eliminate that requirement. I tested them to make sure they were working right, but if you find they're misbehaving, let me know.

[Splinterverse]

Should work for a card no matter where it is. They all should. Previously, they would work for any zone, but the zone needed specified, but I reworked them recently to eliminate that requirement. I tested them to make sure they were working right, but if you find they're misbehaving, let me know.

Will do. Thanks!

[Splinterverse]

Is there a way to trigger an ability just before a step begins? I want something to fire just before MTG():GetStep() == STEP_DECLARE_ATTACKERS. I know I could have it fire in the first main phase, but that would be too early.

This is all for Viashino Bey.

The idea is that the card would ask the player if they are going to attack with Viashino Bey. If the answer is Yes, then the must attack characteristic would be applied to all creatures the controller owns until end of turn. I would also apply it to Viashino so that he has to attack as well.

[Splinterverse]

I'm finished for today. I will be back on Wednesday (at the latest) to do more coding.

All cards referenced below are from the missing cards list.

Coded, tested, and uploaded:
Apathy
Discordant Dirge
Lord Magnus
Paralyze
Quagmire
Recantation
Rumbling Crescendo
Serra's Liturgy
Staff of the Ages
Undertow
Ur-Drago
Urza's Armor
Urza's Guilt
Vampiric Embrace
Vectis Dominator
Vedalken Anatomist
Venarian Gold
Verdant Succession
Vex
View from Above
Vigean Intuition
Vigor Mortis
Vile Requiem

Bugs Fixed:
Dark Sphere -- had two open and close RTA tags on the same RTA, so I removed the extra; did not test to see if it was working.
Volcanic Wind -- caught an error; fixed and tested.

Art Uploaded (All are HQ and were missing):
Halam Djinn
Ur-Drago
Vectis Dominator
View from Above

Questions:

1. Veiled Crocodile http://pastebin.com/YEEAkbB2 This card does everything it is supposed to do. However, when it turns into a crocodile and the next attack step occurs, the game grays out the attack buttons so, in effect, you can't do anything and have to exit. I suspect it has to do with the trigger I am using or the fact that it is an enchantment turned creature. Any advice would be much appreciated.

2. Veteran Brawlers http://pastebin.com/UskHMBLw This card's top ability works perfectly. It's second ability does not. I originally had them matching, but have shortened the second based on advice from Xander. I think the upper one could benefit from the clean-up as well, but I didn't want to bother until I got it working.

3. Yawgmoth's Agenda http://pastebin.com/K3FQJcXG Everything on this card works except casting from graveyard. The text "Play this card" appears on the cards in the graveyard, but you can't click to activate them. I did try looking at Gisa and Geralf and previous suggestion from fallenangle.

4. See previous post for outstanding question on Viashino Bey.


Notes:

I am mostly working my way through the missing cards in reverse alphabetical order. I have tried many of the ones that are listed that I haven't uploaded. In fact, I have a lot of partially coded cards or cards that were fully coded, but don't work. I didn't want to bombard the forums with questions on each card. Just ones that I feel I'm close to finished with. However, if anyone wants to look at the code, I will happily upload any of interest. I am currently in the letter 'U'.

I am skipping through the alphabet when I find similar cards. The -walk ability cards today and the djinn cards yesterday are a result of that (among many others).

See you Wednesday (or sooner if I can sneak away)!

[fallenangle]

Splinterverse,

For Veiled Crocodile, you're going to want a "STATE_BASED_EFFECTS" TRIGGER value or no TRIGGER value in order for the card to trigger whenever the trigger conditions return true. Having it go off at the beginning of a player's step isn't right, probably causes your issue. I also think that the CONTINUOUS_ACTION doesn't need a DURATION tag.

For Veteran Brawlers, I think your problem is that you forgot to close the triggered ability with a </TRIGGERED_ABILITY> tag.

For Yawgmoth's Agenda, I'm not sure. I tried coding something similar and had the same problem you did. I sent Xander an e-mail about this, but he hasn't had time to reply, yet. I think that something is preventing the abilities from properly being granted.

[Splinterverse]

Splinterverse,

For Veiled Crocodile, you're going to want a "STATE_BASED_EFFECTS" TRIGGER value or no TRIGGER value in order for the card to trigger whenever the trigger conditions return true. Having it go off at the beginning of a player's step isn't right, probably causes your issue. I also think that the CONTINUOUS_ACTION doesn't need a DURATION tag.

For Veteran Brawlers, I think your problem is that you forgot to close the triggered ability with a </TRIGGERED_ABILITY> tag.

For Yawgmoth's Agenda, I'm not sure. I tried coding something similar and had the same problem you did. I sent Xander an e-mail about this, but he hasn't had time to reply, yet. I think that something is preventing the abilities from properly being granted.

Thanks, fallenangle. I have made those changes and will test them next time I am able to work on this stuff.

[Splinterverse]

I'm not sure if the Wad is automatically updating. I noticed the stuff I uploaded yesterday is still in the auto-upload folder.

At any rate, I was able to sneak in a couple more cards.

Coded, tested, and uploaded:
Branded Brawlers
Undead Slayer
Urborg Stalker
Veteran Brawlers

Thanks to fallenangle for helping with Veteran Brawlers!


Issues:

1. Veiled Crocodile http://pastebin.com/J9qAd3f4 I changed it to a STATE_BASED_EFFECTS and now it seems to get stuck in a loop when the condition is true. I see numbers appear on the card and they keep counting up (into the hundreds quickly) and I have to concede and leave the game. I tried adding cleanup. I didn't try "break" because I thought return would do it. Not sure what I need here.

2. Urborg http://pastebin.com/Pe2rrKdZ The mana feature works, but the removal of swampwalk and first strike does not. Not sure what's up.

[migookman]

For Urborg, try getting the characteristics as below:

local characteristics = target:GetCurrentCharacteristics()
characteristics:Bool_Set( CHARACTERISTIC_SWAMPWALK, 0 )

[fallenangle]

Splinterverse,

It looks like I gave you bad advice on Veiled Crocodile. I apologize. I think you actually need it in a Continuous Action block like Lupine Prototype. Try this and see if it works (you'll have to move the "xml version" tag all the way to the left when you paste it for the card to work):

Code: Select all

<?xml version="1.0"?>
<CARD_V2 ExportVersion="1">
    <FILENAME text="VEILED_CROCODILE_CW_5789" />
    <CARDNAME text="VEILED_CROCODILE" />
    <TITLE>
        <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[Veiled Crocodile]]></LOCALISED_TEXT>
    </TITLE>
    <MULTIVERSEID value="5789" />
    <ARTID value="VEILED_CROCODILE" />
    <ARTIST name="Paolo Parente" />
    <CASTING_COST cost="{2}{U}" />
    <FLAVOURTEXT>
        <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[Some roads are paved with bad intentions.]]></LOCALISED_TEXT>
    </FLAVOURTEXT>
    <TYPE metaname="Enchantment" />
    <EXPANSION value="UZ" />
    <RARITY metaname="R" />
<STATIC_ABILITY>
<LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="zh-CN"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
        <LOCALISED_TEXT LanguageCode="zh-HK"><![CDATA[When a player has no cards in hand, if Veiled Crocodile is an enchantment, Veiled Crocodile becomes a 4/4 Crocodile creature.]]></LOCALISED_TEXT>
      <INTERVENING_IF>
    if EffectSource() ~= nil and EffectSource():GetCardType():Test( CARD_TYPE_ENCHANTMENT ) then
       return true
    else
       return false
    end
    </INTERVENING_IF>
<CONTINUOUS_ACTION layer="6">
         local bHellbent = false
         local iPlayerCount = MTG():GetNumberOfPlayers()
         for i=0,iPlayerCount-1 do
            local oPlayer = MTG():GetNthPlayer(i)
            if oPlayer ~= nil and oPlayer:Hand_Count() == 0 then
               bHellbent = true
         if bHellbent == true then
            local oCharacteristics = EffectSource() and EffectSource():GetCurrentCharacteristics()
            if oCharacteristics ~= nil then
            oCharacteristics:Power_Set(4)
                oCharacteristics:Toughness_Set(4)
            end
         end
      end
   end
      </CONTINUOUS_ACTION>
      <CONTINUOUS_ACTION layer="4">
            if EffectSource() ~= nil then
                local Characteristics = EffectSource():GetCurrentCharacteristics()
                Characteristics:CardType_GetWritable():Add(CARD_TYPE_CREATURE)
                local SubType = Characteristics:SubType_GetWritable()
                SubType:ClearAllOfType(CARD_TYPE_CREATURE)
                SubType:Add(CREATURE_TYPE_CROCODILE)
            end
        </CONTINUOUS_ACTION>
   </STATIC_ABILITY>
    <AUTHOR><![CDATA[Splinterverse]]></AUTHOR>
    <EDITORS><![CDATA[Splinterverse]]></EDITORS>
    <DATE><![CDATA[29-09-16]]></DATE>
</CARD_V2>

[Xander9009]

Is there a way to trigger an ability just before a step begins? I want something to fire just before MTG():GetStep() == STEP_DECLARE_ATTACKERS. I know I could have it fire in the first main phase, but that would be too early.

This is all for Viashino Bey.

The idea is that the card would ask the player if they are going to attack with Viashino Bey. If the answer is Yes, then the must attack characteristic would be applied to all creatures the controller owns until end of turn. I would also apply it to Viashino so that he has to attack as well.

Try a replacement_effect and pre_trigger triggered ability.

replacement_effect="1" goes in the <TRIGGERED_ABILITY...> line.
pre_trigger="1" goes in the <TRIGGER...> line.

The pre_trigger makes the ability fire before the trigger itself is processed (if possible). replacement_effect should make it appear immediately without waiting for the timer. Combined, they should allow you to do what you need.

----

For Veiled Crocodile, STATE_BASED_EFFECTS is correct. The issue is that you need to prevent the STATE_BASED_EFFECTS trigger from firing while the ability is already on the stack. It's a pretty simple task. You just need to make it only fire if a certain LinkedDC() value is 0. Set that value to 1 if the trigger returns true. Set it to 0 again when the ability is done resolving. (The below code cuts off at a very inconvenient line, making the end of the code easy to miss. Don't miss the RTA at the bottom.)

Code: Select all

        <TRIGGER value="STATE_BASED_EFFECTS ">
            if LinkedDC():Get_Int(0) == 0 and CW_General_IsEnchantment(EffectSource()) then
                local numPlayer = MTG():GetNumberOfPlayers()
                for i = 0, (numPlayer-1) do
                    local player = MTG():GetNthPlayer(i)
                    if player:Hand_Count() == 0 then
                        LinkedDC():Set_Int(0, 1)
                        return true
                    end
                end
            end
            return false
        </TRIGGER>
        <!--Ability's other code-->
        <RESOLUTION_TIME_ACTION>
            LinkedDC():Set_Int(0, 0)
        </RESOLUTION_TIME_ACTION>

Don't forget that since you're now using a linked dc (it must be a linked dc, not an effect dc, though a few other kinds would work), linked_ability_group="1" must be set in this ability's opening tag.

----

For Yawgmoth's Agenda, why do you have the LinkedDC() int 0 code? I might just be overlooking where it's used, but if I'm not, then it just sets int 0 to 1 whenever you cast a spell from the graveyard and resets it to 0 at the beginning of each turn.

Try this utility ability. I don't know if it'll work, but it might.

Code: Select all

<UTILITY_ABILITY resource_id="1" qualifier="Alternate" origin_controller_can_use="1" active_zone="ZONE_EXILE">
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Play this card.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Jouez cette carte.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Juega esta carta.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Diese Länderkarte spielen.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Gioca questa carta.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Play this card.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Play this card.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Play this card.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Jogue este card.]]></LOCALISED_TEXT>
      <COST mana_cost="*" type="Mana" />
   </UTILITY_ABILITY>

[Xander9009]

I'm leaving town for the night and will not have any internet until I return, but I'm taking my laptop with me. This means that the CW will not update until I return, and I don't know when tomorrow that will be. The Auto-Upload folder will also not function until I get back. You can still add new files and decks to it, but they won't be automatically moved until I return.

----

Also, Daretti, Ingenious Iconoclast somehow got deleted. I got it back out of Drive's trash with no issue, but the issue is that I don't know how it happened. So, if anyone notices any other cards missing, please let me know. I checked the trash for any other cards, but I didn't notice any. I did see a bunch of art files, but I didn't have a chance to check if they were just replaced with HQ versions or what. If you notice missing art that was previously included, then, please mention that, too.

[tmxk2012917]

A bug with Rashmi. When the top card with less converted mana was revealed, I could not cast it or put it in my hand