It is currently 18 Jul 2025, 10:06
   
Text Size

Community Wad

Moderator: CCGHQ Admins

Re: Community Wad

Postby thefiremind » 26 Nov 2016, 10:28

nivmizzet1 wrote:Wandering Fumarole: it enters tapped as desired, it's mana ability works fine, and I can get it to become a creature with the ability "{0}: Switch this creature’s power and toughness until end of turn.", but it's this granted ability that doesn't seem to be working.
You forgot to put
Code: Select all
<DURATION simple_duration="UntilEOT" />
for the continuous action that switches P/T.

nivmizzet1 wrote:Quest for Pure Flame: everything seems to work OK expcept the double damage multiplier after sac'ing.
You are trying to grant an ability to a player, but that doesn't make sense. You need to make a delayed trigger that cleans up at the end of turn.
Code: Select all
      <COUNTER_REGISTRATION name="Quest" proliferate="11" />
      <COST type="RemoveCountersSelf" amount="4" counter_type="Quest" />
      <RESOLUTION_TIME_ACTION>
         MTG():CreateDelayedTrigger(3)
      </RESOLUTION_TIME_ACTION>
   </ACTIVATED_ABILITY>
   <TRIGGERED_ABILITY replacement_effect="1" resource_id="3">
      <TRIGGER value="SOURCE_DEALS_DAMAGE" simple_qualifier="objectyoucontrol" pre_trigger="1" damage_type="all" />
      <RESOLUTION_TIME_ACTION>
         Damage():Multiply(2)
      </RESOLUTION_TIME_ACTION>
      <CLEANUP simple_cleanup="EndOfTurn" />
   </TRIGGERED_ABILITY>
EffectController should be available in delayed triggers (unlike EffectSource) so I'm not bothering to make a delayDC and I let "objectyoucontrol" take care of that.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

Re: Community Wad

Postby nivmizzet1 » 26 Nov 2016, 11:03

thefiremind wrote:
nivmizzet1 wrote:Wandering Fumarole: it enters tapped as desired, it's mana ability works fine, and I can get it to become a creature with the ability "{0}: Switch this creature’s power and toughness until end of turn.", but it's this granted ability that doesn't seem to be working.
You forgot to put
Code: Select all
<DURATION simple_duration="UntilEOT" />
for the continuous action that switches P/T.
Whoops, well spotted. But am I right in thinking that wouldn't be the cause of the power and toughness not switching when it's activated? Sorry, I should've explicitly stated that that's what was wrong, instead of just saying the ability wasn't working.

EDIT: Actually, it's working now :D (although I'm not sure why :? )

thefiremind wrote:You are trying to grant an ability to a player, but that doesn't make sense. You need to make a delayed trigger that cleans up at the end of turn.
Code: Select all
      <COUNTER_REGISTRATION name="Quest" proliferate="11" />
      <COST type="RemoveCountersSelf" amount="4" counter_type="Quest" />
      <RESOLUTION_TIME_ACTION>
         MTG():CreateDelayedTrigger(3)
      </RESOLUTION_TIME_ACTION>
   </ACTIVATED_ABILITY>
   <TRIGGERED_ABILITY replacement_effect="1" resource_id="3">
      <TRIGGER value="SOURCE_DEALS_DAMAGE" simple_qualifier="objectyoucontrol" pre_trigger="1" damage_type="all" />
      <RESOLUTION_TIME_ACTION>
         Damage():Multiply(2)
      </RESOLUTION_TIME_ACTION>
      <CLEANUP simple_cleanup="EndOfTurn" />
   </TRIGGERED_ABILITY>
EffectController should be available in delayed triggers (unlike EffectSource) so I'm not bothering to make a delayDC and I let "objectyoucontrol" take care of that.
Thanks, I'll try that out.

EDIT: this is working too!! :D
nivmizzet1
 
Posts: 617
Joined: 21 Mar 2013, 10:10
Has thanked: 100 times
Been thanked: 25 times

Re: Community Wad

Postby thefiremind » 26 Nov 2016, 11:56

nivmizzet1 wrote:But am I right in thinking that wouldn't be the cause of the power and toughness not switching when it's activated?
If you don't specify a duration, then the action ends immediately, so you don't even see it.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

Re: Community Wad

Postby nivmizzet1 » 26 Nov 2016, 12:01

thefiremind wrote:
nivmizzet1 wrote:But am I right in thinking that wouldn't be the cause of the power and toughness not switching when it's activated?
If you don't specify a duration, then the action ends immediately, so you don't even see it.
oh, right. Cheers.
nivmizzet1
 
Posts: 617
Joined: 21 Mar 2013, 10:10
Has thanked: 100 times
Been thanked: 25 times

Re: Community Wad

Postby nivmizzet1 » 26 Nov 2016, 12:38

Chandra, Torch of Defiance isn't playing ball. Her first +1 ability isn't dealing damage if you choose not to cast the spell.
nivmizzet1
 
Posts: 617
Joined: 21 Mar 2013, 10:10
Has thanked: 100 times
Been thanked: 25 times

Re: Community Wad

Postby Xander9009 » 26 Nov 2016, 13:41

tmxk2012917 wrote:A bug of Fork in the Road:

I picked two land cards. One then entered my graveyard while the other was not put into my hand.
This should be fixed.

Thank you to thefiremind for being so helpful to everyone. It's nice to see you active again; it's been awhile.

For Chandra, I've got her in a test deck to look at when I can. I've never quite figured out why she doesn't seem to behave herself. Then again, it is Chandra. She's never been one for following the rules...

I'm glad Elemental Appeal was figured out. I'd checked the token itself as thoroughly as I could, and it was identical to the 3/1 red haste, trample elemental except for its power and multiverse ID. I was going to be very confused if the multiverse ID was the problem, but I noticed the solution had been found before checking it.

I'll go figure out the counters now.

I'm going to be leaving the state for a week or so tonight/tomorrow, so I'll be MIA for awhile longer still. I'll try to keep up with the boards, though. However, this is slightly important, the CW might not update as consistently as usual. Its timing might be a bit off, since I'm not certain I'll have wifi where I'm going. I do have unlimited data on my phone, which should be fast enough to handle it, but I can't guarantee anything, except to say I'll do my best to keep it updating on time.


----

EDIT: Spirit Shackle was missing its counter registration, but actually, I'd already fixed the problem. I just forgot to say I'd already fixed it. I'd had AddPower() instead of Power_Add() (and same for toughness). Even before adding the counter registration, it was working.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby Splinterverse » 26 Nov 2016, 14:08

Xander9009 wrote:EDIT: Spirit Shackle was missing its counter registration, but actually, I'd already fixed the problem. I just forgot to say I'd already fixed it. I'd had AddPower() instead of Power_Add() (and same for toughness). Even before adding the counter registration, it was working.
Did you upload the corrected Spirit Shackle to the .wad? If not, I can add it in with my stuff for today.

Have a safe trip!!!
---------------------------------------------
The DOTP2014 CW is updated nightly between 11 PM and 12 AM EST.
Known Issues/Bugs |
Impossible Cards List | Update Your Land Pools
Splinterverse
 
Posts: 918
Joined: 04 Sep 2016, 13:32
Has thanked: 150 times
Been thanked: 76 times

Re: Community Wad

Postby Xander9009 » 26 Nov 2016, 14:10

I edited the one already in the CW. Most of my edits are directly made to the files in the CW unless it's experimental (in which case it's in a separate folder for safety).
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby Splinterverse » 26 Nov 2016, 17:22

Is there a way to create a new card type (like was done with Planeswalkers)?

I have created a Vanguard card that works but I had to change it's type to artifact to see it on the board. Interestingly, it did work with "Vanguard" as the type but it was invisible. I know it worked because the card is played immediately from the library/hand at the start of the game and adds to the life total. It's other effects were apparent as well.

Also, is there a way to make a badge invisible without losing the ability associated with it?
---------------------------------------------
The DOTP2014 CW is updated nightly between 11 PM and 12 AM EST.
Known Issues/Bugs |
Impossible Cards List | Update Your Land Pools
Splinterverse
 
Posts: 918
Joined: 04 Sep 2016, 13:32
Has thanked: 150 times
Been thanked: 76 times

Re: Community Wad

Postby Splinterverse » 26 Nov 2016, 21:44

Finished coding for today; all cards referenced are from the missing cards list.

Coded, tested, and uploaded:
Abandon Hope
Aphetto Dredging
Capital Punishment
Chained Throatseeker
Custodi Lich (see Open Items)
Frankenstein's Monster
From the Ashes
Jeering Homunculus
Melira's Keepers
Messenger Jays
Orchard Elemental
Orzhov Pontiff
Predator's Howl
Reign of the Pit
Tornado
Wave of Vitriol
Wicked Akuba
Wiitigo
Winnow
Withering Gaze
Wormfang Crab

Bugs fixed:
Greater Werewolf -- updated for new counters (-0/-2)

Art uploaded (all were missing and all are HQ unless noted):
Capital Punishment
Messenger Jays
Orchard Elemental
Predator's Howl
Reign of the Pit -- HQ upgrade
Serra (see Open Items)
Spectral Grasp
The Monarch -- MQ

Open Items:

-- CW_CARD_QUERY_SPLINTERVERSE has been updated and uploaded.

-- Conjurer's Ban http://pastebin.com/ScA4yCnG this I card I previously coded, but I realized it was lasting "until end of turn" instead of "until your next turn." I've tried almost every implementation of "until your next turn" that I can find in the .wad and they don't seem to be working (or I'm doing it wrong).

-- Waterspout Elemental http://pastebin.com/UKrjfAm1 I've tried a bunch of implementations of "skip your next turn" but I can't get it to work here. Maybe I'm doing it wrong or there is a working one out there that I haven't found. Everything else works.

-- Custodi Lich uses a token for "The Monarch", which I have created and uploaded. I made it an artifact because it is more akin to a Clue than it is a Bat or something. Everything inside of it has been tested and works as expected. It even survives board wipes (like Wave of Vitriol for example). We could make it a new type potentially, but other than that, I think it works great with Custodi Lich. It was fun watching "The Monarch" switch in a free-for-all match I played.

-- I created a Vanguard card (Serra), which I have NOT uploaded. It too is an artifact, but it can't survive board wipes like The Monarch because it is not a token. One option might be to create a new type so that it doesn't get hit by spells that affect "all artifacts" or "all nonland permanents". If it were a token, it could survive the board wipes, so we could have a Vanguard "manager card" that comes into play from the library and lets you choose your Vanguard. Then it could create the token (with the board wipe protection inside of it). After that, perhaps it could remove all types from itself to make itself invisible? In any case, Serra does what it is supposed to do -- it comes into play turn 1, ups your life and hand size as well as buffing all of your creatures. Like I said in a previous post, the game will actually let you play it with "Vanguard" as it's type, but it is invisible. I think it's important for the other player to see it so that they know where the effects are coming from.

Next:

Back tomorrow to continue coding missing cards.
---------------------------------------------
The DOTP2014 CW is updated nightly between 11 PM and 12 AM EST.
Known Issues/Bugs |
Impossible Cards List | Update Your Land Pools
Splinterverse
 
Posts: 918
Joined: 04 Sep 2016, 13:32
Has thanked: 150 times
Been thanked: 76 times

Re: Community Wad

Postby Xander9009 » 26 Nov 2016, 21:54

Waterspout Elemental: this card should have an intervening if block. Unfortunately, I can't currentmy check how best to skip a turn. But I can point out that line 96 is unneeded.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby thefiremind » 26 Nov 2016, 22:06

It seems fine to me. You are using my implementation exactly as in Jeering Homunculus and I have no idea why it should work only on 1 card out of 2.

You are creating a delayed trigger 24 that is nowhere to be found: you missed at least one ability. The skip turn code should skip all the phases of the turn and give the player no hand limit for the skipped turn because the cleanup step is actually impossible to skip.
This was the first working implementation invented by sumomole and me.

The problem with the monarch and Serra is that if they are artifacts, they'll count as artifacts for all cards that care about it. If they buff Master of Etherium, for example, it's not really ideal. If you want to add exceptions on all cards that care about artifacts for the monarch and for all vanguards, good luck. :mrgreen:
New types can't be added because types are hard-coded inside the executable.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

Re: Community Wad

Postby Splinterverse2 » 26 Nov 2016, 22:17

thefiremind wrote:
It seems fine to me. You are using my implementation exactly as in Jeering Homunculus and I have no idea why it should work only on 1 card out of 2.

You are creating a delayed trigger 24 that is nowhere to be found: you missed at least one ability. The skip turn code should skip all the phases of the turn and give the player no hand limit for the skipped turn because the cleanup step is actually impossible to skip.
This was the first working implementation invented by sumomole and me.

The problem with the monarch and Serra is that if they are artifacts, they'll count as artifacts for all cards that care about it. If they buff Master of Etherium, for example, it's not really ideal. If you want to add exceptions on all cards that care about artifacts for the monarch and for all vanguards, good luck. :mrgreen:
New types can't be added because types are hard-coded inside the executable.
I thought the planeswalker type was added using enchantments as a base?

In any case, I could try enchantment instead of artifact. I might also experiment with the vanguard type because it did work, but it was invisible. I wouldn't mind updating all the artifact seeking cards for The Monarch (or enchantments if there are fewer in that vein). Updating them all for Vanguard cards would be hard because there are many more of those but who knows? We have some creative folks on here. Maybe we will find a way.
Splinterverse2
 
Posts: 52
Joined: 20 Sep 2016, 13:52
Has thanked: 13 times
Been thanked: 0 time

Re: Community Wad

Postby Xander9009 » 26 Nov 2016, 22:42

I didn't think about it earlier, but it would be best to mark the vanguard as enchantments, not artifacts. All cards that care about enchantment to already use one of two functions to determine if a given card is an enchantment or to add enchantments to filters thank to planeswalkers. Those can be easily modified to include other exceptions.

Edit: to include all vanguards would be relatively simple. Just use a names page similar to those found in the D14_plw.lol file. But that can be handled by me later if needed, but for now just include all vanguard cards you make in a list that can be referenced later.

See if it can display a card with both enchantment and vanguard.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby Splinterverse » 27 Nov 2016, 09:40

Xander9009 wrote:I didn't think about it earlier, but it would be best to mark the vanguard as enchantments, not artifacts. All cards that care about enchantment to already use one of two functions to determine if a given card is an enchantment or to add enchantments to filters thank to planeswalkers. Those can be easily modified to include other exceptions.

Edit: to include all vanguards would be relatively simple. Just use a names page similar to those found in the D14_plw.lol file. But that can be handled by me later if needed, but for now just include all vanguard cards you make in a list that can be referenced later.

See if it can display a card with both enchantment and vanguard.
Tested. Both "The Monarch" and Serra function identically as enchantments as they did as artifacts. With Serra, I was able to have both Vanguard and Enchantment as the type. Vanguard didn't display in game, but it was there in the code. Perhaps we could make a subtype for it or something.

One thing though . . . the art on both showed up as full card art instead of in the normal window. That might actually be kind of cool for Vanguard to distinguish them, but it looks odd on "The Monarch."

What dimensions would we use if we wanted the art to be full card art? I have the original for Serra and I can recrop it to specifically be displayed as full card art. If that's not possible, do you know how to "turn off" the full card art look? (They didn't have that when they were Artifacts, so I'm wondering if it's an Enchantment specific thing due to Planeswalkers having that sometimes?) Although, I've seen some creatures with full card art as well, like Crimson Kobolds currently does. (It looks fine in Deck Builder, but Crimson Kobolds' art appears stretched in game.)
---------------------------------------------
The DOTP2014 CW is updated nightly between 11 PM and 12 AM EST.
Known Issues/Bugs |
Impossible Cards List | Update Your Land Pools
Splinterverse
 
Posts: 918
Joined: 04 Sep 2016, 13:32
Has thanked: 150 times
Been thanked: 76 times

PreviousNext

Return to 2014

Who is online

Users browsing this forum: No registered users and 7 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 7 users online :: 0 registered, 0 hidden and 7 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 7 guests

Login Form