More Cards with the new keywords

[Sloth]

Here are some cards with the new keywords that can be added to cards.txt:

Code: Select all

Flame Jet
1 R
Sorcery
no text
spDamageP:3
Cycling:2

Iron Will
W
Instant
no text
spPumpTgt:+0/+4
Cycling:2

Slippery Bogle
UG
Creature Beast
no text
1/1
This card can't be the target of spells or abilities your opponents control.

Endless Cockroaches
1 B B
Creature Insect
no text
1/1
When this card is put into a graveyard from the battlefield, return this card to its owner's hand

Shivan Phoenix
4 R R
Creature Phoenix
no text
3/4
Flying
When this card is put into a graveyard from the battlefield, return this card to its owner's hand

Barbarian General
4 R
Creature Human Barbarian Soldier
no text
3/2
Horsemanship

Riding Red Hare
2 W
Sorcery
Target creature gets +3/+3 and gains horsemanship until end of turn.
spPumpTgt:+3/+3/Horsemanship

Shu Elite Companions
4 W
Creature Human Soldier
no text
3/3
Horsemanship

Shu General
3 W
Creature Human Soldier
no text
2/2
Vigilance
Horsemanship

Wei Elite Companions
4 B
Creature Human Soldier
no text
3/3
Horsemanship

Wei Scout
1 B
Creature Human Soldier Scout
no text
1/1
Horsemanship

Wei Strike Force
2 B
Creature Human Soldier
no text
2/1
Horsemanship

Wu Elite Cavalry
3 U
Creature Human Soldier
no text
2/3
Horsemanship

Wu Light Cavalry
1 U
Creature Human Soldier
no text
1/2
Horsemanship

Yellow Scarves Cavalry
1 R
Creature Human Soldier
no text
1/1
Horsemanship
This creature cannot block

Yellow Scarves General
3 R
Creature Human Soldier
no text
2/2
Horsemanship
This creature cannot block

Vampiric Touch
2 B
Sorcery
Vampiric Touch deals 2 damage to target opponent and you gain 2 life.
spLoseLifeGainLife:2


Here is the entry for card-pictures.txt:

Code: Select all

Flame_Jet                   http://www.wizards.com/global/images/magic/general/Flame_Jet.jpg
Iron_Will                   http://www.wizards.com/global/images/magic/general/Iron_Will.jpg
Slippery_Bogle              http://www.wizards.com/global/images/magic/general/Slippery_Bogle.jpg
Endless_Cockroaches      http://resources.wizards.com/Magic/Cards/PO/en-us/Card4220.jpg
Shivan_Phoenix              http://www.wizards.com/global/images/magic/general/Shivan_Phoenix.jpg
Barbarian_General      http://www.wizards.com/global/images/magic/general/Barbarian_General.jpg
Riding_Red_Hare              http://www.wizards.com/global/images/magic/general/Riding_Red_Hare.jpg
Shu_Elite_Companions      http://www.wizards.com/global/images/magic/general/Shu_Elite_Companions.jpg
Shu_General              http://www.wizards.com/global/images/magic/general/Shu_General.jpg
Wei_Elite_Companions      http://www.wizards.com/global/images/magic/general/Wei_Elite_Companions.jpg
Wei_Scout              http://www.wizards.com/global/images/magic/general/Wei_Scout.jpg
Wei_Strike_Force      http://www.wizards.com/global/images/magic/general/Wei_Strike_Force.jpg
Wu_Elite_Cavalry      http://www.wizards.com/global/images/magic/general/Wu_Elite_Cavalry.jpg
Wu_Light_Cavalry      http://www.wizards.com/global/images/magic/general/Wu_Light_Cavalry.jpg
Yellow_Scarves_Cavalry      http://www.wizards.com/global/images/magic/general/Yellow_Scarves_Cavalry.jpg
Yellow_Scarves_General      http://www.wizards.com/global/images/magic/general/Yellow_Scarves_General.jpg
Vampiric_Touch              http://resources.wizards.com/Magic/Cards/PO/en-us/Card4244.jpg


[mtgrares]

As always, great work. Thanks for including the card pictures too.

[DennisBergkamp]

Yes, thanks for finding these

[Chris H.]

Yes, thank you very much for these new cards. It is always nice to have additional cards to add to the next version.

[Chris H.]

We can also add this card:

Code: Select all

Mage's Guile
1 U
Instant
Target creature gains shroud until end of turn.
spPumpTgt:Shroud
Cycling:U

[Sloth]

We can also add this card:

Code: Select all

Mage's Guile
1 U
Instant
Target creature gains shroud until end of turn.
spPumpTgt:Shroud
Cycling:U

Another easy card to add. Just one remark:
The AI will not be able to use Mage's Guile effectively, since it won't use it to counter targeted spells. So I think it should be added to the list of cards to remove in GenerateConstructedDeck.java. Otherwise it's fine, I just tested it.

[DennisBergkamp]

Ok, sounds good.
There are many more of these we should add to that list, by the way.

[Chris H.]

I just ran a test with:

Mage's Guile
1 U
Instant
Target creature gains shroud until end of turn.
spPumpTgt:Shroud
Cycling:U

I suspected that this spell might have the same problem as Iron Will. Have you had a chance to modify the spPumpTgt code, Dennis. I might take a look at this later tonight or tomorrow.

[DennisBergkamp]

Hmm, I did look at it. I think Rob commented out the description setter, but I'm not sure what the reason was for this. I'll PM him.

[Sloth]

I'm not sure if you noticed it, but Iron Will and Mage's Guile actually give you both options (playing the spell and cycling the card), but the first option has no text (or the text is above the displayed text box). You can click above the cycling option and the spells work normally.

[Rob Cashwalker]

Hmm, I did look at it. I think Rob commented out the description setter, but I'm not sure what the reason was for this. I'll PM him.

No need to PM me.. I'm here reading along....

This is because I had assumed spells would have only the one effect, and building the description strings was buggy at first for some weird reason.

I've decided that future keyword parsing should include the descriptions as parameters. More on this when I finalize my post for new spDamageTgt code.

[DennisBergkamp]

Too late

Well, I guess when defining Mage's Guile and Iron Will like this:

Code: Select all

Mage's Guile
1 U
Instant
Target creature gains shroud until end of turn.
spPumpTgt:Shroud
Cycling:U

Iron Will
W
Instant
Target creature gets +0/+4 until end of turn.
spPumpTgt:+0/+4
Cycling:2


The code works, but the description of both spellAbilities get set to blank text. No clue why, even though it probably has something to do with the cycling code.

[DennisBergkamp]

This is because I had assumed spells would have only the one effect, and building the description strings was buggy at first for some weird reason.

I've decided that future keyword parsing should include the descriptions as parameters. More on this when I finalize my post for new spDamageTgt code.

Ok. I guess for now, we'll leave Mage's Guile and Iron Will out of this version, no biggie.

[Chris H.]

We are looking forward to Rob's forthcoming statement on this matter. I spent a little time thinking about the problem. I noticed that the Flame Jet spell which also has cycling gives the text for both choices when we cast the spell.

And, like Sloth, I too noticed the slight band of color where the missing choice should go. Although I did not think to actually click on the band to see if it would activate.

[Rob Cashwalker]

The existing damage code builds a description and assigns it. But for whatever reason I didn't do that with the spPump code, so the description shows up as blank, luckily your display properties highlight it as a slightly off color, mine shows up as plain white.