Ability_Cost discussion

[friarsol]

I must have just skipped the file when I was committing. Make sure it's fine with 2375.

[DennisBergkamp]

Yup, works great now! Thanks

[DennisBergkamp]

I'm just trying to commit Wurmcoil Engine, but the SVN seems to have some trouble... anyone else have the same problem?

Code: Select all

General filesystem error
svn: Commit failed (details follow):
svn: MERGE request failed on '/svn/src'
svn: Commit failed unexpectedly --- please try again later (9)

[friarsol]

I'm just trying to commit Wurmcoil Engine, but the SVN seems to have some trouble... anyone else have the same problem?

Code: Select all

General filesystem error
svn: Commit failed (details follow):
svn: MERGE request failed on '/svn/src'
svn: Commit failed unexpectedly --- please try again later (9)

Yea I'm getting the same thing. Must be down right now.

[Sloth]

I tested some cards that have a cost of tapping creatures today and found this bug:

When I cancel the ability the game doesn't work as normal: When The computer wants to play a spell, taps its mana sources, a message appears in the top left saying that an error may have occured. Starting a game after that causes my Moxen not to appear on the battlefield when cast (they just vanish).

[friarsol]

I tested some cards that have a cost of tapping creatures today and found this bug:

When I cancel the ability the game doesn't work as normal: When The computer wants to play a spell, taps its mana sources, a message appears in the top left saying that an error may have occured. Starting a game after that causes my Moxen not to appear on the battlefield when cast (they just vanish).

All of them did it? Just give me one of the names so I can test it out tomorrow.

[Sloth]

I tested some cards that have a cost of tapping creatures today and found this bug:

When I cancel the ability the game doesn't work as normal: When The computer wants to play a spell, taps its mana sources, a message appears in the top left saying that an error may have occured. Starting a game after that causes my Moxen not to appear on the battlefield when cast (they just vanish).

All of them did it? Just give me one of the names so I can test it out tomorrow.

I tested Hand of Justice and a new card Spurred Wolverine. But now I remember having this bug multiple times the last days (I think without tapping creatures, just canceling an ability).

Code: Select all

Name:Spurred Wolverine
ManaCost:4 R
Types:Creature Wolverine Beast
Text:no text
PT:3/2
K:abPumpTgtC tapXType<2/Beast>:First Strike
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/spurred_wolverine.jpg
End


[DennisBergkamp]

Whoa, I think I added the "tapping creatures" code, it was probably me who introduced this bug

[Sloth]

Whoa, I think I added the "tapping creatures" code, it was probably me who introduced this bug

OK, I tested again and it's not a problem of the tap cost. I get the bug also when canceling any abilities. For example Greed or Grapeshot Catapult.

EDIT: Revision 2530 has fixed this. Thanks Sol!

[friarsol]

Alright I was able to recreate the bug and fixed both the issues (current game dying and next game being borked). This was in some code I wrote that was "freezing" triggered abilities. The goal was to fix a bug where triggered abilities were hitting the stack before the spell that was in the process of being cast.

Code: Select all

If you tap Forbidden Orchard during "Pay mana cost" prompt for Wrath of God, the spell is put on top in the stack so the token survives. No matter how Wrath is cast, it should not.


Now if you cancel out of an Ability, the Frozen triggers will be cleared and the next Spell/Ability to be played will use the Stack as normal.

The Forbidden Orchard example isn't quite fixed yet, since the "Frozen" code is only being called by the Requirements class, which handles Target and Ability_Cost. Once we get everything using Ability_Cost it should be magically fixed.