SVN Bug Reports

[Snacko]

You can use SavePreferencesListener, which hooks you with ForgePreferences to save some data in forge.preferences. However if you need object serialization then either simple XMLEncoder which is java build-in or something more sophisticated like google protobuf

[lazylockie]

Also,

Code: Select all

ComputerUtil : payManaCost() cost was not paid for Emerald Medallion


Do you know what the AI had in play when this happened? He might have tried paying with something but didn't properly activate that ability, and not end up with enough mana. That'll help tracking it down.

If I remember correctly, AI had all Forests tapped, but had 2 Eldrazi Spawn tokens, so I presume AI attempted to use the Spawn tokens to cast the medallion?

edit:

r5331
Ajani's Mantra is triggering on both upkeeps

[lazylockie]

Fixed the Essence Wardens. It's not so much that they're invisible, it's that they trigger while still in the library.

Angel's Feather, Dragon's Claw and the other ones are still triggering from library.

[Jaedayr]

r5337

Code: Select all

Error - the LQ picture for boiling_blood.jpg could not be found on the server.
Error - the LQ picture for benalish_missionary.jpg could not be found on the server.

[Jaedayr]

r5337

These are observations based on my current quest cards.

Sorting by rarity in the Quest Mode Deck Editor looks strange. It looks like it is sorting by the SVar:Rarity but then displaying the SetInfo:rarity. There are several cards at the end of the list such as Moon Sprite and Auriok Sunchaser that seem out of place.

Dromad Purebred has *error* displayed in the Set column of the editor

Cards won in the immediately preceding match are no longer denoted by an asterisk, so there is no easy way to see what you won.

While sorting by Stats, Death's Shadow appears after the 1/5 creature and before the 2/1 creature. Should it sort after my 9/9 creature?

[Jaedayr]

r5337

I am still experiencing severe lag and slowdown whenever I begin my second match. During the first match and a subsequent visit to deck editor and card shop everything is fine. When I start the second match everything slows down. I am using LQ pics and every time I even move my mouse over a card my CPU goes to 100pct and stays there a couple seconds. I have changed nothing except to update to the current SVN. Anybody have any ideas or suggestions? The game becomes almost unplayable and I have never had this problem before, even when I was using HQ pics.

*edit*

My second crash in two days.

Code: Select all

An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


Java heap space


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.OutOfMemoryError: Java heap space
   at java.lang.AbstractStringBuilder.<init>(Unknown Source)
   at java.lang.StringBuilder.<init>(Unknown Source)
   at forge.Card.getBaseAttackString(Card.java:1757)
   at forge.CardFactory.copyStats(CardFactory.java:8420)
   at forge.CardFactory.getCard2(CardFactory.java:263)
   at forge.CardFactory.getCard(CardFactory.java:238)
   at forge.QuestData_BoosterPack.getColor(QuestData_BoosterPack.java:223)
   at forge.QuestData_BoosterPack.getRare(QuestData_BoosterPack.java:210)
   at forge.QuestUtil.setupQuest(QuestUtil.java:738)
   at forge.ReadQuest_Assignment.run(ReadQuest_Assignment.java:174)
   at forge.quest.main.QuestQuest.readQuests(QuestQuest.java:51)
   at forge.quest.main.QuestQuest.getQuests(QuestQuest.java:40)
   at forge.quest.main.QuestMainPanel.createQuestPanel(QuestMainPanel.java:339)
   at forge.quest.main.QuestMainPanel.createNextMatchPanel(QuestMainPanel.java:92)
   at forge.quest.main.QuestMainPanel.initUI(QuestMainPanel.java:83)
   at forge.quest.main.QuestMainPanel.<init>(QuestMainPanel.java:64)
   at forge.quest.QuestFrame.<init>(QuestFrame.java:39)
   at forge.quest.main.QuestMainPanel$11.execute(QuestMainPanel.java:467)
   at forge.Gui_Quest_DeckEditor$2.execute(Gui_Quest_DeckEditor.java:330)
   at forge.Gui_Quest_DeckEditor_Menu.close(Gui_Quest_DeckEditor_Menu.java:1018)
   at forge.Gui_Quest_DeckEditor$3.windowClosing(Gui_Quest_DeckEditor.java:338)
   at java.awt.AWTEventMulticaster.windowClosing(Unknown Source)
   at java.awt.Window.processWindowEvent(Unknown Source)
   at javax.swing.JFrame.processWindowEvent(Unknown Source)
   at java.awt.Window.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)


[friarsol]

I haven't noticed any slowdown at all. Are you sure there isn't anything weird about your setup? Are you using the default quest.preferences file? How many cards are in your quest file?

[friarsol]

Sorting by rarity in the Quest Mode Deck Editor looks strange. It looks like it is sorting by the SVar:Rarity but then displaying the SetInfo:rarity. There are several cards at the end of the list such as Moon Sprite and Auriok Sunchaser that seem out of place.

I think you just answered your question. Those "cardsthat look weird" ARE the new cards. They display their correct set, but are listed last because they are new.

[lazylockie]

I haven't noticed any slowdown at all. Are you sure there isn't anything weird about your setup? Are you using the default quest.preferences file? How many cards are in your quest file?

I've noticed a slowdown as well, even with a fresh quest data, but after like 4 consecutive games without closing Forge. Then I restart it and it works fine again.

[Jaedayr]

The only lines different in quest preferences are these:

Code: Select all

winsForRankIncrease=30,4,5,6
winsForMediumAI=100,9,8,7
winsForHardAI=200,18,16,14

I have 1071 cards currently.

I just tried again with the old quest UI and had no problems so I am wondering if something is going on there.

Minor note, at 1024x768 the checkbox option to use new Quest UI is mostly cut off at the bottom of the window, only the upper part of the text and box are visible.

[Chris H.]

r5337

I am still experiencing severe lag and slowdown whenever I begin my second match. During the first match and a subsequent visit to deck editor and card shop everything is fine. When I start the second match everything slows down. I am using LQ pics and every time I even move my mouse over a card my CPU goes to 100pct and stays there a couple seconds. I have changed nothing except to update to the current SVN. Anybody have any ideas or suggestions? The game becomes almost unplayable and I have never had this problem before, even when I was using HQ pics.

*edit*

My second crash in two days.

Code: Select all

An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


Java heap space


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.OutOfMemoryError: Java heap space
   at java.lang.AbstractStringBuilder.<init>(Unknown Source)
   at java.lang.StringBuilder.<init>(Unknown Source)
   at forge.Card.getBaseAttackString(Card.java:1757)
   at forge.CardFactory.copyStats(CardFactory.java:8420)
   at forge.CardFactory.getCard2(CardFactory.java:263)
   at forge.CardFactory.getCard(CardFactory.java:238)
   at forge.QuestData_BoosterPack.getColor(QuestData_BoosterPack.java:223)
   at forge.QuestData_BoosterPack.getRare(QuestData_BoosterPack.java:210)
   at forge.QuestUtil.setupQuest(QuestUtil.java:738)
   at forge.ReadQuest_Assignment.run(ReadQuest_Assignment.java:174)
   at forge.quest.main.QuestQuest.readQuests(QuestQuest.java:51)
   at forge.quest.main.QuestQuest.getQuests(QuestQuest.java:40)
   at forge.quest.main.QuestMainPanel.createQuestPanel(QuestMainPanel.java:339)
   at forge.quest.main.QuestMainPanel.createNextMatchPanel(QuestMainPanel.java:92)
   at forge.quest.main.QuestMainPanel.initUI(QuestMainPanel.java:83)
   at forge.quest.main.QuestMainPanel.<init>(QuestMainPanel.java:64)
   at forge.quest.QuestFrame.<init>(QuestFrame.java:39)
   at forge.quest.main.QuestMainPanel$11.execute(QuestMainPanel.java:467)
   at forge.Gui_Quest_DeckEditor$2.execute(Gui_Quest_DeckEditor.java:330)
   at forge.Gui_Quest_DeckEditor_Menu.close(Gui_Quest_DeckEditor_Menu.java:1018)
   at forge.Gui_Quest_DeckEditor$3.windowClosing(Gui_Quest_DeckEditor.java:338)
   at java.awt.AWTEventMulticaster.windowClosing(Unknown Source)
   at java.awt.Window.processWindowEvent(Unknown Source)
   at javax.swing.JFrame.processWindowEvent(Unknown Source)
   at java.awt.Window.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)


`
When forge was modified to handle the HQ pics, people started to report java heap errors. Dennis, Silly Freak and Snakco did what they could to get this situation resolved.

I seem to remember Snakco and/or Silly Freak stating that there were several ways to handle the memory. This makes me wonder if recent improvements to forge may have added to the amount of memory used. We now have the background pic, battlefield and filter icons and changes to the quest mode GUI.

Are we adding images to the memory (java heap space?) and not releasing it as soon as we should? I have no experience with the memory management unfortunately and I admit that I could be wrong about what people are noticing.

[friarsol]

It sounds like it has to do with the new Quest Mode GUI not releasing Memory when its no longer in use (or not reusing memory that it already had set aside)

[slapshot5]

r5337

Code: Select all

Error - the LQ picture for boiling_blood.jpg could not be found on the server.
Error - the LQ picture for benalish_missionary.jpg could not be found on the server.

fixed.

[Fnoed]

Let me break out the memory profiler...

[jhhh]

untap 2 lands change to 3 --->YouUntapUpTo/3/Land

Name:Frantic Search
ManaCost:2 U
Types:Instant
Text:no text
A:SP$Draw | Cost$ 2 U | NumCards$ 2 | SpellDescription$ Draw two cards, then discard two cards. Untap up to three lands. | SubAbility$ SVar=DBDiscard
SVar:DBDiscard:DB$Discard | NumCards$ 2 | Mode$ TgtChoose | SubAbility$ YouUntapUpTo/3/Land
# Use old subability for untapping until AF$Untap can handle Urza block style "Free" spells
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/frantic_search.jpg
SetInfo:ULG|Common|http://magiccards.info/scans/en/ul/32.jpg
End