It is currently 15 Aug 2025, 00:54
   
Text Size

SVN Bug Reports

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: SVN Bug Reports

Postby Corwin72 » 01 Feb 2011, 14:42

Build 6000!!!
Attacking with Phyrexian Crusader equipped with Sword of Feast and Famine. At damage step I receive a Null error. My lands are not untapped. I can continue. Poison counters are applied.

I think that this issue is due to the Sword not knowing how to interact with infect.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby Hellfish » 01 Feb 2011, 16:06

Corwin72 wrote:Build 6000!!!
Attacking with Phyrexian Crusader equipped with Sword of Feast and Famine. At damage step I receive a Null error. My lands are not untapped. I can continue. Poison counters are applied.

I think that this issue is due to the Sword not knowing how to interact with infect.
Fixed, it's discard ability was actually missing a parameter :)
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby friarsol » 01 Feb 2011, 16:56

I notice this a lot with Jace 2.0 but I've seen it with some of the Triggers and some other places as well. When a Yes/No Dialog pops up asking me a question about a specific card, the card detail panel doesn't change to show you what the card is. So I can either guess at what the card is, or look it up in my browser.

I'm not familiar with how the Dialogs work, but maybe we can set the CardDetailPanel before the popup happens, or somehow have a link in the Dialog that would set the CardDetailPanel to the host card?
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Hellfish » 01 Feb 2011, 17:57

friarsol wrote:I notice this a lot with Jace 2.0 but I've seen it with some of the Triggers and some other places as well. When a Yes/No Dialog pops up asking me a question about a specific card, the card detail panel doesn't change to show you what the card is. So I can either guess at what the card is, or look it up in my browser.

I'm not familiar with how the Dialogs work, but maybe we can set the CardDetailPanel before the popup happens, or somehow have a link in the Dialog that would set the CardDetailPanel to the host card?
Triggers always tells you what card the ability belongs to. However, I fixed this anyway, for hardcoded cards that use the yes/no dialog. :)
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby friarsol » 01 Feb 2011, 18:06

Hellfish wrote:Triggers always tells you what card the ability belongs to. However, I fixed this anyway, for hardcoded cards that use the yes/no dialog. :)
Oh I mean something a little different. I want to see the full card in the Detail Panel on the side.

If you don't know what Powder Keg does, and you are asked to put a counter on it, you don't know what those counters are doing. So you don't know why you would say yes or no. Or in a similar case, I know what Powder Keg does. I just don't know how many counters are on this particular Powder Keg. So I don't know if I should be adding a counter or not.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Hellfish » 01 Feb 2011, 18:14

Yeah, I did as you suggested is what I was trying to say. The card detail panel on the right shows the source card now ;)
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby friarsol » 01 Feb 2011, 21:43

I was just in the Proliferate code block adding in some hooks for Trigger and it looks like the AI might be doing Proliferate incorrectly. Of course I had to rig up a very convoluted situation to prove that was the case.

Anyway, it looks like the AI is adding one of EVERY counter to the cards it chooses with Proliferate. It should be choosing one counter for each card/player and adding that.

I rigged this up by taking a Coral Reef and a Blue creature for my deck. Giving the AI some Hada Freeblade's and something that can Proliferate that I knew the AI would cast/activate. Then I activated my Reef on one of the Allies. Once the AI Proliferated it now had an additional +1/+1 and a +1/+0 on that Ally.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby lazylockie » 02 Feb 2011, 04:02

Oopsie, forgot the revision: 6020

AI had Mortician Beetle in play (I was testing a deck) and cast a kicked Gatekeeper of Malakir. It gave the following error:

Code: Select all
An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


null


Version:
Forge -- official beta: $Date: 2011-01-06 14:34:48 -0200 (qui, 06 jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.Trigger_Sacrificed.performTest(Unknown Source)
   at forge.TriggerHandler.runSingleTrigger(Unknown Source)
   at forge.TriggerHandler.runTrigger(Unknown Source)
   at forge.GameAction.sacrifice(Unknown Source)
   at forge.CardFactoryUtil$17.selectCard(Unknown Source)
   at forge.GuiInput.selectCard(Unknown Source)
   at forge.GuiDisplay4$10.mousePressed(Unknown Source)
   at java.awt.AWTEventMulticaster.mousePressed(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)

lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: SVN Bug Reports

Postby Chris H. » 02 Feb 2011, 13:05

friarsol wrote:
Hellfish wrote:Bug in r5600:
Evoke seems to be out of commission, and looks like it has been for a while. First, I don't get the option to evoke, say, AEthersnipe. Second, either the usage of Evoke in the cards currently in Forge is wrong or our docs are wrong. (Evoke is used as SVars, whereas in the keyword/AF topic it's a keyword) Neither way gives me the option to evoke.
Looks like all the Evoke cards are hard-coded too :(. We could do this with an Evoke keyword which gives a secondary cost (similar to the Kicker one i did last night). I have an idea how to make it smoother which I can write into Kicker as well if it works as expected.

Each of the Evoke cards will have their normal ETB ability. And a secondary ETB ability which will basically be When this ETB, if it was evoked (Card.self+evoked), sacrifice it.
`
I stumbled across this last night. AEthersnipe was using the new Evoke keyword and the Evoke ability worked. The other Evoke cards were using the SVar form and the Evoke ability was non-functional. I used AEthersnipe as a template and was able to repair the four cards that were originally using the non-functional SVar form.

I just took a quick glance and there appears to be several hard-coded cards that can be converted and there is also some Evoke cards to be added. Some of the potential new Evoke cards are using a "leaves the battlefield" ability rather than a "enters the battlefield" ability. I think that the triggers may be far enough along to handle this at this time.

With the repairs above I noticed that when the cards are Evoked two abilities are appearing on the stack and I hope that this is correct and not some weird artifact of the code at this time. :mrgreen:
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Hellfish » 02 Feb 2011, 13:23

No, two abilities being stacked is 100% by the rules. Evoke is basically one half static ability, one half triggered ability. :)
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby Chris H. » 02 Feb 2011, 15:36

Hellfish wrote:No, two abilities being stacked is 100% by the rules. Evoke is basically one half static ability, one half triggered ability. :)
`
Ah, nothing to worry about, great. 8)
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Sloth » 02 Feb 2011, 17:48

lazylockie wrote:AI had Mortician Beetle in play (I was testing a deck) and cast a kicked Gatekeeper of Malakir. It gave the following error:
Fixed. The whole sacrifice trigger wasn't working somehow.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby Jaedayr » 02 Feb 2011, 19:21

r6052
Code: Select all
Error - possibly missing URL for: citanul_hierophants.jpg
Error - possibly missing URL for: sachi_daughter_of_seshiro.jpg
Error - possibly missing URL for: basal_sliver.jpg
I looked at the txt file for the first card and everything looks fine to me.
Jaedayr
Tester
 
Posts: 523
Joined: 08 Jul 2010, 00:06
Has thanked: 16 times
Been thanked: 13 times

Re: SVN Bug Reports

Postby friarsol » 03 Feb 2011, 16:12

r6073
I'm sure this has been around for a while, since I know all of the copy type cards aren't very consistent. But Rite of Replication on a Level Up creature seems to sort of half copy the Level Up ability. I can pay the Level Up cost, but a counter is never placed on the creature. I'm not convinced that if I managed to get a counter onto it that it would get boosted appropriately either.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby jeffwadsworth » 03 Feb 2011, 17:20

Cheers.
Last edited by jeffwadsworth on 03 Feb 2011, 18:02, edited 1 time in total.
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 34 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 34 users online :: 0 registered, 0 hidden and 34 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 34 guests

Login Form