SVN Bug Reports

[Fnoed]

I've committed the hack to clean the image cache. It is triggered in quest mode when a new game is started. With this hack I see that the heap usage is stable at 150M whereas without it the usage would increase ~20M after a game. If other people can confirm that this eliminates the slowdown in quest mode, I'll put in a better fix that will also apply to the normal game mode.

I don't notice a slowdown due to the increased image loading, even using the hires images; this could change if forge is ran on a slower system, though.

[lazylockie]

I've committed the hack to clean the image cache. It is triggered in quest mode when a new game is started. With this hack I see that the heap usage is stable at 150M whereas without it the usage would increase ~20M after a game. If other people can confirm that this eliminates the slowdown in quest mode, I'll put in a better fix that will also apply to the normal game mode.

I don't notice a slowdown due to the increased image loading, even using the hires images; this could change if forge is ran on a slower system, though.

You did this fix for the new or old gui?

[Fnoed]

The new one. You can apply it to the old one by adding the line

Code: Select all

ImageCache.clear();


into the method forge.Gui_Quest#playGameButton_actionPerformed

[lazylockie]

The new one. You can apply it to the old one by adding the line

Code: Select all

ImageCache.clear();


into the method forge.Gui_Quest#playGameButton_actionPerformed

Thanks, I'm gonna test them both and tell the results.

[Fnoed]

Let me quickly remind you of the VisualVM tool that is bundled with all recent JDKs. This can be used to attach to a running process and see the heap usage.

[lazylockie]

Let me quickly remind you of the VisualVM tool that is bundled with all recent JDKs. This can be used to attach to a running process and see the heap usage.

I was at revision 6145 yesterday and this fix seemed to work fine (my heap usage didn't go higher than 200mb). Although by nature the game becomes a bit unresponsive after some matches in a row. Still, after this fix it's much better (yay for playing more than 2 matches in a row!)

However, on revision 6155 (I've made a SVN checkout/update from scratch) I got this error when clicking Quest Mode:

Code: Select all

An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


forge/quest/data/QuestData


Version:
Forge -- official beta: $Date: 2011-01-06 14:34:48 -0200 (qui, 06 jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NoClassDefFoundError: forge/quest/data/QuestData
   at java.lang.Class.getDeclaredMethods0(Native Method)
   at java.lang.Class.privateGetDeclaredMethods(Unknown Source)
   at java.lang.Class.getDeclaredMethod(Unknown Source)
   at java.awt.Component.isCoalesceEventsOverriden(Unknown Source)
   at java.awt.Component.access$500(Unknown Source)
   at java.awt.Component$3.run(Unknown Source)
   at java.awt.Component$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.awt.Component.checkCoalescing(Unknown Source)
   at java.awt.Component.<init>(Unknown Source)
   at java.awt.Container.<init>(Unknown Source)
   at java.awt.Window.<init>(Unknown Source)
   at java.awt.Frame.<init>(Unknown Source)
   at java.awt.Frame.<init>(Unknown Source)
   at javax.swing.JFrame.<init>(Unknown Source)
   at forge.Gui_QuestOptions.<init>(Unknown Source)
   at forge.Gui_NewGame$5.actionPerformed(Unknown Source)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at org.jvnet.substance.utils.RolloverButtonListener.mouseReleased(RolloverButtonListener.java:111)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: forge.quest.data.QuestData
   at java.net.URLClassLoader$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   ... 43 more


[friarsol]

However, on revision 6155 (I've made a SVN checkout/update from scratch) I got this error when clicking Quest Mode:

I just got the same thing. It looks like the converted Quest file is messed up.

I stopped the running process through Eclipse when I was in the middle of the match. Not sure if the new Quest data file has an issue closing this way or the original conversion is incorrect?

[friarsol]

Lazy, see if my last check in solved your issue? It looks like it's solved it for me.

[Fnoed]

Ah, the new library is causing issues. I thought that Eclipse would include the entire libs folder automatically. In any case you can force a reconversion by deleting the questData.dat file from the res/quest folder. That should force a reconversion.

[lazylockie]

Lazy, see if my last check in solved your issue? It looks like it's solved it for me.

revision 6164:

I thought it was related to some of my quest files (because I keep some of them intact), but even on a fresh install I'm getting:

Code: Select all

An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


forge/quest/data/QuestData


Version:
Forge -- official beta: $Date: 2011-01-06 14:34:48 -0200 (qui, 06 jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NoClassDefFoundError: forge/quest/data/QuestData
   at java.lang.Class.getDeclaredMethods0(Native Method)
   at java.lang.Class.privateGetDeclaredMethods(Unknown Source)
   at java.lang.Class.getDeclaredMethod(Unknown Source)
   at java.awt.Component.isCoalesceEventsOverriden(Unknown Source)
   at java.awt.Component.access$500(Unknown Source)
   at java.awt.Component$3.run(Unknown Source)
   at java.awt.Component$3.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.awt.Component.checkCoalescing(Unknown Source)
   at java.awt.Component.<init>(Unknown Source)
   at java.awt.Container.<init>(Unknown Source)
   at java.awt.Window.<init>(Unknown Source)
   at java.awt.Frame.<init>(Unknown Source)
   at java.awt.Frame.<init>(Unknown Source)
   at javax.swing.JFrame.<init>(Unknown Source)
   at forge.Gui_QuestOptions.<init>(Unknown Source)
   at forge.Gui_NewGame$5.actionPerformed(Unknown Source)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: forge.quest.data.QuestData
   at java.net.URLClassLoader$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
   at java.lang.ClassLoader.loadClass(Unknown Source)
   ... 42 more


[Fnoed]

Hmm. It looks like the new deserializer cannot find the QuestData class. Can you confirm that the class forge.quest.data.QuestData exists in your sources?

[lazylockie]

Hmm. It looks like the new deserializer cannot find the QuestData class. Can you confirm that the class forge.quest.data.QuestData exists in your sources?

I do have QuestData.java, though I don't have QuestData.class

[Fnoed]

Your eclipse project is not compiling all the sources then. I can't help you here I'm afraid; try looking in the your project's settings for a way to add the package forge.quest to the list of compiled sources.

Alternately, if you are willing to try a different IDE, I have created a set of instructions on how to get things set-up using IntelliJ here. That project should work out of the box.

[friarsol]

Your eclipse project is not compiling all the sources then. I can't help you here I'm afraid; try looking in the your project's settings for a way to add the package forge.quest to the list of compiled sources.

Alternately, if you are willing to try a different IDE, I have created a set of instructions on how to get things set-up using IntelliJ here. That project should work out of the box.

What a pusher you are.

Lazy, right-click on cardforge, select Properties. Then select Java Build Path. Make sure cardforge/src Inludes All. Mine does it by default so I'm not sure what's up with your build?

[timmermac]

I'm using r6165 and am having the same problem. Is there something that can be done for people that use Snacko's scripts?