It is currently 15 Aug 2025, 10:07
   
Text Size

SVN Bug Reports

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: SVN Bug Reports

Postby Fnoed » 11 Feb 2011, 06:07

That some was me :(; I was overzealous in removing old code.
Restored in r6302.
Fnoed
 
Posts: 84
Joined: 20 Dec 2010, 01:03
Has thanked: 0 time
Been thanked: 3 times

Re: SVN Bug Reports

Postby Rob Cashwalker » 11 Feb 2011, 14:28

Thanks... I had to resort to installing and using SVN from my linux command line in order to look through the history to figure out when and why it had been removed. Searching the SVN history in Eclipse didn't help, because the file was no longer in source control and Google shows it, but doesn't list when it was deleted... very frustrating.... I used the SVN log command to list out all the changes (in verbose mode, to list files changed) since october, and then searched for DeckConverter.java.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: SVN Bug Reports

Postby Corwin72 » 11 Feb 2011, 15:58

build 6306
I created a deck in the main deck editor.
I tried to export and received this error:

CardFactory : getCard() invalid card name - All Is Dust|ROE

Update:
This happens when I export any deck. It gives the error for the first card in the deck.
I can import preexisting decks into the main deck editor or quest mode deck editor. When I import into the standard deck editor I lose access to adding new cards. All cards are missing from the card selector area at the top of the screen.
Last edited by Corwin72 on 11 Feb 2011, 17:37, edited 1 time in total.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby Sloth » 11 Feb 2011, 16:10

The AI can use Repeal to bounce anything by paying only U. It works for the player though.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby friarsol » 11 Feb 2011, 16:48

Sloth wrote:The AI can use Repeal to bounce anything by paying only U. It works for the player though.
Interesting. There's a few cards that use similar logic. I'm debugging Storm right now, but I can take a peak after. I think the X may not be getting properly considered in ComputerUtil.canPayCosts()
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby lazylockie » 11 Feb 2011, 17:24

r6307

I was testing some cards when I got the following errors when forge starts, then the games starts normally and freezes when pressing any button.

Code: Select all
An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


2


Version:
Forge -- official beta: $Date: 2011-01-06 14:34:48 -0200 (qui, 06 jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.ArrayIndexOutOfBoundsException: 2
   at forge.ReadCard.loadCard(Unknown Source)
   at forge.ReadCard.run(Unknown Source)
   at forge.CardFactory.readCards(Unknown Source)
   at forge.CardFactory.<init>(Unknown Source)
   at forge.AllZone.<clinit>(Unknown Source)
   at forge.Gui_NewGame$2.run(Unknown Source)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)

Code: Select all
An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


CardFactory : readCards() thread error - 2


Version:
Forge -- official beta: $Date: 2011-01-06 14:34:48 -0200 (qui, 06 jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.RuntimeException: CardFactory : readCards() thread error - 2
   at forge.CardFactory.readCards(Unknown Source)
   at forge.CardFactory.<init>(Unknown Source)
   at forge.AllZone.<clinit>(Unknown Source)
   at forge.Gui_NewGame$2.run(Unknown Source)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: SVN Bug Reports

Postby friarsol » 11 Feb 2011, 18:03

lazylockie wrote:r6307

I was testing some cards when I got the following errors when forge starts, then the games starts normally and freezes when pressing any button.
What cards? You should test them a batch at a time to try to narrow down which one is causing the issue.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby lazylockie » 11 Feb 2011, 18:58

friarsol wrote:
lazylockie wrote:r6307

I was testing some cards when I got the following errors when forge starts, then the games starts normally and freezes when pressing any button.
What cards? You should test them a batch at a time to try to narrow down which one is causing the issue.
I test only one at time. I was testing Sharding Sphinx and using Snacko's script and it started giving me that error. I changed to IntelliJ IDEA and the Sphinx worked fine (along all other cards I've made thereafter)
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: SVN Bug Reports

Postby Fnoed » 11 Feb 2011, 19:13

lazylockie wrote:
friarsol wrote:
lazylockie wrote:r6307

I was testing some cards when I got the following errors when forge starts, then the games starts normally and freezes when pressing any button.
What cards? You should test them a batch at a time to try to narrow down which one is causing the issue.
I test only one at time. I was testing Sharding Sphinx and using Snacko's script and it started giving me that error. I changed to IntelliJ IDEA and the Sphinx worked fine (along all other cards I've made thereafter)
That's strange; in theory, there should be no difference b/w using the script and doing an svn update in the IDE.
Fnoed
 
Posts: 84
Joined: 20 Dec 2010, 01:03
Has thanked: 0 time
Been thanked: 3 times

Re: SVN Bug Reports

Postby Rob Cashwalker » 11 Feb 2011, 20:42

Corwin72 wrote:build 6306
I created a deck in the main deck editor.
I tried to export and received this error:

CardFactory : getCard() invalid card name - All Is Dust|ROE

Update:
This happens when I export any deck. It gives the error for the first card in the deck.
I can import preexisting decks into the main deck editor or quest mode deck editor. When I import into the standard deck editor I lose access to adding new cards. All cards are missing from the card selector area at the top of the screen.
OK. Now that the DeckEditor is back, I can work on fixing it to work with set codes.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: SVN Bug Reports

Postby Corwin72 » 11 Feb 2011, 21:52

build 6306
I have gained control of the computer's Ballynock Trapper. When the opponent cast a white spell there was a trigger to untap the trapper. This should only happen if the controller casts a white spell not the owner of the card.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby lazylockie » 11 Feb 2011, 22:37

Fnoed wrote:
lazylockie wrote:
friarsol wrote:What cards? You should test them a batch at a time to try to narrow down which one is causing the issue.
I test only one at time. I was testing Sharding Sphinx and using Snacko's script and it started giving me that error. I changed to IntelliJ IDEA and the Sphinx worked fine (along all other cards I've made thereafter)
That's strange; in theory, there should be no difference b/w using the script and doing an svn update in the IDE.
I think I figured out. I didn't know that forge could read directly cardsfolder.zip, so I kept the txt files. When I removed the txt files it worked fine
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: SVN Bug Reports

Postby slapshot5 » 11 Feb 2011, 23:19

lazylockie wrote:r6307

I was testing some cards when I got the following errors when forge starts, then the games starts normally and freezes when pressing any button.

Looks to me like Lightning Rift trigger SVar is missing a part.

-slapshot5

edit: and Resounding Thunder and Solar Blast
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: SVN Bug Reports

Postby Chris H. » 11 Feb 2011, 23:47

Two of the new cards are causing an error exception when forge is launched. These cards are Lightning Rift and Resounding Thunder. I removed them from the SVN for the time being. Below are the card texts and an archive with both cards.

Lightning Rift | Open
Name:Lightning Rift
ManaCost:1 R
Types:Enchantment
Text:no text
T:Mode$ Cycled | ValidCard$ Card | Execute$ TrigDamage | TriggerDescription$ Whenever a player cycles a card, you may pay 1. If you do, CARDNAME deals 2 damage to target creature or player.
SVar:TrigDamage | Cost$ 1 | Tgt$ TgtCP | NumDmg$ 2
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/lightning_rift.jpg
SetInfo:ONS|Uncommon|http://magiccards.info/scans/en/on/217.jpg
End


Resounding Thunder | Open
Name:Resounding Thunder
ManaCost:2 R
Types:Instant
Text:no text
K:Cycling:5 R B G
A:SP$DealDamage | Cost$ 2 R | Tgt$ TgtCP | NumDmg$ 3 | SpellDescription$ CARDNAME deals 3 damage to target creature or player.
T:Mode$ Cycled | ValidCard$ Card.Self | Execute$ TrigDamage | TriggerDescription$ When you cycle CARDNAME, it deals 6 damage to target creature or player.
SVar:TrigDamage | Cost$ 0 | Tgt$ TgtCP | NumDmg$ 6
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/resounding_thunder.jpg
SetInfo:ALA|Common|http://magiccards.info/scans/en/ala/110.jpg
End

`
Attachments
Two buggy cards.zip
(1 KiB) Downloaded 215 times
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby jeffwadsworth » 12 Feb 2011, 00:37

Even these corrections crash the client. Strange.

Code: Select all
Name:Lightning Rift
ManaCost:1 R
Types:Enchantment
Text:no text
T:Mode$ Cycled | ValidCard$ Card | Execute$ TrigDamage | TriggerDescription$ Whenever a player cycles a card, you may pay 1. If you do, CARDNAME deals 2 damage to target creature or player.
SVar:TrigDamage:AB$DealDamage | Cost$ 1 | ValidTgts$ Creature,Player | TgtPrompt$ Select target creature or player | NumDmg$ 2
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/lightning_rift.jpg
End
Code: Select all
Name:Resounding Thunder
ManaCost:2 R
Types:Instant
Text:no text
K:Cycling:5 R B G
A:SP$DealDamage | Cost$ 2 R | ValidTgts$ Creature,Player | NumDmg$ 3 | SpellDescription$ CARDNAME deals 3 damage to target creature or player.
T:Mode$ Cycled | ValidCard$ Card.Self | Execute$ TrigDamage | TriggerDescription$ When you cycle CARDNAME, it deals 6 damage to target creature or player.
SVar:TrigDamage:SP$DealDamage | Cost$ 0 | ValidTgts$ Creature,Player | TgtPrompt$ Select target creature or player | NumDmg$ 6
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/resounding_thunder.jpg
End
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 20 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 20 users online :: 0 registered, 0 hidden and 20 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 20 guests

Login Form