Issue 113 Converting Hardcoded Cards to AFs/Trigger

[Chris H.]

I will start with the ? cards.

`
Thank you Jeff.

[friarsol]

Here are some Instants in CF_Instant that I think can be moved over

Code: Select all

Pongify
Peel from Reality
Crib Swap
Sprout Swarm (although it's Convoke still doesn't work)
Life Burst
Accumulated Knowledge
Overwhelming Intellect
Stroke of Genius
Windstorm
Starstorm
Vitalizing Cascade (If the Math doesn't work. We can do the ugly GainLife X with a GainLife 3 subability.)
Burst Lightning
Berserk
Agony Warp


[friarsol]

And the Sorceries:

Code: Select all

Lab Rats
Roiling Terrain
Plague Wind
Wheel of Fortune (if Discard works)
Deep Analysis
Grizzly Fate (Threshold 4.2)
Delirium Skeins
Ichor Slick
Reminisce
Innocent Blood
Identity Crisis
Bestial Menace
Exhume?
Prosperity
Hurricane
Earthquake
Rolling Earthquake
Savage Twister
Stream of Life
Lavalanche
Psychic Drain
Channel the Suns
Perish the Thought(this is a changeZone not a Discard)
Burning Inquiry
Reanimate
Ashes to Ashes
Last Stand
Decree of Justice


[jeffwadsworth]

Here are some Instants in CF_Instant that I think can be moved over

Code: Select all

Pongify
Peel from Reality
Crib Swap
Sprout Swarm (although it's Convoke still doesn't work)
Life Burst
Accumulated Knowledge
Overwhelming Intellect
Stroke of Genius
Windstorm
Starstorm
Vitalizing Cascade (If the Math doesn't work. We can do the ugly GainLife X with a GainLife 3 subability.)
Burst Lightning
Berserk
Agony Warp


I will start with this list. All are done except for Overwhelming Intellect which I can't get to recognize the targeted counted spell. Berserk wasn't in there.

[friarsol]

A very short land list:

Code: Select all

Bojuka Bog
Gods' Eye, Gate to the Reikai
Magosi, the Waterveil


[Chris H.]

I am trying to convert Mongrel Pack but I can't limit the activating phase. The card file is below and it does not not matter when this card hits the graveyard, 4 tokens get put on the battlefield:

Mongrel Pack card | Open

Name:Mongrel Pack
ManaCost:3 G
Types:Creature Hound
Text:no text
PT:4/1
T:Mode$ ChangesZone | Origin$ Battlefield | Destination$ Graveyard | ValidCard$ Card.Self | Execute$ TrigToken | ActivatingPhases$ BeginCombat->EndCombat | TriggerDescription$ When CARDNAME is put into a graveyard from the battlefield during combat, put four 1/1 green Hound creature tokens onto the battlefield.
SVar:TrigToken:AB$Token | Cost$ 0 | TokenAmount$ 4 | TokenName$ Hound | TokenTypes$ Creature,Hound | TokenOwner$ Controller | TokenColors$ Green | TokenPower$ 1 | TokenToughness$ 1
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/mongrel_pack.jpg
SetInfo:TMP|Rare|http://magiccards.info/scans/en/tp/131.jpg
End

[Hellfish]

Triggers can't be limited to phases currently. I'll try to implement that tomorrow morning/possibly evening.

[Chris H.]

Triggers can't be limited to phases currently. I'll try to implement that tomorrow morning/possibly evening.

`
OK, no problem, I figured that had not yet been implemented.

[jeffwadsworth]

And the Sorceries:

Code: Select all

Lab Rats
Roiling Terrain
Plague Wind
Wheel of Fortune (if Discard works)
Deep Analysis
Grizzly Fate (Threshold 4.2)
Delirium Skeins
Ichor Slick
Reminisce
Innocent Blood
Identity Crisis
Bestial Menace
Exhume?
Prosperity
Hurricane
Earthquake
Rolling Earthquake
Savage Twister
Stream of Life
Lavalanche
Psychic Drain
Channel the Suns
Perish the Thought(this is a changeZone not a Discard)
Burning Inquiry
Reanimate
Ashes to Ashes
Last Stand
Decree of Justice


I will get these.

[Hellfish]

Triggers can now be limited to phases using a comma-separated list of phases in the TriggerPhases$ parameter.Phase names for reference:

Code: Select all

Untap
Upkeep
Draw
Main1
BeginCombat
Declare Attackers
Declare Attackers - Play Instants and Abilities
Declare Blockers
Declare Blockers - Play Instants and Abilities
Combat Damage
First Strike Damage
EndCombat
Main2
End of Turn
Cleanup


[friarsol]

Triggers can now be limited to phases using a comma-separated list of phases in the TriggerPhases$ parameter.Phase names for reference:

Could you also handle "->" the way it works for AFs? This would make things like InCombat so much cleaner.

[Hellfish]

Shamelessly copied from AbilityFactory. Done!

[Chris H.]

Triggers can now be limited to phases using a comma-separated list of phases in the TriggerPhases$ parameter.

`
I updated my local copy to the new r6561 with the TriggerPhases$ code. I re-tried the Mongrel Pack mod and there is still no limitations taking place. The 4 Hound tokens are appearing wether it is during combat or not.

Aha! Eureka!

I initially failed to see that "ActivatingPhases$' is for normal non-trigged abs and we have to use "TriggerPhases$" for the new triggers.

[Chris H.]

I have one here for Hellfish. I have converted sooo many cards over the last couple of months that I may have made a simple mistake ... or the spell counter AF may need some adjustments to make this conversion work:

Mystic Snake | Open

Name:Mystic Snake
ManaCost:1 G U U
Types:Creature Snake
Text:no text
PT:2/2
K:Flash
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Card.Self | Execute$ TrigCounterspell | TriggerDescription$ When CARDNAME enters the battlefield, counter target spell.
SVar:TrigCounterspell:AB$Counter | Cost$ 0 | Type$ Spell | Destination$ Graveyard
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/mystic_snake.jpg
SetInfo:APC|Rare|http://magiccards.info/scans/en/ap/112.jpg
SetInfo:TSB|Special|http://magiccards.info/scans/en/tsts/97.jpg
End

[Hellfish]

I think the problem with Mystic Snake lies in how AF_Countermagic uses a custom input state to choose which spellability on the stack to counter. I don't think it plays nice with the trigger system. Gimme a day or so, I'll look into it.