SVN Bug Reports
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: SVN Bug Reports
by friarsol » 03 Mar 2011, 00:38
Why don't we just look for Cards that are unblocked the same way the Ninjutsu code does?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: SVN Bug Reports
by jeffwadsworth » 03 Mar 2011, 16:10
v.7054
Chose the 5 color deck from Generate Deck for the AI and received this error.
Chose the 5 color deck from Generate Deck for the AI and received this error.
- Code: Select all
GenerateConstructedDeck() : generateDeck() error, deck size it not 60, deck size is 49
Version:
Forge -- official beta: $Date: 2011-01-06 10:34:48 -0600 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $
OS: Windows 7 Version: 6.1 Architecture: x86
Java Version: 1.6.0_23 Vendor: Sun Microsystems Inc.
Detailed error trace:
java.lang.RuntimeException: GenerateConstructedDeck() : generateDeck() error, deck size it not 60, deck size is 49
at forge.GenerateConstructedMultiColorDeck.generate5ColorDeck(GenerateConstructedMultiColorDeck.java:96)
at forge.Gui_NewGame.generateConstructed5ColorDeck(Gui_NewGame.java:677)
at forge.Gui_NewGame.genDecks(Gui_NewGame.java:641)
at forge.Gui_NewGame.startButton_actionPerformed(Gui_NewGame.java:572)
at forge.Gui_NewGame$11.actionPerformed(Gui_NewGame.java:397)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
- jeffwadsworth
- Super Tester Elite
- Posts: 1172
- Joined: 20 Oct 2010, 04:47
- Location: USA
- Has thanked: 287 times
- Been thanked: 70 times
Re: SVN Bug Reports
by UnderFlow » 04 Mar 2011, 23:51
Revision 7102:
Sphinx-Bone Wand triggers when an Instant or Sorcery is played, but does neither get counters nor deal damage (or ask for a target).
Edit:
Also 7102:
I got a null-pointer exception when the computer sacrificed his Stun Sniper enchanted with Squee's Embrace to my Grave Pact trigger.
Edit2:
Another one: I reanimated my opponents Master of the Wild Hunt via Geth, Lord of the Vault. The Master made Wolf tokens in the computers upkeep, but not in mine.
Sphinx-Bone Wand triggers when an Instant or Sorcery is played, but does neither get counters nor deal damage (or ask for a target).
Edit:
Also 7102:
I got a null-pointer exception when the computer sacrificed his Stun Sniper enchanted with Squee's Embrace to my Grave Pact trigger.
Edit2:
Another one: I reanimated my opponents Master of the Wild Hunt via Geth, Lord of the Vault. The Master made Wolf tokens in the computers upkeep, but not in mine.
Re: SVN Bug Reports
by friarsol » 05 Mar 2011, 16:29
r7124
Activated Suicidal Charge during AIs turn. AI "conveniently" decides not to attack with his -1/1 Utopia Tree even though it should be attacking. He didn't even attempt to tap it so it didn't have to attack.
Activated Suicidal Charge during AIs turn. AI "conveniently" decides not to attack with his -1/1 Utopia Tree even though it should be attacking. He didn't even attempt to tap it so it didn't have to attack.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: SVN Bug Reports
by Sloth » 05 Mar 2011, 23:17
Fixed!friarsol wrote:r7124
Activated Suicidal Charge during AIs turn. AI "conveniently" decides not to attack with his -1/1 Utopia Tree even though it should be attacking. He didn't even attempt to tap it so it didn't have to attack.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: SVN Bug Reports
by Replika » 06 Mar 2011, 17:08
r7171
Noggle Bridgebreaker is very, very weird. The AI cast it and I was asked to choose a land I control. I chose one of the AI's Mountains, the return ability went on the stack targeting that Mountain and returned... the Noggle Bridgebreaker and not the Mountain.
The Bridgebreaker should return a land of its controllers choice without targeting it (HIDDEN).
Edit: (Also r7171)
Lifelink (the ability, not the card) uses the stack, but shouldn't.
The AI's Perilous Myr that traded with my Heartlash Cinder chose that same Cinder as the target for its ability, which is not only stupid, but also shouldn't be possible at all.
The AI is able to not choose a target for its Journey to Nowhere if I control no creatures but the AI does.
A Journey to Nowhere that didn't exile something (either because the AI did the thing above or because there was no legal target for it when cast) causes a NPE when leaving the battlefield.
The AI is using tap abilities (like Goldmeadow Harrier) very inefficient. It always uses them MP1 even if it needs the mana elsewhere and uses them even if it does not attack afterwards.
Noggle Bridgebreaker is very, very weird. The AI cast it and I was asked to choose a land I control. I chose one of the AI's Mountains, the return ability went on the stack targeting that Mountain and returned... the Noggle Bridgebreaker and not the Mountain.
The Bridgebreaker should return a land of its controllers choice without targeting it (HIDDEN).
Edit: (Also r7171)
Lifelink (the ability, not the card) uses the stack, but shouldn't.
The AI's Perilous Myr that traded with my Heartlash Cinder chose that same Cinder as the target for its ability, which is not only stupid, but also shouldn't be possible at all.
The AI is able to not choose a target for its Journey to Nowhere if I control no creatures but the AI does.
A Journey to Nowhere that didn't exile something (either because the AI did the thing above or because there was no legal target for it when cast) causes a NPE when leaving the battlefield.
The AI is using tap abilities (like Goldmeadow Harrier) very inefficient. It always uses them MP1 even if it needs the mana elsewhere and uses them even if it does not attack afterwards.
Re: SVN Bug Reports
by friarsol » 06 Mar 2011, 23:00
Hmmm.. I just activated Suicidal Charge again, and the AI decided not to attack with half of his goblins. (Playing against C3PO)Sloth wrote:Fixed!friarsol wrote:r7124
Activated Suicidal Charge during AIs turn. AI "conveniently" decides not to attack with his -1/1 Utopia Tree even though it should be attacking. He didn't even attempt to tap it so it didn't have to attack.
1/1 Sensation Gorger and 1/1 Goblin Outlander attacked. 2/1 Goblin Cavaliers and 1/1 Goblin Ringleader didn't. I have a 6/6 Rockslide Elemental, a 3/2 Goblin Roughrider and a 2/2 Yavimaya Enchantress.
A few matches ago I activated it the AI seemed to attack properly, not sure why he's not attacking this time. All of the creatures have the ability as expected.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: SVN Bug Reports
by ZzzzSleep » 06 Mar 2011, 23:15
Is it possible that Masher8's attacking code changes are deciding that the creature shouldn't attack after the special ability tells it that it should?friarsol wrote:Hmmm.. I just activated Suicidal Charge again, and the AI decided not to attack with half of his goblins. (Playing against C3PO)Sloth wrote:Fixed!friarsol wrote:r7124
Activated Suicidal Charge during AIs turn. AI "conveniently" decides not to attack with his -1/1 Utopia Tree even though it should be attacking. He didn't even attempt to tap it so it didn't have to attack.
1/1 Sensation Gorger and 1/1 Goblin Outlander attacked. 2/1 Goblin Cavaliers and 1/1 Goblin Ringleader didn't. I have a 6/6 Rockslide Elemental, a 3/2 Goblin Roughrider and a 2/2 Yavimaya Enchantress.
A few matches ago I activated it the AI seemed to attack properly, not sure why he's not attacking this time. All of the creatures have the ability as expected.
Re: SVN Bug Reports
by Chris H. » 06 Mar 2011, 23:18
`Replika wrote:r7171
Noggle Bridgebreaker is very, very weird. The AI cast it and I was asked to choose a land I control. I chose one of the AI's Mountains, the return ability went on the stack targeting that Mountain and returned... the Noggle Bridgebreaker and not the Mountain.
The Bridgebreaker should return a land of its controllers choice without targeting it (HIDDEN).
I just checked and the card file for Noggle Bridgebreaker looks like this:
- Noggle Bridgebreaker card | Open
- Name:Noggle Bridgebreaker
ManaCost:2 UR UR
Types:Creature Noggle Rogue
Text:no text
PT:4/3
K:When CARDNAME enters the battlefield, return a land you control to its owner's hand.
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/noggle_bridgebreaker.jpg
SetInfo:EVE|Common|http://magiccards.info/scans/en/eve/107.jpg
End
Notice that this card is not currently using AF or triggers but instead uses a keyword. I would suggest that we convert the cards using this keyword to AF and then retire yet another keyword.

-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: SVN Bug Reports
by Chris H. » 07 Mar 2011, 01:34
`Chris H. wrote:Notice that this card is not currently using AF or triggers but instead uses a keyword. I would suggest that we convert the cards using this keyword to AF and then retire yet another keyword.
Turns out all but two of the cards were converted. I converted Noggle Bridgebreaker and Orzhov Basilica. I then retired the old keyword.

-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: SVN Bug Reports
by Replika » 07 Mar 2011, 17:02
r7231
Vampire Lacerator does not use the stack, but it should.
The AI seems to hate tapped creatures: It uses its removal spells on tapped Goblin tokens even if there are untapped tokens of the same size/type around. This is especially annoying because the AI then proceeds to not attack into the one untapped token that it should have killed.
Vampire Lacerator does not use the stack, but it should.
The AI seems to hate tapped creatures: It uses its removal spells on tapped Goblin tokens even if there are untapped tokens of the same size/type around. This is especially annoying because the AI then proceeds to not attack into the one untapped token that it should have killed.
Re: SVN Bug Reports
by Sloth » 07 Mar 2011, 20:02
This is fixed now! Good point Replika.Replika wrote:The AI seems to hate tapped creatures: It uses its removal spells on tapped Goblin tokens even if there are untapped tokens of the same size/type around. This is especially annoying because the AI then proceeds to not attack into the one untapped token that it should have killed.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: SVN Bug Reports
by Jaedayr » 07 Mar 2011, 20:38
r7255
Got the following when I started Forge
Chris has already fixed this.
Got the following when I started Forge
- Code: Select all
An error has occured. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
mtgerror@yahoo.com
AbilityFactory Parsing Error in getAbility() : Split length of SpellDescription$ in Snuff Out is not 2.
Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $
OS: Windows XP Version: 5.1 Architecture: x86
Java Version: 1.6.0_24 Vendor: Sun Microsystems Inc.
Detailed error trace:
java.lang.RuntimeException: AbilityFactory Parsing Error in getAbility() : Split length of SpellDescription$ in Snuff Out is not 2.
at forge.AbilityFactory.getMapParams(AbilityFactory.java:111)
at forge.AbilityFactory.getAbility(AbilityFactory.java:126)
at forge.CardFactory.getCard2(CardFactory.java:4679)
at forge.CardFactory.getCard(CardFactory.java:313)
at forge.CardFactory.<init>(CardFactory.java:73)
at forge.AllZone.<clinit>(AllZone.java:29)
at forge.Gui_NewGame$2.run(Gui_NewGame.java:142)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$000(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
Chris has already fixed this.

Who is online
Users browsing this forum: No registered users and 7 guests