SVN Bug Reports

[friarsol]

r8310
AI activates Spawning Pool and attacks. Next turn it activates it, but for some reason it doesn't actually gain the new Types. Then it activates it again and nothing happens again. Must be something weird in the resolution code in Animate? It seems like all of the params were getting reset at some point.

[Hellfish]

I controlled Disciple of the Vault and sacrificed Chromatic Star. I still had the issue that I had to pass priority for the triggers to be put onto the stack.

Partially fixed, I'm looking into the targeting bit now.

Mishra, Artificer Prodigy triggers from the graveyard.

Among the last remnants of the WheneverKeyword, along with Mirari. If AF_ChangeZone could take a list of Origin's this would be doable in script, but I'm thinking such a change would be pretty difficult.

[Corwin72]

r8316
Caress of Phyrexia has extra text in the text box.

| Open

Target player draws three cards, loses 3 life, and gets three poison counters. Caress of Phyrexia Caress of Phyrexia

[friarsol]

r8316
Caress of Phyrexia has extra text in the text box.

| Open

Target player draws three cards, loses 3 life, and gets three poison counters. Caress of Phyrexia Caress of Phyrexia

I've noticed this recently with a lot of cards. It appears that if a SubAbility doesn't have a SpellDescription it's appending it's name to the Parent Abilities Description. I'm not sure where this change happened, but I don't know when that would be appropriate.

[Jaedayr]

r8320

I get the following when trying to run Forge from Eclipse

Code: Select all

An error has occurred. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


null


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_24 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.ReadCard.loadCard(ReadCard.java:155)
   at forge.ReadCard.run(ReadCard.java:119)
   at forge.card.cardFactory.CardFactory.readCards(CardFactory.java:129)
   at forge.card.cardFactory.CardFactory.<init>(CardFactory.java:98)
   at forge.AllZone.<clinit>(AllZone.java:33)
   at forge.Gui_NewGame$2.run(Gui_NewGame.java:149)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


[friarsol]

I got an NPE when the AI appeared to try to attack with a Rabid Wombat attached with a Beastmaster's Magemark

Code: Select all

   at forge.card.abilityFactory.AbilityFactory.getDefinedCards(AbilityFactory.java:835)
   at forge.CombatUtil.predictPowerBonusOfBlocker(CombatUtil.java:890)
   at forge.CombatUtil.canDestroyAttacker(CombatUtil.java:1069)
   at forge.ComputerUtil_Attack2.shouldAttack(ComputerUtil_Attack2.java:520)
   at forge.ComputerUtil_Attack2.getAttackers(ComputerUtil_Attack2.java:472)
   at forge.ComputerUtil.getAttackers(ComputerUtil.java:937)
   at forge.ComputerAI_General.declare_attackers(ComputerAI_General.java:229)
   at forge.ComputerAI_Input.think(ComputerAI_Input.java:54)
   at forge.ComputerAI_Input.showMessage(ComputerAI_Input.java:33)
   at forge.GuiInput.setInput(GuiInput.java:29)
   at forge.GuiInput.update(GuiInput.java:23)
   at java.util.Observable.notifyObservers(Unknown Source)
   at java.util.Observable.notifyObservers(Unknown Source)
   at forge.MyObservable.updateObservers(MyObservable.java:9)
   at forge.Phase.nextPhase(Phase.java:384)
   at forge.GuiDisplay4$25.actionPerformed(GuiDisplay4.java:746)


[Hellfish]

Sol: Fixed!

Jaedayr:Sounds like a card txt is missing the End line. If you replace the comment on line 165 of ReadCard.java with

Code: Select all

System.out.println(t);


it should print the problem card's name to the console before throwing the exception. It doesn't do that here,btw.

[slapshot5]

r8310
AI activates Spawning Pool and attacks. Next turn it activates it, but for some reason it doesn't actually gain the new Types. Then it activates it again and nothing happens again. Must be something weird in the resolution code in Animate? It seems like all of the params were getting reset at some point.

This is happening because the second time through, the params it's getting are from the granted regen ability. If anyone knows how/why this may be the case, please post to save me some digging.

First animate:

Code: Select all

Params: {Types=Creature,Skeleton, Cost=1 B, SpellDescription=CARDNAME becomes a 1/1 black Skeleton creature with "B: Regenerate this creature" until end of turn. It's still a land. (If it regenerates, the next time it would be destroyed this turn, it isn't. Instead tap it, remove all damage from it, and remove it from combat.), AB=Animate, Power=1, Toughness=1, Defined=Self, Colors=Black, Abilities=ABRegen}
Got the following types from params: [Creature, Skeleton]
Animate types to add: [Creature, Skeleton]


second animate:

Code: Select all

Params: {Cost=B, SpellDescription=Regenerate CARDNAME., AB=Regenerate}
Got the following types from params: []
Animate types to add: []


-slapshot5

edit: I can confirm something with the granted ability is confusing it. Faerie Conclave works as expected on the second animate.

[slapshot5]

Re: Spawning Pool

Nevermind. I got it. Just a basic misunderstanding of exactly how instances of AbilityFactory work.

-slapshot5

[Chris H.]

r8294: Grim Affliction and Dementia Bat do not show either card pictures or set info.

Edit: Add Insatiable Souleater to this as well. I'm noticing that all affected cards are from New Phyrexia.

Edit 3: It is definite now: All cards from New Phyrexia that I have encountered to this point do not show either card pictures or set info.

`
The New Phyrexia cards point to the wotc server and this server will not have the new pics available until the 12th or the 13th I suspect. For some reason on my computer these cards are displaying the pic for Groffskithur in the deck editor. Strange.

These cards have the setInfo set via the script. We may need to make an adjustment to the deck editor and/or the table code to get the set info displayed. Currently, it is blank or shows the AI column data. Another strange.

`
I added the missing New Phyrexia set data to the SetInfoUtil class in rev 8334. The new NPH cards should now look correct in the deck editor. We are still missing the pics but I think that the pic links will soon become active, next weekend I hope.

[Jaedayr]

Sol: Fixed!

Jaedayr:Sounds like a card txt is missing the End line. If you replace the comment on line 165 of ReadCard.java with

Code: Select all

System.out.println(t);


it should print the problem card's name to the console before throwing the exception. It doesn't do that here,btw.

Fixed! Glissa's Scorn was out of sync with the SVN but resync didn't flag it as a problem.

[Jaedayr]

r8336

This may be a variation of the previously reported problem playing the leftmost card in your hand. I was unable to play the second from the left card in my hand, Mystify. I was able to play the other four cards in my hand. I actually played the leftmost card, making Mystify the new leftmost card but was still unable to play it.

[Jaedayr]

r8391

Got the following during AI Main1 as it was trying to play a card. There was one operation on the stack.

Code: Select all

An error has occurred. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


null


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_24 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.card.abilityFactory.AbilityFactory.calculateAmount(AbilityFactory.java:796)
   at forge.card.abilityFactory.AbilityFactory_AlterLife.gainLifeStackDescription(AbilityFactory_AlterLife.java:131)
   at forge.card.abilityFactory.AbilityFactory_AlterLife$3.getStackDescription(AbilityFactory_AlterLife.java:99)
   at forge.card.abilityFactory.AbilityFactory_ChangeZone.changeKnownOriginStackDescription(AbilityFactory_ChangeZone.java:1093)
   at forge.card.abilityFactory.AbilityFactory_ChangeZone.changeZoneDescription(AbilityFactory_ChangeZone.java:180)
   at forge.card.abilityFactory.AbilityFactory_ChangeZone.access$2(AbilityFactory_ChangeZone.java:172)
   at forge.card.abilityFactory.AbilityFactory_ChangeZone$2.getStackDescription(AbilityFactory_ChangeZone.java:75)
   at forge.GuiDisplay4$19.update(GuiDisplay4.java:520)
   at java.util.Observable.notifyObservers(Unknown Source)
   at java.util.Observable.notifyObservers(Unknown Source)
   at forge.MyObservable.updateObservers(MyObservable.java:9)
   at forge.MagicStack.push(MagicStack.java:700)
   at forge.MagicStack.add(MagicStack.java:277)
   at forge.MagicStack.addAndUnfreeze(MagicStack.java:83)
   at forge.card.spellability.Cost_Payment.payComputerCosts(Cost_Payment.java:682)
   at forge.ComputerUtil.playCards(ComputerUtil.java:65)
   at forge.ComputerAI_General.playCards(ComputerAI_General.java:39)
   at forge.ComputerAI_General.main1(ComputerAI_General.java:24)
   at forge.ComputerAI_Input.think(ComputerAI_Input.java:48)
   at forge.ComputerAI_Input.showMessage(ComputerAI_Input.java:33)
   at forge.GuiInput.setInput(GuiInput.java:29)
   at forge.GuiInput.update(GuiInput.java:23)
   at java.util.Observable.notifyObservers(Unknown Source)
   at java.util.Observable.notifyObservers(Unknown Source)
   at forge.MyObservable.updateObservers(MyObservable.java:9)
   at forge.Phase.nextPhase(Phase.java:384)
   at forge.GuiDisplay4$25.actionPerformed(GuiDisplay4.java:746)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


[Jaedayr]

r8391

Got the following trying to activate the ability of Geth, Lord of the Vault. I had selected a card from the AI graveyard and it was in the process of resolving.

This looks like the same place in the code as my last post, but with a different action causing it.

Code: Select all

An error has occurred. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


null


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_24 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.card.abilityFactory.AbilityFactory.calculateAmount(AbilityFactory.java:796)
   at forge.card.abilityFactory.AbilityFactory_ZoneAffecting.millStackDescription(AbilityFactory_ZoneAffecting.java:482)
   at forge.card.abilityFactory.AbilityFactory_ZoneAffecting$6.getStackDescription(AbilityFactory_ZoneAffecting.java:457)
   at forge.card.abilityFactory.AbilityFactory_ChangeZone.changeKnownOriginStackDescription(AbilityFactory_ChangeZone.java:1093)
   at forge.card.abilityFactory.AbilityFactory_ChangeZone.changeZoneDescription(AbilityFactory_ChangeZone.java:180)
   at forge.card.abilityFactory.AbilityFactory_ChangeZone.access$2(AbilityFactory_ChangeZone.java:172)
   at forge.card.abilityFactory.AbilityFactory_ChangeZone$1.getStackDescription(AbilityFactory_ChangeZone.java:47)
   at forge.card.spellability.SpellAbility_Requirements.addAbilityToStack(SpellAbility_Requirements.java:114)
   at forge.card.spellability.SpellAbility_Requirements.finishPaying(SpellAbility_Requirements.java:94)
   at forge.card.spellability.Cost_Payment.payCost(Cost_Payment.java:424)
   at forge.card.spellability.Cost_Payment$2.done(Cost_Payment.java:762)
   at forge.card.spellability.Cost_Payment$2.selectCard(Cost_Payment.java:734)
   at forge.GuiInput.selectCard(GuiInput.java:49)
   at forge.GuiDisplay4$10.mousePressed(GuiDisplay4.java:380)
   at java.awt.AWTEventMulticaster.mousePressed(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)


[slapshot5]

Oh crap. That's me. Hang on.