It is currently 14 Aug 2025, 14:47
   
Text Size

AbilityFactory TODO list

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: AbilityFactory TODO list

Postby slapshot5 » 11 May 2011, 22:46

I have renamed everything to "Dig". Documentation still forthcoming after parameter tweaks are finalized (for now).

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: AbilityFactory TODO list

Postby slapshot5 » 12 May 2011, 16:53

Re: Dig AF vs ChangeZone AF

Is something like Thoughtpicker Witch better implemented with modifications to ChangeZone or with Dig? I can implement it with no code changes in AF_Dig. (I submitted to SVN if you want to view.)

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: AbilityFactory TODO list

Postby friarsol » 12 May 2011, 17:07

slapshot5 wrote:Re: Dig AF vs ChangeZone AF

Is something like Thoughtpicker Witch better implemented with modifications to ChangeZone or with Dig? I can implement it with no code changes in AF_Dig. (I submitted to SVN if you want to view.)

-slapshot5
To me that makes more sense to be in Dig. Digging is a refined version of ChangeZone where it's taking multiple cards from somewhere (usually the Library) and doing something to a few of them and doing something to the rest.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: AbilityFactory TODO list

Postby slapshot5 » 14 May 2011, 14:18

Starting on AF_Copy. See original post in other thread, but post follow-up/discussion here.
Ok. I'm feeling just stupid enough to try AF_Copy today. It's dreary, the coffee is ready, and the female is gone. After all, if I just copy the Kiki code, it can't be any worse than we already have, right?

Can someone post a list of the most basic test cards? Once the basics work, it can be expanded. As I said, I'll use Kiki as a template.

I suppose the AI is as simple as "copy best available valid card"?
-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: AbilityFactory TODO list

Postby Chris H. » 14 May 2011, 14:30

slapshot5 wrote:Starting on AF_Copy. See original post in other thread, but post follow-up/discussion here.
Ok. I'm feeling just stupid enough to try AF_Copy today. It's dreary, the coffee is ready, and the female is gone. After all, if I just copy the Kiki code, it can't be any worse than we already have, right?

Can someone post a list of the most basic test cards? Once the basics work, it can be expanded. As I said, I'll use Kiki as a template.

I suppose the AI is as simple as "copy best available valid card"?
`
We wish you luck. =D>
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: AbilityFactory TODO list

Postby friarsol » 14 May 2011, 14:55

slapshot5 wrote:Starting on AF_Copy. See original post in other thread, but post follow-up/discussion here.
Ok. I'm feeling just stupid enough to try AF_Copy today. It's dreary, the coffee is ready, and the female is gone. After all, if I just copy the Kiki code, it can't be any worse than we already have, right?

Can someone post a list of the most basic test cards? Once the basics work, it can be expanded. As I said, I'll use Kiki as a template.

I suppose the AI is as simple as "copy best available valid card"?
-slapshot5
Here's a list that might be helpful.
http://magiccards.info/query?q=+-o%3Asp ... er&s=cname
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: AbilityFactory TODO list

Postby slapshot5 » 14 May 2011, 16:50

Ok, I have the basics of an AF_CopyPermanent checked in. As we add more cards, more parameters will probably be necessary, and tweaks will undoubtedly need to happen.

Targeting/Defined is for Card objects.

Keywords param adds keywords to the created token
AtEOT param (can be Sacrifice or Exile) adds a sacrifice or exile at end of turn for the created token (not just a keyword so a little AI can be extracted...)

Please try to add a few new cards and see what parameters/tweaks we are going to need.

-slapshot5

edit: SacAtEOT -> AtEOT
Last edited by slapshot5 on 14 May 2011, 17:29, edited 1 time in total.
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: AbilityFactory TODO list

Postby Hellfish » 14 May 2011, 17:11

Well, if you can implement extra good AI using a SacAtEOT parameter rather than keyword, an ExileAtEOT parameter would probably also be good for Splinter Twin, Mimic Vat and Heat Shimmer
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: AbilityFactory TODO list

Postby SoulStorm » 14 May 2011, 17:26

Turned on the computer this afternoon, checked the change log, and saw AF_CopyPermanent.

Here's a copy of my post from the log:

Dennis, I did not expect to see this today, but you have no idea how happy I am to see it! Not only have you implemented my most anticipated AF, but you just happened to implement the #1 card on my AF Copy list, Mirrorworks! I had no idea it was my birthday today. :)
SoulStorm
 
Posts: 423
Joined: 24 Jun 2010, 22:48
Has thanked: 16 times
Been thanked: 11 times

Re: AbilityFactory TODO list

Postby slapshot5 » 14 May 2011, 17:31

Hellfish wrote:Well, if you can implement extra good AI using a SacAtEOT parameter rather than keyword, an ExileAtEOT parameter would probably also be good for Splinter Twin, Mimic Vat and Heat Shimmer
Yep. I saw Heat Shimmer and implemented it as AtEOT param with values of Sacrifice and Exile.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: AbilityFactory TODO list

Postby Hellfish » 14 May 2011, 17:45

Cool stuff! One step further towards Mimic Vat, Prototype Portal & Soul Foundry :D
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: AbilityFactory TODO list

Postby friarsol » 15 May 2011, 13:01

Well if anyone is motivated to try their hand at 'CopySpell' now that they mastered the power of 'CopyPermanent' it would be great to have WheneverKeyword completely removed from the codebase. I'm taking a look to see if I can convert Mishra today.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: AbilityFactory TODO list

Postby slapshot5 » 15 May 2011, 13:13

friarsol wrote:Well if anyone is motivated to try their hand at 'CopySpell' now that they mastered the power of 'CopyPermanent' it would be great to have WheneverKeyword completely removed from the codebase. I'm taking a look to see if I can convert Mishra today.
Yep. That's why mine was CopyPermanent and not just Copy... :) I think Chris is bored, what with all those crazy big checkins I saw yesterday. Maybe he'll take a crack. :D
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: AbilityFactory TODO list

Postby Chris H. » 15 May 2011, 13:59

slapshot5 wrote:Yep. That's why mine was CopyPermanent and not just Copy... :) I think Chris is bored, what with all those crazy big checkins I saw yesterday. Maybe he'll take a crack. :D
`
Hehe.

Sloth and Corwin have done a great job of revamping existing and adding new quest decks. Need to give Sloth a break for real life stuff, and he will get back to Corwin and I once he can look at our most recent work. :)

Currently I am trying to finish adding spaces and changing the card real name with "CARDNAME" in SpellDescription$. I ran out of steam a few weeks ago when I started and I am now trying to finish this monster off.

I also want to change over the various ".getController().equals(AllZone.ComputerPlayer)" and ".getController().equals(AllZone.HumanPlayer)" to "getController().isComputer()" and "getController().isHuman()".

This is the kind of work that is just right for us jr. programmers in training. :)

I have also spent some time studying PhaseUtil.canOnlyUntapOneLand(). I thought that I might be able to create a CanOnlyUntap keyword for this ... but it looks like this is going to take me more time to figure out.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: AbilityFactory TODO list

Postby slapshot5 » 15 May 2011, 14:45

Ok. I'll look at AF_CopySpell today. I'm going to use the Kiki argument: "If I just copy Fork, it can't be worse than we already have!"

And maybe a little static animate. I think Soulstorm may be onto something in another thread. I think he's checking the current thoughts for rules-compliance.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: Baidu [Spider] and 32 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 33 users online :: 1 registered, 0 hidden and 32 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: Baidu [Spider] and 32 guests

Login Form