It is currently 17 Aug 2025, 19:37
   
Text Size

SVN Bug Reports

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: SVN Bug Reports

Postby Chris H. » 27 May 2011, 12:35

Hellfish wrote:On a sidenote, is google code weird for anyone else? It only shows me all revisions up to r8972 and then there are big gaps in the list.
`
I use the URL http://code.google.com/p/cardforge/source/list and this gives me the full list of Commit log messages. This does help me with the change logs for the beta release. :D

In the past, several people have noticed gaps in the list. I think they were using a different URL.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Corwin72 » 27 May 2011, 13:27

r9003
Stoneforge Mystic is not triggering when it comes into play.
Everflowing Chalice does not prompt to kick it when cast.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby Sloth » 27 May 2011, 15:25

Corwin72 wrote:r9003
Stoneforge Mystic is not triggering when it comes into play.
Yes, there was some change in the etb triggers. It can be fixed by removing the triggerzone from the card script.

EDIT: I think there are more than 100 cards that need this change. :(
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby Corwin72 » 27 May 2011, 17:24

I am not sure if it is related but Sword of Body and Mind does not trigger when the creature deals damage to the player.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: SVN Bug Reports

Postby Chris H. » 27 May 2011, 18:01

Hmmm.

We have 1015 cards that have a " | TriggerZones$ " as part of it's trigger. Is it just the etb cards that need to be converted? Do we need to convert all cards containing " | TriggerZones$ " ?
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Hellfish » 27 May 2011, 18:13

Likely and hopefully just the ChangesZone triggers.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby Chris H. » 27 May 2011, 18:34

OK, I did a search on the cardsfolder for "T:Mode$ ChangesZone" and found 929 cards. I searched these 929 cards for " | TriggerZones$ " and found 259 cards that are potential candidates:

| Open
abduction.txt
admonition_angel.txt
adventuring_gear.txt
aether_charge.txt
aether_flash.txt
akki_raider.txt
akoum_battlesinger.txt
algae_gharial.txt
amulet_of_vigor.txt
angelic_chorus.txt
angelic_renewal.txt
ankh_of_mishra.txt
arcbound_crusher.txt
archon_of_redemption.txt
aura_shards.txt
auriok_champion.txt
auspicious_ancestor.txt
avenger_of_zendikar.txt
azorius_aethermage.txt
baloth_woodcrasher.txt
barishi.txt
baru_fist_of_krosa.txt
battered_golem.txt
battlewand_oak.txt
bereavement.txt
bestial_fury.txt
black_market.txt
bladewings_thrall.txt
blasting_station.txt
blood_seeker.txt
blood_speaker.txt
bloodghast.txt
bogardan_firefiend.txt
boggart_shenanigans.txt
bojuka_brigand.txt
bridge_from_below.txt
butcher_of_malakir.txt
calcite_snapper.txt
carnival_of_souls.txt
carrier_pigeons.txt
caustic_crawler.txt
compost.txt
cosis_ravager.txt
cream_of_the_crop.txt
dauthi_ghoul.txt
deathbringer_thoctar.txt
deathgreeter.txt
dingus_egg.txt
dingus_staff.txt
dire_undercurrents.txt
disciple_of_the_vault.txt
doomsday_specter.txt
dormant_sliver.txt
dread.txt
dross_harvester.txt
dross_scorpion.txt
earthlink.txt
electropotence.txt
elephant_guide.txt
elvish_vanguard.txt
emeria_angel.txt
energy_field.txt
essence_warden.txt
eternity_vessel.txt
extractor_demon.txt
fangren_marauder.txt
fatal_attraction.txt
fecundity.txt
femeref_enchantress.txt
field_of_souls.txt
fledgling_griffin.txt
fortitude.txt
garruks_packleader.txt
genju_of_the_realm.txt
geyser_glider.txt
glassdust_hulk.txt
glaze_fiend.txt
glint_hawk_idol.txt
glissa_the_traitor.txt
glistening_oil.txt
goblin_pyromancer.txt
goblin_sharpshooter.txt
godtracker_of_jund.txt
golgari_germination.txt
grave_pact.txt
grave_titan.txt
graypelt_hunter.txt
grazing_gladehart.txt
griffin_guide.txt
grim_feast.txt
grinding_station.txt
gristle_grinner.txt
hada_freeblade.txt
hagra_crocodile.txt
hagra_diabolist.txt
halimar_excavator.txt
hamletback_goliath.txt
haru_onna.txt
hedron_crab.txt
hedron_rover.txt
hedron_scrabbler.txt
heightened_awareness.txt
herd_gnarr.txt
highland_berserker.txt
hissing_iguanar.txt
icatian_moneychanger.txt
in_the_web_of_war.txt
incendiary.txt
indebted_samurai.txt
inheritance.txt
intruder_alarm.txt
ior_ruin_expedition.txt
joraga_bard.txt
juniper_order_ranger.txt
kalastria_highborn.txt
karstoderm.txt
kavu_lair.txt
kavu_monarch.txt
kazandu_blademaster.txt
kazuul_warlord.txt
kemuri_onna.txt
khalni_heart_expedition.txt
kiri_onna.txt
knucklebone_witch.txt
kresh_the_bloodbraided.txt
last_laugh.txt
leonin_elder.txt
leyline_of_vitality.txt
liability.txt
lifegift.txt
lim_dul_the_necromancer.txt
llanowar_sentinel.txt
lurking_skirge.txt
magnetic_mine.txt
makindi_shieldmate.txt
mantle_of_leadership.txt
marker_beetles.txt
masked_admirers.txt
massacre_wurm.txt
merfolk_observer.txt
merrow_harbinger.txt
mighty_emergence.txt
mirrorworks.txt
molder_beast.txt
moonlit_wake.txt
moriok_rigger.txt
mortuary.txt
murasa_pyromancer.txt
mycoid_shepherd.txt
natures_wrath.txt
necroskitter.txt
nether_traitor.txt
nihilith.txt
nikko_onna.txt
nimana_sell_sword.txt
noxious_ghoul.txt
ob_nixilis_the_fallen.txt
ondu_cleric.txt
oran_rief_survivalist.txt
orchard_warden.txt
overburden.txt
paleoloth.txt
pawn_of_ulamog.txt
plague_spitter.txt
plated_geopede.txt
poisonbelly_ogre.txt
polluted_bonds.txt
primeval_titan.txt
proper_burial.txt
prowess_of_the_fair.txt
pyknite.txt
quest_for_ancient_secrets.txt
quest_for_the_goblin_lord.txt
quest_for_the_gravelord.txt
rampaging_baloths.txt
rank_and_file.txt
reach_of_branches.txt
reaper_king.txt
ritual_of_steel.txt
rockslide_elemental.txt
roil_elemental.txt
rotlung_reanimator.txt
sadistic_glee.txt
sangromancer.txt
sarcomancy.txt
scavenger_drake.txt
scrapheap.txt
screaming_seahawk.txt
seascape_aerialist.txt
seed_the_land.txt
seedguide_ash.txt
seers_sundial.txt
sekkuar_deathkeeper.txt
serum_tank.txt
shades_form.txt
shattered_angel.txt
sigil_captain.txt
sigil_of_the_new_dawn.txt
skeletal_vampire.txt
sky_hussar.txt
sleeping_potion.txt
sludge_strider.txt
snapping_creeper.txt
sosukes_summons.txt
soul_net.txt
soul_stair_expedition.txt
soul_warden.txt
soulcatcher.txt
soulcatchers_aerie.txt
souls_attendant.txt
soultether_golem.txt
spirit_cairn.txt
spirit_loop.txt
stalking_vengeance.txt
steppe_lynx.txt
stone_seeder_hierophant.txt
stormfront_riders.txt
suleimans_legacy.txt
summoning_station.txt
sun_titan.txt
sunspring_expedition.txt
sunstrike_legionnaire.txt
surrakar_marauder.txt
suture_priest.txt
tablet_of_epityr.txt
tainted_aether.txt
tajuru_archer.txt
talus_paladin.txt
territorial_baloth.txt
teysa_orzhov_scion.txt
tideforce_elemental.txt
timid_drake.txt
totem_speaker.txt
treefolk_harbinger.txt
tuktuk_grunts.txt
turntimber_ranger.txt
twilight_drover.txt
umara_raptor.txt
vampirism.txt
venarian_gold.txt
vengeful_dead.txt
vermiculos.txt
vigil_for_the_lost.txt
vinelasher_kudzu.txt
viridian_revel.txt
vulturous_zombie.txt
warped_devotion.txt
welkin_hawk.txt
where_ancients_tread.txt
windrider_eel.txt
wirewood_herald.txt
wirewood_hivemaster.txt
wirewood_savage.txt
wretched_anurid.txt
yoke_of_the_damned.txt
yomiji_who_bars_the_way.txt
yuki_onna.txt
zektar_shrine_expedition.txt
zo_zu_the_punisher.txt
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Hellfish » 27 May 2011, 18:56

Thanks. Forgot that only the triggers with "ValidCards$ Card.Self" were affected,though. Sorry! >_> Sloth is alredy going through these at crazy speeds though :O
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby Chris H. » 27 May 2011, 19:02

Hellfish wrote:Thanks. Forgot that only the triggers with "ValidCards$ Card.Self" were affected,though. Sorry! >_> Sloth is alredy going through these at crazy speeds though :O
`
Yep, I did a further search on those 259 cards using "Card.Self" and it went down to 81 cards.

I think that Sloth is moving through these fairly quickly.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Sloth » 27 May 2011, 19:09

I went through, but my windows search tool is pretty limited. I'm sure I missed some with irregular ordering (I only checked those with Origin - Destination - ValidCard).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby DeadSpeak » 28 May 2011, 04:04

Gitaxian Probe is a sorcery and not an instant (which is insane :lol: )
DeadSpeak
 
Posts: 104
Joined: 25 Dec 2009, 00:14
Location: Denmark
Has thanked: 4 times
Been thanked: 3 times

Re: SVN Bug Reports

Postby friarsol » 28 May 2011, 04:13

Just got a crash with Festering Wound. I cast it on the AIs Multani's Acolyte and during the next upkeep I got an NPE.

Code: Select all
   at forge.card.trigger.Trigger.matchesValid(Trigger.java:362)
   at forge.card.trigger.Trigger_Phase.performTest(Trigger_Phase.java:42)
   at forge.card.trigger.TriggerHandler.runSingleTrigger(TriggerHandler.java:325)
   at forge.card.trigger.TriggerHandler.runTrigger(TriggerHandler.java:280)
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Rob Cashwalker » 28 May 2011, 05:29

Sloth wrote:I went through, but my windows search tool is pretty limited. I'm sure I missed some with irregular ordering (I only checked those with Origin - Destination - ValidCard).
Try using Notepad++. It has a comprehensive file search function and it puts the results in a highlight list on the bottom, so you can see the matches at a glance then click on the line to open the file and jump to the line.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: SVN Bug Reports

Postby Sloth » 28 May 2011, 08:12

Rob Cashwalker wrote:
Sloth wrote:I went through, but my windows search tool is pretty limited. I'm sure I missed some with irregular ordering (I only checked those with Origin - Destination - ValidCard).
Try using Notepad++. It has a comprehensive file search function and it puts the results in a highlight list on the bottom, so you can see the matches at a glance then click on the line to open the file and jump to the line.
I just tried it and it does not have what I need. I want to perform a search for files that contain multiple expressions. Example: "ChangesZone" and "Self".
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby Chris H. » 28 May 2011, 12:03

Sloth wrote:I just tried it and it does not have what I need. I want to perform a search for files that contain multiple expressions. Example: "ChangesZone" and "Self".
`
In an effort to make myself useful I used the built-in OS searching ability on my Mac. I include a screenshot showing the search criteria and also a list of the card files that match.

There are 47 cards that contain all 5 of the contents that I am searching for, but many of these cards are likely to have more that just a single trigger.

list of cards that match | Open
abduction.txt
admonition_angel.txt
akoum_battlesinger.txt
avenger_of_zendikar.txt
bestial_fury.txt
bojuka_brigand.txt
carrier_pigeons.txt
fatal_attraction.txt
goblin_pyromancer.txt
grave_titan.txt
graypelt_hunter.txt
hada_freeblade.txt
hagra_diabolist.txt
halimar_excavator.txt
haru_onna.txt
heightened_awareness.txt
highland_berserker.txt
icatian_moneychanger.txt
joraga_bard.txt
kazandu_blademaster.txt
kazuul_warlord.txt
kemuri_onna.txt
kiri_onna.txt
llanowar_sentinel.txt
makindi_shieldmate.txt
massacre_wurm.txt
murasa_pyromancer.txt
nikko_onna.txt
nimana_sell_sword.txt
noxious_ghoul.txt
ondu_cleric.txt
oran_rief_survivalist.txt
primeval_titan.txt
sarcomancy.txt
seascape_aerialist.txt
serum_tank.txt
sleeping_potion.txt
stormfront_riders.txt
suleimans_legacy.txt
sun_titan.txt
tajuru_archer.txt
talus_paladin.txt
tuktuk_grunts.txt
turntimber_ranger.txt
umara_raptor.txt
venarian_gold.txt
yuki_onna.txt

`
Attachments
Searching.jpg
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 9 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 9 users online :: 0 registered, 0 hidden and 9 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 9 guests

Login Form