It is currently 27 Aug 2025, 16:22
   
Text Size

Is anyone working on the deck editors presently?

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Is anyone working on the deck editors presently?

Postby Braids » 23 Aug 2011, 02:53

regarding Issue 51 and Issue 134.

i have been considering taking these on. they could both be implemented by a stand alone application with well defined integration protocols.

input would be the card names with optional picture specifiers, with an unrestricted quantity flag for constructed mode and individual quantities available for each card in limited modes. input may also need one or more directories for card art.

output would be one or more file system paths to deck files that were created or modified with the editor.

upon closing the app, calling code would have to verify that the resulting decks do not violate the quantity or card name rules.

of course, if someone knows of an existing deck editor that can be restrictive and communicative in these fashions, i'd rather not reinvent the wheel.
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Re: Is anyone working on the deck editors presently?

Postby jendave » 23 Aug 2011, 15:21

Have you ever looked at Nate's Deck Builder?
viewtopic.php?f=29&t=464&start=285

It provided the basis for the Forge Deck Editor
jendave
 
Posts: 307
Joined: 01 Jun 2008, 07:19
Has thanked: 8 times
Been thanked: 21 times

Re: Is anyone working on the deck editors presently?

Postby Rob Cashwalker » 23 Aug 2011, 16:12

Wait on the deck editor stuff until there's a change in the card object architecture. The sorting and populating of the editor lists is what takes so much time due to the current architecture.

Redesigning the editor from the ground-up would allow for the inheritance I know you would love. Basic layout is unchanging, some menu items may appear/disappear/function differently, card shop has extra data for values.. just minor differences.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Is anyone working on the deck editors presently?

Postby Braids » 25 Aug 2011, 02:21

Rob Cashwalker wrote:Wait on the deck editor stuff until there's a change in the card object architecture. The sorting and populating of the editor lists is what takes so much time due to the current architecture.

Redesigning the editor from the ground-up would allow for the inheritance I know you would love. Basic layout is unchanging, some menu items may appear/disappear/function differently, card shop has extra data for values.. just minor differences.
is someone already redesigning the editor(s), then? i wasn't planning on touching the card shop. although that could be incorporated. i want to switch the constructed and limited deck editors to the same standalone application. this would help the sorting and populating of the editor lists as well.

i'm not a big lover of inheritance. believe it or not. i think model view {and possibly controller} separation is more important.

i can wait, but i suspect i would be parsing mtg-data.txt into JavaDB, rather than using one of the Forge Card classes.

unless, like i said, there's an editor out there that already handles the input and outputs i described in the first post of this topic.
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Re: Is anyone working on the deck editors presently?

Postby Braids » 25 Aug 2011, 02:32

jendave wrote:Have you ever looked at Nate's Deck Builder?
viewtopic.php?f=29&t=464&start=285

It provided the basis for the Forge Deck Editor
i just looked at it. i didn't see any source, and i saw at least one DLL file. i need something that is 100% Java with an open source license, in order to make it conform to the interface requirements i mentioned in the first post.
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Re: Is anyone working on the deck editors presently?

Postby Rob Cashwalker » 25 Aug 2011, 03:18

Braids wrote:is someone already redesigning the editor(s), then? i wasn't planning on touching the card shop. although that could be incorporated. i want to switch the constructed and limited deck editors to the same standalone application. this would help the sorting and populating of the editor lists as well.

i'm not a big lover of inheritance. believe it or not. i think model view {and possibly controller} separation is more important.

i can wait, but i suspect i would be parsing mtg-data.txt into JavaDB, rather than using one of the Forge Card classes.

unless, like i said, there's an editor out there that already handles the input and outputs i described in the first post of this topic.
Why standalone? No existing codebase would deal with our card data. The Forge deck editor is functional, it's the data structure that's slow. How would you limit card availability from the mtg-data.txt to what Forge supports? With two apps you'll end up with duplicate memory usage.

I just think you're barking up the wrong Tree of Tales ...
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Is anyone working on the deck editors presently?

Postby friarsol » 25 Aug 2011, 03:25

Rob Cashwalker wrote:I just think you're barking up the wrong Tree of Tales ...
Oh god, not you too.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Is anyone working on the deck editors presently?

Postby Rob Cashwalker » 25 Aug 2011, 03:47

It just rolled off my tongue/fingers... seemed natural...
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Is anyone working on the deck editors presently?

Postby Braids » 25 Aug 2011, 19:19

Rob Cashwalker wrote:Why standalone? No existing codebase would deal with our card data. The Forge deck editor is functional, it's the data structure that's slow. How would you limit card availability from the mtg-data.txt to what Forge supports? With two apps you'll end up with duplicate memory usage.

I just think you're barking up the wrong Tree of Tales ...
did i start the trend of using card names as euphemisms or clever decoration in posts? 8)

ok, not necessarily standalone, but potentially standalone. something that could be standalone would be pretty useful in general. i have yet to see a decent free deck editor for a limited card pool.

i described above how to limit card availability. the card pool would be an input to the deck editor feature.

anyway, the point is moot. Max mtg has scooped me by taking assignment of the Mantis issues involving the deck editor. :?
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Re: Is anyone working on the deck editors presently?

Postby Rob Cashwalker » 25 Aug 2011, 21:06

He's likely just revising it for the new card objects. You could still design a new interface that works in all modes.
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: Is anyone working on the deck editors presently?

Postby Max mtg » 25 Aug 2011, 22:59

Oops, I haven't looked through topics in this forum for long.

I am working at both deckeditors and cardshop. I have 4 objectives:
1. Improve performance. For that I will use lightweight card classes and a different approach at data model (have references
2. Suuport management of prints of same card from different edition.
3. Make the editors use a common basis - at least a window base class with filters and so on.
4. Implement some of the minor features requested (like make deck be written to file in particular order)
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Is anyone working on the deck editors presently?

Postby Max mtg » 25 Aug 2011, 22:59

Braids wrote:
Rob Cashwalker wrote:anyway, the point is moot. Max mtg has scooped me by taking assignment of the Mantis issues involving the deck editor. :?
Sorry, I was unaware of you plans.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Is anyone working on the deck editors presently?

Postby Braids » 25 Aug 2011, 23:35

Max mtg wrote:
Braids wrote:
Rob Cashwalker wrote:anyway, the point is moot. Max mtg has scooped me by taking assignment of the Mantis issues involving the deck editor. :?
Sorry, I was unaware of you plans.
it's ok. i should have taken the assignments myself before i posted the question. that would have prompted you to at least contact me.

i just remembered another reason why i wanted a separate deck editor application -- to avoid the GNU Public License virus. i don't think invoking a system command is considered run time linkage, so it would have been safe.

@Max mtg, keep doing what you're doing. you have the passion for the project. it's neat to see. i'll find something interesting to do elsewhere. oh, i remember something else. i'm not sure if you'll find forge.card.cardFactory.LazyCardFactory useful or not, but it's there if you need the code.
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Re: Is anyone working on the deck editors presently?

Postby Snacko » 26 Aug 2011, 10:27

Braids wrote:
jendave wrote:Have you ever looked at Nate's Deck Builder?
viewtopic.php?f=29&t=464&start=285

It provided the basis for the Forge Deck Editor
i just looked at it. i didn't see any source, and i saw at least one DLL file. i need something that is 100% Java with an open source license, in order to make it conform to the interface requirements i mentioned in the first post.
It's 100% java, the plugins, for example MWS does depend on dlls because MWS is a Windows executable.
sources https://gitorious.org/arcane license gplv3
Snacko
DEVELOPER
 
Posts: 826
Joined: 29 May 2008, 19:35
Has thanked: 4 times
Been thanked: 74 times

Re: Is anyone working on the deck editors presently?

Postby Braids » 27 Aug 2011, 02:09

Snacko wrote:[Nate's Deck Builder is] 100% java, the plugins, for example MWS does depend on dlls because MWS is a Windows executable.
sources https://gitorious.org/arcane license gplv3
i was specifically trying to avoid GPL. thanks for the clarification, though.
"That is the dumbest thing I've ever seen." --Rob Cashwalker, regarding Innistrad double-sided cards. One of the first times he and I have ever agreed on something. ;)
User avatar
Braids
Programmer
 
Posts: 556
Joined: 22 Jun 2011, 00:39
Location: Unknown. Hobby: Driving myself and others to constructive madness.
Has thanked: 1 time
Been thanked: 1 time

Next

Return to Forge

Who is online

Users browsing this forum: No registered users and 45 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 45 users online :: 0 registered, 0 hidden and 45 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 45 guests

Login Form