Feature Requests Thread
by mtgrares
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Feature Requests Thread
by Accountancy » 30 Aug 2011, 08:48
Would it be possible to add functionality so that when you click on a creature to make it attack, clicking on it again will stop it from being declared as an attacker, as yet, if you accidentally click on a creature during the declare attackers step, you have to live with your decision and the creature usually dies.
- Accountancy
- Posts: 230
- Joined: 14 Aug 2009, 12:39
- Has thanked: 22 times
- Been thanked: 2 times
Re: Feature Requests Thread
by Sloth » 30 Aug 2011, 09:08
Good news. This feature is also there: Try right clicking on the attacking creature.Accountancy wrote:Would it be possible to add functionality so that when you click on a creature to make it attack, clicking on it again will stop it from being declared as an attacker, as yet, if you accidentally click on a creature during the declare attackers step, you have to live with your decision and the creature usually dies.

-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Feature Requests Thread
by Accountancy » 03 Sep 2011, 09:37
Could we please do away with the function that after you win 2 games in a match, you get no option to repeat the match? It just gives the player less choice and when playing with randomly generated decks, if you want to play more than three games, you have to purposely lost the last one.
- Accountancy
- Posts: 230
- Joined: 14 Aug 2009, 12:39
- Has thanked: 22 times
- Been thanked: 2 times
Re: Feature Requests Thread
by slapshot5 » 03 Sep 2011, 10:24
That's not a feature request. That's a straight up bug. I don't know what the right fix is. It looks like it got integrated with the quest stuff somehow.Accountancy wrote:Could we please do away with the function that after you win 2 games in a match, you get no option to repeat the match? It just gives the player less choice and when playing with randomly generated decks, if you want to play more than three games, you have to purposely lost the last one.
-slapshot5
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: Feature Requests Thread
by Max mtg » 03 Sep 2011, 13:33
I don't see this bug in my development build. Accountancy, what version are you using?slapshot5 wrote:That's not a feature request. That's a straight up bug. I don't know what the right fix is. It looks like it got integrated with the quest stuff somehow.Accountancy wrote:Could we please do away with the function that after you win 2 games in a match, you get no option to repeat the match? It just gives the player less choice and when playing with randomly generated decks, if you want to play more than three games, you have to purposely lost the last one.
-slapshot5
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Feature Requests Thread
by slapshot5 » 03 Sep 2011, 17:17
I see it in my svn version. r10193. Just play a 1 game (non-quest) and win it. Notice the restart button is enabled. It should only be enabled if you or the computer have won 2 games, and thus, the match.Max mtg wrote:I don't see this bug in my development build. Accountancy, what version are you using?slapshot5 wrote:That's not a feature request. That's a straight up bug. I don't know what the right fix is. It looks like it got integrated with the quest stuff somehow.Accountancy wrote:Could we please do away with the function that after you win 2 games in a match, you get no option to repeat the match? It just gives the player less choice and when playing with randomly generated decks, if you want to play more than three games, you have to purposely lost the last one.
-slapshot5
-slapshot5
Edit: The problem is in Gui_WinLose.java about line 107:
restartButton.setEnabled(!model.match.isMatchWonByHuman());
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: Feature Requests Thread
by Sloth » 03 Sep 2011, 17:39
Good find. I think it's best to always enable it.slapshot5 wrote:
Edit: The problem is in Gui_WinLose.java about line 107:
restartButton.setEnabled(!model.match.isMatchWonByHuman());
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Feature Requests Thread
by slapshot5 » 03 Sep 2011, 18:25
What I described was the way it worked for as long as I can remember. However, I would not object to it being enabled all the time.Sloth wrote:Good find. I think it's best to always enable it.slapshot5 wrote:
Edit: The problem is in Gui_WinLose.java about line 107:
restartButton.setEnabled(!model.match.isMatchWonByHuman());
-slapshot5
- slapshot5
- Programmer
- Posts: 1391
- Joined: 03 Jan 2010, 17:47
- Location: Mac OS X
- Has thanked: 25 times
- Been thanked: 68 times
Re: Feature Requests Thread
by Accountancy » 04 Sep 2011, 04:08
That's what I'd like to see. I simply meant that the restart button should always be usable, I can't think of a reason for not letting the player restart a match.slapshot5 wrote:What I described was the way it worked for as long as I can remember. However, I would not object to it being enabled all the time.Sloth wrote:Good find. I think it's best to always enable it.slapshot5 wrote:
Edit: The problem is in Gui_WinLose.java about line 107:
restartButton.setEnabled(!model.match.isMatchWonByHuman());
-slapshot5
- Accountancy
- Posts: 230
- Joined: 14 Aug 2009, 12:39
- Has thanked: 22 times
- Been thanked: 2 times
Re: Feature Requests Thread
by Max mtg » 04 Sep 2011, 18:55
Last time I disabled it in order not to confuse the player who has won a match in quest mode and would like to just claim his reward (and not ocasionally hit restart to launch the match once more)Accountancy wrote:That's what I'd like to see. I simply meant that the restart button should always be usable, I can't think of a reason for not letting the player restart a match.
Maybe it should just be auto-clicked then? I mean once player won a match in quest mode, he is not even shown this window, but directly proceeds to receiving all prizes?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Feature Requests Thread
by Sloth » 04 Sep 2011, 19:18
Now that you mention this, I'm not sure why this button is enabled in quest mode anyway. If you start a match in quest mode you shouldn't be able to restart it until you win, or?Max mtg wrote:Last time I disabled it in order not to confuse the player who has won a match in quest mode and would like to just claim his reward (and not ocasionally hit restart to launch the match once more)Accountancy wrote:That's what I'd like to see. I simply meant that the restart button should always be usable, I can't think of a reason for not letting the player restart a match.
Maybe it should just be auto-clicked then? I mean once player won a match in quest mode, he is not even shown this window, but directly proceeds to receiving all prizes?
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Feature Requests Thread
by Max mtg » 04 Sep 2011, 19:32
It is because of your change in r10215 to make it always enabled.Sloth wrote:Now that you mention this, I'm not sure why this button is enabled in quest mode anyway. If you start a match in quest mode you shouldn't be able to restart it until you win, or?Max mtg wrote:Last time I disabled it in order not to confuse the player who has won a match in quest mode and would like to just claim his reward (and not ocasionally hit restart to launch the match once more)
Maybe it should just be auto-clicked then? I mean once player won a match in quest mode, he is not even shown this window, but directly proceeds to receiving all prizes?
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Feature Requests Thread
by Sloth » 05 Sep 2011, 18:49
What I meant is, that it shouldn't be available in quest mode (no matter if you win or not).Max mtg wrote:It is because of your change in r10215 to make it always enabled.Sloth wrote:Now that you mention this, I'm not sure why this button is enabled in quest mode anyway. If you start a match in quest mode you shouldn't be able to restart it until you win, or?
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Feature Requests Thread
by inb63 » 08 Sep 2011, 22:12
What about Kamigawa flip cards and the Innistrad transform mechanic? It would be so much fun to be able to use those cards in Forge 

Who is online
Users browsing this forum: No registered users and 31 guests