It is currently 12 Sep 2025, 12:18
   
Text Size

Innistrad Scripts

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Innistrad Scripts

Postby friarsol » 05 Sep 2011, 14:38

Max mtg wrote:I want to point to a fact that the current version of forge will not include card into database used by quests and deckeditor unless setinfo is specified. Such card will also be impossible to load from deck.
This has never been the case before. Why is that true now?
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Innistrad Scripts

Postby slapshot5 » 05 Sep 2011, 14:40

Is there a bug out there for this? Certainly, SetInfo is not needed in a basic constructed DeckEditor. I never really use quests, so I don't know about those.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Innistrad Scripts

Postby ArsenalNut » 05 Sep 2011, 14:43

inb63 wrote:
ArsenalNut wrote:#SetInfo:IND|Common|Empty
The official three-letter code for Innistrad is ISD
Scripts are now fixed.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Innistrad Scripts

Postby ArsenalNut » 05 Sep 2011, 14:52

friarsol wrote:
Max mtg wrote:I want to point to a fact that the current version of forge will not include card into database used by quests and deckeditor unless setinfo is specified. Such card will also be impossible to load from deck.
This has never been the case before. Why is that true now?
I found this using the latest code out of the repository. That's why I included the SetInfo in my post. I've been manually adding the field since the current SetInfo script won't handle Innistrad cards.

I related this change of importance of SetInfo to Max mtg in CardDb exception thread
http://www.slightlymagic.net/forum/viewtopic.php?f=52&t=5289&start=30.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Innistrad Scripts

Postby Max mtg » 05 Sep 2011, 14:59

friarsol wrote:
Max mtg wrote:I want to point to a fact that the current version of forge will not include card into database used by quests and deckeditor unless setinfo is specified. Such card will also be impossible to load from deck.
This has never been the case before. Why is that true now?
Since 10146, transition to CardDb and resolition of issue 157 it is true. A card must belong to a set, and all current cards actually do.

slapshot5 wrote:Is there a bug out there for this? Certainly, SetInfo is not needed in a basic constructed DeckEditor. I never really use quests, so I don't know about those.
-slapshot5
This is by design that card without a set cannot exist. With set in the setInfo line comes card's rarity, SVar:Rarity is deprecated (because rarity varies from set to set an cannot be a property of a card).

Basic constructed deckeditor, as well as all other editors, was switched to lightweight cards and different filters, that's why it is so fast now.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Innistrad Scripts

Postby slapshot5 » 05 Sep 2011, 15:17

Max mtg wrote:This is by design that card without a set cannot exist. With set in the setInfo line comes card's rarity, SVar:Rarity is deprecated (because rarity varies from set to set an cannot be a property of a card).

Basic constructed deckeditor, as well as all other editors, was switched to lightweight cards and different filters, that's why it is so fast now.
I understand the need for lightweight cards in DeckEditors. My eyes popped out of my head the first time I tried it the new fast way, and WOW.

But, I don't understand why this design requires SetInfo for the card to be included in the deck editor.

I'm pretty sure this is a perfectly valid .dck file:

Code: Select all
[metadata]
Name=drf-green
Deck Type=constructed
[main]
1 Llanowar Elves
2 Aquastrand Spider
[sideboard]
Nothing in that file requires SetInfo. And since a DeckEditor's main function is to provide a GUI for creating this file, this leads me back to the question of why SetInfo *needs* to be present to include in the DeckEditor.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Innistrad Scripts

Postby Max mtg » 05 Sep 2011, 15:25

slapshot5 wrote:But, I don't understand why this design requires SetInfo for the card to be included in the deck editor.

Nothing in that file requires SetInfo. And since a DeckEditor's main function is to provide a GUI for creating this file, this leads me back to the question of why SetInfo *needs* to be present to include in the DeckEditor.
Deckeditor needs rarity in SetInfo to display them in a list of cards, or would you like just to see blank fields for the cards in development?
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Innistrad Scripts

Postby slapshot5 » 05 Sep 2011, 15:27

Max mtg wrote:Deckeditor needs rarity in SetInfo to display them in a list of cards, or would you like just to see blank fields for the cards in development?
Blank/unknown/"?"/whatever. Whatever you think looks best.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: Innistrad Scripts

Postby Max mtg » 05 Sep 2011, 15:30

slapshot5 wrote:
Max mtg wrote:Deckeditor needs rarity in SetInfo to display them in a list of cards, or would you like just to see blank fields for the cards in development?
Blank/unknown/"?"/whatever. Whatever you think looks best.


-slapshot5
Ok, will be there soon
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Innistrad Scripts

Postby Max mtg » 05 Sep 2011, 15:38

10253
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Innistrad Scripts

Postby ArsenalNut » 05 Sep 2011, 18:35

Sloth wrote:
Iran wrote:I make this script for Endless Ranks of the Dead . I'm not sure this is 100% correct.
How can i claim this card? I could not.

Code: Select all
Name:Endless Ranks of the Dead
Cost:2 B B
Types:Enchantment
Text:no text
T:Mode$ Phase | Phase$ Upkeep | TriggerZones$ Battlefield | Execute$ TrigToken | TriggerDescription$
At the beginning of your upkeep, put X 2/2 black zombie creature tokens onto the battlefield, where X is half the number of the zombies you control, rounded down.
SVar:TrigToken:AB$Token | Cost$ 0 | TokenImage$ B 2 2 Zombie |  TokenAmount$ X | TokenName$ Zombie | TokenTypes$ Creature,Zombie | TokenOwner$ You | TokenPower$ 2 | TokenToughness$ 2 | TokenColors$ Black
SVar:X:Count$Valid Creature.zombie+YouCtrl/HalfDown
End
The script looks good Iran. You have to log yourself in the wiki (Username and Password is the same as for this forum) to edit the page.
The Phase trigger needs "ValidPlayer$ You" so it only trigger during the controllers upkeep phase. Otherwise it works. Cool when used with "Army of the Damned".
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Innistrad Scripts

Postby friarsol » 05 Sep 2011, 22:12

Max mtg wrote:
slapshot5 wrote:
Max mtg wrote:Deckeditor needs rarity in SetInfo to display them in a list of cards, or would you like just to see blank fields for the cards in development?
Blank/unknown/"?"/whatever. Whatever you think looks best.
Ok, will be there soon
Thanks for getting this fixed up so quickly Max. In general, SetInfo will exist, so it'll only be noticeable in the primary deck editor for the short amount of time cards are missing SetInfo.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Innistrad Scripts

Postby Iran » 06 Sep 2011, 03:38

Hellfish wrote:Olivia Voldaren is affected by a bug in the GainControl abilityfactory that is currently being looked into.
I think ArsenalNut make changes in GainControl AF. Would this fix the problem of Olivia Voldaren?
Iran
 
Posts: 251
Joined: 11 Jul 2011, 04:36
Has thanked: 61 times
Been thanked: 4 times

Re: Innistrad Scripts

Postby ArsenalNut » 06 Sep 2011, 04:13

Iran wrote:
Hellfish wrote:Olivia Voldaren is affected by a bug in the GainControl abilityfactory that is currently being looked into.
I think ArsenalNut make changes in GainControl AF. Would this fix the problem of Olivia Voldaren?
Yes, the rev I checked in fixed the problems with not returning all the controlled permanents. I used Olivia Voldaren as one of my test cases.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Innistrad Scripts

Postby ArsenalNut » 06 Sep 2011, 04:35

Some equipment for the Vampire hunter :)

Wooden Stake | Open
Name:Wooden Stake
ManaCost:2
Types:Artifact Equipment
Text:Equipped creature gets +1/+0.
K:eqPump 1:+1/+0
T:Mode$ Blocks | ValidCard$ Card.AttachedBy | ValidBlocked$ Creature.Vampire | Execute$ TrigDestroyBlocked | TriggerDescription$ Whenever equipped creature blocks or becomes blocked by a Vampire, destroy that creature. It can't be regenerated.
T:Mode$ Blocks | ValidCard$ Creature.Vampire | ValidBlocked$ Card.AttachedBy | Execute$ TrigDestroyBlocker | Secondary$ True | TriggerDescription$ Whenever equipped creature blocks or becomes blocked by a Vampire, destroy that creature. It can't be regenerated.
SVar:TrigDestroyBlocked:AB$Destroy | Cost$ 0 | Defined$ TriggeredAttacker | NoRegen$ True
SVar:TrigDestroyBlocker:AB$Destroy | Cost$ 0 | Defined$ TriggeredBlocker | NoRegen$ True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/wooden_stake.jpg
End

The AI was not very bright about blocking creatures equipped with Wooden Stake. It blocked my Devout Monk equipped with Wooden Stake with an Arrogant Bloodlord.

Blazing Torch is a reprint from Odyssey so I am going to go ahead and check it into the repository.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 32 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 32 users online :: 0 registered, 0 hidden and 32 guests (based on users active over the past 10 minutes)
Most users ever online was 7967 on 09 Sep 2025, 23:08

Users browsing this forum: No registered users and 32 guests

Login Form