CardDb exception

[Max mtg]

The "NEW" column is back in shop AND deckeditor for quest mode.

[Sloth]

The "NEW" column is back in shop AND deckeditor for quest mode.

Good work Max. This feature is much appreciated (and much more obvious now).

[friarsol]

10182 - added a column with number of decks.
May I close issue 102 with that?

Yea that should work.

[ArsenalNut]

Reading the Innistrad script thread, reminded me about the missing SetInfo exception. I know the SetInfo line is in the process of being deprecated. Is that going to be done before the next biweekly release?

The current release doesn't need SetInfo line for testing card scripts like Innistrad but a release based on the current trunk would. This might cause a lot of crash reports if people aren't aware of the change.

[Max mtg]

Reading the Innistrad script thread, reminded me about the missing SetInfo exception. I know the SetInfo line is in the process of being deprecated. Is that going to be done before the next biweekly release?

The current release doesn't need SetInfo line for testing card scripts like Innistrad but a release based on the current trunk would. This might cause a lot of crash reports if people aren't aware of the change.

If we are loading card data from cardname.txt, SetInfo should not be ever deprecated. It is a mandatory field, no card without it would show in deckeditor. And it does not, there is an exception thrown during load of such cards.

A way to add support of Innistrad is like this:
1. Add a line to res\blockdata\setdata.txt

Code: Select all

Index:78|Code2:ISD|Code3:ISD|Name:Innistrad

2. Add aprropriate SetInfo to the cards you are developing

UPD: already done #1

Did I get you right that a clear error message should be added there instead of just throwing?

[ArsenalNut]

If we are loading card data from cardname.txt, SetInfo should not be ever deprecated. It is a mandatory field, no card without it would show in deckeditor. And it does not, there is an exception thrown during load of such cards.

I may have miss interpreted FriarSol intentions about SetInfo. He was only asking about the URL part of the SetInfo. (See http://www.slightlymagic.net/forum/viewtopic.php?f=52&t=5272)

Did I get you right that a clear error message should be added there instead of just throwing?

If the SetInfo is going to be required for card scripts in future releases, I think a clear error message is better than throwing an exception which generates a crash report. Can you setup it up so that cards with missing info are just ignored and the user is given a message that the card was ignored?

[Max mtg]

friarsol meant only the URL part of the SetInfo line (and I agree that URL is optional here), but the set name and rarity (and number of images if the card has more than one) are to be kept.

Ok, I'll make something about that

[friarsol]

While I'm fine with the Rarity SVar being removed, I don't think that SetInfo should be required, as this is an easy way to cause incorrect Rarity (or Set data) to the cards. We have an automated script that adds this data, but the script cannot be run for cards in the latest set until it exists in magiccards.info.

Instead of ignoring cards without SetInfo, I'd much prefer these cards to be listed as Unknown for both Rarity and Set if all SetInfo data is missing, so they can appear in the deck editors. Since running the SetInfoScript shouldn't be necessary for the normal Card Scripting process.

[Chris H.]

With our new nightly builds I try to run the setInfoScript.py script and the oracleScript.py script right before I run the nightly build script.

People enjoy scripting the new card sets. We want to encourage them to play test their card scripts before they are submitted. These people should not have to install Python in order to run these scripts themselves.

[Max mtg]

People enjoy scripting the new card sets. We want to encourage them to play test their card scripts before they are submitted. These people should not have to install Python in order to run these scripts themselves.

viewtopic.php?f=52&t=5315&start=22

[Chris H.]

People enjoy scripting the new card sets. We want to encourage them to play test their card scripts before they are submitted. These people should not have to install Python in order to run these scripts themselves.

viewtopic.php?f=52&t=5315&start=22

`
Ah, thank you for the quick fix.