Who is planning to do what?

[Hellfish]

The protection issue bugged me enough to rob me of sleep, but a quick test dispelled that worry as well. Had an Aku Djinn and a Wall of Putrid Flesh out, cast Wojek Siren on Aku Djinn, Wall of Putrid Flesh correctly didn't gain the pump.

[friarsol]

The protection issue bugged me enough to rob me of sleep, but a quick test dispelled that worry as well. Had an Aku Djinn and a Wall of Putrid Flesh out, cast Wojek Siren on Aku Djinn, Wall of Putrid Flesh correctly didn't gain the pump.

Shouldn't the pump still be granted? Overrun applies to creatures with Pro. Green. Wrath of God can kill a Black Knight ?

[Hellfish]

Hmm, I was thinking of another case, that of the damagedealing radiance cards vs protection. In that case the effect shouldn't happen, but in this case you are correct. See, I should've gone to sleep instead . I have a solution brewing in my head,though, I will tackle this tomorrow.

[friarsol]

Hmm, I was thinking of another case, that of the damagedealing radiance cards vs protection. In that case the effect shouldn't happen, but in this case you are correct. See, I should've gone to sleep instead . I have a solution brewing in my head,though, I will tackle this tomorrow.

I think the Entity.Damage code itself should be able to handle protection properly. The AF should just try to do it, to whatever it thinks should get it.

[ArsenalNut]

I still cannot understand the whole mechanics for the spells pipeline, so I'll switch to deckbuilding. I would like to implement a special form for import: you copy-paste a deck as seen on some website to the left part of the form and see what forge has understood in a list on the right.

If a deck is well-recognized, player hits accept, otherwise tries to correct the text or enter cards manually (by selecting them from a list)

I like this idea. That's how I got started with Forge, I wanted to play some of the decks on the Magic website but didn't have the cards. I started looking at parsing the html page source but I think your idea of a copy and paste is better. Parsing plain text descriptions is more generic than trying make an html parser for each website's deck format.

[Max mtg]

@ArsenalNut, you can give it a try since 10593 - but the very import is still not implemeneted.

[ArsenalNut]

@ArsenalNut, you can give it a try since 10593 - but the very import is still not implemeneted.

First impression, Very Nice!!! It worked very well for the deck structure used by WotC's website.

I tried it on three different websites:
1) http://www.wizards.com/Magic/Magazine/Article.aspx?x=mtg/daily/deck/803
It flagged the missing cards nicely but it also flagged the line "15 sideboard cards" as 15 missing cards.

2) http://tappedout.net/mtg-decks/chains-of-ohgod/
This is a deck SlapShot linked on the Forge Deck forum. It basically didn't work for this site but to be fair the text that got pasted looks radically different from what's displayed on the webpage. (Sorry I don't know how to make images to show the difference)

3) http://www.slightlymagic.net/forum/viewtopic.php?f=48&t=5363
This is SlapShot's post where I found link #2. Using this deck list, all the real cards were flagged correctly but "60 Total Cards" and "25 Land" were flagged as 85 cards missing.

Will the deck importer keep the sideboard information? I know sideboarding isn't supported in the constructed games yet, but it would nice if the information was still there for future use.

I don't read very many Magic websites so somebody else might be able to suggest other sites to try.

[Hellfish]

Hmm, I was thinking of another case, that of the damagedealing radiance cards vs protection. In that case the effect shouldn't happen, but in this case you are correct. See, I should've gone to sleep instead . I have a solution brewing in my head,though, I will tackle this tomorrow.

I think the Entity.Damage code itself should be able to handle protection properly. The AF should just try to do it, to whatever it thinks should get it.

I committed some code that separates targeted from untargeted cards to apply the effect to, at least in AF_Pump. I will keep hacking away at this, for the other radiance effects.

[Max mtg]

@ArsenalNut,
I made some tweaks to recognize better sources #1 & #3
As for #2 - I copied the following list from tapped-out which recognized as it should have.

Code: Select all

Categorize by:
Score: 23
Land (25)

    4x Creeping Tar Pit
    11x Island
    10x Swamp

Instant (10)

    4x Dark Ritual
    2x Evacuation
    4x Wheel and Deal

Enchantment (8)

    3x Chains of Mephistopheles
    3x Forced Fruition
    2x Leyline of the Void

Sorcery (6)

    2x Damnation
    4x Sign in Blood

Artifact (7)

    3x Howling Mine
    2x Panoptic Mirror
    2x Teferi's Puzzle Box

Creature (4)

    2x Kozilek, Butcher of Truth
    2x Magus of the Jar

[ZzzzSleep]

@ArsenalNut, you can give it a try since 10593 - but the very import is still not implemeneted.

First impression, Very Nice!!! It worked very well for the deck structure used by WotC's website.

1) http://www.wizards.com/Magic/Magazine/Article.aspx?x=mtg/daily/deck/803
2) http://tappedout.net/mtg-decks/chains-of-ohgod/
3) http://www.slightlymagic.net/forum/viewtopic.php?f=48&t=5363

<snip!>
I don't read very many Magic websites so somebody else might be able to suggest other sites to try.

There's http://www.starcitygames.com.
Here's an example decklist in their format (just copied and pasted from my browser).

Toolbox Loam
Featured by Gene Richtsmeier on 2011-09-25 (Legacy)
Print this deck!
Maindeck:

Artifacts
4 Chalice of the Void
4 Mox Diamond

Creatures
4 Dark Confidant
3 Knight of the Reliquary
1 Scavenging Ooze
2 Tarmogoyf
1 Terravore

Instants
3 Dismember

Sorceries
4 Burning Wish
2 Devastating Dreams
3 Green Sun's Zenith
3 Life from the Loam

Lands
1 Badlands
1 Bayou
1 Bloodstained Mire
1 Bojuka Bog
3 Forgotten Cave
1 Maze of Ith
1 Plateau
1 Savannah
2 Taiga
3 Tranquil Thicket
4 Wasteland
4 Wooded Foothills

Land Creatures
1 Dryad Arbor

Legendary Lands
1 Karakas
1 Volrath's Stronghold

Sideboard:

2 Phyrexian Metamorph
2 Choke
1 Gaddock Teeg
1 Devastating Dreams
1 Green Sun's Zenith
1 Hull Breach
1 Life from the Loam
1 Perish
1 Pulverize
1 Retribution of the Meek
1 Reverent Silence
1 Vindicate
1 The Tabernacle at Pendrell Vale

[Max mtg]

@ZzzzSleep, this recognized fine.

I've commited a version that allows player to transfer cards to deckeditor.
Known bugs:
* Sideboard is lost (the constructed mode sideboard is not supported by the game at all)
* The imported cards simply replace the contents of the deck currently open, no "deck is not saved" notice.

I'll improve the deck document model next.

[ArsenalNut]

@ArsenalNut,
I made some tweaks to recognize better sources #1 & #3
As for #2 - I copied the following list from tapped-out which recognized as it should have.

Code: Select all

Categorize by:
Score: 23
Land (25)

    4x Creeping Tar Pit
    11x Island
    10x Swamp

Instant (10)

    4x Dark Ritual
    2x Evacuation
    4x Wheel and Deal

Enchantment (8)

    3x Chains of Mephistopheles
    3x Forced Fruition
    2x Leyline of the Void

Sorcery (6)

    2x Damnation
    4x Sign in Blood

Artifact (7)

    3x Howling Mine
    2x Panoptic Mirror
    2x Teferi's Puzzle Box

Creature (4)

    2x Kozilek, Butcher of Truth
    2x Magus of the Jar

Weird, here's what it looks like when I copy and paste from tappedout.net

Code: Select all

Categorize by:
Score: 23
Land (25)

    * 4x Creeping Tar Pit
      MTG Card: Creeping Tar Pit
      MTG Card: Creeping Tar Pit
    * 11x Island
      MTG Card: Island
      MTG Card: Island
    * 10x Swamp
      MTG Card: Swamp
      MTG Card: Swamp

Instant (10)

    * 4x Dark Ritual
      MTG Card: Dark Ritual
      MTG Card: Dark Ritual
    * 2x Evacuation
      MTG Card: Evacuation
      MTG Card: Evacuation
    * 4x Wheel and Deal
      MTG Card: Wheel and Deal
      MTG Card: Wheel and Deal

Enchantment (8)

    * 3x Chains of Mephistopheles
      MTG Card: Chains of Mephistopheles
      MTG Card: Chains of Mephistopheles
    * 3x Forced Fruition
      MTG Card: Forced Fruition
      MTG Card: Forced Fruition
    * 2x Leyline of the Void
      MTG Card: Leyline of the Void
      MTG Card: Leyline of the Void

Sorcery (6)

    * 2x Damnation
      MTG Card: Damnation
      MTG Card: Damnation
    * 4x Sign in Blood
      MTG Card: Sign in Blood
      MTG Card: Sign in Blood

Artifact (7)

    * 3x Howling Mine
      MTG Card: Howling Mine
      MTG Card: Howling Mine
    * 2x Panoptic Mirror
      MTG Card: Panoptic Mirror
      MTG Card: Panoptic Mirror
    * 2x Teferi's Puzzle Box
      MTG Card: Teferi's Puzzle Box
      MTG Card: Teferi's Puzzle Box

Creature (4)

    * 2x Kozilek, Butcher of Truth
      MTG Card: Kozilek, Butcher of Truth
      MTG Card: Kozilek, Butcher of Truth
    * 2x Magus of the Jar


I am using Firefox 3.6.16 as my browser. I wonder if that makes a difference.

[Max mtg]

Weird, here's what it looks like when I copy and paste from tappedout.net

I am using Firefox 3.6.16 as my browser. I wonder if that makes a difference.

Not sure. I tried IE9 - got almost the same as originally with firefox 6

[Hellfish]

Radiance should be good now. Those 7 extra cards pushed Ravnica over 70%

[jeffwadsworth]

Radiance should be good now. Those 7 extra cards pushed Ravnica over 70%

Rollin' rollin' rollin'...