It is currently 26 Aug 2025, 23:24
   
Text Size

Magic Data

General Discussion of the Intricacies

Moderator: CCGHQ Admins

Re: Magic Data

Postby Max mtg » 29 Sep 2011, 22:26

Arch, please note that they HAVE added the color indicator field, which holds a color to use instead of the one derived from card's face manacost (if any)

http://gatherer.wizards.com/Pages/Card/ ... eid=221212
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Magic Data

Postby Arch » 01 Oct 2011, 14:40

Updated, see first post.
User avatar
Arch
Programmer
 
Posts: 206
Joined: 04 Jul 2009, 09:35
Has thanked: 0 time
Been thanked: 15 times

Re: Magic Data

Postby Max mtg » 07 Oct 2011, 00:32

Thanks a lot, Arch!

I've been working with the xml you've provided. It turned out, that some cards described in cards.xml are not linked to any set via meta.xml. I failed to find them on gatherer or magiccards.info too. Where did they come from?
Code: Select all
Arden Angel
Ashuza's Breath
Aswan Jaguar
Call from the Grave
Camato Scout
Celestine Reef
Drench the Soil in Their Blood
Faerie Dragon
Gem Bazaar
Goblin Polka Band
Hapato's Might
Horizon Boughs
Imprison This Insolent Wretch
Lydari Druid
Lydari Elephant
Mirrored Depths
Murgish Cemetery
Necropolis of Azar
Orcish Catapult
Pandora's Box
Perhaps You've Met My Cohort
Plots That Span Centuries
Power Struggle
Prismatic Dragon
Rainbow Knights
Saji's Torrent
Tember City
Tornellan Protector
Velican Dragon
Whimsy
Your Inescapable Doom
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Magic Data

Postby MageKing17 » 07 Oct 2011, 03:06

Max mtg wrote:I've been working with the xml you've provided. It turned out, that some cards described in cards.xml are not linked to any set via meta.xml. I failed to find them on gatherer or magiccards.info too. Where did they come from?
Code: Select all
Arden Angel
Ashuza's Breath
Aswan Jaguar
Call from the Grave
Camato Scout
Celestine Reef
Drench the Soil in Their Blood
Faerie Dragon
Gem Bazaar
Goblin Polka Band
Hapato's Might
Horizon Boughs
Imprison This Insolent Wretch
Lydari Druid
Lydari Elephant
Mirrored Depths
Murgish Cemetery
Necropolis of Azar
Orcish Catapult
Pandora's Box
Perhaps You've Met My Cohort
Plots That Span Centuries
Power Struggle
Prismatic Dragon
Rainbow Knights
Saji's Torrent
Tember City
Tornellan Protector
Velican Dragon
Whimsy
Your Inescapable Doom
Aswan Jaguar, Call from the Grave, Faerie Dragon, Gem Bazaar, Goblin Polka Band, Necropolis of Azar, Orcish Catapult, Pandora's Box, Power Struggle, Prismatic Dragon, Rainbow Knights, and Whimsy are from the Microprose game. Drench The Soil in Their Blood, Imprison This Insolent Wretch, Perhaps You've Met My Cohort, Plots That Span Centuries, and Your Inescapable Doom are Archenemy cards that weren't released with the actual Archenemy set. Arden Angel, Ashuza's Breath, Comato Scout, Hapato's Might, Lydari Druid, Lydari Elephant, Murgish Cemetary, Saji's Torrent, Tornellan Protector, and Velican Dragon are from the Dreamcast game.
User avatar
MageKing17
Programmer
 
Posts: 473
Joined: 12 Jun 2008, 20:40
Has thanked: 5 times
Been thanked: 9 times

Re: Magic Data

Postby Max mtg » 07 Oct 2011, 09:56

I am not sure if these cards should be present in XML, since even gatherer does not support them.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Magic Data

Postby Huggybaby » 07 Oct 2011, 15:47

Well, it is called Magic Data, not Gatherer Data. ;)
User avatar
Huggybaby
Administrator
 
Posts: 3227
Joined: 15 Jan 2006, 19:44
Location: Finally out of Atlanta
Has thanked: 748 times
Been thanked: 601 times

Re: Magic Data

Postby Arch » 07 Oct 2011, 16:45

Max mtg wrote:I am not sure if these cards should be present in XML, since even gatherer does not support them.
I could see some arguments for removing the dreamcast and microprose cards as they don't seem to be recognized in general. The archenemy cards will definitely stay as well as the planechase cards. (Pretty sure there's some promo planes in there.)

I'm not going to remove anything without a good reason though. There would basically have to be a negative impact on the data for me to do that. That gatherer is not supporting them is not good enough.
User avatar
Arch
Programmer
 
Posts: 206
Joined: 04 Jul 2009, 09:35
Has thanked: 0 time
Been thanked: 15 times

Re: Magic Data

Postby Huggybaby » 07 Oct 2011, 16:52

That's a good decision, in line with our document-everything-then-take-what-you-need philosophy.
User avatar
Huggybaby
Administrator
 
Posts: 3227
Joined: 15 Jan 2006, 19:44
Location: Finally out of Atlanta
Has thanked: 748 times
Been thanked: 601 times

Re: Magic Data

Postby Max mtg » 07 Oct 2011, 23:30

Some of these cards were disobeying common magic grammar rules, so I removed them from (my local) parsing anyway.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Magic Data

Postby MageKing17 » 08 Oct 2011, 02:11

Max mtg wrote:Some of these cards were disobeying common magic grammar rules, so I removed them from (my local) parsing anyway.
I think all of the Microprose and Dreamcast cards disobey common magic grammar rules (a.k.a. "templating") because they weren't created by Wizards of the Coast, were written a long time ago, and haven't been updated because they're not a part of their database.
User avatar
MageKing17
Programmer
 
Posts: 473
Joined: 12 Jun 2008, 20:40
Has thanked: 5 times
Been thanked: 9 times

Re: Magic Data

Postby silly freak » 08 Oct 2011, 16:26

to resolve this issue, what about abbing some kind of <source> to the data, which is generally gatherer, but might be microprose or some other? this would enable filtering and hopefully make everyone happy...
___

where's the "trust me, that will work!" switch for the compiler?
Laterna Magica - blog, forum, project, 2010/09/06 release!
silly freak
DEVELOPER
 
Posts: 598
Joined: 26 Mar 2009, 07:18
Location: Vienna, Austria
Has thanked: 93 times
Been thanked: 25 times

Re: Magic Data

Postby Marek14 » 08 Oct 2011, 18:59

MageKing17 wrote:
Max mtg wrote:Some of these cards were disobeying common magic grammar rules, so I removed them from (my local) parsing anyway.
I think all of the Microprose and Dreamcast cards disobey common magic grammar rules (a.k.a. "templating") because they weren't created by Wizards of the Coast, were written a long time ago, and haven't been updated because they're not a part of their database.
Actually, *I* have tried to update them - but it doesn't always get the best results, since sometimes I need to guess at the intended functionality... and I don't have any specific data about how Faerie Dragon and Whimsy are supposed to be working, I only managed to find a list of effects and when I asked about the algorithms at Manalink part of the forums, they realized that I'm crazy :)
Marek14
Tester
 
Posts: 2773
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 303 times

Re: Magic Data

Postby Max mtg » 09 Oct 2011, 02:05

silly freak wrote:to resolve this issue, what about abbing some kind of <source> to the data, which is generally gatherer, but might be microprose or some other? this would enable filtering and hopefully make everyone happy...
It would be enough just to bind those cards to their respective sets (add some lines to meta.xml), one of those sets is ASTRAL... other ones can be also found with some help from more dedicated players.
So that users of XML would be aware that cards from certain sets are not suppoted by Wizards.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Magic Data

Postby Arch » 09 Oct 2011, 07:55

Max mtg wrote:It would be enough just to bind those cards to their respective sets (add some lines to meta.xml), one of those sets is ASTRAL... other ones can be also found with some help from more dedicated players.
So that users of XML would be aware that cards from certain sets are not suppoted by Wizards.
This is how it should be done. Astral and Dreamcast are already part of the setinfo.xml but I guess that the mapping I'm doing doesn't properly match these cards. I'll add that to the buglist.
User avatar
Arch
Programmer
 
Posts: 206
Joined: 04 Jul 2009, 09:35
Has thanked: 0 time
Been thanked: 15 times

Re: Magic Data

Postby Max mtg » 09 Oct 2011, 15:37

Found another potential bug - card name is Planeswalker's Mischief.
http://gatherer.wizards.com/Pages/Card/ ... seid=25887

The text "(If it has X in its mana cost, X is 0.)" is written in italics on gatherer and is a general hint on rules, and therefore it should go to rules reminder instead of being kept in the rule body.
Thanks.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

PreviousNext

Return to Magic Rules Engine Programming

Who is online

Users browsing this forum: No registered users and 5 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 5 users online :: 0 registered, 0 hidden and 5 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 5 guests

Login Form