Know any UI Developers? (Bounty Inside)

[Sloth]

Glad you like them I just tested and I like how you positioned them. Great job. The only issue I came across is cosmetic and probably not worth looking into even, but if there is more than one type of counter on the card, the lowest number determines the image used. Perhaps it should be the highest instead?

After thinking about it, I went for the sum of all counters. I hope you are ok with that.

[moomarc]

Glad you like them I just tested and I like how you positioned them. Great job. The only issue I came across is cosmetic and probably not worth looking into even, but if there is more than one type of counter on the card, the lowest number determines the image used. Perhaps it should be the highest instead?

After thinking about it, I went for the sum of all counters. I hope you are ok with that.

That's even better. I was just concerned that users might take the visual clue and think that a card has too few counters and make poor decisions based on that (without looking at the card detail panel). So good call there!

[moomarc]

@Rob: There's some strange behaviour when using randomly selected decks in constructed mode with the new GUI. If you've already played a constructed game before with decks that you've picked, then start a new one with Random for both Human and Ai, the window that pops up will list the last deck used by each player, instead of the new random pick that is then used in the match.

If it is the first match after starting Forge, the application crashes with the following NullPointerException:

Code: Select all

Version:
Forge version SVN, build ID 10923

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_26 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.view.swing.Gui_HomeScreen.doDeckLogic(Gui_HomeScreen.java:997)
   at forge.view.swing.Gui_HomeScreen.doStartGame(Gui_HomeScreen.java:1444)
   at forge.view.swing.Gui_HomeScreen.access$27(Gui_HomeScreen.java:1437)
   at forge.view.swing.Gui_HomeScreen$16.actionPerformed(Gui_HomeScreen.java:508)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)

The final scenario is if playing with a Random deck after playing with generated decks, the pop up says 'You are playing with: null"

So somehow the code for random decks is looking for the last used deck name for the pop-up. The correct name and deck is shown in-game though. I tested in the regular UI to be sure but things work normally there.

One other small request. Is it possible to have the decks listed alphabetically as with the regular UI?

Is there any progress on getting the Sealed and Draft modes working in the new GUI yet?

[slapshot5]

@Rob and moonmarc - Can we add an Exit button of some kind on the new Home Screen? Different window managers handle closing/terminating applications differently, so it would be nice if we provided something so the user can exit from the home screen.

Thanks,
-slapshot5

[moomarc]

@Rob and moonmarc - Can we add an Exit button of some kind on the new Home Screen? Different window managers handle closing/terminating applications differently, so it would be nice if we provided something so the user can exit from the home screen.

@Rob, just let me know if you need me to do anything. Also, how many languages do we have support for? If I can get translations for some of the graphics buttons I can make some replacement packs for a few of the languages.

[slapshot5]

Also, how many languages do we have support for? If I can get translations for some of the graphics buttons I can make some replacement packs for a few of the languages.

We have English and German language files. The German can all be found in res/lang/de.properties

-slapshot5

[moomarc]

Also, how many languages do we have support for? If I can get translations for some of the graphics buttons I can make some replacement packs for a few of the languages.

We have English and German language files. The German can all be found in res/lang/de.properties

Thanks! I'll try get a button set out for this.

[Rob Cashwalker]

Marc, yeah, throw together an Exit Button.. I'll see if I can add it soon.

[slapshot5]

Can we center the Gui_HomeScreen? Should just be a matter of adding:

Code: Select all

GuiUtils.centerFrame(gHS);

near the end of Gui_HomeScreen.initialize()

BTW - Is there a better place to post bugs/suggestions about Gui_HomeScreen? Seems like it deserves its own thread in the Developer's section...

-slapshot5