AbilityFactory TODO list

[friarsol]

I'm gonna take a crack at AF_Attach. My first iteration will be just for casting Auras. I know Rob and I had a discussion at some point a while back, so each Aura will come with a parameter to tell the AI how it should be doing its logic. I'll be porting & updating some of the Logic that exists in enPump/enCurse/enControl. I think this will help a lot with actually trying to track down what's going on with Auras in general.

[Chris H.]

I would not mind seeing an end to the enPump/enCurse/enControl keywords. It served it's purpose back in the early days of "proof of concept" coding while Rob's idea of scripting cards was being developed and advanced. Any plans should probably also eventually include the eqPump keyword.

What about the generic aura keyword? Your plans for an AF_Attach might be able to replace this code at the same time.

[friarsol]

I know this isn't AF specifically, but I just added a new Issue (http://code.google.com/p/cardforge/issues/detail?id=138) with dream that someone will try their hand at Converting Static Effects to a system like AFs and Triggers and figured I'd repost here for more visibility.

[friarsol]

Speaking of Attach and Static, is there any functions that exist that I can pass in a card, and get what values are being pumped for Power, Toughness, or Keywords? (Since stPumpEnchanted would be replacing enPump I still need to grab these values for the AI checks.) It seems like this would be a common need, but as far as I can tell the function isn't separated from the calculation code.

Similarly, is there a function that compares a Keywords "Stackability"? Ex. Multiple instances of Flanking are stackable (non-Flanking Blockers get -X/-X). But If I give a Serra Angel Flying it doesn't get to Fly higher than the other Flyers.

[Sloth]

Similarly, is there a function that compares a Keywords "Stackability"? Ex. Multiple instances of Flanking are stackable (non-Flanking Blockers get -X/-X). But If I give a Serra Angel Flying it doesn't get to Fly higher than the other Flyers.

Use isStackingKeyword in CardUtil.

I know this isn't AF specifically, but I just added a new Issue (http://code.google.com/p/cardforge/issues/detail?id=138) with dream that someone will try their hand at Converting Static Effects to a system like AFs and Triggers and figured I'd repost here for more visibility.

I will try to code this. I was thinking about static effects a lot recently anyway. I will start a new topic called StaticEffectFactory.

[slapshot5]

I'm working on ProtectionAll at the moment.

-slapshot5

[slapshot5]

Just a heads up that after a long wait, AF_Charm is checked in. You can use it something like this:

Code: Select all

A:SP$ Charm | Cost$ B | Choices$ DBDamage,DBPump,DBTap | SpellDescription$ Choose one - CARDNAME deals 1 damage to target creature and you gain 1 life; or target creature gains first strike until end of turn; or tap target creature.
SVar:DBDamage:DB$ DealDamage | ValidTgts$ Creature | TgtPrompt$ Select target creature to deal damage | NumDmg$ 1 | SubAbility$ DBGain | SpellDescription$ CARDNAME deals 1 damage to target creature and you gain 1 life.
SVar:DBGain:DB$ GainLife | Defined$ You | LifeAmount$ 1
SVar:DBPump:DB$ Pump | ValidTgts$ Creature | TgtPrompt$ Select target creature to gain First Strike | KW$ First Strike | SpellDescription$ Target creature gains first strike until end of turn.
SVar:DBTap:DB$ Tap | ValidTgts$ Creature | TgtPrompt$ Select target creature to tap | SpellDescription$ Tap target creature.


Two remaining items here:
1. The Commands are not yet supported. (i.e. the CharmNum$ param with a number > 1)
2. AI is not yet implemented

-slapshot5

[Sloth]

Just a heads up that after a long wait, AF_Charm is checked in. You can use it something like this:

Two remaining items here:
1. The Commands are not yet supported. (i.e. the CharmNum$ param with a number > 1)
2. AI is not yet implemented

-slapshot5

What I expected from AF charm was to be used on triggered abilities. Is there a way to make this work?

Example:

| Open

Name:Inquisitor Exarch
ManaCost:W W
Types:Creature Cleric
Text:no text
PT:2/2
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Card.Self | Execute$ TrigCharm | TriggerDescription$ When CARDNAME enters the battlefield, choose one - You gain 2 life; or target opponent loses 2 life.
SVar:TrigCharm:AB$ Charm | Cost$ 0 | Choices$ DBGain,DBLose | SpellDescription$ Choose one - You gain 2 life; or target opponent loses 2 life.
SVar:DBGain:DB$ GainLife | Defined$ You | LifeAmount$ 2 | SpellDescription$ You gain 2 life.
SVar:DBLose:DB$ LoseLife | Defined$ You | LifeAmount$ 2 | ValidTgts$ Opponent | SpellDescription$ Target opponent loses 3 life. | SpellDescription$ Target opponent loses 2 life.
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/inquisitor_exarch.jpg
End

[slapshot5]

It's supposed to work. Doesn't it? What are you seeing?

-slapshot5

[Sloth]

It's supposed to work. Doesn't it? What are you seeing?

-slapshot5

The trigger fires, the ability goes on the stack, but does nothing.

[Hellfish]

I think the problem is that Triggers use gameAction.playSpellAbility_NoStack, which doesn't handle charms at all,rather than gameAction.playSpellAbility. I'll try to take care of it.

[slapshot5]

I think the problem is that Triggers use gameAction.playSpellAbility_NoStack, which doesn't handle charms at all,rather than gameAction.playSpellAbility. I'll try to take care of it.

Hellfish,

I can take care of this tonight after work. I realized what the problem was right after I asked the question. I've already got a fix in mind.

-slapshot5

[Hellfish]

Okay, cool!

EDIT: Just thought of something; Will there be support for an entwine parameter?

[slapshot5]

Okay, cool!

EDIT: Just thought of something; Will there be support for an entwine parameter?

I've got Charm working in Triggers now, but I'm still debugging some problems with Defined$. I assume that problem is because I set up SubAbilities after the AF processing, but I'll have to dig into to see how to fix it.

Entwine - Hadn't thought of it recently (I guess I did consider that a couple months ago when I first thought about this.) Once I get Defined and Triggers working, I'll look into it.

-slapshot5

[slapshot5]

Well, I'm a couple steps closer to Inquisitor Exarch. Charms are now chosen from Triggers, and Defined works. But targeting when used with a trigger doesn't.

I think the Charm code needs to be added earlier in the Trigger code, but I'm not sure where the targeting takes place.

-slapshot5