Mulitstate cards test drive
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Mulitstate cards test drive
by Hellfish » 20 Oct 2011, 21:53
EDIT: Screw preservation.
Take 2, this time with Characteristics!
The way it works this time is that a Card can have one OR two CardCharacteristic objects. These objects contain Name, Type, ManaCost and everything else that would change between states of multistate cards. Card.getName(),getType() etc. all delegate to the currently active CardCharacteristic object. No more swapping cards in and out of the game, all that happens now is an Integer changes 1->0 or 0->.
I'd like you to keep an especially close eye on Copy/Clone effects on Flip or Doublefaced cards. Also try the Deck Editor.
Patch (for r11379,): http://www.mediafire.com/?a1hb6yydhlsa3jg
Awww yeah, full archive incoming!
http://www.mediafire.com/?jjfjj5u6lzli6jb
UPDATE:Fixes unblocked attackers crash.
Obviously, please keep bug reports in this thread.
Take 2, this time with Characteristics!
The way it works this time is that a Card can have one OR two CardCharacteristic objects. These objects contain Name, Type, ManaCost and everything else that would change between states of multistate cards. Card.getName(),getType() etc. all delegate to the currently active CardCharacteristic object. No more swapping cards in and out of the game, all that happens now is an Integer changes 1->0 or 0->.
I'd like you to keep an especially close eye on Copy/Clone effects on Flip or Doublefaced cards. Also try the Deck Editor.
Patch (for r11379,): http://www.mediafire.com/?a1hb6yydhlsa3jg
Awww yeah, full archive incoming!
http://www.mediafire.com/?jjfjj5u6lzli6jb
UPDATE:Fixes unblocked attackers crash.
Obviously, please keep bug reports in this thread.
Last edited by Hellfish on 24 Oct 2011, 19:43, edited 17 times in total.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by jeffwadsworth » 20 Oct 2011, 21:55
WOOT!! Never thought I would see anything done on this one.
- jeffwadsworth
- Super Tester Elite
- Posts: 1172
- Joined: 20 Oct 2010, 04:47
- Location: USA
- Has thanked: 287 times
- Been thanked: 70 times
Re: Mulitstate cards test drive
by Hellfish » 20 Oct 2011, 22:04
It's not out of the woods yet, it's gotta survive THE TWO TRIALS OF USABILITY AND MAINTAINABILITY! (ominous echo)
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by jeffwadsworth » 20 Oct 2011, 22:45
Screeching Bats transforms into Stalking Vampire. It has summoning sickness. To my knowledge, it should not.
Playing with Kenzo the Hardhearted that was correctly flipped following it delivering damage to a creature that died on the previous turn. I attacked with it and was blocked by an Ancient Hydra. This error popped up:
Playing with Kenzo the Hardhearted that was correctly flipped following it delivering damage to a creature that died on the previous turn. I attacked with it and was blocked by an Ancient Hydra. This error popped up:
- | Open
- jeffwadsworth
- Super Tester Elite
- Posts: 1172
- Joined: 20 Oct 2010, 04:47
- Location: USA
- Has thanked: 287 times
- Been thanked: 70 times
Re: Mulitstate cards test drive
by Hellfish » 21 Oct 2011, 08:19
Thanks,Jeff. Fixed those two, here's a new patch (for r11320)
EDIT: Removed link, newer patch forthcoming which fixes changing state during combat.
EDIT: <see first post>
Includes Cloistered Youth / Unholy Fiend and AF_ChangeStateAll and Moonmist.
EDIT:Will keep patch updates in the first post.
EDIT: Removed link, newer patch forthcoming which fixes changing state during combat.
EDIT: <see first post>
Includes Cloistered Youth / Unholy Fiend and AF_ChangeStateAll and Moonmist.
EDIT:Will keep patch updates in the first post.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by Hellfish » 21 Oct 2011, 12:21
New patch, see first post.
Added condition parameters for use with ISD Werewolves. Added Gatstaf Shepherd / Gatstaf Howler as an example. Alternate state card images now work.
Added condition parameters for use with ISD Werewolves. Added Gatstaf Shepherd / Gatstaf Howler as an example. Alternate state card images now work.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by jeffwadsworth » 21 Oct 2011, 15:10
I believe Moonmist should be an effect. Right now, it affects cards that were present when it was cast. Anything new to the battlefield is not affected.
My creature Gatstaf Howler. During the opponents upkeep, its transform trigger hit the stack due to my casting 2 spells during my turn. This error occurred.
Unholy Fiend. You should only lose 1 life during your end step. Right now, you lose it on your opponents end step also.
Test game with Soul Foundry and Gatstaf Shepard. Imprinted Gatstaf Shepard with Soul Foundry. The transform trigger hits the stack and fizzles on resolution. Gatstaf Shepard does not transform.
My creature Gatstaf Howler. During the opponents upkeep, its transform trigger hit the stack due to my casting 2 spells during my turn. This error occurred.
- | Open
Unholy Fiend. You should only lose 1 life during your end step. Right now, you lose it on your opponents end step also.
Last edited by jeffwadsworth on 21 Oct 2011, 16:54, edited 1 time in total.
- jeffwadsworth
- Super Tester Elite
- Posts: 1172
- Joined: 20 Oct 2010, 04:47
- Location: USA
- Has thanked: 287 times
- Been thanked: 70 times
Re: Mulitstate cards test drive
by Hellfish » 21 Oct 2011, 16:38
Re: The Soul Foundry bit.
Copies of DFC cards only copy the state that was active at the time, and can't transform since they aren't actual double-faced card. This is according to extra rulings made.
I will look into your other points. Thanks!
Copies of DFC cards only copy the state that was active at the time, and can't transform since they aren't actual double-faced card. This is according to extra rulings made.
I will look into your other points. Thanks!
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by Sloth » 21 Oct 2011, 18:17
I've looked at the code Hellfish and I think it would be better to not create a new card object when the card transforms. All the swapping of cards for targets and combat would have to be done for other things like remembered, receivedDamageFromThisTurn, dealtDamageToThisTurn, assignedDamageMap, gainControlTargets, equipping, ... and most importantly for things that we might add in the future.
Isn't it easier to just overwrite the Name, type, P/T and other printed stuff?
Isn't it easier to just overwrite the Name, type, P/T and other printed stuff?
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Mulitstate cards test drive
by Hellfish » 21 Oct 2011, 18:29
It doesn't create a new card object on transform, it swaps in a preexisting card object. But that's beside the point.
I can modify this method to overwrite characteristics with the alternate's values instead.Occam's Razor and all that.
I'll give it a whirl!
EDIT: One problem I see with it is that keywords handled in postFactoryKeywords wouldn't function correctly if the keyword list is simply swapped in.
I can modify this method to overwrite characteristics with the alternate's values instead.Occam's Razor and all that.
I'll give it a whirl!
EDIT: One problem I see with it is that keywords handled in postFactoryKeywords wouldn't function correctly if the keyword list is simply swapped in.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by Sloth » 21 Oct 2011, 19:10
Well those are only for printed keywords, are there any transforming cards with one of those?Hellfish wrote:EDIT: One problem I see with it is that keywords handled in postFactoryKeywords wouldn't function correctly if the keyword list is simply swapped in.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Mulitstate cards test drive
by Hellfish » 21 Oct 2011, 19:37
Hmm, there is not.There could be,though, in Dark Ascension or Roll.
And that's not considering Custom cards.
And that's not considering Custom cards.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by Sloth » 21 Oct 2011, 19:54
I'm not so happy about these keywords anyway. If Flashback would be read during runtime Snapcaster Mage and Past in Flames would be scriptable. Fortunately a lot of them are just shortcuts for triggered, activated or static abilities that can always be written out if necessary (Graft, Modular, Provoke, etc.).Hellfish wrote:Hmm, there is not.There could be,though, in Dark Ascension or Roll.
And that's not considering Custom cards.
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Mulitstate cards test drive
by Hellfish » 22 Oct 2011, 08:57
Last patch for right now, still using the Card-swapping system. Addresses Multistate planeswalkers, adds Garruk Relentless / Garruk, the Veil-Cursed. I will focus on trying to implement a similar system based on Sloth's suggestion.
Milod: This patch requires access to the source code in Eclipse. I will try to provide a compiled version. I'll post here if I manage it.
Milod: This patch requires access to the source code in Eclipse. I will try to provide a compiled version. I'll post here if I manage it.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Who is online
Users browsing this forum: No registered users and 42 guests