Mulitstate cards test drive

[Hellfish]

Okay, status update: I've implemented a new system based on Sloth's suggestion that doesn't keep separate Card object but separate CardCharacteristics objects for states.CardCharacteristics objects are sort of collection classes for Name/Type/Abilities/everything that would change between states of a multistate card.The Card objects themselves track this. I also had to go trawling through the whole Script file->CardRules->CardPrinted system to setup the new script format for the alternates. I probably butchered the whole system but it seems to work! Plus, while I was there I hacked in support in the deckeditor for multistate cards.

I'll probably put out a patch sometime tomorrow. Here's a laundry list for those who're wondering.
-The ability to view the alternate state in the deckeditor. DONE!
-Clone interaction. DONE?
-MSC Planeswalker ability limitation. DONE!
-ImageFilename for alternate state. DONE!
-Triggers on alternate state working properly. DONE!
-Restructure TriggerHandler to get rid of trigger registering and just loop through all cards in the game looking for triggers. DONE!

Bugs:
-Alternate states do not get their colors set correctly (they remain colorless) DONE!
-Not everything is copied properly (SVars, ImageFilename...) DONE!

All items ticked off, which means I'll post a patch... After I come back from the shops.

Script example:

| Open

Name:Cloistered Youth
ManaCost:1 W
Types:Creature Human
Text:no text
PT:1/1
T:Mode$ Phase | Phase$ Upkeep | ValidPlayer$ You | TriggerZones$ Battlefield | Execute$ TrigTransform | OptionalDecider$ You | TriggerDescription$ At the beginning of your upkeep, you may transform CARDNAME.
SVar:TrigTransform:AB$ChangeState | Cost$ 0 | Defined$ Self
SVar:Rarity:Uncommon
AlternateMode:DoubleFaced
SetInfo:ISD|Uncommon|http://magiccards.info/scans/en/isd/8a.jpg
Oracle:At the beginning of your upkeep, you may transform Cloistered Youth.

ALTERNATE

Name:Unholy Fiend
ManaCost:no cost
Colors:Black
Types:Creature Horror
Text:no text
PT:3/3
T:Mode$ Phase | Phase$ End of Turn | ValidPlayer$ You | TriggerZones$ Battlefield | Execute$ TrigLoseLife | TriggerDescription$ At the beginning of your end step, you lose 1 life.
SVar:TrigLoseLife:AB$LoseLife | Cost$ 0 | Defined$ You | LifeAmount$ 1
SVar:Rarity:Uncommon
SetInfo:ISD|Uncommon|http://magiccards.info/scans/en/isd/8b.jpg
Oracle:Creature - Horror\n3/3\nAt the beginning of your end step, you lose 1 life.

End

[Sloth]

Sounds promising Hellfish! Can't wait to test.

[Hellfish]

Alright, check the bottom of the first post for the new Characteristic-based system!

Please try out scripting multistate cards and keep a close eye on Clone/Copy effects *crosses fingers*

[Chris H.]

Patch (for r11365): http://www.mediafire.com/?q67asi4x446nulz

Havn't figured out how to produce a proper .jar file, sorry.

`
Dave knows more about this stuff than I do, but you should be able to create a new build as a .tar.bz2 archive via a Maven command locally on your computer by doing the following:

1] Open Run Configurations dialog.

2] Click on the Maven Build item rather than the Java Application option listed on the left side of the window.

3] Click on the New Launch Configuration button.

4] Give the Launch Configuration a good name.

5] Make sure that the Base directory path points to your working project with your new code.

6] Past the following goal into your Goals text box:

-U -B clean -P windows-linux install

7] Click on the Apply button and then the Run button. Watch your console. When finished there should be an .tar.bz2 archive in your project target folder. Upload the archive to MediaFire.

8] Do a File -> Refresh. Then do a Run -> Run As -> Maven Clean to remove the new contents from the target folder. Do another File -> Refresh.

[jeffwadsworth]

Awaiting new patch.

[Hellfish]

I think you got the wrong patch there, Jeff. MultiStateHandler.java is not in the new system. I might've linked to the wrong patch, I'll check. EDIT: Try the one linked now. EDIT AGAIN: To clarify, don't apply this patch over the previous ones, apply it to a clean checkout of r11365.

Thanks, Chris, I'll try those instructions.

[jeffwadsworth]

Looks like that new patch "V2" is missing some cards. Gatstaf Shepard and Screeching Bats.

[Hellfish]

Oh yeah,thanks, forgot about those. You can put together Screeching Bat / Stalking Vampire with a little Cut&Paste and comparing with Unholy Fiend. Gatstaf Shepherd / Gatstaf Howler needs a Trigger condition that I forgot to add in. Will fix.

[Iran]

When the developers introduces DF cards in forge, he would can solve the issue with the AI doesn't blocks with two or more when one card asks this. Because one of the most Werewof card is Kruin Outlaw/Terror of Kruin Pass.
The Terror of Kruin Pass have the effects below:
Double strike
Each Werewolf you control can't be blocked except by two or more creatures.

Thanks

[Hellfish]

When the developers introduces DF cards in forge, he would can solve the issue with the AI doesn't blocks with two or more when one card asks this. Because one of the most Werewof card is Kruin Outlaw/Terror of Kruin Pass.
The Terror of Kruin Pass have the effects below:
Double strike
Each Werewolf you control can't be blocked except by two or more creatures.

Thanks

That is a separate issue in the blocking system that I don't know how to deal with. My work here is only to enable multistate cards, not to make sure all of them can be scripted with regards to other features in Forge.

[Hellfish]

New patch, see first post!

This version adds the Werewolf transformation conditions to Triggers. (WerewolfTransformCondition$ True and WerewolfUntransformCondition$ True, see Gatstaf Shepherd / Gatstaf Howler)

The CardDb now keeps a separate CardPrinted for each state, meaning that multistate cards works with both deck editors AND Download Set Pictures LQ. Also added Screeching Bat / Stalking Vampire.

@Chris or Dave, I'm trying to run the maven run config that Chris specified, but it complains that I'm not using the correct JDK (>1.4). As far as I can tell, I'm using JDK 1.7.

| Open

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project forge: Compilation failure
[ERROR] Unable to locate the Javac Compiler in:
[ERROR] C:\Program Files\Java\jre6\..\lib\tools.jar
[ERROR] Please ensure you are using JDK 1.4 or above and
[ERROR] not a JRE (the com.sun.tools.javac.Main class is required).
[ERROR] In most cases you can change the location of your Java
[ERROR] installation by setting the JAVA_HOME environment variable.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/disp ... eException

[Hellfish]

I've pored over gatherer and found only 6 flip/dfc cards that possibly cause other problems in Forge, all other flip/dfc cards should be implementable from the get-go.

| Open

Kitsune Mystic / Autumn-Tail, Kitsune Sage - Needs enchantment moving(AF_Attach)
Civilized Scholar / Homicidal Brute - The transform conditions can't be done currently that I know of.
Delver of Secrets / Insectile Aberration - Again, the transform condition can't be done currently.
Sasaya, Orochi Ascendant / Sasaya's Essence - Flip condition. Not sure we can handle the mana shenanigans?
Kruin Outlaw / Terror of Kruin Pass - "Can't be blocked except by two or more creatures"
Akki Lavarunner / Tok-Tok, Volcano Born - Damage modification.

I'm also unsure if our "Fight" implementation is up to snuff for Daybreak Ranger / Nightfall Predator but it's there, at least.

I could be greedy and implement all the others myself, but that would just be mean

[Chris H.]

@Chris or Dave, I'm trying to run the maven run config that Chris specified, but it complains that I'm not using the correct JDK (>1.4). As far as I can tell, I'm using JDK 1.7.

| Open

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project forge: Compilation failure
[ERROR] Unable to locate the Javac Compiler in:
[ERROR] C:\Program Files\Java\jre6\..\lib\tools.jar
[ERROR] Please ensure you are using JDK 1.4 or above and
[ERROR] not a JRE (the com.sun.tools.javac.Main class is required).
[ERROR] In most cases you can change the location of your Java
[ERROR] installation by setting the JAVA_HOME environment variable.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/disp ... eException

`
Good question Hellfish. I wish that I had a good answer. I hope that Dave sees this message and can give some guidance.

[friarsol]

@Chris or Dave, I'm trying to run the maven run config that Chris specified, but it complains that I'm not using the correct JDK (>1.4). As far as I can tell, I'm using JDK 1.7.

| Open

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project forge: Compilation failure
[ERROR] Unable to locate the Javac Compiler in:
[ERROR] C:\Program Files\Java\jre6\..\lib\tools.jar
[ERROR] Please ensure you are using JDK 1.4 or above and
[ERROR] not a JRE (the com.sun.tools.javac.Main class is required).
[ERROR] In most cases you can change the location of your Java
[ERROR] installation by setting the JAVA_HOME environment variable.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/disp ... eException

`
Good question Hellfish. I wish that I had a good answer. I hope that Dave sees this message and can give some guidance.

Hellfish, you are using the JRE (Java Runtime Environment) where it's asking you for the JDK (Java Development Kit).

[Hellfish]

Doi!
Thanks, I'll try again after I fix some unwanted behaviour.