Mulitstate cards test drive
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Mulitstate cards test drive
by Chris H. » 26 Oct 2011, 19:36
`Hellfish wrote:That was the one I modded. So it didn't work?
I built a local copy of rev 11441 using Maven. I only have the non-set card pics in this copy of forge. I downloaded the new available card pics this morning after I ran the daily build script.
I run rev 11441 and find that Nezumi Shortfang has an error so I remove the card, OK. Try again.
I select "Download Card LQ Pictures". It says that there are 51 pics to download. I get a list of "Error - Possibly missing URL for" many of the new cards.
I check the pics folder for the new cards that were successfully downloade and find pics for:
howlpack_alpha.jpg
wildblood_pack.jpg
gatstaf_howler.jpg
Here is the log from the terminal:
- log from the terminal | Open
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Mulitstate cards test drive
by Sloth » 26 Oct 2011, 19:56
This is not a problem in the code. The card text files are simply missing the Picture SVar.Chris H. wrote:`Hellfish wrote:That was the one I modded. So it didn't work?
I built a local copy of rev 11441 using Maven. I only have the non-set card pics in this copy of forge. I downloaded the new available card pics this morning after I ran the daily build script.
I run rev 11441 and find that Nezumi Shortfang has an error so I remove the card, OK. Try again.
I select "Download Card LQ Pictures". It says that there are 51 pics to download. I get a list of "Error - Possibly missing URL for" many of the new cards.
I check the pics folder for the new cards that were successfully downloade and find pics for:
howlpack_alpha.jpg
wildblood_pack.jpg
gatstaf_howler.jpg
Here is the log from the terminal:
- log from the terminal | Open
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Re: Mulitstate cards test drive
by Chris H. » 26 Oct 2011, 20:06
`Sloth wrote:This is not a problem in the code. The card text files are simply missing the Picture SVar.
I suspected the same thing until I noticed that the Gatstaf Shepherd / Gatstaf Howler card appears to have both pic URLs and yet it only downloading one of the two pics.
- Gatstaf Shepherd / Gatstaf Howler card | Open
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Mulitstate cards test drive
by ArsenalNut » 26 Oct 2011, 22:02
At r11464 the behavior has changed, Forge now downloaded only the alternate card image instead of only the primary card image like r11434 did. Chis H. is seeing the same problem.Hellfish wrote:That was the one I modded. So it didn't work?
So many cards, so little time
-
ArsenalNut - Posts: 512
- Joined: 08 Jul 2011, 03:49
- Has thanked: 27 times
- Been thanked: 121 times
Re: Mulitstate cards test drive
by Chris H. » 26 Oct 2011, 22:49
Some of these new cards were missing their LQ pic URLs. I added them to as many of the cards as I could.
I attempted to verify that both URLs would lead to the appropriate card pics. Unfortunately, some of the cards only have one of the pics available rather than both of them.
Does anybody have any ideas on how we should handle this?
I attempted to verify that both URLs would lead to the appropriate card pics. Unfortunately, some of the cards only have one of the pics available rather than both of them.
Does anybody have any ideas on how we should handle this?
-
Chris H. - Forge Moderator
- Posts: 6320
- Joined: 04 Nov 2008, 12:11
- Location: Mac OS X Yosemite
- Has thanked: 644 times
- Been thanked: 643 times
Re: Mulitstate cards test drive
by goonjamin » 27 Oct 2011, 00:37
I made a deck with some double sided cards to test out the awesome new functionality. I beat a the AI a few times with random decks and thought it would be fun to see how it played this deck. It seems to work fine but when the cards flip mine show the backside image but the AI's just show up blank?
Attached is an image of what I am seeing and this is on svn rev 11474.
Attached is an image of what I am seeing and this is on svn rev 11474.
- Attachments
-
Re: Mulitstate cards test drive
by friarsol » 27 Oct 2011, 03:29
I just created a few new Quests in a row to see how many double faced guys I can build a deck around and just ended up with Krallenhorde Wantons in my starting pool which gave me a similar crash as above.Hellfish wrote:Fixed it. Thanks!friarsol wrote:Jaedayr reported this, but it's similar to the error I received above. http://cardforge.org/bugz/view.php?id=496
Looks like he received the back side of a double faced card as reward. These cards should not be part of the reward pool/card shop.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Mulitstate cards test drive
by Hellfish » 27 Oct 2011, 08:01
@Chris, ArsenalNut: Fixed. I had forgotten to move a member from Card to CardCharacteristics.
@Sol: Fixed, alternate states are now filtered out from the starting pool.
@Sol: Fixed, alternate states are now filtered out from the starting pool.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by Hellfish » 27 Oct 2011, 16:11
Could you please check r11492 (or really, anything newer than r11479)? I'm not seeing this particular bug here.goonjamin wrote:I made a deck with some double sided cards to test out the awesome new functionality. I beat a the AI a few times with random decks and thought it would be fun to see how it played this deck. It seems to work fine but when the cards flip mine show the backside image but the AI's just show up blank?
Attached is an image of what I am seeing and this is on svn rev 11474.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by moomarc » 27 Oct 2011, 17:20
Just played with r11493 and I have the same issue.Hellfish wrote:Could you please check r11492 (or really, anything newer than r11479)? I'm not seeing this particular bug here.goonjamin wrote:I made a deck with some double sided cards to test out the awesome new functionality. I beat a the AI a few times with random decks and thought it would be fun to see how it played this deck. It seems to work fine but when the cards flip mine show the backside image but the AI's just show up blank?
-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Mulitstate cards test drive
by Hellfish » 27 Oct 2011, 19:05
Welp, turns out you need to actually commit the fix after you make it. I really need a *doi* smilie >_>
Try r11495.
Try r11495.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Mulitstate cards test drive
by moomarc » 27 Oct 2011, 19:35
Hellfish wrote:Welp, turns out you need to actually commit the fix after you make it. I really need a *doi* smilie >_>
Try r11495.
Thanks! I'll test in the morning.-Marc
-
moomarc - Pixel Commander
- Posts: 2091
- Joined: 04 Jun 2010, 15:22
- Location: Johannesburg, South Africa
- Has thanked: 371 times
- Been thanked: 372 times
Re: Mulitstate cards test drive
by slowe » 28 Oct 2011, 01:02
A Garruk, the Veil-Cursed just (rev 11504) turned up in the Card Shop for me.Hellfish wrote:Fixed it. Thanks!friarsol wrote:Jaedayr reported this, but it's similar to the error I received above. http://cardforge.org/bugz/view.php?id=496
Looks like he received the back side of a double faced card as reward. These cards should not be part of the reward pool/card shop.
I would have commented on the Mantis issue, but its fixed status prevents that.Re: Mulitstate cards test drive
by goonjamin » 28 Oct 2011, 01:49
Fix works great for meHellfish wrote:Welp, turns out you need to actually commit the fix after you make it. I really need a *doi* smilie >_>
Try r11495.
Who is online
Users browsing this forum: No registered users and 60 guests