Cleanup old functions/variables

[Sloth]

In order to further trim down the code, I want to hunt down some unneeded functions/variables and post them here. If someone things we still need them post here.

If you find something which is no longer needed, you can post it here.

First find: Some commands

1.ReplaceMoveToGraveyardCommand
Only used by: Cerebral Eruption (which I think is scriptable)

2. CycleCommand
not used at all.

3. addTurnFaceUpCommand
not used at all

[jeffwadsworth]

I will work on Cerebral Eruption right now and scratch it off the list. *DONE*

[Sloth]

I will work on Cerebral Eruption right now and scratch it off the list. *DONE*

Thanks Jeff!

[slapshot5]

Is the ZCTrigger class used at all, or is it a relic of the past? Does anyone know for sure?

-slapshot5

[Sloth]

Is the ZCTrigger class used at all, or is it a relic of the past? Does anyone know for sure?

-slapshot5

This is still used a lot. Just search for addComesIntoPlayCommand (Fading, Echo, "CARDNAME comes into play tapped",...).

[slapshot5]

I know it's used. Maybe I asked the wrong question. Is it *needed* in the new Trigger system?

[Sloth]

I know it's used. Maybe I asked the wrong question. Is it *needed* in the new Trigger system?

They should all be replaceable with static triggered abilities.

[Sloth]

I've rewritten the Recover keyword and noticed the old version set a cancelCommand of a spellAbility, but getcancelCommand is never used (or the variable). Does anybody need this?

[Doublestrike]

There's a few rogue packages in the SVN from Braids and Max mtg - can these be sliced out somehow, or renamed (relicensed)?

[slapshot5]

I think this method in ManaPool is now defunct:

Code: Select all

public final void subtractOne(final String manaStr) {


-slapshot5

[jendave]

There's a few rogue packages in the SVN from Braids and Max mtg - can these be sliced out somehow, or renamed (relicensed)?

They can be renamed. They cannot be relicensed. As far as I know, only Braids' code needs to be handled with care regarding license (it is dual-licensed). I inserted a license header at the top of all files in the project with the appropriate license. Make sure any file that you touch retains the proper header.

[Doublestrike]

Make sure any file that you touch retains the proper header.

@jendave - cheers, thanks for the reply. I probably won't do much with them, those packages just sort of irritate my OCD.

Regarding the "proper header", shouldn't all files have the same header, or something? Not sure how this works but it seems sort of half-implemented (or less).

Anyway, just throwing these ideas out there, maybe they're inconsequential.

[friarsol]

I was looking at Landwalk, seeing if we can clean things up, and it seems like we might be able to convert all of the different Landwalk keywords into Static Abilities.

The current reminder text says: "This creature is unblockable as long as defending player controls a Swamp."

The only problem with this is the Legends Enchantments (Deadfall) that negate landwalking. Can anyone think of a good way of handling that?

[slapshot5]

Here's the big one: What should we do with the Old GUI code? Should we start weeding it out piece-by-piece? Nobody will be able to weed it all out by themselves. But as we find unused things, should we remove them?

Or is there a reason to keep this code around?

I was looking specifically at GuiDisplay.addObservers

It comes up when I'm searching for the Observer leaks, but it never gets called. (Called from GuiDisplay constructor, but that constructor is only called wrapped with "if (Constant.Runtime.OLDGUI[0]) {", which cannot get set anymore.)

In the interest of moving forward, my vote is to remove old GUI pieces/methods as we determine it it not being used, then when we are close, we can start deleting classes.

-slapshot5

[friarsol]

That's probably the right way to go. I'm all for clearing out unused classes. The main one I'd be careful around is the Multi-Blockers UI element.