Cleanup old functions/variables

[Doublestrike]

@slapshot - I personally have not come across it in extensive UI work, and none of the new UI uses it (remaining old UI components are the battlefield, and the deck editors).

[slapshot5]

I think it was from the old new home screen gui. (That Rob did?) Maybe it's for tab order functionality? Anyways, I'm assuming you have no intention of using it Doublestrike. True? If true, I'll remove it.

-slapshot5

[Doublestrike]

return true;

[Rob Cashwalker]

Eclipse's WindowBuilder added that in. I used it for my stab at the gui as well as the bug report screen.

[Chris H.]

Eclipse's WindowBuilder added that in. I used it for my stab at the gui as well as the bug report screen.

`
I just now attempted to access the bug report screen from the Utilities view and got this crash report:

Crash Report | Open

This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.

javax/xml/rpc/ServiceException


Version:
Forge version SVN

OS: Mac OS X Version: 10.7.2 Architecture: x86_64

Java Version: 1.6.0_29 Vendor: Apple Inc.

Detailed error trace:
java.lang.NoClassDefFoundError: javax/xml/rpc/ServiceException
at forge.error.BugzReporter.<init>(BugzReporter.java:146)
at forge.control.home.ControlUtilities$6.actionPerformed(ControlUtilities.java:93)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2028)
at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2351)
at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
at java.awt.Component.processMouseEvent(Component.java:6373)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
at java.awt.Component.processEvent(Component.java:6138)
at java.awt.Container.processEvent(Container.java:2085)
at java.awt.Component.dispatchEventImpl(Component.java:4735)
at java.awt.Container.dispatchEventImpl(Container.java:2143)
at java.awt.Component.dispatchEvent(Component.java:4565)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4621)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4282)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4212)
at java.awt.Container.dispatchEventImpl(Container.java:2129)
at java.awt.Window.dispatchEventImpl(Window.java:2478)
at java.awt.Component.dispatchEvent(Component.java:4565)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:679)
at java.awt.EventQueue.access$000(EventQueue.java:85)
at java.awt.EventQueue$1.run(EventQueue.java:638)
at java.awt.EventQueue$1.run(EventQueue.java:636)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
at java.awt.EventQueue$2.run(EventQueue.java:652)
at java.awt.EventQueue$2.run(EventQueue.java:650)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:649)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
Caused by: java.lang.ClassNotFoundException: javax.xml.rpc.ServiceException
at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
... 39 more

[slapshot5]

I just now attempted to access the bug report screen from the Utilities view and got this crash report:

Hey Chris,

I read this while I was at work yesterday, but then forgot about it. I'll look at it tonight when I get home.

-slapshot5

[slapshot5]

I just now attempted to access the bug report screen from the Utilities view and got this crash report:

Hey Chris,

I read this while I was at work yesterday, but then forgot about it. I'll look at it tonight when I get home.

-slapshot5

Well, it's not my change about deleting that package that broke it. I'm not sure exactly what the problem is, but it looks like we are missing a jar or some such thing.

-slapshots

[Chris H.]

I just now attempted to access the bug report screen from the Utilities view and got this crash report:

Hey Chris,

I read this while I was at work yesterday, but then forgot about it. I'll look at it tonight when I get home.

-slapshot5

Well, it's not my change about deleting that package that broke it. I'm not sure exactly what the problem is, but it looks like we are missing a jar or some such thing.

`
I tried accessing the bug report screen from the Utilities view using an earlier snapshot build and got the same result.

I also checked our last beta build, Forge: 1.2.2-r13318 dated 01-20-2012 and the bug report screen works OK on this one so it appears to be a recent issue.

[slapshot5]

From what I investigated last night, I am suspicious of r13334 where the folloowing was removed from pom.xml:

Code: Select all

        <dependency>
            <groupId>javax.xml</groupId>
            <artifactId>jaxrpc-api</artifactId>
            <version>1.1</version>
        </dependency>


Hopefully jendave has some time to look into this further.

-slapshot5

[jendave]

I'll look at it. IIRC, Forge does not directly depend on this lib, Mantis does. I removed all of the Mantis deps from the Forge pom.xml and put them into the Mantis pom in the repo. It appears I may have missed one.

[jendave]

Maven is not pulling the Mantis transitive dependencies the way I would expect so in the meantime I will put the Mantis deps (including jaxrpc) back into the Forge pom.xml. Hopefully I can fix up the Mantis pom file so Forge does not have to track these deps explicitly.

[Doublestrike]

The old Quest UI is now completely updated to the new UI. I have removed all deprecated classes in r13816; will be watching here for unforeseen consequences.

[Doublestrike]

Do we need the forge.properties file? This file has one line of "code", and a lot of comments:

"forge.properties" | Open

#properties-file for mtg forge

#####################
## The file format ##
#####################

# maybe you're familiar with property files. it's a simple way for key/value mappings:
# a line starting with '#' is a comment and is ignored. empty lines are also ignored
# other lines are interpreted as <key>=<value>. If you want to use special characters,
# you have to escape them, by prepending '\'.
# so for the key "contains'='", write "contains'\='", and for the key "contains'\'", write "contains'\\'"
# line breaks can be added as \n


# this file uses a slightly enhanced concept, including key suffixes.
# you can't use keys containing "--" for this reason:

# a property ending with "--transparent-properties" results in the referenced properties-file being added

# a property ending with "--properties" also result in adding, but the name used to add it is prepended.

# assume a properties file:
# #example.properties
# property=value
# referencing it with
# example--properties=example.properties
# will result in the key "example/property". referencing it with
# example--transparent-properties=example.properties
# will result in the key "property".

# the third suffix is "--file", and used to reference other files/directories needed in forge
# all paths specified, no matter what suffix, are relative to the current file and not neccessarily to this one

# some substitutions are applied to a path. "$$" is replaced with "$", a "~/" or "~\" at the path's beginning is
# replaced with the user's home directory. a pattern like "${*}" ("*" being any string) is replaced with the
# system variable, for example, ${user.home} is (at the beginning) the same as "~"

# all that said, the only thing of importance is that the keys do not change, and that all files are referenced
# correctly. the structure of your properties is not of relevance. you could also include all information in this
# file if you preserve the full keys.



# this link includes the main properties file. you can move/rename etc. the res-folder. you just have to change
# this single line
main--transparent-properties=res/main.properties

Seems like this information could (should?) be somewhere more relevant, and this file could be removed.

[Doublestrike]

While I'm at it, in main.properties:

image/base--file=pics
image/token--file=pics/tokens
image/icon--file=images/icons
image/product--file=pics_product
pics/booster/images--file=quest/booster-images.txt

Seems like the icon pics should be with the rest of the pics by default. The images/ directory only exists to support these icon pics - time for it to go, I reckon.

Would this cause significant complications?

[Chris H.]

Oh, it looks like the current project no longer has a /res/images/ folder. This folder has two subdirectories named /images/icons/ and /images/deckeditor/.

I guess that we no lonker need /images/deckeditor/ folder and it's contents with your new work.

The /images/icons/ folder holds the pics used for the various quest mode opponents. It also contains the pics that are displayed in the bazaar for the various pets/plants.