Quest classes refactoring

[moomarc]

Thanks Chris. I'll get those done.

[Doublestrike]

Just coming back after a bit of a break, I notice my old quest datas don't work, because they're missing the "realistic" enum. When I decode them, their whole XML structure has changed also...will there be support for these in the future, or are they permanently broken? Bummer if broken, because I played these quests a lot...I suppose I could rebuild by hand.

[Max mtg]

Just coming back after a bit of a break, I notice my old quest datas don't work, because they're missing the "realistic" enum. When I decode them, their whole XML structure has changed also...will there be support for these in the future, or are they permanently broken? Bummer if broken, because I played these quests a lot...I suppose I could rebuild by hand.

Drop here your old quest data (both unzipped and unzipped) - I'll see how it can be restored.

[moomarc]

Okay, I've committed the script versions of the quest pics. Move them as you see fit, but for now they're located in res/quest/bazaarcards/nursery (and /petshop)

For now I left out an image field so we must decide how we want to handle that. I've also left the pets as they currently are and will just post alternatives here for review.

[Max mtg]

Okay, I've committed the script versions of the quest pics. Move them as you see fit, but for now they're located in res/quest/bazaarcards/nursery (and /petshop)

For now I left out an image field so we must decide how we want to handle that. I've also left the pets as they currently are and will just post alternatives here for review.

Thanks!
I've moved the formerly hadcoded data into xml and moved your text files to a more siutable place. While that data is already commited, let me add code that would read it soon.

[Max mtg]

I'm done with quest classes refactoring, but it does not work now =(
One thing is unclear to me for now.

The card I read from file is stored for later good times. I try to copy it before each game, but it just does not work by any means. Do you have any ideas how a Card object that is not bound to CardFactory can be copied to a new instance?

[Chris H.]

Using today's snapshot build based on rev 14821 I noticed that my wolf pet was available for my next match but my plant wall was not. I went into the bazaar and had to re-purchase my plant wall and had to re-purchase the upgrades that I had made a few days ago.

I started my match and see that we still need some way to assign a token pic file name but so far this part of the project is moving forward.

Looking good so far.

[Max mtg]

Looking good so far.

It is not as good =(
I managed to enable pictures, yes. But activated abilies don't work!
Looks like the card should be passed to abilityfactory or something like that?

There's another problem: sometimes as the game starts, cards are not deal at all. Empty hands have both of us - computer and I.

[Doublestrike]

Drop here your old quest data (both unzipped and unzipped) - I'll see how it can be restored.

During splash screen, this happens twice:

EDIT "Your message contains 322367 characters. The maximum number of allowed characters is 60000." attached as text files.

[Doublestrike]

I also get the following NPE with old DAT files (that worked a week or two ago):

"NPE" | Open

java.lang.NullPointerException
at forge.quest.io.QuestDataIO.updateSaveFile(QuestDataIO.java:232)
at forge.quest.io.QuestDataIO.loadData(QuestDataIO.java:138)
at forge.gui.home.quest.CSubmenuQuestData.update(CSubmenuQuestData.java:93)
at forge.gui.home.quest.CSubmenuQuestData.initialize(CSubmenuQuestData.java:49)
at forge.view.ViewHomeUI.populateMenu(ViewHomeUI.java:216)
at forge.view.ViewHomeUI.initialize(ViewHomeUI.java:152)
at forge.view.FView.instantiateCachedUIStates(FView.java:141)
at forge.view.FView.initialize(FView.java:66)
at forge.view.Main$2.run(Main.java:66)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$000(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Two files attached with this problem, change extension to dat.

[Chris H.]

I managed to enable pictures, yes. But activated abilies don't work!
Looks like the card should be passed to abilityfactory or something like that?

`
It looks like the Wolf pet has the Flanking keyword added when it is fully trained. I see that my fully trained plant wall is missing the life gain ability.

We have a few cards that will add an AF ability to another card. I have seen the script for a few of these cards but I do not know how the code works.

There's another problem: sometimes as the game starts, cards are not deal at all. Empty hands have both of us - computer and I.

`
I have played a few quest matches the last couple of days and have not yet experienced this bug.

We also have a report that the quest challenges are not putting the initial cards on the battlefield at the start of the match. I have not yet won enough matches to reproduce this bug.


And thank you for taking the time to perform the quest refactoring.

[friarsol]

We have a few cards that will add an AF ability to another card. I have seen the script for a few of these cards but I do not know how the code works.

This isn't what we want, we just need the Pets to continue down the full Card Creation path, so it needs to call into AbilityFactory (as well as Static Abilities and Triggered Abilities) just like a normal card does.

[Sloth]

I'm done with quest classes refactoring, but it does not work now =(
One thing is unclear to me for now.

The card I read from file is stored for later good times. I try to copy it before each game, but it just does not work by any means. Do you have any ideas how a Card object that is not bound to CardFactory can be copied to a new instance?

The function copyTokens should be able to do that. It's not really complete (all abilities, triggers etc. are missing). But i can complete it for you.

EDIT: Just checking: readCard in CardReader can't be used for what you want?

[friarsol]

Quest mode seems to be not very stable lately. Right now I have two quests named bob one a .xml and .dat, both available on the quest saves screen. When I close and reopen, it seems like all the changes I made in one of my saves no longer exist, possibly because it was overwritten (selling most of my cards, and the deck I built).

It looks like the quests aren't being unloaded properly either, so when I switch quest saves one with 50+ wins and a new one all the challenges from the first save game are still there. I was also getting some funkiness with my Start button not being active. Soo, there's definitely some funkiness going on with it. We should make sure this all gets ironed out before the next release.

Edit: Deleting doesn't seem to do anything useful. And neither does renaming. Actually, I'm more confused after trying to do both of these actions with what is being shown. in res/quest/data I see bob.xml and tim.dat but I don't see any tim in my quest saves, but there are two bobs. Somehow one of these bobs has the deck I built, and the other doesn't.

[Max mtg]

I also get the following NPE with old DAT files (that worked a week or two ago):

`
Your saves are working now. That was quite easy.

The function copyTokens should be able to do that. It's not really complete (all abilities, triggers etc. are missing). But i can complete it for you.

EDIT: Just checking: readCard in CardReader can't be used for what you want?

`
I already use readCard, however it does not set up activated abilities of cards. Not sure about copyTokens. I need to convert the script lines into real abilities. So looks like I should use getCard2 from AbstractCardFactory