Complete: Deck set assignment deck converter

[Xitax]

Bugfix version: link removed - old version.

-Fixed bad assignment of EVE to levelers
-Fixed bad assignment of EVE to cards from EVT (Elspeth vs. Tezzeret)

The following cards generated a Forge error even though they are in the sets assigned:
Thought Courier:9ED
Eager Cadet:S99
Concentrate:8ED
AEther Flash:7ED
Ambition's Cost:8ED
AEthersnipe:COM
Familiar Ground:7ED
Vengeance:9ED

[moomarc]

Bugfix version: http://www.mediafire.com/?p8r6saz14l08lnm

-Fixed bad assignment of EVE to levelers
-Fixed bad assignment of EVE to cards from EVT (Elspeth vs. Tezzeret)

The following cards generated a Forge error even though they are in the sets assigned:
Thought Courier:9ED
Eager Cadet:S99
Concentrate:8ED
AEther Flash:7ED
Ambition's Cost:8ED
AEthersnipe:COM
Familiar Ground:7ED
Vengeance:9ED

Just checked Vengeance and it appears that it was only available with the box sets in 8th and 9th Edition, actually having the 'Special' rarity for 8ED. I'm assuming the others are similar, but will check. Thanks Xitax!

The other senior devs should just decide whether we should add the set info to the cards if they were only in box sets. Edit: Nevermind. I see Eager Cadet had the same thing but had those added, so fixing em all....

Edit 2: Turns out that the other 6 were simply missing so I've added where necessary and committed. Vengeance was only available with the 8ED and 9ED box sets (listed as uncommon for 9eb and Special for 8eb). Same for Eager Cadet which is also listed as Special rarity for Starter 1999 and 2000.
The set info python script skips all those whereas mtg-data.txt lists them all as the rarity of the regular card (Vengeance-uncommon, Eager Cadet-common). Eager Cadet has the 9E det info in its script, but it was added by hand because if deleted and you run the script its left out. So I'm not sure what to do for these. I've added the missing sets in my local copy with rarities as listed on magiccards.info, so ready to commit if given the go-ahead.

[Xitax]

Appreciate that you looked those up for me - if it were me I'd add them all as I have card pictures for them all, but if the devs don't want the two special cards added I'll have to restrict them by hand. That would be too bad as originally the program was designed to be maintenance-free as time goes on.

[Xitax]

OK, I think I've reached a nearly final version:
Download removed: new version.

-Fixed bug where a card was listed more than one time in a deckfile. Program now combines multiples into a single line before assigning sets.
-Added list function in case the user wants to see the deckfile before conversion.
-Distribution is now in .zip archive.

Instructions: Unzip into its own folder. Go get mtg-data.txt from /res and setdata.txt from /res/blockdata and place in same folder. Copy decks to convert into same folder, run program. There are several options within the program which should be self-explanatory. Output will be in subfolder /output, created if not present.

[Xitax]

New bugfix: Wouldn't parse decks if there were trailing spaces after card names.

The program has and will successfully convert all quest and gos' constructed decks without error. There are some Forge errors with cards missing from sets where they should exist, but that's it.

[Xitax]

Has anyone tried it out? Have any comments or suggestions?

[moomarc]

Has anyone tried it out? Have any comments or suggestions?

Just tried it and its awesome. So nice to not have to edit each precon manually to get everything to have the right set pic. Thanks Xitax!

[Xitax]

It's broken with the new version of datafiles with 1.2.7. A quick look at mtg-data.txt reveals the reason why: they're now using many 2-letter set abbreviations and they don't match setdata.txt any more. Before I go off half-cocked and do something like hardcode the setdata in (the only solution that I can see), I'd like to ask what the intention is concerning these files?

For example I have "A" or "LEA" for alpha in setdata, and "1E" in mtg-data.txt. Thanks!

I suppose I should add that the reason that I'd hardcode the set data in is that if I use mtg-data.txt as the sole set resource I have to filter out by hand all the sets that Forge doesn't use so it comes to the same thing as hardcoding them in the conversion script. That is, unless I have a way to correlate the two, which right now I don't.

EDIT: Well, one way to deal with it is to change the setinfo in mtg-data.txt to the 3-letter versions. Not too terribly difficult, though not ideal.

EDIT 2: Deleted link as mtg-text still has some errors - will fix soon.

[friarsol]

I'm not sure why this change happened for mtg-data, I'll ask Arch since we're not the one who generates it. I noticed there's some funkiness in the PerSetTracking script related to the set data changing formats as well.

[7Durandal7]

Using that mtg-data.txt file works well. I did have an error with Mana Crypt. Couldn't be found in sets PLS, CFX or M12.

[friarsol]

Using that mtg-data.txt file works well. I did have an error with Mana Crypt. Couldn't be found in sets PLS, CFX or M12.

Mana Crypt is a Media Insert (in the early days of magic there were books with card giveaways in them, Mana Crypt was one of these). I'm not sure where you got the above sets as possibilities for it?

[7Durandal7]

Mana Crypt is a Media Insert (in the early days of magic there were books with card giveaways in them, Mana Crypt was one of these). I'm not sure where you got the above sets as possibilities for it?

I used xitax's posted mtg-data.txt, I'm guessing it's an error in that somewhere.

[Xitax]

Ok, fixed a problem with 4ED, and changed the media promo code to MBP from PPC. Thanks, 7Durandal7!

[mark]

I try to use it with wine but it fails:

Code: Select all

Can't open file: No such file or directory at Z:\home\mark\opt\forge\forge-1.2.8\res\decks\constructed\decksetfix.exe line 9.

This exe file was created with the evaluation version of Perl2Exe.


could you also upload the original perl script, please?

[Xitax]

Here it is.