Cleanup and hoping to increase performance

[Max mtg]

I am not that confident about the Rob's idea of learning winning strategies from people playing forge.
If someone does not like "svar" in front of "deckwants", it's ok to is just keep "DeckWants:" in card scripts. As long as its about pointing at some favourable cards, that would be enough.

There is a routine to filter CardLists in DeckWants class - it might be a good idea to replace it with a predicate lazy builder.

[mcrawford620]

Yeah, I'll try to rewrite the DeckWants; the tests make it pretty easy to do so. It definitely can live in the CardPrinted instead of the Card since it would never be needed during a game.
I'd never heard of Predicates before so that's all new. I think I'm getting the hang of it, though.

[Max mtg]

Looks like cards that start in play via Quests aren't being run through the cardfactory creation.

Eladamri's Vineyard isn't triggering at all from the Green Medium Quest. If I cast a Vineyard in constructed play, it triggers just fine.

fixed in r16400, though it was not related to Card lazy loading at all.

[Max mtg]

I made some more fixes regarding memory allocation mainly

The slowest part by now is really the GUI. See the picture below

[Chris H.]

I launched today's snapshot build by double clicking on the jar file rather than using the launcher. Forge launched without an increased java heap space.

I played a quick game and spent a little time in the deck editor. I did not get a java heap space error.

[mcrawford620]

Right now I'm getting this error when trying to add lands to the LimitedDeck:

Code: Select all

java.util.NoSuchElementException: Asked for card 'Swamp' from 'ARN': set found, but the card wasn't. :(
   at forge.item.CardDb.getCard(CardDb.java:281)
   at forge.item.CardDb.getCard(CardDb.java:254)
   at forge.game.limited.LimitedDeck.addLands(LimitedDeck.java:245)


Probably it was not being done the right way, but here's what it says:

Code: Select all

final CardPrinted cp = CardDb.instance().getCard(clrCnts[i].getColor(), aiPlayables.get(0).getEdition());

What should I do there instead?

[Sloth]

Right now I'm getting this error when trying to add lands to the LimitedDeck:

Code: Select all

java.util.NoSuchElementException: Asked for card 'Swamp' from 'ARN': set found, but the card wasn't. :(
   at forge.item.CardDb.getCard(CardDb.java:281)
   at forge.item.CardDb.getCard(CardDb.java:254)
   at forge.game.limited.LimitedDeck.addLands(LimitedDeck.java:245)


Probably it was not being done the right way, but here's what it says:

Code: Select all

final CardPrinted cp = CardDb.instance().getCard(clrCnts[i].getColor(), aiPlayables.get(0).getEdition());

Why don't you use this?

Code: Select all

final CardPrinted cp = CardDb.instance().getCard(clrCnts[i].getColor());

If aiPlayables.get(0) comes from a set without basic lands, the getCard you've used has to fail.

[mcrawford620]

Why don't you use this?

Code: Select all

final CardPrinted cp = CardDb.instance().getCard(clrCnts[i].getColor());

If aiPlayables.get(0) comes from a set without basic lands, the getCard you've used has to fail.

That's better, thanks. I think the original intent was to keep the "look" of the lands the same as the rest of the limited deck, pulling them from the same set. But also I didn't know what I was doing.

Is there a way to tell if a set has basic lands?

[Max mtg]

Is there a way to tell if a set has basic lands?

• Check isCardSupported(name, set) function to test card's presence in db.
• Obtain a cardPrinted (from any set), then get CardRules and learn which sets contain the card (getSetsPrinted() )
• FModel.editions has all editions with indices so that you can compare them and find the latest one but not exceeding ARN (or other target edition)

[Max mtg]

mcrawford620, please note that LimitedDeck class and its descendants do provide only some methods to build up a deck. They do not extend deck's functionality but rather act as a separate agent, who can be given a number of cards and return a deck.

This is why I removed base class of Deck from your LimitedDeck class.
Instead BuildDeck method is public now and returns a deck, and it is no called by constructor automatically.

I am sorry for having interferred into your code.

[mcrawford620]

You're right, I should not have extended Deck. Thanks for cleaning it up. No apology needed!