It is currently 21 Aug 2025, 19:48
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby ArsenalNut » 01 Oct 2012, 14:55

PowerClaws wrote:
ArsenalNut wrote:I could not reproduce the problem. Here's how I tested.
1) Get 4 Scrublands and 2 Orzhov Signets in play
2) Cast Sorin, Lord of Innistrad
3) Select first signet to pay for Sorin
4) Tap a Scrubland to pay for signet mana ability, then a white and a black mana show up in the manapool.
5) Unchanged cost for Sorin is still displayed and select the other signet
6) Repeat step 4
Final state was 2 white mana and 2 black mana in the manapool and unchanged cost for Sorin.
I did this twice, once casting both signets using the lands, the other had one signet paid by the other signet, it occurred for the second case only
I am still not seeing a problem. Here's what I saw when I used the 2nd signet to pay for the first
1) Cast Sorin
2) Get a prompt to pay 2 W B
3) Use click first signet to pay for Sorin
4) Get a prompt to one mana for signet ability
5) Use click second signet to pay for first signet
6) Get another prompt to one mana for second signet ability
7) tap Scrubland to pay for 2nd signet (step 6 prompt)
8 ) W B mana show up in mana pool
9) prompt reverts back to step 4
10) tap Scrubland to pay for 1st signet (step 4 prompt)
11) another W B mana show up in mana pool for a total of 2xW and 2xB
12) prompt reverts back to step 2
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Bug Reports (snapshot builds)

Postby PowerClaws » 02 Oct 2012, 09:45

ArsenalNut wrote:
PowerClaws wrote:
ArsenalNut wrote:I could not reproduce the problem. Here's how I tested.
1) Get 4 Scrublands and 2 Orzhov Signets in play
2) Cast Sorin, Lord of Innistrad
3) Select first signet to pay for Sorin
4) Tap a Scrubland to pay for signet mana ability, then a white and a black mana show up in the manapool.
5) Unchanged cost for Sorin is still displayed and select the other signet
6) Repeat step 4
Final state was 2 white mana and 2 black mana in the manapool and unchanged cost for Sorin.
I did this twice, once casting both signets using the lands, the other had one signet paid by the other signet, it occurred for the second case only
I am still not seeing a problem. Here's what I saw when I used the 2nd signet to pay for the first
1) Cast Sorin
2) Get a prompt to pay 2 W B
3) Use click first signet to pay for Sorin
4) Get a prompt to one mana for signet ability
5) Use click second signet to pay for first signet
6) Get another prompt to one mana for second signet ability
7) tap Scrubland to pay for 2nd signet (step 6 prompt)
8 ) W B mana show up in mana pool
9) prompt reverts back to step 4
10) tap Scrubland to pay for 1st signet (step 4 prompt)
11) another W B mana show up in mana pool for a total of 2xW and 2xB
12) prompt reverts back to step 2
ok, so have a hand of 4 scrublands, 2 orzhov signets and sorin.
play the four scrublands
cast one signet by tapping two lands
cast the other signet by tapping the first signet
untap the lands
cast sorin by tapping the first signet and paying by tapping a scrubland (mana pool contains W and B, prompt says the pay 2WB)
tap the other signet and pay by using a mana from the mana pool (the mana reads W and 2B and the prompt says pay mana cost: 2)
PowerClaws
 
Posts: 131
Joined: 30 Jan 2012, 11:33
Has thanked: 28 times
Been thanked: 8 times

Re: Bug Reports (snapshot builds)

Postby ArsenalNut » 02 Oct 2012, 13:10

PowerClaws wrote:ok, so have a hand of 4 scrublands, 2 orzhov signets and sorin.
play the four scrublands
cast one signet by tapping two lands
cast the other signet by tapping the first signet
untap the lands
cast sorin by tapping the first signet and paying by tapping a scrubland (mana pool contains W and B, prompt says the pay 2WB)
tap the other signet and pay by using a mana from the mana pool (the mana reads W and 2B and the prompt says pay mana cost: 2)
Prompt says pay mana cost: 2 W B at the end when I try this exact sequence. I am not sure why I cannot reproduce the issue. I am running the latest code out the repository in Eclipse. Let's check again after the next beta drop.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Bug Reports (snapshot builds)

Postby PowerClaws » 02 Oct 2012, 14:01

ArsenalNut wrote:
PowerClaws wrote:ok, so have a hand of 4 scrublands, 2 orzhov signets and sorin.
play the four scrublands
cast one signet by tapping two lands
cast the other signet by tapping the first signet
untap the lands
cast sorin by tapping the first signet and paying by tapping a scrubland (mana pool contains W and B, prompt says the pay 2WB)
tap the other signet and pay by using a mana from the mana pool (the mana reads W and 2B and the prompt says pay mana cost: 2)
Prompt says pay mana cost: 2 W B at the end when I try this exact sequence. I am not sure why I cannot reproduce the issue. I am running the latest code out the repository in Eclipse. Let's check again after the next beta drop.
Just tried with the most recent snapshot, doesnt happen, i dunno what it was but mine mustve been crazy for a moment
PowerClaws
 
Posts: 131
Joined: 30 Jan 2012, 11:33
Has thanked: 28 times
Been thanked: 8 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 02 Oct 2012, 14:02

Hey Rumble,

I saw you committed this change, but it's incorrect: http://svn.slightlymagic.net/websvn/dif ... &peg=17292

Even though ROE is "part" of the Zendikar block, Sealed does not use Zen, WWK, ROE packs together since ROE is a large expansion. Zen block uses Half (rounded up) Zen packs, and Half (rounded down) WWK packs. ROE uses all ROE packs.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby PowerClaws » 02 Oct 2012, 14:03

Love the change to the multicolour filter in editor, but now the editor only shows multicolour cards while enabled, i can live with that though, just thought you'd want to know

Edit: i may be wrong there, ill look later
Last edited by PowerClaws on 02 Oct 2012, 14:47, edited 1 time in total.
PowerClaws
 
Posts: 131
Joined: 30 Jan 2012, 11:33
Has thanked: 28 times
Been thanked: 8 times

Re: Bug Reports (snapshot builds)

Postby RumbleBBU » 02 Oct 2012, 14:07

friarsol wrote:Hey Rumble,

I saw you committed this change, but it's incorrect: http://svn.slightlymagic.net/websvn/dif ... &peg=17292

Even though ROE is "part" of the Zendikar block, Sealed does not use Zen, WWK, ROE packs together since ROE is a large expansion. Zen block uses Half (rounded up) Zen packs, and Half (rounded down) WWK packs. ROE uses all ROE packs.
Understood. I have rolled back the change.
User avatar
RumbleBBU
 
Posts: 394
Joined: 18 Aug 2012, 04:24
Has thanked: 29 times
Been thanked: 66 times

Re: Bug Reports (snapshot builds)

Postby FabioFLX » 03 Oct 2012, 08:49

Every time I try to start a draft with Return to Ravnica block it gives the following error:

Code: Select all
null

Version:
Forge version 1.2.15-SNAPSHOT

OS: Linux Version: 3.2.0-30-generic Architecture: amd64

Java Version: 1.6.0_24 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.game.limited.BoosterDraftAI.choose(BoosterDraftAI.java:100)
   at forge.game.limited.BoosterDraft.computerChoose(BoosterDraft.java:304)
   at forge.game.limited.BoosterDraft.nextChoice(BoosterDraft.java:251)
   at forge.gui.deckeditor.controllers.CEditorDraftingProcess.init(CEditorDraftingProcess.java:251)
[...]
Thank you and hope this helps.
User avatar
FabioFLX
 
Posts: 78
Joined: 27 Sep 2011, 13:08
Has thanked: 4 times
Been thanked: 7 times

Re: Bug Reports (snapshot builds)

Postby RumbleBBU » 03 Oct 2012, 09:30

FabioFLX wrote:Every time I try to start a draft with Return to Ravnica block it gives the following error:
Alas, this is a known issue. The fundamental problem is that since there are currently no draft rankings for RtR cards, and, consequently, the AI can't decide which cards to draft (or pick in sealed deck games).

Unless the AI deck building algorithm is changed somehow, Draft and Sealed Deck games with RtR boosters won't work until we get some draft rankings for those cards.
User avatar
RumbleBBU
 
Posts: 394
Joined: 18 Aug 2012, 04:24
Has thanked: 29 times
Been thanked: 66 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 03 Oct 2012, 10:40

RumbleBBU wrote:
FabioFLX wrote:Every time I try to start a draft with Return to Ravnica block it gives the following error:
Alas, this is a known issue. The fundamental problem is that since there are currently no draft rankings for RtR cards, and, consequently, the AI can't decide which cards to draft (or pick in sealed deck games).

Unless the AI deck building algorithm is changed somehow, Draft and Sealed Deck games with RtR boosters won't work until we get some draft rankings for those cards.
Is there a default value that can be assigned to card when it has no ranking?
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 03 Oct 2012, 11:19

Max mtg wrote:
RumbleBBU wrote:
FabioFLX wrote:Every time I try to start a draft with Return to Ravnica block it gives the following error:
Alas, this is a known issue. The fundamental problem is that since there are currently no draft rankings for RtR cards, and, consequently, the AI can't decide which cards to draft (or pick in sealed deck games).

Unless the AI deck building algorithm is changed somehow, Draft and Sealed Deck games with RtR boosters won't work until we get some draft rankings for those cards.
Is there a default value that can be assigned to card when it has no ranking?
I made a quick fix for this, but i will also try to update rankings.txt.

EDIT: The list of bestiaire.org is still a bit rough (Worldspine Wurm is #14 in a limited environment with the speed dictated by Rakdos?), but better than nothing.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 03 Oct 2012, 14:15

(Moved to different thread, feel free to delete)
Last edited by friarsol on 03 Oct 2012, 14:57, edited 1 time in total.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 03 Oct 2012, 14:17

I see that Sloth fixed the Fireball cost increase SVar but it looks like the "Targeted$" doesn't actually grab players in the List. So when I was testing Fireball (originally) I would target 2 creatures and a Player and it would properly give me 2 R (which is why I didn't notice the math not working). So now if you do the same thing it only gives 1 R, since the Player isn't counted in the list. I'm probably not gonna be at my codebase until tomorrow night (10/4 after 7pm Eastern). A simple non-code fix might be to add Targeted$Amount and TargetedPlayers$Amount to make sure all the targets are being accumulated properly.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Milod » 03 Oct 2012, 17:06

u are able to play Transguild Promenade even if u already played a land this turn :roll:
Milod
 
Posts: 360
Joined: 20 Jul 2011, 08:57
Has thanked: 4 times
Been thanked: 5 times

Re: Bug Reports (snapshot builds)

Postby Almeida » 03 Oct 2012, 17:48

hey guys excellent work

Dryad Militant crash when trigger and Tragic Slip morbid not work
Last edited by moomarc on 03 Oct 2012, 20:37, edited 1 time in total.
Reason: Mouseover
User avatar
Almeida
 
Posts: 41
Joined: 24 Dec 2011, 04:48
Has thanked: 0 time
Been thanked: 0 time

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 6 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 6 users online :: 0 registered, 0 hidden and 6 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 6 guests

Login Form