It is currently 27 Aug 2025, 17:06
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby moomarc » 04 Feb 2013, 13:36

Thanks max. That was fast! Confirmed working!
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Bug Reports (snapshot builds)

Postby Chris H. » 04 Feb 2013, 13:48

moomarc wrote:Thanks max. That was fast! Confirmed working!
 
1.3.6 is built and deployed to cardforge but I will not advertise this buggy release.

I will update my local copy and will then will release 1.3.7 to the user base.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Bug Reports (snapshot builds)

Postby ArsenalNut » 04 Feb 2013, 14:49

Max mtg wrote:
ArsenalNut wrote:r19335, I am not sure if this behavior is really a bug but the sideboard changes are getting reset between 2nd and 3rd game. I just clicked OK between the 2nd and 3rd games and was surprised to find cards that I know I had sided out for the 2nd game appeared in my hand and library for game 3.
The changes to deck were applied to the second match and discarded afterwards, this is a bug.

Was adressed by r19359 - see if it works for you.
I tested sideboarding in r19378 and appears not to be working at all. After game one I sideboard out three of the same card but when I look at my library at the start of game two, the three cards are still there and my sideboard cards are not.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 04 Feb 2013, 15:32

I noticed someone was gussying up CardDetailPanel from commit logs. There was a minor bug with cards that have both X and a colorless value in the casting cost, where the colorless value appears before the X (like in the card Mind Warp 3 X B instead of X 3 B), if you want to resolve that while you are in there.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 04 Feb 2013, 15:41

Uhh, looks like I've spoiled another release.
19380 does fix the sideboarding problem, but 1.3.7 is out already

Sol, I think that bug is settled deeper in manacost to string. Must be mine as well
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby goonjamin » 04 Feb 2013, 16:15

r19380

In the deck editor I accidently added 4 of a card to a new deck (so the current deck pane showed only 4 Intervention Pact in the deck). I then clicked the remove 4 of a card button to get rid of them. The cards were removed but I also got this error. Note if I remove the cards one by one I don't get this error.

Code: Select all
This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
   http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.

Row index out of range


Version:
Forge version 1.3.8-SNAPSHOT-r0000

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.6.0_35 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.IllegalArgumentException: Row index out of range
   at javax.swing.JTable.boundRow(Unknown Source)
   at javax.swing.JTable.setRowSelectionInterval(Unknown Source)
   at forge.gui.deckeditor.tables.EditorTableView$3.run(EditorTableView.java:261)
   at java.awt.event.InvocationEvent.dispatch(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$400(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
goonjamin
 
Posts: 133
Joined: 19 Aug 2010, 19:51
Has thanked: 39 times
Been thanked: 5 times

Re: Bug Reports (snapshot builds)

Postby myk » 04 Feb 2013, 16:20

this bug is undoubtedly mine. I'll get it. Edit: fixed in r19381. Thanks for the report!
myk
 
Posts: 439
Joined: 17 Jan 2013, 02:39
Location: California
Has thanked: 38 times
Been thanked: 57 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 04 Feb 2013, 19:08

Where do we post data-related errors?

There's an error in a deck file - see viewtopic.php?p=109045#p109045
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby ArsenalNut » 05 Feb 2013, 06:14

I get the following crash everytime I try to play Unburial Rites
Unburial Rites Crash | Open
java.lang.NullPointerException
at forge.gui.CardDetailPanel.setCard(CardDetailPanel.java:186)
at forge.gui.match.controllers.CDetail.showCard(CDetail.java:51)
at forge.gui.match.CMatchUI.setCard(CMatchUI.java:235)
at forge.gui.GuiChoose$1.valueChanged(GuiChoose.java:193)
at javax.swing.JList.fireSelectionValueChanged(Unknown Source)
at javax.swing.JList$ListSelectionHandler.valueChanged(Unknown Source)
at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source)
at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source)
at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source)
at javax.swing.DefaultListSelectionModel.changeSelection(Unknown Source)
at javax.swing.DefaultListSelectionModel.changeSelection(Unknown Source)
at javax.swing.DefaultListSelectionModel.setSelectionInterval(Unknown Source)
at javax.swing.JList.setSelectedIndex(Unknown Source)
at forge.gui.ListChooser.show(ListChooser.java:201)
at forge.gui.ListChooser.show(ListChooser.java:181)
at forge.gui.GuiChoose.getChoices(GuiChoose.java:203)
at forge.gui.GuiChoose.getChoices(GuiChoose.java:184)
at forge.gui.GuiChoose.oneOrNone(GuiChoose.java:51)
at forge.card.spellability.TargetSelection.chooseCardFromList(TargetSelection.java:516)
at forge.card.spellability.TargetSelection.chooseValidInput(TargetSelection.java:330)
at forge.card.spellability.TargetSelection.chooseTargets(TargetSelection.java:226)
at forge.card.spellability.SpellAbilityRequirements.fillRequirements(SpellAbilityRequirements.java:130)
at forge.card.spellability.SpellAbilityRequirements.fillRequirements(SpellAbilityRequirements.java:96)
at forge.GameAction.playSpellAbility(GameAction.java:1859)
at forge.game.player.Player.playSpellAbility(Player.java:3140)
at forge.control.input.InputPassPriority.selectCard(InputPassPriority.java:87)
at forge.gui.GuiInput.selectCard(GuiInput.java:115)
at forge.gui.match.nonsingleton.CHand.cardclickAction(CHand.java:188)
at forge.gui.match.nonsingleton.CHand.access$0(CHand.java:182)
at forge.gui.match.nonsingleton.CHand$1.mousePressed(CHand.java:60)
at java.awt.AWTEventMulticaster.mousePressed(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$000(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$2.run(Unknown Source)
at java.awt.EventQueue$2.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Bug Reports (snapshot builds)

Postby myk » 05 Feb 2013, 08:06

ArsenalNut wrote:I get the following crash everytime I try to play Unburial Rites
Fixed in r19397. Thanks!
myk
 
Posts: 439
Joined: 17 Jan 2013, 02:39
Location: California
Has thanked: 38 times
Been thanked: 57 times

Re: Bug Reports (snapshot builds)

Postby RumbleBBU » 05 Feb 2013, 10:44

A new bug related to the card picture panel and spell shop.

When I sell the highlighted card to the spell shop, the card picture panel display switches over from your inventory to the highlighted card in the spell shop - instead of moving over to the next highlighted card in your inventory (like it used to).

This is actually more serious than you'd think. I've just accidentally sold several cards from a booster I won thinking they were Ali Babas - because the card picture display had switched over from my inventory to the spell shop, which happened to have Ali Baba at the top of the list. In fact, I have no idea what cards I sold...I only looked at the card picture panel and thought that I was selling an Ali Baba next.
User avatar
RumbleBBU
 
Posts: 394
Joined: 18 Aug 2012, 04:24
Has thanked: 29 times
Been thanked: 66 times

Re: Bug Reports (snapshot builds)

Postby moomarc » 05 Feb 2013, 11:03

Crash when Vexing Devil's ETB trigger resolves:
Vexing Devil crash | Open
forge.game.player.HumanPlayer cannot be cast to forge.game.player.AIPlayer


Version:
Forge version SVN

OS: Windows 7 Version: 6.1 Architecture: x86

Java Version: 1.6.0_35 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.ClassCastException: forge.game.player.HumanPlayer cannot be cast to forge.game.player.AIPlayer
at forge.card.abilityfactory.CommonAbility.doTrigger(CommonAbility.java:72)
at forge.card.trigger.WrappedAbility.resolve(WrappedAbility.java:500)
at forge.card.abilityfactory.AbilityFactory.resolve(AbilityFactory.java:1526)
at forge.game.zone.MagicStack.resolveStack(MagicStack.java:893)
at forge.game.phase.PhaseHandler.passPriority(PhaseHandler.java:735)
at forge.game.player.PlayerController.passPriority(PlayerController.java:72)
at forge.game.ai.AiInputCommon.showMessage(AiInputCommon.java:110)
at forge.gui.GuiInput.setInput(GuiInput.java:71)
at forge.gui.GuiInput.update(GuiInput.java:54)
at java.util.Observable.notifyObservers(Unknown Source)


Edit: Changing the OptionalDecider to TriggeredCardOpponent doesn't help.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Bug Reports (snapshot builds)

Postby Max mtg » 05 Feb 2013, 11:17

moomarc wrote:Crash when Vexing Devil's ETB trigger resolves:

Detailed error trace:
java.lang.ClassCastException: forge.game.player.HumanPlayer cannot be cast to forge.game.player.AIPlayer
at forge.card.abilityfactory.CommonAbility.doTrigger(CommonAbility.java:72)
at forge.card.trigger.WrappedAbility.resolve(WrappedAbility.java:500)
at forge.card.abilityfactory.AbilityFactory.resolve(AbilityFactory.java:1526)

Edit: Changing the OptionalDecider to TriggeredCardOpponent doesn't help.
That's just wonderful!
Who is casting Vexing Devil? If human is, then AI should decide if it wants the devil to deal him 4 dmg and die.
But it turned out that doTrigger was called for human player who is controlling the ability, but cannot choose!
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Bug Reports (snapshot builds)

Postby myk » 05 Feb 2013, 11:20

RumbleBBU wrote:When I sell the highlighted card to the spell shop, the card picture panel display switches over from your inventory to the highlighted card in the spell shop - instead of moving over to the next highlighted card in your inventory (like it used to).
D'oh! Fixed in r19409. Thanks! I hope you were able to get your cards back..
myk
 
Posts: 439
Joined: 17 Jan 2013, 02:39
Location: California
Has thanked: 38 times
Been thanked: 57 times

Re: Bug Reports (snapshot builds)

Postby moomarc » 05 Feb 2013, 11:23

Max mtg wrote:
moomarc wrote:Crash when Vexing Devil's ETB trigger resolves:

Detailed error trace:
java.lang.ClassCastException: forge.game.player.HumanPlayer cannot be cast to forge.game.player.AIPlayer
at forge.card.abilityfactory.CommonAbility.doTrigger(CommonAbility.java:72)
at forge.card.trigger.WrappedAbility.resolve(WrappedAbility.java:500)
at forge.card.abilityfactory.AbilityFactory.resolve(AbilityFactory.java:1526)

Edit: Changing the OptionalDecider to TriggeredCardOpponent doesn't help.
That's just wonderful!
Who is casting Vexing Devil? If human is, then AI should decide if it wants the devil to deal him 4 dmg and die.
But it turned out that doTrigger was called for human player who is controlling the ability, but cannot choose!
My apologies for leaving out that detail. I was the one that cast the Vexing Devil. Works fine if the opponent casts it.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 28 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 28 users online :: 0 registered, 0 hidden and 28 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 28 guests

Login Form